Uh oh!
There was an error while loading. Please reload this page.
chore: bump cpu submodule pin past the bending RLS/JRLS relax fix - #63
Merged
Conversation
Picks up fastfields-cpu-lib#82, which bumps fastfields-cpu-impl to #69's fix for #51 (relax_bending_rls_/relax_bending_jrls_ used a 2*niter colour-loop bound instead of pow<ndim>(3)*niter, leaving most of the field unrelaxed for bending-order RLS/JRLS relaxation) and adds a deterministic regression test for it. part of #33
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
cpusubmodule pin to fastfields-cpu-lib#82, which:fastfields-cpu-implto fastfields-cpu-impl#69 — fixesci: make clang-format non-blocking in lint workflow #51:relax_bending_rls_/relax_bending_jrls_used a2*nitercolour-loop bound instead ofpow<ndim>(3)*niter, leaving most of the field unrelaxed for bending-order RLS/JRLS relaxation (found while re-verifying Flow regulariser: full jitfields parity (+ Lamé self-adjointness fix) #25/Field regulariser: full jitfields parity (kernel / precond / forward / relax / accumulate) #33's status).run_2d_relax_rls_bending_sweep_visits_every_colour) that fails without the fix (38/50 interior voxels left untouched) and passes with it.cudais untouched (unaffected by this fix).Testing
Validated at the affected layer: fastfields-cpu-lib's
test_reg_field(13364 checks) andtest_reg_flow(11415 checks, unaffected — sanity check) both pass against the bumped pin. This is a mechanical gitlink-only bump on top of that; a full from-scratchmake allrelink of every module (distance/posdef/resize/restrict/splinc/pushpull/pushpull_backward/reg_field/reg_flow) was not re-run here for time, since none of those other modules touchreg_field.h/reg_flow.h.part of #33
Workstream: claude-jitfields-to-fastfields
Generated by Claude Code