Skip to content

PoC: embed Viceroy directly into the fastly binary - #1805

Closed
jedisct1 wants to merge 1 commit into
mainfrom
fdenis/viceroy-embedded
Closed

PoC: embed Viceroy directly into the fastly binary#1805
jedisct1 wants to merge 1 commit into
mainfrom
fdenis/viceroy-embedded

Conversation

@jedisct1

@jedisct1jedisct1 commented May 28, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Change summary

This allows shipping Viceroy inside the fastly binary so the common path becomes pure local extraction. No more downloads.

The embedded binary lives behind a viceroy_embed build tag. Without the tag, fastly builds and behaves exactly as before.

On first run the binary is decompressed. It's embedded as zstd-compressed to avoid bloating the binary too much if Viceroy is not used — each per-platform release archive grows by 8-10 MB. We already require klauspost/compress so no new dependencies are required.

Extraction failures or version mismatches fall through to the existing download flow untouched, as do --viceroy-path and FASTLY_VICEROY_USE_PATH.

The pinned Viceroy version is the contents of pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0. Bumping it is a one-line edit followed by a checksums refresh.

make build-embedded builds a CLI executable with Viceroy embedded.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

End users get a self-contained fastly binary (when built with viceroy_embed) that runs fastly compute serve offline, with no network round-trip to fetch Viceroy on first use. Default builds are unaffected.

Are there any considerations that need to be addressed for release?

Per-platform release archives grow by 8-10 MB when built with the viceroy_embed tag.

No breaking changes; the download path remains the fallback and existing overrides (--viceroy-path, FASTLY_VICEROY_USE_PATH) continue to work.

@jedisct1
PoC: embed Viceroy directly into the fastly binary
9b47415
This allows shipping Viceroy inside the fastly binary so the common
path becomes pure local extraction. No more downloads.
The embedded binary lives behind a `viceroy_embed` build tag.
Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as
ztd-compressed to avoid bloating the binary too much if
viceroy is not used - Each per-platform release archive grows by
8-10 MB. We already require klauspost/compress so no new
dependencies are required.
Extraction failures or version mismatches fall through to the
existing download flow untouched, as do --viceroy-path and
FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of
pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0.
Bumping it is a one-line edit followed by a checksums refresh.
"make build-embedded" builds a CLI executable with Viceroy embedded.
@mschfhmschfh mentioned this pull request Jun 25, 2026
Merged
5 tasks
kpfleming pushed a commit that referenced this pull request Jul 7, 2026
@mschfh
feat(compute): add install-viceroy command to pre-install Viceroy (#1833
f596ad9
)
### Change summary
The container images (`Dockerfile-go`, `Dockerfile-node`,
`Dockerfile-rust`) re-download Viceroy on each container start (raised
in
#1828 (review)),
this PR adds an explicit `fastly compute install-viceroy` command that
downloads and
installs the Viceroy local-testing binary.
#### Implementation
Rather than duplicate the download logic, the existing installer was
extracted out into a shared `viceroyInstaller`
(`pkg/commands/compute/viceroy.go`).
Both `compute serve` and the new command call it, so every
version/override
mechanism (the manifest's `[local_server] viceroy_version`,
`FASTLY_VICEROY_USE_PATH`)
applies identically during a pre-install. `ServeCommand.GetViceroy` is
now a thin
wrapper, so behavior is unchanged.
This is intentionally simpler than #1805 (which embeds binaries into the
CLI binary).
All Submissions:
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?
### New Feature Submissions:
* [x] Does your submission pass tests?
### Changes to Core Features:
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?
### User Impact
A new `fastly compute install-viceroy` command lets users (and the
container
images) pre-install Viceroy ahead of time, so `compute serve` can start
without
needing to download it. No change to existing behavior - `compute serve`
still
installs Viceroy on demand if it isn't already present.
### Are there any considerations that need to be addressed for release?
None. No breaking changes - the command is purely additive and the
shared
extraction keeps `compute serve`'s install path identical.
@jedisct1
jedisct1 deleted the fdenis/viceroy-embedded branch July 29, 2026 16:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jedisct1
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
PoC: embed Viceroy directly into the fastly binary by jedisct1 · Pull Request #1805 · fastly/cli · GitHub
Skip to content
PoC: embed Viceroy directly into the fastly binary - #1805
Closed
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Closed
PoC: embed Viceroy directly into the fastly binary#1805
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Conversation
@jedisct1
@jedisct1jedisct1
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Change summary
This allows shipping Viceroy inside the fastly binary so the common path becomes pure local extraction. No more downloads.
The embedded binary lives behind a viceroy_embed build tag. Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as zstd-compressed to avoid bloating the binary too much if Viceroy is not used — each per-platform release archive grows by 8-10 MB. We already require klauspost/compress so no new dependencies are required.
Extraction failures or version mismatches fall through to the existing download flow untouched, as do --viceroy-path and FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0. Bumping it is a one-line edit followed by a checksums refresh.
make build-embedded builds a CLI executable with Viceroy embedded.
All Submissions:
  •  Have you followed the guidelines in our Contributing document?
  •  Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
  •  Does your submission pass tests?
Changes to Core Features:
  •  Have you written new tests for your core changes, as applicable?
  •  Have you successfully run tests with your changes locally?
User Impact
End users get a self-contained fastly binary (when built with viceroy_embed) that runs fastly compute serve offline, with no network round-trip to fetch Viceroy on first use. Default builds are unaffected.
Are there any considerations that need to be addressed for release?
Per-platform release archives grow by 8-10 MB when built with the viceroy_embed tag.
No breaking changes; the download path remains the fallback and existing overrides (--viceroy-path, FASTLY_VICEROY_USE_PATH) continue to work.
@jedisct1
PoC: embed Viceroy directly into the fastly binary
9b47415
This allows shipping Viceroy inside the fastly binary so the common
path becomes pure local extraction. No more downloads.
The embedded binary lives behind a `viceroy_embed` build tag.
Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as
ztd-compressed to avoid bloating the binary too much if
viceroy is not used - Each per-platform release archive grows by
8-10 MB. We already require klauspost/compress so no new
dependencies are required.
Extraction failures or version mismatches fall through to the
existing download flow untouched, as do --viceroy-path and
FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of
pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0.
Bumping it is a one-line edit followed by a checksums refresh.
"make build-embedded" builds a CLI executable with Viceroy embedded.
@mschfhmschfh
mentioned this pull request
Jun 25, 2026
 Merged

5 tasks
kpfleming pushed a commit
that referenced
this pull request
Jul 7, 2026
@mschfh
feat(compute): add install-viceroy command to pre-install Viceroy (#1833
f596ad9
)
### Change summary
The container images (`Dockerfile-go`, `Dockerfile-node`,
`Dockerfile-rust`) re-download Viceroy on each container start (raised
in
#1828 (review)),
this PR adds an explicit `fastly compute install-viceroy` command that
downloads and
installs the Viceroy local-testing binary.
#### Implementation
Rather than duplicate the download logic, the existing installer was
extracted out into a shared `viceroyInstaller`
(`pkg/commands/compute/viceroy.go`).
Both `compute serve` and the new command call it, so every
version/override
mechanism (the manifest's `[local_server] viceroy_version`,
`FASTLY_VICEROY_USE_PATH`)
applies identically during a pre-install. `ServeCommand.GetViceroy` is
now a thin
wrapper, so behavior is unchanged.
This is intentionally simpler than #1805 (which embeds binaries into the
CLI binary).
All Submissions:
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?
### New Feature Submissions:
* [x] Does your submission pass tests?
### Changes to Core Features:
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?
### User Impact
A new `fastly compute install-viceroy` command lets users (and the
container
images) pre-install Viceroy ahead of time, so `compute serve` can start
without
needing to download it. No change to existing behavior - `compute serve`
still
installs Viceroy on demand if it isn't already present.
### Are there any considerations that need to be addressed for release?
None. No breaking changes - the command is purely additive and the
shared
extraction keeps `compute serve`'s install path identical.
@jedisct1
jedisct1
deleted the

fdenis/viceroy-embedded

branch
July 29, 2026 16:05
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@jedisct1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
PoC: embed Viceroy directly into the fastly binary by jedisct1 · Pull Request #1805 · fastly/cli · GitHub
Skip to content
PoC: embed Viceroy directly into the fastly binary - #1805
Closed
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Closed
PoC: embed Viceroy directly into the fastly binary#1805
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Conversation
@jedisct1
@jedisct1jedisct1
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Change summary
This allows shipping Viceroy inside the fastly binary so the common path becomes pure local extraction. No more downloads.
The embedded binary lives behind a viceroy_embed build tag. Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as zstd-compressed to avoid bloating the binary too much if Viceroy is not used — each per-platform release archive grows by 8-10 MB. We already require klauspost/compress so no new dependencies are required.
Extraction failures or version mismatches fall through to the existing download flow untouched, as do --viceroy-path and FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0. Bumping it is a one-line edit followed by a checksums refresh.
make build-embedded builds a CLI executable with Viceroy embedded.
All Submissions:
  •  Have you followed the guidelines in our Contributing document?
  •  Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
  •  Does your submission pass tests?
Changes to Core Features:
  •  Have you written new tests for your core changes, as applicable?
  •  Have you successfully run tests with your changes locally?
User Impact
End users get a self-contained fastly binary (when built with viceroy_embed) that runs fastly compute serve offline, with no network round-trip to fetch Viceroy on first use. Default builds are unaffected.
Are there any considerations that need to be addressed for release?
Per-platform release archives grow by 8-10 MB when built with the viceroy_embed tag.
No breaking changes; the download path remains the fallback and existing overrides (--viceroy-path, FASTLY_VICEROY_USE_PATH) continue to work.
@jedisct1
PoC: embed Viceroy directly into the fastly binary
9b47415
This allows shipping Viceroy inside the fastly binary so the common
path becomes pure local extraction. No more downloads.
The embedded binary lives behind a `viceroy_embed` build tag.
Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as
ztd-compressed to avoid bloating the binary too much if
viceroy is not used - Each per-platform release archive grows by
8-10 MB. We already require klauspost/compress so no new
dependencies are required.
Extraction failures or version mismatches fall through to the
existing download flow untouched, as do --viceroy-path and
FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of
pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0.
Bumping it is a one-line edit followed by a checksums refresh.
"make build-embedded" builds a CLI executable with Viceroy embedded.
@mschfhmschfh
mentioned this pull request
Jun 25, 2026
 Merged

5 tasks
kpfleming pushed a commit
that referenced
this pull request
Jul 7, 2026
@mschfh
feat(compute): add install-viceroy command to pre-install Viceroy (#1833
f596ad9
)
### Change summary
The container images (`Dockerfile-go`, `Dockerfile-node`,
`Dockerfile-rust`) re-download Viceroy on each container start (raised
in
#1828 (review)),
this PR adds an explicit `fastly compute install-viceroy` command that
downloads and
installs the Viceroy local-testing binary.
#### Implementation
Rather than duplicate the download logic, the existing installer was
extracted out into a shared `viceroyInstaller`
(`pkg/commands/compute/viceroy.go`).
Both `compute serve` and the new command call it, so every
version/override
mechanism (the manifest's `[local_server] viceroy_version`,
`FASTLY_VICEROY_USE_PATH`)
applies identically during a pre-install. `ServeCommand.GetViceroy` is
now a thin
wrapper, so behavior is unchanged.
This is intentionally simpler than #1805 (which embeds binaries into the
CLI binary).
All Submissions:
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?
### New Feature Submissions:
* [x] Does your submission pass tests?
### Changes to Core Features:
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?
### User Impact
A new `fastly compute install-viceroy` command lets users (and the
container
images) pre-install Viceroy ahead of time, so `compute serve` can start
without
needing to download it. No change to existing behavior - `compute serve`
still
installs Viceroy on demand if it isn't already present.
### Are there any considerations that need to be addressed for release?
None. No breaking changes - the command is purely additive and the
shared
extraction keeps `compute serve`'s install path identical.
@jedisct1
jedisct1
deleted the

fdenis/viceroy-embedded

branch
July 29, 2026 16:05
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@jedisct1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
PoC: embed Viceroy directly into the fastly binary by jedisct1 · Pull Request #1805 · fastly/cli · GitHub
Skip to content
PoC: embed Viceroy directly into the fastly binary - #1805
Closed
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Closed
PoC: embed Viceroy directly into the fastly binary#1805
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Conversation
@jedisct1
@jedisct1jedisct1
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Change summary
This allows shipping Viceroy inside the fastly binary so the common path becomes pure local extraction. No more downloads.
The embedded binary lives behind a viceroy_embed build tag. Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as zstd-compressed to avoid bloating the binary too much if Viceroy is not used — each per-platform release archive grows by 8-10 MB. We already require klauspost/compress so no new dependencies are required.
Extraction failures or version mismatches fall through to the existing download flow untouched, as do --viceroy-path and FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0. Bumping it is a one-line edit followed by a checksums refresh.
make build-embedded builds a CLI executable with Viceroy embedded.
All Submissions:
  •  Have you followed the guidelines in our Contributing document?
  •  Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
  •  Does your submission pass tests?
Changes to Core Features:
  •  Have you written new tests for your core changes, as applicable?
  •  Have you successfully run tests with your changes locally?
User Impact
End users get a self-contained fastly binary (when built with viceroy_embed) that runs fastly compute serve offline, with no network round-trip to fetch Viceroy on first use. Default builds are unaffected.
Are there any considerations that need to be addressed for release?
Per-platform release archives grow by 8-10 MB when built with the viceroy_embed tag.
No breaking changes; the download path remains the fallback and existing overrides (--viceroy-path, FASTLY_VICEROY_USE_PATH) continue to work.
@jedisct1
PoC: embed Viceroy directly into the fastly binary
9b47415
This allows shipping Viceroy inside the fastly binary so the common
path becomes pure local extraction. No more downloads.
The embedded binary lives behind a `viceroy_embed` build tag.
Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as
ztd-compressed to avoid bloating the binary too much if
viceroy is not used - Each per-platform release archive grows by
8-10 MB. We already require klauspost/compress so no new
dependencies are required.
Extraction failures or version mismatches fall through to the
existing download flow untouched, as do --viceroy-path and
FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of
pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0.
Bumping it is a one-line edit followed by a checksums refresh.
"make build-embedded" builds a CLI executable with Viceroy embedded.
@mschfhmschfh
mentioned this pull request
Jun 25, 2026
 Merged

5 tasks
kpfleming pushed a commit
that referenced
this pull request
Jul 7, 2026
@mschfh
feat(compute): add install-viceroy command to pre-install Viceroy (#1833
f596ad9
)
### Change summary
The container images (`Dockerfile-go`, `Dockerfile-node`,
`Dockerfile-rust`) re-download Viceroy on each container start (raised
in
#1828 (review)),
this PR adds an explicit `fastly compute install-viceroy` command that
downloads and
installs the Viceroy local-testing binary.
#### Implementation
Rather than duplicate the download logic, the existing installer was
extracted out into a shared `viceroyInstaller`
(`pkg/commands/compute/viceroy.go`).
Both `compute serve` and the new command call it, so every
version/override
mechanism (the manifest's `[local_server] viceroy_version`,
`FASTLY_VICEROY_USE_PATH`)
applies identically during a pre-install. `ServeCommand.GetViceroy` is
now a thin
wrapper, so behavior is unchanged.
This is intentionally simpler than #1805 (which embeds binaries into the
CLI binary).
All Submissions:
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?
### New Feature Submissions:
* [x] Does your submission pass tests?
### Changes to Core Features:
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?
### User Impact
A new `fastly compute install-viceroy` command lets users (and the
container
images) pre-install Viceroy ahead of time, so `compute serve` can start
without
needing to download it. No change to existing behavior - `compute serve`
still
installs Viceroy on demand if it isn't already present.
### Are there any considerations that need to be addressed for release?
None. No breaking changes - the command is purely additive and the
shared
extraction keeps `compute serve`'s install path identical.
@jedisct1
jedisct1
deleted the

fdenis/viceroy-embedded

branch
July 29, 2026 16:05
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@jedisct1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
PoC: embed Viceroy directly into the fastly binary by jedisct1 · Pull Request #1805 · fastly/cli · GitHub
Skip to content
PoC: embed Viceroy directly into the fastly binary - #1805
Closed
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Closed
PoC: embed Viceroy directly into the fastly binary#1805
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Conversation
@jedisct1
@jedisct1jedisct1
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Change summary
This allows shipping Viceroy inside the fastly binary so the common path becomes pure local extraction. No more downloads.
The embedded binary lives behind a viceroy_embed build tag. Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as zstd-compressed to avoid bloating the binary too much if Viceroy is not used — each per-platform release archive grows by 8-10 MB. We already require klauspost/compress so no new dependencies are required.
Extraction failures or version mismatches fall through to the existing download flow untouched, as do --viceroy-path and FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0. Bumping it is a one-line edit followed by a checksums refresh.
make build-embedded builds a CLI executable with Viceroy embedded.
All Submissions:
  •  Have you followed the guidelines in our Contributing document?
  •  Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
  •  Does your submission pass tests?
Changes to Core Features:
  •  Have you written new tests for your core changes, as applicable?
  •  Have you successfully run tests with your changes locally?
User Impact
End users get a self-contained fastly binary (when built with viceroy_embed) that runs fastly compute serve offline, with no network round-trip to fetch Viceroy on first use. Default builds are unaffected.
Are there any considerations that need to be addressed for release?
Per-platform release archives grow by 8-10 MB when built with the viceroy_embed tag.
No breaking changes; the download path remains the fallback and existing overrides (--viceroy-path, FASTLY_VICEROY_USE_PATH) continue to work.
@jedisct1
PoC: embed Viceroy directly into the fastly binary
9b47415
This allows shipping Viceroy inside the fastly binary so the common
path becomes pure local extraction. No more downloads.
The embedded binary lives behind a `viceroy_embed` build tag.
Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as
ztd-compressed to avoid bloating the binary too much if
viceroy is not used - Each per-platform release archive grows by
8-10 MB. We already require klauspost/compress so no new
dependencies are required.
Extraction failures or version mismatches fall through to the
existing download flow untouched, as do --viceroy-path and
FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of
pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0.
Bumping it is a one-line edit followed by a checksums refresh.
"make build-embedded" builds a CLI executable with Viceroy embedded.
@mschfhmschfh
mentioned this pull request
Jun 25, 2026
 Merged

5 tasks
kpfleming pushed a commit
that referenced
this pull request
Jul 7, 2026
@mschfh
feat(compute): add install-viceroy command to pre-install Viceroy (#1833
f596ad9
)
### Change summary
The container images (`Dockerfile-go`, `Dockerfile-node`,
`Dockerfile-rust`) re-download Viceroy on each container start (raised
in
#1828 (review)),
this PR adds an explicit `fastly compute install-viceroy` command that
downloads and
installs the Viceroy local-testing binary.
#### Implementation
Rather than duplicate the download logic, the existing installer was
extracted out into a shared `viceroyInstaller`
(`pkg/commands/compute/viceroy.go`).
Both `compute serve` and the new command call it, so every
version/override
mechanism (the manifest's `[local_server] viceroy_version`,
`FASTLY_VICEROY_USE_PATH`)
applies identically during a pre-install. `ServeCommand.GetViceroy` is
now a thin
wrapper, so behavior is unchanged.
This is intentionally simpler than #1805 (which embeds binaries into the
CLI binary).
All Submissions:
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?
### New Feature Submissions:
* [x] Does your submission pass tests?
### Changes to Core Features:
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?
### User Impact
A new `fastly compute install-viceroy` command lets users (and the
container
images) pre-install Viceroy ahead of time, so `compute serve` can start
without
needing to download it. No change to existing behavior - `compute serve`
still
installs Viceroy on demand if it isn't already present.
### Are there any considerations that need to be addressed for release?
None. No breaking changes - the command is purely additive and the
shared
extraction keeps `compute serve`'s install path identical.
@jedisct1
jedisct1
deleted the

fdenis/viceroy-embedded

branch
July 29, 2026 16:05
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@jedisct1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
PoC: embed Viceroy directly into the fastly binary by jedisct1 · Pull Request #1805 · fastly/cli · GitHub
Skip to content
PoC: embed Viceroy directly into the fastly binary - #1805
Closed
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Closed
PoC: embed Viceroy directly into the fastly binary#1805
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Conversation
@jedisct1
@jedisct1jedisct1
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Change summary
This allows shipping Viceroy inside the fastly binary so the common path becomes pure local extraction. No more downloads.
The embedded binary lives behind a viceroy_embed build tag. Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as zstd-compressed to avoid bloating the binary too much if Viceroy is not used — each per-platform release archive grows by 8-10 MB. We already require klauspost/compress so no new dependencies are required.
Extraction failures or version mismatches fall through to the existing download flow untouched, as do --viceroy-path and FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0. Bumping it is a one-line edit followed by a checksums refresh.
make build-embedded builds a CLI executable with Viceroy embedded.
All Submissions:
  •  Have you followed the guidelines in our Contributing document?
  •  Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
  •  Does your submission pass tests?
Changes to Core Features:
  •  Have you written new tests for your core changes, as applicable?
  •  Have you successfully run tests with your changes locally?
User Impact
End users get a self-contained fastly binary (when built with viceroy_embed) that runs fastly compute serve offline, with no network round-trip to fetch Viceroy on first use. Default builds are unaffected.
Are there any considerations that need to be addressed for release?
Per-platform release archives grow by 8-10 MB when built with the viceroy_embed tag.
No breaking changes; the download path remains the fallback and existing overrides (--viceroy-path, FASTLY_VICEROY_USE_PATH) continue to work.
@jedisct1
PoC: embed Viceroy directly into the fastly binary
9b47415
This allows shipping Viceroy inside the fastly binary so the common
path becomes pure local extraction. No more downloads.
The embedded binary lives behind a `viceroy_embed` build tag.
Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as
ztd-compressed to avoid bloating the binary too much if
viceroy is not used - Each per-platform release archive grows by
8-10 MB. We already require klauspost/compress so no new
dependencies are required.
Extraction failures or version mismatches fall through to the
existing download flow untouched, as do --viceroy-path and
FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of
pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0.
Bumping it is a one-line edit followed by a checksums refresh.
"make build-embedded" builds a CLI executable with Viceroy embedded.
@mschfhmschfh
mentioned this pull request
Jun 25, 2026
 Merged

5 tasks
kpfleming pushed a commit
that referenced
this pull request
Jul 7, 2026
@mschfh
feat(compute): add install-viceroy command to pre-install Viceroy (#1833
f596ad9
)
### Change summary
The container images (`Dockerfile-go`, `Dockerfile-node`,
`Dockerfile-rust`) re-download Viceroy on each container start (raised
in
#1828 (review)),
this PR adds an explicit `fastly compute install-viceroy` command that
downloads and
installs the Viceroy local-testing binary.
#### Implementation
Rather than duplicate the download logic, the existing installer was
extracted out into a shared `viceroyInstaller`
(`pkg/commands/compute/viceroy.go`).
Both `compute serve` and the new command call it, so every
version/override
mechanism (the manifest's `[local_server] viceroy_version`,
`FASTLY_VICEROY_USE_PATH`)
applies identically during a pre-install. `ServeCommand.GetViceroy` is
now a thin
wrapper, so behavior is unchanged.
This is intentionally simpler than #1805 (which embeds binaries into the
CLI binary).
All Submissions:
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?
### New Feature Submissions:
* [x] Does your submission pass tests?
### Changes to Core Features:
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?
### User Impact
A new `fastly compute install-viceroy` command lets users (and the
container
images) pre-install Viceroy ahead of time, so `compute serve` can start
without
needing to download it. No change to existing behavior - `compute serve`
still
installs Viceroy on demand if it isn't already present.
### Are there any considerations that need to be addressed for release?
None. No breaking changes - the command is purely additive and the
shared
extraction keeps `compute serve`'s install path identical.
@jedisct1
jedisct1
deleted the

fdenis/viceroy-embedded

branch
July 29, 2026 16:05
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@jedisct1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
PoC: embed Viceroy directly into the fastly binary by jedisct1 · Pull Request #1805 · fastly/cli · GitHub
Skip to content
PoC: embed Viceroy directly into the fastly binary - #1805
Closed
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Closed
PoC: embed Viceroy directly into the fastly binary#1805
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Conversation
@jedisct1
@jedisct1jedisct1
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Change summary
This allows shipping Viceroy inside the fastly binary so the common path becomes pure local extraction. No more downloads.
The embedded binary lives behind a viceroy_embed build tag. Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as zstd-compressed to avoid bloating the binary too much if Viceroy is not used — each per-platform release archive grows by 8-10 MB. We already require klauspost/compress so no new dependencies are required.
Extraction failures or version mismatches fall through to the existing download flow untouched, as do --viceroy-path and FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0. Bumping it is a one-line edit followed by a checksums refresh.
make build-embedded builds a CLI executable with Viceroy embedded.
All Submissions:
  •  Have you followed the guidelines in our Contributing document?
  •  Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
  •  Does your submission pass tests?
Changes to Core Features:
  •  Have you written new tests for your core changes, as applicable?
  •  Have you successfully run tests with your changes locally?
User Impact
End users get a self-contained fastly binary (when built with viceroy_embed) that runs fastly compute serve offline, with no network round-trip to fetch Viceroy on first use. Default builds are unaffected.
Are there any considerations that need to be addressed for release?
Per-platform release archives grow by 8-10 MB when built with the viceroy_embed tag.
No breaking changes; the download path remains the fallback and existing overrides (--viceroy-path, FASTLY_VICEROY_USE_PATH) continue to work.
@jedisct1
PoC: embed Viceroy directly into the fastly binary
9b47415
This allows shipping Viceroy inside the fastly binary so the common
path becomes pure local extraction. No more downloads.
The embedded binary lives behind a `viceroy_embed` build tag.
Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as
ztd-compressed to avoid bloating the binary too much if
viceroy is not used - Each per-platform release archive grows by
8-10 MB. We already require klauspost/compress so no new
dependencies are required.
Extraction failures or version mismatches fall through to the
existing download flow untouched, as do --viceroy-path and
FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of
pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0.
Bumping it is a one-line edit followed by a checksums refresh.
"make build-embedded" builds a CLI executable with Viceroy embedded.
@mschfhmschfh
mentioned this pull request
Jun 25, 2026
 Merged

5 tasks
kpfleming pushed a commit
that referenced
this pull request
Jul 7, 2026
@mschfh
feat(compute): add install-viceroy command to pre-install Viceroy (#1833
f596ad9
)
### Change summary
The container images (`Dockerfile-go`, `Dockerfile-node`,
`Dockerfile-rust`) re-download Viceroy on each container start (raised
in
#1828 (review)),
this PR adds an explicit `fastly compute install-viceroy` command that
downloads and
installs the Viceroy local-testing binary.
#### Implementation
Rather than duplicate the download logic, the existing installer was
extracted out into a shared `viceroyInstaller`
(`pkg/commands/compute/viceroy.go`).
Both `compute serve` and the new command call it, so every
version/override
mechanism (the manifest's `[local_server] viceroy_version`,
`FASTLY_VICEROY_USE_PATH`)
applies identically during a pre-install. `ServeCommand.GetViceroy` is
now a thin
wrapper, so behavior is unchanged.
This is intentionally simpler than #1805 (which embeds binaries into the
CLI binary).
All Submissions:
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?
### New Feature Submissions:
* [x] Does your submission pass tests?
### Changes to Core Features:
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?
### User Impact
A new `fastly compute install-viceroy` command lets users (and the
container
images) pre-install Viceroy ahead of time, so `compute serve` can start
without
needing to download it. No change to existing behavior - `compute serve`
still
installs Viceroy on demand if it isn't already present.
### Are there any considerations that need to be addressed for release?
None. No breaking changes - the command is purely additive and the
shared
extraction keeps `compute serve`'s install path identical.
@jedisct1
jedisct1
deleted the

fdenis/viceroy-embedded

branch
July 29, 2026 16:05
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@jedisct1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
PoC: embed Viceroy directly into the fastly binary by jedisct1 · Pull Request #1805 · fastly/cli · GitHub
Skip to content
PoC: embed Viceroy directly into the fastly binary - #1805
Closed
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Closed
PoC: embed Viceroy directly into the fastly binary#1805
jedisct1 wants to merge 1 commit into
mainfrom 
fdenis/viceroy-embedded
Conversation
@jedisct1
@jedisct1jedisct1
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Change summary
This allows shipping Viceroy inside the fastly binary so the common path becomes pure local extraction. No more downloads.
The embedded binary lives behind a viceroy_embed build tag. Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as zstd-compressed to avoid bloating the binary too much if Viceroy is not used — each per-platform release archive grows by 8-10 MB. We already require klauspost/compress so no new dependencies are required.
Extraction failures or version mismatches fall through to the existing download flow untouched, as do --viceroy-path and FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0. Bumping it is a one-line edit followed by a checksums refresh.
make build-embedded builds a CLI executable with Viceroy embedded.
All Submissions:
  •  Have you followed the guidelines in our Contributing document?
  •  Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
  •  Does your submission pass tests?
Changes to Core Features:
  •  Have you written new tests for your core changes, as applicable?
  •  Have you successfully run tests with your changes locally?
User Impact
End users get a self-contained fastly binary (when built with viceroy_embed) that runs fastly compute serve offline, with no network round-trip to fetch Viceroy on first use. Default builds are unaffected.
Are there any considerations that need to be addressed for release?
Per-platform release archives grow by 8-10 MB when built with the viceroy_embed tag.
No breaking changes; the download path remains the fallback and existing overrides (--viceroy-path, FASTLY_VICEROY_USE_PATH) continue to work.
@jedisct1
PoC: embed Viceroy directly into the fastly binary
9b47415
This allows shipping Viceroy inside the fastly binary so the common
path becomes pure local extraction. No more downloads.
The embedded binary lives behind a `viceroy_embed` build tag.
Without the tag, fastly builds and behaves exactly as before.
On first run the binary is decompressed. It's embedded as
ztd-compressed to avoid bloating the binary too much if
viceroy is not used - Each per-platform release archive grows by
8-10 MB. We already require klauspost/compress so no new
dependencies are required.
Extraction failures or version mismatches fall through to the
existing download flow untouched, as do --viceroy-path and
FASTLY_VICEROY_USE_PATH.
The pinned Viceroy version is the contents of
pkg/embedded/viceroy/VICEROY_VERSION, currently 0.18.0.
Bumping it is a one-line edit followed by a checksums refresh.
"make build-embedded" builds a CLI executable with Viceroy embedded.
@mschfhmschfh
mentioned this pull request
Jun 25, 2026
 Merged

5 tasks
kpfleming pushed a commit
that referenced
this pull request
Jul 7, 2026
@mschfh
feat(compute): add install-viceroy command to pre-install Viceroy (#1833
f596ad9
)
### Change summary
The container images (`Dockerfile-go`, `Dockerfile-node`,
`Dockerfile-rust`) re-download Viceroy on each container start (raised
in
#1828 (review)),
this PR adds an explicit `fastly compute install-viceroy` command that
downloads and
installs the Viceroy local-testing binary.
#### Implementation
Rather than duplicate the download logic, the existing installer was
extracted out into a shared `viceroyInstaller`
(`pkg/commands/compute/viceroy.go`).
Both `compute serve` and the new command call it, so every
version/override
mechanism (the manifest's `[local_server] viceroy_version`,
`FASTLY_VICEROY_USE_PATH`)
applies identically during a pre-install. `ServeCommand.GetViceroy` is
now a thin
wrapper, so behavior is unchanged.
This is intentionally simpler than #1805 (which embeds binaries into the
CLI binary).
All Submissions:
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?
### New Feature Submissions:
* [x] Does your submission pass tests?
### Changes to Core Features:
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?
### User Impact
A new `fastly compute install-viceroy` command lets users (and the
container
images) pre-install Viceroy ahead of time, so `compute serve` can start
without
needing to download it. No change to existing behavior - `compute serve`
still
installs Viceroy on demand if it isn't already present.
### Are there any considerations that need to be addressed for release?
None. No breaking changes - the command is purely additive and the
shared
extraction keeps `compute serve`'s install path identical.
@jedisct1
jedisct1
deleted the

fdenis/viceroy-embedded

branch
July 29, 2026 16:05
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@jedisct1