') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add Dockerfile-go by mschfh · Pull Request #1828 · fastly/cli · GitHub
Skip to content

Add Dockerfile-go - #1828

Merged
anthony-gomez-fastly merged 1 commit into
fastly:mainfrom
mschfh:dockerfile-golang
Jun 24, 2026
Merged

Add Dockerfile-go#1828
anthony-gomez-fastly merged 1 commit into
fastly:mainfrom
mschfh:dockerfile-golang

Conversation

@mschfh

@mschfhmschfh commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Change summary

Adds a Dockerfile-go to the repo, mirroring the existing Dockerfile-node and Dockerfile-rust but based on the golang:latest image. Like the others, this is a convenience Dockerfile that users can build to get a container with the Fastly CLI installed.

Build/run usage is documented in comments at the bottom of the file:

docker build -t fastly/cli/go . -f ./Dockerfile-go
docker run -v $PWD:/app -it -p 7676:7676 fastly/cli/go compute serve --addr="0.0.0.0:7676"

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

User Impact

Adds a Go-based Dockerfile option alongside the existing Node and Rust ones for users who prefer to build their own Fastly CLI container. No impact on existing functionality or users.

Are there any considerations that need to be addressed for release?

None. No breaking changes, and the image is not part of any build or release pipeline.

@mschfh
mschfhforce-pushed the dockerfile-golang branch from 955a76f to 2476631CompareJune 24, 2026 07:26
@mschfh
mschfh marked this pull request as ready for review June 24, 2026 07:26
@mschfh
mschfh requested a review from a team as a code ownerJune 24, 2026 07:26
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Jun 24, 2026
View reviewed changes

@anthony-gomez-fastlyanthony-gomez-fastly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for your contribution! LGTM, once @kpfleming reviews we can see about merging

kpfleming
kpfleming approved these changes Jun 24, 2026
View reviewed changes

@kpflemingkpfleming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this being merged as-is, but it (of course) suffers from the same issues that the others do. The example command for using the image is ... compute serve, which means that Viceroy will have to be downloaded and that sort of defeats the purpose of using a container image since it isn't self-contained and requires Internet access at runtime (and the Viceroy binary will have to be downloaded every time, unlike a local CLI installation where it will only be downloaded once).

If the CLI had some command which could be used to trigger the download of the ancillary binaries that could be used in the Dockerfile to avoid this problem... but it doesn't :-)

@anthony-gomez-fastly
anthony-gomez-fastly merged commit 27987db into fastly:mainJun 24, 2026
10 checks passed
@mschfh
mschfh deleted the dockerfile-golang branch June 24, 2026 18:05
@mschfhmschfh mentioned this pull request Jun 25, 2026
Merged
5 tasks
@mschfh

mschfh commented Jun 25, 2026

Copy link
Copy Markdown
ContributorAuthor

@kpfleming#1833 adds a install-viceroy command

@BrewTestBotBrewTestBot mentioned this pull request Jun 26, 2026
Merged
kpfleming pushed a commit that referenced this pull request Jul 7, 2026
@mschfh
feat(compute): add install-viceroy command to pre-install Viceroy (#1833
f596ad9
)
### Change summary
The container images (`Dockerfile-go`, `Dockerfile-node`,
`Dockerfile-rust`) re-download Viceroy on each container start (raised
in
#1828 (review)),
this PR adds an explicit `fastly compute install-viceroy` command that
downloads and
installs the Viceroy local-testing binary.
#### Implementation
Rather than duplicate the download logic, the existing installer was
extracted out into a shared `viceroyInstaller`
(`pkg/commands/compute/viceroy.go`).
Both `compute serve` and the new command call it, so every
version/override
mechanism (the manifest's `[local_server] viceroy_version`,
`FASTLY_VICEROY_USE_PATH`)
applies identically during a pre-install. `ServeCommand.GetViceroy` is
now a thin
wrapper, so behavior is unchanged.
This is intentionally simpler than #1805 (which embeds binaries into the
CLI binary).
All Submissions:
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?
### New Feature Submissions:
* [x] Does your submission pass tests?
### Changes to Core Features:
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?
### User Impact
A new `fastly compute install-viceroy` command lets users (and the
container
images) pre-install Viceroy ahead of time, so `compute serve` can start
without
needing to download it. No change to existing behavior - `compute serve`
still
installs Viceroy on demand if it isn't already present.
### Are there any considerations that need to be addressed for release?
None. No breaking changes - the command is purely additive and the
shared
extraction keeps `compute serve`'s install path identical.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpflemingkpflemingkpfleming approved these changes
@anthony-gomez-fastlyanthony-gomez-fastlyanthony-gomez-fastly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mschfh@kpfleming@anthony-gomez-fastly