') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat(compute): add install-viceroy command to pre-install Viceroy by mschfh · Pull Request #1833 · fastly/cli · GitHub
Skip to content

feat(compute): add install-viceroy command to pre-install Viceroy - #1833

Merged
kpfleming merged 3 commits into
fastly:mainfrom
mschfh:viceroy-install
Jul 7, 2026
Merged

feat(compute): add install-viceroy command to pre-install Viceroy#1833
kpfleming merged 3 commits into
fastly:mainfrom
mschfh:viceroy-install

Conversation

@mschfh

@mschfhmschfh commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Change summary

The container images (Dockerfile-go, Dockerfile-node, Dockerfile-rust) re-download Viceroy on each container start (raised in #1828 (review)), this PR adds an explicit fastly compute install-viceroy command that downloads and
installs the Viceroy local-testing binary.

Implementation

Rather than duplicate the download logic, the existing installer was extracted out into a shared viceroyInstaller (pkg/commands/compute/viceroy.go).

Both compute serve and the new command call it, so every version/override
mechanism (the manifest's [local_server] viceroy_version, FASTLY_VICEROY_USE_PATH)
applies identically during a pre-install. ServeCommand.GetViceroy is now a thin
wrapper, so behavior is unchanged.

This is intentionally simpler than #1805 (which embeds binaries into the CLI binary).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

A new fastly compute install-viceroy command lets users (and the container
images) pre-install Viceroy ahead of time, so compute serve can start without
needing to download it. No change to existing behavior - compute serve still
installs Viceroy on demand if it isn't already present.

Are there any considerations that need to be addressed for release?

None. No breaking changes - the command is purely additive and the shared
extraction keeps compute serve's install path identical.

@mschfh
mschfhforce-pushed the viceroy-install branch 4 times, most recently from beef7c1 to 84bb5c1CompareJune 25, 2026 07:34
@mschfh
mschfh marked this pull request as ready for review June 25, 2026 07:45
@mschfh
mschfh requested a review from a team as a code ownerJune 25, 2026 07:45
@mschfh
mschfh requested a review from rcarilJune 25, 2026 07:45
@mschfhmschfh mentioned this pull request Jun 25, 2026
Merged
2 tasks
kpfleming
kpfleming requested changes Jun 29, 2026
View reviewed changes

@kpflemingkpfleming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach here, although I'd rather the command be named fastly compute install-tools - then later (if not in this PR) it can be extended to install wasm-tools which is needed by fastly compute build, resulting in the same benefits for users who are using container images for building their projects.

@mschfh
mschfh requested a review from kpflemingJuly 4, 2026 20:20
@mschfh

mschfh commented Jul 4, 2026

Copy link
Copy Markdown
ContributorAuthor

Added the requested changes and rebased it

@kpfleming

kpfleming commented Jul 7, 2026

Copy link
Copy Markdown
Member

This looks great! Thanks for the contribution.

@kpfleming
kpfleming enabled auto-merge (squash) July 7, 2026 18:18
@kpfleming
kpfleming merged commit f596ad9 into fastly:mainJul 7, 2026
10 checks passed
@mschfh
mschfh deleted the viceroy-install branch July 7, 2026 23:13
@mschfh

mschfh commented Jul 7, 2026

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing/merging!
Are there plans to cut a new release soon, to enable it the Dockerfiles?

@mschfhmschfh mentioned this pull request Jul 7, 2026
Merged
2 tasks
@kpfleming

kpfleming commented Jul 8, 2026

Copy link
Copy Markdown
Member

Yep... our regularly scheduled release for July should happen tomorrow (see the README.md for a description of the release schedule).

rcaril added a commit that referenced this pull request Jul 8, 2026
@mschfh@rcaril
build(docker): enable compute install-tools (#1842)
2529553
### Change summary
This change preinstalls viceroy during the Docker image builds using the
`compute install-tools` command introduced in #1833
All Submissions:
* [X] Have you followed the guidelines in our Contributing document?
* [X] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?
### Are there any considerations that need to be addressed for release?
This will require a new release which includes the changes from #1833
Co-authored-by: Richard Carillo <77027245+rcaril@users.noreply.github.com>
@BrewTestBotBrewTestBot mentioned this pull request Jul 8, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpflemingkpflemingkpfleming approved these changes
@rcarilrcarilAwaiting requested review from rcarilrcaril is a code owner automatically assigned from fastly/developer-tools

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mschfh@kpfleming