Uh oh!
There was an error while loading. Please reload this page.
Avoid stack overflow on large marker threads - #6264
Merged
fqueze merged 2 commits intoAug 18, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #6264 +/- ##
==========================================
+ Coverage 83.73% 83.76% +0.03%
==========================================
Files 350 350 Lines 37523 37546 +23 Branches 10543 10563 +20 ==========================================
+ Hits 31420 31451 +31 + Misses 5676 5668 -8
Partials 427 427 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
canova
requested changes
Aug 18, 2026
canova
left a comment
Member
There was a problem hiding this comment.
The Math.min/max fix looks correct, but I'm not so sure about aggregateWithLargeThreadHint. Currently it shows the same error message on any error which might actually mislead more.
Comment on lines
+711
to
+721
| if (isNarrowed) { | ||
| throw error; | ||
| } | ||
| const message = error instanceof Error ? error.message : String(error); | ||
| throw new Error( | ||
| `${message}\nFailed while aggregating all ${markerCount} markers of this ` + | ||
| `thread. Narrowing the query to a subset of the same thread works: ` + | ||
| `rerun with --search <substring>, or with --min-duration / --category, ` + | ||
| `which filter the markers before they are aggregated.` | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
Is this still necessary after your fix? If so, what is triggering this issue?
Also currently this aggregateWithLargeThreadHint catches everything which doesn't feel right. It might be another issue that's throwing error.
ContributorAuthor
There was a problem hiding this comment.
aggregateWithLargeThreadHint removed in the update.
Unfiltered thread markers failed with "Maximum call stack size exceeded" on threads above roughly 1M markers: computeRateStats spread the whole gap array into Math.min/Math.max, once per marker name group. Compute the min, max and mean in a single pass instead.
fquezeforce-pushed
the
profiler-cli-large-thread-crash-pr
branch
from
August 18, 2026 15:13
eda57cc to
a58bb85Comparecanova
approved these changes
Aug 18, 2026
fqueze
enabled auto-merge (squash)
August 18, 2026 15:36
Uh oh!
There was an error while loading. Please reload this page.
fatadel added a commit
that referenced
this pull request
Sep 3, 2026
Changes: [Nazım Can Altınova] Update oxfmt 0.59.0 → 0.63.0 (major) (#6262) [Andrew Creskey] Show which network requests were prefetched (#6259) [Florian Quèze] profiler-cli: document the marker field:value search syntax (#6265) [Florian Quèze] profiler-cli: report one time base for text and JSON output (#6266) [Florian Quèze] profiler-cli: avoid a stack overflow on large marker threads (#6264) [Markus Stange] Give the frameTable a lib column (#6258) [Florian Quèze] profiler-cli: accept --limit 0 as unlimited, and make truncation loud (#6267) [Florian Quèze] profiler-cli: report the network request count the filters ran against (#6274) [Nazım Can Altınova] Fix dark mode contrast of the warning icons in the publish panel (#6280) [Nazım Can Altınova] Extract the publish panel warning indicator into a small component (#6282) [Markus Stange] More typed arrays in the FrameTable (and a flags column) (#6173) [Nazım Can Altınova] Improve the profiler-cli publish script and document the whole deployment in a better way (#6260) [fatadel] 🔃 Sync: l10n -> main (September 3, 2026) (#6301) [fatadel] Bump profiler-cli version to 0.9.0 (#6302) And special thanks to our localizers: es-CL: ravmn nl: Mark Heijl sv-SE: Andreas Pettersson sv-SE: Luna Jernberg sv-SE: Peter Kihlstedt tr: Selim Şumlu tr: giray zh-CN: 高乐喆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
thread markers on a thread with over ~1M markers failed with "Maximum call stack size exceeded". The cause was computeRateStats spreading its per-name gap array into Math.min/Math.max: an argument spread pushes one argument per element and V8 overflows around 100k. aggregateMarkersByName calls it once per marker name, so the trigger is the largest name group, not the thread size.
Reduce the gaps to min/avg/max in a single pass with no intermediate array, and wrap the whole-thread aggregation so that any remaining failure points at --search / --min-duration / --category, which narrow the same query.