Skip to content

Extract the publish panel warning indicator into a small component - #6282

Merged
canova merged 1 commit into
firefox-devtools:mainfrom
canova:extract-warn-icon
Aug 24, 2026
Merged

Extract the publish panel warning indicator into a small component#6282
canova merged 1 commit into
firefox-devtools:mainfrom
canova:extract-warn-icon

Conversation

@canova

@canovacanova commented Aug 24, 2026

Copy link
Copy Markdown
Member

The two warning indicators next to the checkboxes duplicated the
Localized wrapper boilerplate. Move it into a local WarningIndicator
component. I'll use it in another checkbox later for source upload.
@canova
canova marked this pull request as ready for review August 24, 2026 16:39
@canova
canova enabled auto-merge (squash) August 24, 2026 16:39
@canova
canova merged commit 8744367 into firefox-devtools:mainAug 24, 2026
22 checks passed
@codecov

codecovBot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.79%. Comparing base (9203f11) to head (ea74d09).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #6282 +/- ##
========================================
Coverage 83.79% 83.79% ========================================
Files 350 350 Lines 37583 37586 +3 Branches 10459 10564 +105 ========================================
+ Hits 31492 31495 +3 
Misses 5664 5664 Partials 427 427 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fatadelfatadel mentioned this pull request Sep 3, 2026
fatadel added a commit that referenced this pull request Sep 3, 2026
Changes:
[Nazım Can Altınova] Update oxfmt 0.59.0 → 0.63.0 (major) (#6262)
[Andrew Creskey] Show which network requests were prefetched (#6259)
[Florian Quèze] profiler-cli: document the marker field:value search
syntax (#6265)
[Florian Quèze] profiler-cli: report one time base for text and JSON
output (#6266)
[Florian Quèze] profiler-cli: avoid a stack overflow on large marker
threads (#6264)
[Markus Stange] Give the frameTable a lib column (#6258)
[Florian Quèze] profiler-cli: accept --limit 0 as unlimited, and make
truncation loud (#6267)
[Florian Quèze] profiler-cli: report the network request count the
filters ran against (#6274)
[Nazım Can Altınova] Fix dark mode contrast of the warning icons in the
publish panel (#6280)
[Nazım Can Altınova] Extract the publish panel warning indicator into a
small component (#6282)
[Markus Stange] More typed arrays in the FrameTable (and a flags column)
(#6173)
[Nazım Can Altınova] Improve the profiler-cli publish script and
document the whole deployment in a better way (#6260)
[fatadel] 🔃 Sync: l10n -> main (September 3, 2026) (#6301)
[fatadel] Bump profiler-cli version to 0.9.0 (#6302)
And special thanks to our localizers:
es-CL: ravmn
nl: Mark Heijl
sv-SE: Andreas Pettersson
sv-SE: Luna Jernberg
sv-SE: Peter Kihlstedt
tr: Selim Şumlu
tr: giray
zh-CN: 高乐喆
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@canova@mstange