Uh oh!
There was an error while loading. Please reload this page.
profiler-cli: report the network request count the filters ran against - #6274
Merged
canova merged 2 commits intoAug 24, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #6274 +/- ##
=======================================
Coverage 83.79% 83.79% =======================================
Files 350 350 Lines 37583 37584 +1 Branches 10459 10459 =======================================
+ Hits 31492 31493 +1
Misses 5664 5664 Partials 427 427 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fquezeforce-pushed
the
profiler-cli-network-request-count
branch
from
August 20, 2026 19:41
be9ae73 to
2d21320Comparecanova
requested changes
Aug 21, 2026
canova
left a comment
Member
There was a problem hiding this comment.
Please also add totalCandidateCount to schemas.txt
| const parts = summary.byThread.map( | ||
| (thread) => | ||
| `${thread.threadHandle} ${thread.threadName} (${thread.requestCount} reqs, ${formatDuration(thread.inFlightMs)} in flight)` | ||
| `${thread.threadHandle} ${thread.threadName} (${thread.requestCount} completed reqs, ${formatDuration(thread.inFlightMs)} in flight)` |
Member
There was a problem hiding this comment.
completed reqs is incorrect. It includes both completed and in-flight requests. See:
profiler/src/profile-query/network-summary.ts
Lines 400 to 402 in df31314
`thread network --limit 0` printed "114 requests ... (filtered from 104)" -- a pre-filter total below the count it qualified. totalRequestCount counts only completed legs and incompleteCount only in-flight ones, so redirect and cancel legs are counted by neither and the sum of the two is not the set the filters ran against. Add totalCandidateCount and use it for that total. `profile info`'s "By thread:" row has the same undercount and said only "reqs", so it printed 104 where `thread network` printed 114 for the same thread; it now says "started reqs", which covers the completed and in-flight legs that count includes.
fquezeforce-pushed
the
profiler-cli-network-request-count
branch
from
August 21, 2026 15:59
2d21320 to
4655e96Comparecanova
approved these changes
Aug 24, 2026
canova
enabled auto-merge (squash)
August 24, 2026 13:46
Uh oh!
There was an error while loading. Please reload this page.
fatadel added a commit
that referenced
this pull request
Sep 3, 2026
Changes: [Nazım Can Altınova] Update oxfmt 0.59.0 → 0.63.0 (major) (#6262) [Andrew Creskey] Show which network requests were prefetched (#6259) [Florian Quèze] profiler-cli: document the marker field:value search syntax (#6265) [Florian Quèze] profiler-cli: report one time base for text and JSON output (#6266) [Florian Quèze] profiler-cli: avoid a stack overflow on large marker threads (#6264) [Markus Stange] Give the frameTable a lib column (#6258) [Florian Quèze] profiler-cli: accept --limit 0 as unlimited, and make truncation loud (#6267) [Florian Quèze] profiler-cli: report the network request count the filters ran against (#6274) [Nazım Can Altınova] Fix dark mode contrast of the warning icons in the publish panel (#6280) [Nazım Can Altınova] Extract the publish panel warning indicator into a small component (#6282) [Markus Stange] More typed arrays in the FrameTable (and a flags column) (#6173) [Nazım Can Altınova] Improve the profiler-cli publish script and document the whole deployment in a better way (#6260) [fatadel] 🔃 Sync: l10n -> main (September 3, 2026) (#6301) [fatadel] Bump profiler-cli version to 0.9.0 (#6302) And special thanks to our localizers: es-CL: ravmn nl: Mark Heijl sv-SE: Andreas Pettersson sv-SE: Luna Jernberg sv-SE: Peter Kihlstedt tr: Selim Şumlu tr: giray zh-CN: 高乐喆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
thread network --limit 0printed "114 requests ... (filtered from 104)" -- a pre-filter total below the count it qualified. totalRequestCount counts only completed legs and incompleteCount only in-flight ones, so redirect and cancel legs are counted by neither and the sum of the two is not the set the filters ran against. Add totalCandidateCount and use it for that total.profile info's "By thread:" row has the same undercount and said only "reqs", so it printed 104 wherethread networkprinted 114 for the same thread; it now says "completed reqs".