[material_ui] Port flutter/flutter #186670 "Use local semantics tester in Material selection tests" by MarlonJD · Pull Request #11983 · flutter/packages

MarlonJD · 2026-06-25T12:37:14Z

This PR ports flutter/flutter#186670 by @MarlonJD from flutter/flutter to flutter/packages.

It moves the affected Material selection tests from material_ui's temporarily_disabled_tests directory into the main test directory now that their gross ../widgets/semantics_tester.dart import has been fixed to use material_ui's local semantics_tester.dart.

This follows the porting instructions in flutter/flutter#188444:

merge commits from the original PR are not included
the affected temporarily_disabled_tests files are moved into the main test directory after fixing the gross import

Validation:

dart format --set-exit-if-changed packages/material_ui/test/checkbox_test.dart packages/material_ui/test/radio_test.dart packages/material_ui/test/range_slider_test.dart packages/material_ui/test/slider_test.dart packages/material_ui/test/toggle_buttons_test.dart
git diff --check
flutter test test/checkbox_test.dart test/radio_test.dart test/range_slider_test.dart test/slider_test.dart test/toggle_buttons_test.dart

The targeted test command passed with 304 tests.

gemini-code-assist

Code Review

This pull request removes the @Skip annotations from several test files, including checkbox_test.dart, radio_test.dart, range_slider_test.dart, slider_test.dart, and toggle_buttons_test.dart. It also updates the import path of semantics_tester.dart from a relative parent directory to a local path, and reformats several test blocks in slider_test.dart. The review feedback points out a grammatical typo in one of the test descriptions in slider_test.dart and suggests correcting 'appear' to 'appears'.

MarlonJD · 2026-06-25T12:48:38Z

A note on why these files moved out of temporarily_disabled_tests: flutter/flutter#188444 says that when a port fixes a gross import for tests in material_ui/cupertino_ui, those tests may be moved back into the main test directory. These five files were skipped only for the old gross ../widgets/semantics_tester.dart import. This PR fixes that to use material_ui's local semantics_tester.dart, so I moved the affected tests into packages/material_ui/test/ and removed the file-level @Skip.

I also verified the enabled tests locally with:\n\nflutter test test/checkbox_test.dart test/radio_test.dart test/range_slider_test.dart test/slider_test.dart test/toggle_buttons_test.dart

That passed with 304 tests.

justinmc

LGTM 👍

Thanks so much for porting this PR so quickly! Let me know if there's anything in the porting instructions in flutter/flutter#188444 that could be improved.

I see there are still a bunch of formatting changes in this PR, but I'm not sure whether or not they are needed. Let's let CI run and see if it passes, if so then I think it's good.

flutter-dashboard · 2026-06-25T16:14:50Z

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

MarlonJD · 2026-06-25T16:27:28Z

Thanks! I pushed ac8073ea4 to address the dashboard merge-conflict blocker. The conflict came from slider_test.dart landing on main first via #11977, so I dropped that file from this port and kept only the remaining four Material selection test moves.

GitHub now reports the PR as mergeable, and tree-status is passing. I also re-ran the local validation for the updated 4-file scope:

git diff --check upstream/main...HEAD
dart format --set-exit-if-changed packages/material_ui/test/checkbox_test.dart packages/material_ui/test/radio_test.dart packages/material_ui/test/range_slider_test.dart packages/material_ui/test/toggle_buttons_test.dart (0 changed)
flutter test test/checkbox_test.dart test/radio_test.dart test/range_slider_test.dart test/toggle_buttons_test.dart (198 tests passed)

One possible improvement for the porting instructions: it may help to include a concrete PR title example, such as [material_ui] Port flutter/flutter #NNNNNN "Original PR title", and to make the temporarily_disabled_tests rule explicit: if a file was skipped only because of the gross ../widgets/semantics_tester.dart import, the port should fix the import, remove the file-level @Skip, and move the file back into packages/<package>/test/. If the equivalent file has already landed on packages/main, leave it out of the port to avoid duplicate move conflicts.

QuncCccccc · 2026-06-25T19:20:53Z

Hi @MarlonJD! Thanks a lot for your contribution! Could you help fix Linux analyze master and stable? Seems the imports need to be sorted.

MarlonJD · 2026-06-25T20:23:35Z

Fixed in 6c54de724 by sorting the material_ui selection test imports.

Local validation:

dart format --set-exit-if-changed packages/material_ui/test/checkbox_test.dart packages/material_ui/test/radio_test.dart packages/material_ui/test/range_slider_test.dart packages/material_ui/test/toggle_buttons_test.dart (0 changed)
dart run script/tool/bin/flutter_plugin_tools.dart analyze --packages material_ui --base-branch origin/main --custom-analysis=script/configs/custom_analysis.yaml (No issues found!)
flutter test test/checkbox_test.dart test/radio_test.dart test/range_slider_test.dart test/toggle_buttons_test.dart (198 tests passed)

The GitHub label/check-change gates have run; waiting for the remaining Linux analyze master/stable presubmit statuses to be scheduled/reported.

auto-submit · 2026-06-26T17:10:20Z

autosubmit label was removed for flutter/packages/11983, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

QuncCccccc

LGTM

…er#188792) flutter/packages@656ccaa...274ed3e 2026-06-30 nateshmbhat1@gmail.com [video_player_android] Add video track selection support (flutter/packages#11475) 2026-06-30 engine-flutter-autoroll@skia.org Manual roll Flutter from b081f33 to 0c80830 (1 revision) (flutter/packages#12058) 2026-06-30 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove `widgets` import from `material_test.dart` (flutter/packages#12056) 2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove `widgets` imports from `card_test.dart`, `checkbox_list_tile_test.dart` (flutter/packages#12054) 2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove `widgets/clipboard_utils.dart`, `widgets/text_selection_toolbar_utils.dart` imports from `adaptive_text_selection_toolbar_test.dart` (flutter/packages#12053) 2026-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from 11e339e to b081f33 (1 revision) (flutter/packages#12050) 2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove `widgets/clipboard_utils.dart` imports from `date_picker_test.dart`, `input_date_picker_form_field_test.dart`, `search_test.dart`, `selectable_text_test.dart`, `text_form_field_test.dart`, `text_selection_test.dart` (flutter/packages#12030) 2026-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from 87224e0 to 11e339e (4 revisions) (flutter/packages#12041) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `text_field_test` (flutter/packages#12022) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Port PR (flutter#184807) from flutter/flutter to material_ui (flutter/packages#11972) 2026-06-29 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `button_test.dart` to `SemanticsHandle` (flutter/packages#11992) 2026-06-29 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `radio_test.dart` to `SemanticsHandle` (flutter/packages#11981) 2026-06-29 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `picker_test.dart` to `SemanticsHandle` (flutter/packages#12008) 2026-06-29 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Create util files. Remove widgets import in `adaptive_text_selection_toolbar_test.dart` and `text_selection_test.dart` (flutter/packages#12023) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `floating_action_button_test` (flutter/packages#12014) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `dropdown_test` (flutter/packages#12011) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `chip_test` (flutter/packages#12009) 2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove widgets import in `data_table_test.dart`, `switch_test.dart` and `tooltip_theme_test.dart` (flutter/packages#12031) 2026-06-29 burak.karahan@mail.ru [material_ui] Port flutter/flutter flutter#186670 "Use local semantics tester in Material selection tests" (flutter/packages#11983) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `switch_list_tile_test` (flutter/packages#12020) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `popup_menu_test` (flutter/packages#12018) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `date_range_picker_test` (flutter/packages#12010) 2026-06-29 stuartmorgan@google.com [google_sign_in] Simplify Android user ID extraction (flutter/packages#12025) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actionsBot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 25, 2026

MarlonJD force-pushed the decoupling-port-186670 branch from 8c3a514 to 334905eCompare June 25, 2026 12:44

MarlonJD marked this pull request as ready for review June 25, 2026 12:44

MarlonJD mentioned this pull request Jun 25, 2026
Use local semantics tester in Material selection tests flutter/flutter#186670
Closed

gemini-code-assistBot reviewed Jun 25, 2026
View reviewed changes

Comment threadpackages/material_ui/test/slider_test.dart Outdated

test: use local material semantics tester imports
29324a4

MarlonJD force-pushed the decoupling-port-186670 branch from 334905e to 29324a4Compare June 25, 2026 12:49

Piinks changed the title ~~[Decoupling] Port flutter/flutter #186670 "Use local semantics tester in Material selection tests"~~[material_ui] Port flutter/flutter #186670 "Use local semantics tester in Material selection tests"Jun 25, 2026

justinmc approved these changes Jun 25, 2026
View reviewed changes

justinmc added the CICD Run CI/CD label Jun 25, 2026

test: drop already-ported material slider test move
ac8073e

github-actionsBot removed the CICD Run CI/CD label Jun 25, 2026

This was referenced Jun 25, 2026
[material_ui] Remove widgets import in radio_test.dart#11996
Closed
(Test cross-imports) Don't cross-import test utils flutter/flutter#182636
Open
Remove semantics_tester import from range_slider_test.dart flutter/flutter#185972
Closed

QuncCccccc added the CICD Run CI/CD label Jun 25, 2026

fix(material_ui): sort selection test imports
6c54de7

github-actionsBot removed the CICD Run CI/CD label Jun 25, 2026

QuncCccccc added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 25, 2026

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2026

QuncCccccc approved these changes Jun 26, 2026
View reviewed changes

Piinks removed the CICD Run CI/CD label Jun 29, 2026

Piinks added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 29, 2026

auto-submitBot merged commit 9d4c585 into flutter:mainJun 29, 2026
88 checks passed

engine-flutter-autoroll mentioned this pull request Jun 30, 2026
Roll Packages from 656ccaae4f49 to 274ed3e0f9f6 (23 revisions) flutter/flutter#188792
Merged

Navigation Menu

Uh oh!

[material_ui] Port flutter/flutter #186670 "Use local semantics tester in Material selection tests" - #11983

[material_ui] Port flutter/flutter #186670 "Use local semantics tester in Material selection tests"#11983
auto-submit[bot] merged 3 commits into
flutter:mainfrom
MarlonJD:decoupling-port-186670

MarlonJD commented Jun 25, 2026•
edited
Loading

Uh oh!

gemini-code-assistBot left a comment

Uh oh!

Uh oh!

MarlonJD commented Jun 25, 2026

Uh oh!

justinmc left a comment

Uh oh!

flutter-dashboardBot commented Jun 25, 2026

Uh oh!

MarlonJD commented Jun 25, 2026

Uh oh!

QuncCccccc commented Jun 25, 2026

Uh oh!

MarlonJD commented Jun 25, 2026

Uh oh!

auto-submitBot commented Jun 26, 2026

Uh oh!

QuncCccccc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

MarlonJD commented Jun 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assistBot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

MarlonJD commented Jun 25, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboardBot commented Jun 25, 2026

Uh oh!

MarlonJD commented Jun 25, 2026

Uh oh!

QuncCccccc commented Jun 25, 2026

Uh oh!

MarlonJD commented Jun 25, 2026

Uh oh!

auto-submitBot commented Jun 26, 2026

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MarlonJD commented Jun 25, 2026•
edited
Loading