Skip to content

[material_ui] Remove widgets imports from card_test.dart, checkbox_list_tile_test.dart - #12054

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_material_card_checkbox_list_tile_tests
Jun 29, 2026
Merged

[material_ui] Remove widgets imports from card_test.dart, checkbox_list_tile_test.dart#12054
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_material_card_checkbox_list_tile_tests

Conversation

@QuncCccccc

@QuncCcccccQuncCccccc commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-imports of widgets/feedback_tester.dart and widgets/semantics_tester.dart.
  • Removed @Skip tag, all tests in this file have passed.
  • Moved the files to test/ folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented
    exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Jun 29, 2026
@github-actionsgithub-actionsBot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 29, 2026
gemini-code-assist[bot]
gemini-code-assistBot reviewed Jun 29, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @Skip annotations from card_test.dart and checkbox_list_tile_test.dart, enabling these test files. Additionally, it reorganizes and updates the import paths within both files. There are no review comments, and I have no feedback to provide.

Piinks
Piinks approved these changes Jun 29, 2026
View reviewed changes

@PiinksPiinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one LGTM too!

@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2026
@auto-submit
auto-submitBot merged commit b3a895e into flutter:mainJun 29, 2026
87 checks passed
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 30, 2026
Merged
pullBot pushed a commit to safarmer/flutter that referenced this pull request Jun 30, 2026
@engine-flutter-autoroll
Roll Packages from 656ccaae4f49 to 274ed3e0f9f6 (23 revisions) (flutt…
1d3a9ae
…er#188792)
flutter/packages@656ccaa...274ed3e
2026-06-30 nateshmbhat1@gmail.com [video_player_android] Add video track
selection support (flutter/packages#11475)
2026-06-30 engine-flutter-autoroll@skia.org Manual roll Flutter from
b081f33 to 0c80830 (1 revision) (flutter/packages#12058)
2026-06-30 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove `widgets` import from `material_test.dart`
(flutter/packages#12056)
2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove `widgets` imports from `card_test.dart`,
`checkbox_list_tile_test.dart` (flutter/packages#12054)
2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove `widgets/clipboard_utils.dart`,
`widgets/text_selection_toolbar_utils.dart` imports from
`adaptive_text_selection_toolbar_test.dart` (flutter/packages#12053)
2026-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from
11e339e to b081f33 (1 revision) (flutter/packages#12050)
2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove `widgets/clipboard_utils.dart` imports from
`date_picker_test.dart`, `input_date_picker_form_field_test.dart`,
`search_test.dart`, `selectable_text_test.dart`,
`text_form_field_test.dart`, `text_selection_test.dart`
(flutter/packages#12030)
2026-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from
87224e0 to 11e339e (4 revisions) (flutter/packages#12041)
2026-06-29 21270878+elliette@users.noreply.github.com [material_ui]
Enable `text_field_test` (flutter/packages#12022)
2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Port
PR (flutter#184807) from flutter/flutter to material_ui
(flutter/packages#11972)
2026-06-29 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`button_test.dart` to `SemanticsHandle` (flutter/packages#11992)
2026-06-29 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`radio_test.dart` to `SemanticsHandle` (flutter/packages#11981)
2026-06-29 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`picker_test.dart` to `SemanticsHandle` (flutter/packages#12008)
2026-06-29 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui]
Create util files. Remove widgets import in
`adaptive_text_selection_toolbar_test.dart` and
`text_selection_test.dart` (flutter/packages#12023)
2026-06-29 21270878+elliette@users.noreply.github.com [material_ui]
Enable `floating_action_button_test` (flutter/packages#12014)
2026-06-29 21270878+elliette@users.noreply.github.com [material_ui]
Enable `dropdown_test` (flutter/packages#12011)
2026-06-29 21270878+elliette@users.noreply.github.com [material_ui]
Enable `chip_test` (flutter/packages#12009)
2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `data_table_test.dart`, `switch_test.dart` and
`tooltip_theme_test.dart` (flutter/packages#12031)
2026-06-29 burak.karahan@mail.ru [material_ui] Port flutter/flutter
flutter#186670 "Use local semantics tester in Material selection tests"
(flutter/packages#11983)
2026-06-29 21270878+elliette@users.noreply.github.com [material_ui]
Enable `switch_list_tile_test` (flutter/packages#12020)
2026-06-29 21270878+elliette@users.noreply.github.com [material_ui]
Enable `popup_menu_test` (flutter/packages#12018)
2026-06-29 21270878+elliette@users.noreply.github.com [material_ui]
Enable `date_range_picker_test` (flutter/packages#12010)
2026-06-29 stuartmorgan@google.com [google_sign_in] Simplify Android
user ID extraction (flutter/packages#12025)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiinksPiinksPiinks approved these changes
@justinmcjustinmcAwaiting requested review from justinmc
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: material_uitriage-frameworkShould be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc@Piinks