Skip to content

[quick_actions_ios]unskip XCUITests - #12436

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
hellohuanlin:quick_actions_unskip_ios_xcuitests
Aug 24, 2026
Merged

[quick_actions_ios]unskip XCUITests#12436
auto-submit[bot] merged 3 commits into
flutter:mainfrom
hellohuanlin:quick_actions_unskip_ios_xcuitests

Conversation

@hellohuanlin

@hellohuanlinhellohuanlin commented Aug 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

It looks like flutter/flutter#169928 has been addressed, so the test should already been passing.

See also: flutter/flutter#170180 (comment)

List which issues are fixed by this PR. You must list at least one issue.

Fixesflutter/flutter#190966

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Aug 11, 2026
gemini-code-assist[bot]
gemini-code-assistBot reviewed Aug 11, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables the testQuickActionWithFreshStart and testQuickActionWhenAppIsInBackground UI tests in RunnerUITests.swift by removing the temporary XCTSkip statements and their associated comments. There are no review comments, and I have no feedback to provide.

@hellohuanlinhellohuanlin mentioned this pull request Aug 11, 2026
Closed
@hellohuanlin
hellohuanlinforce-pushed the quick_actions_unskip_ios_xcuitests branch from 7d66fda to f935f31CompareAugust 18, 2026 21:28
@vashworth

vashworth commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@hellohuanlin The tests are still failing, is this ready for review?

@hellohuanlin
hellohuanlin marked this pull request as draft August 20, 2026 19:38
@hellohuanlin

hellohuanlin commented Aug 20, 2026

Copy link
Copy Markdown
ContributorAuthor

@vashworth sorry still on it. converted to draft

@hellohuanlin

hellohuanlin commented Aug 21, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

The test passed now, but it takes 120+ seconds. I filed a separate issue here: flutter/flutter#191467

Test case 'RunnerUITests.testQuickActionWhenAppIsInBackground()' passed on 'Clone 2 of Flutter-iPhone - RunnerUITests-Runner (36664)' (138.994 seconds)
Test case 'RunnerUITests.testQuickActionWithFreshStart()' passed on 'Clone 2 of Flutter-iPhone - RunnerUITests-Runner (36664)' (127.354 seconds)

@hellohuanlinhellohuanlin mentioned this pull request Aug 21, 2026
Open
@hellohuanlin
hellohuanlin marked this pull request as ready for review August 21, 2026 04:30
gemini-code-assist[bot]
gemini-code-assistBot reviewed Aug 21, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables the testQuickActionWithFreshStart and testQuickActionWhenAppIsInBackground UI tests in RunnerUITests.swift. It updates the springboard icon name to "Quick Actions Example" and modifies the element queries to use descendants(matching: .any) instead of otherElements to accommodate changes in Flutter's semantics type representation. There are no review comments, and I have no feedback to provide.

@hellohuanlinhellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2026
@auto-submit
auto-submitBot merged commit f8e559d into flutter:mainAug 24, 2026
13 checks passed
This was referenced Aug 25, 2026
Closed
Merged
zijiehe-google-com pushed a commit to zijiehe-google-com/flutter that referenced this pull request Aug 25, 2026
@engine-flutter-autoroll
Roll Packages from df2ba94faea6 to 740f09361ccc (17 revisions) (flutt…
15d8908
…er#191734)
flutter/packages@df2ba94...740f093
2026-08-25 srawlins@google.com [cupertino_ui] Remove unused parameters
from constructors of generic classes. (flutter/packages#12457)
2026-08-25 srawlins@google.com [material_ui] Remove unused parameters
from constructors of generic classes. (flutter/packages#12458)
2026-08-25 6655696+guidezpl@users.noreply.github.com Ignore shared code
for iOS platform implementation of Google Maps plugin
(flutter/packages#12529)
2026-08-25 136096126+glitchfl@users.noreply.github.com [cross_file]
fixed `readAsString` decoding in-memory bytes as UTF-16
(flutter/packages#12479)
2026-08-25 lozhkovoi@gmail.com [cupertino_ui] Remove two items assert to
allow CupertinoTabBar to have one tab (flutter/packages#12546)
2026-08-25 huahua8893@sina.cn [cupertino_ui] Fix covered sheet revealing
root route through top gap (flutter/packages#12530)
2026-08-25 fluttergithubbot@gmail.com Sync release-go_router-18.0.0 to
main (flutter/packages#12575)
2026-08-25 fluttergithubbot@gmail.com Sync release-material_ui-1.1.0 to
main (flutter/packages#12577)
2026-08-25 fluttergithubbot@gmail.com Sync release-cupertino_ui-1.0.1 to
main (flutter/packages#12576)
2026-08-24 41930132+hellohuanlin@users.noreply.github.com
[quick_actions_ios]unskip XCUITests (flutter/packages#12436)
2026-08-24 karthimanikuttan001@gmail.com Fix RangeSlider thumb overlay
remains visible after touch interaction ends (flutter/packages#12560)
2026-08-24 victor.orozco@cloudsufi.com [google_sign_in] Increase iOS
coverage tests (flutter/packages#12484)
2026-08-24 269567208+reidbaker-agent@users.noreply.github.com
[camera_android_camerax] Migrate from dart_skills_lint to skills_lint
(flutter/packages#12543)
2026-08-24 74037732+developerashkan@users.noreply.github.com [go_router]
Clarify onEnter/redirect ordering, add regression test
(flutter/packages#12337)
2026-08-24 brunocorona.alcantar@gmail.com [material_ui] Port
flutter/flutter flutter#185149 "Slider label clips the screen"
(flutter/packages#12572)
2026-08-24 engine-flutter-autoroll@skia.org Roll Flutter from
65c9a8d to 9a82789 (17 revisions) (flutter/packages#12578)
2026-08-24 stuartmorgan@google.com [tool] Fix dart_test.yaml parsing
(flutter/packages#12574)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworthvashworthvashworth approved these changes
@okorohelijahokorohelijahokorohelijah approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: quick_actionsplatform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[quick_actions_ios] integration test fails

3 participants

@hellohuanlin@vashworth@okorohelijah