Skip to content

[tool] Fix dart_test.yaml parsing - #12574

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
stuartmorgan-g:tool-dart-test-yaml-parse
Aug 24, 2026
Merged

[tool] Fix dart_test.yaml parsing#12574
auto-submit[bot] merged 2 commits into
flutter:mainfrom
stuartmorgan-g:tool-dart-test-yaml-parse

Conversation

@stuartmorgan-g

@stuartmorgan-gstuartmorgan-g commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Use YAML parsing rather than a regex to extract the test_on value from package-level dart_test.yaml files. This avoids failing to recognize valid values just because they don't match the exact regex format.

Fixesflutter/flutter#191495

@stuartmorgan-g
[tool] Fix dart_test.yaml parsing
ba90f5e
Use YAML parsing rather than a regex to extract the `test_on` value from
package-level dart_test.yaml files. This avoids failing to recognize
valid values just because they don't match the exact regex format.
Fixesflutter/flutter#191495
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Aug 24, 2026
gemini-code-assist[bot]
gemini-code-assistBot reviewed Aug 24, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces regex-based parsing of dart_test.yaml with YAML parsing using the yaml package, and adds a test to verify formatting flexibility. Feedback suggests handling cases where loadYaml returns null (such as empty files) to prevent an unintended FormatException, and correcting the filename in the error message from ci_config.yaml to dart_test.yaml.

Comment threadscript/tool/lib/src/dart_test_command.dart
elliette
elliette approved these changes Aug 24, 2026
View reviewed changes

@ellietteelliette left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2026
@auto-submit
auto-submitBot merged commit 4b8cb3f into flutter:mainAug 24, 2026
13 checks passed
This was referenced Aug 25, 2026
Closed
Merged
zijiehe-google-com pushed a commit to zijiehe-google-com/flutter that referenced this pull request Aug 25, 2026
@engine-flutter-autoroll
Roll Packages from df2ba94faea6 to 740f09361ccc (17 revisions) (flutt…
15d8908
…er#191734)
flutter/packages@df2ba94...740f093
2026-08-25 srawlins@google.com [cupertino_ui] Remove unused parameters
from constructors of generic classes. (flutter/packages#12457)
2026-08-25 srawlins@google.com [material_ui] Remove unused parameters
from constructors of generic classes. (flutter/packages#12458)
2026-08-25 6655696+guidezpl@users.noreply.github.com Ignore shared code
for iOS platform implementation of Google Maps plugin
(flutter/packages#12529)
2026-08-25 136096126+glitchfl@users.noreply.github.com [cross_file]
fixed `readAsString` decoding in-memory bytes as UTF-16
(flutter/packages#12479)
2026-08-25 lozhkovoi@gmail.com [cupertino_ui] Remove two items assert to
allow CupertinoTabBar to have one tab (flutter/packages#12546)
2026-08-25 huahua8893@sina.cn [cupertino_ui] Fix covered sheet revealing
root route through top gap (flutter/packages#12530)
2026-08-25 fluttergithubbot@gmail.com Sync release-go_router-18.0.0 to
main (flutter/packages#12575)
2026-08-25 fluttergithubbot@gmail.com Sync release-material_ui-1.1.0 to
main (flutter/packages#12577)
2026-08-25 fluttergithubbot@gmail.com Sync release-cupertino_ui-1.0.1 to
main (flutter/packages#12576)
2026-08-24 41930132+hellohuanlin@users.noreply.github.com
[quick_actions_ios]unskip XCUITests (flutter/packages#12436)
2026-08-24 karthimanikuttan001@gmail.com Fix RangeSlider thumb overlay
remains visible after touch interaction ends (flutter/packages#12560)
2026-08-24 victor.orozco@cloudsufi.com [google_sign_in] Increase iOS
coverage tests (flutter/packages#12484)
2026-08-24 269567208+reidbaker-agent@users.noreply.github.com
[camera_android_camerax] Migrate from dart_skills_lint to skills_lint
(flutter/packages#12543)
2026-08-24 74037732+developerashkan@users.noreply.github.com [go_router]
Clarify onEnter/redirect ordering, add regression test
(flutter/packages#12337)
2026-08-24 brunocorona.alcantar@gmail.com [material_ui] Port
flutter/flutter flutter#185149 "Slider label clips the screen"
(flutter/packages#12572)
2026-08-24 engine-flutter-autoroll@skia.org Roll Flutter from
65c9a8d to 9a82789 (17 revisions) (flutter/packages#12578)
2026-08-24 stuartmorgan@google.com [tool] Fix dart_test.yaml parsing
(flutter/packages#12574)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellietteellietteelliette approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[packages] Test infra: Skipping all tests for a package is considered a failure

2 participants

@stuartmorgan-g@elliette