[cupertino_ui] Remove unused parameters from constructors of generic classes. by srawlins · Pull Request #12457 · flutter/packages

srawlins · 2026-08-13T15:35:06Z

We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes.

This is work towards dart-lang/sdk#47839.

Pre-Review Checklist

Test exempt, as this code is covered by existing static and runtime checks.

We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839.

gemini-code-assist

Code Review

This pull request removes unused super.key and super.settings parameters from the constructors of several private classes within the cupertino_ui package, specifically in context_menu.dart, route.dart, segmented_control.dart, and sheet.dart. There are no review comments to address, and no further feedback is provided.

dkwingsmt

LGTM. Thank you for the clean up!

Piinks

This still needs the pending changelog entry.

auto-submit · 2026-08-25T00:45:05Z

autosubmit label was removed for flutter/packages/12457, because This PR has not met approval requirements for merging. Changes were requested by {Piinks}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 0 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

…ages into unused-generic-cup

Piinks

Private class changes, no changelog needed, override labels to land.

auto-submit · 2026-08-25T14:19:17Z

autosubmit label was removed for flutter/packages/12457, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

…er#191734) flutter/packages@df2ba94...740f093 2026-08-25 srawlins@google.com [cupertino_ui] Remove unused parameters from constructors of generic classes. (flutter/packages#12457) 2026-08-25 srawlins@google.com [material_ui] Remove unused parameters from constructors of generic classes. (flutter/packages#12458) 2026-08-25 6655696+guidezpl@users.noreply.github.com Ignore shared code for iOS platform implementation of Google Maps plugin (flutter/packages#12529) 2026-08-25 136096126+glitchfl@users.noreply.github.com [cross_file] fixed `readAsString` decoding in-memory bytes as UTF-16 (flutter/packages#12479) 2026-08-25 lozhkovoi@gmail.com [cupertino_ui] Remove two items assert to allow CupertinoTabBar to have one tab (flutter/packages#12546) 2026-08-25 huahua8893@sina.cn [cupertino_ui] Fix covered sheet revealing root route through top gap (flutter/packages#12530) 2026-08-25 fluttergithubbot@gmail.com Sync release-go_router-18.0.0 to main (flutter/packages#12575) 2026-08-25 fluttergithubbot@gmail.com Sync release-material_ui-1.1.0 to main (flutter/packages#12577) 2026-08-25 fluttergithubbot@gmail.com Sync release-cupertino_ui-1.0.1 to main (flutter/packages#12576) 2026-08-24 41930132+hellohuanlin@users.noreply.github.com [quick_actions_ios]unskip XCUITests (flutter/packages#12436) 2026-08-24 karthimanikuttan001@gmail.com Fix RangeSlider thumb overlay remains visible after touch interaction ends (flutter/packages#12560) 2026-08-24 victor.orozco@cloudsufi.com [google_sign_in] Increase iOS coverage tests (flutter/packages#12484) 2026-08-24 269567208+reidbaker-agent@users.noreply.github.com [camera_android_camerax] Migrate from dart_skills_lint to skills_lint (flutter/packages#12543) 2026-08-24 74037732+developerashkan@users.noreply.github.com [go_router] Clarify onEnter/redirect ordering, add regression test (flutter/packages#12337) 2026-08-24 brunocorona.alcantar@gmail.com [material_ui] Port flutter/flutter flutter#185149 "Slider label clips the screen" (flutter/packages#12572) 2026-08-24 engine-flutter-autoroll@skia.org Roll Flutter from 65c9a8d to 9a82789 (17 revisions) (flutter/packages#12578) 2026-08-24 stuartmorgan@google.com [tool] Fix dart_test.yaml parsing (flutter/packages#12574) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…sses (flutter#191398) We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839 This change is mirrored at flutter/packages#12457 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…classes. (flutter#12457) We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839. ## Pre-Review Checklist Test exempt, as this code is covered by existing static and runtime checks.

Remove unused parameters from constructors of generic classes.
0e7c0e6
We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839.

flutter-dashboardBot added the CICD Run CI/CD label Aug 13, 2026

github-actionsBot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Aug 13, 2026

gemini-code-assistBot reviewed Aug 13, 2026
View reviewed changes

Piinks added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 17, 2026

dkwingsmt self-requested a review August 19, 2026 18:37

srawlins mentioned this pull request Aug 20, 2026
[cupertino] Remove unused parameters from constructors of generic classes flutter/flutter#191398
Merged
10 tasks

dkwingsmt approved these changes Aug 25, 2026
View reviewed changes

Merge branch 'main' into unused-generic-cup
35ff67b

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2026

Piinks requested changes Aug 25, 2026
View reviewed changes

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2026

srawlins added 4 commits August 24, 2026 18:01

Merge branch 'main' into unused-generic-cup
07245c8

changelog
bcd743b

Merge branch 'unused-generic-cup' of github.com:srawlins/flutter-pack…
a4e5bad
…ages into unused-generic-cup

pending
ffdfd7e

Piinks reviewed Aug 25, 2026
View reviewed changes

Comment threadpackages/cupertino_ui/CHANGELOG.md Outdated

Update packages/cupertino_ui/CHANGELOG.md
888a5ed

Piinks approved these changes Aug 25, 2026
View reviewed changes

Piinks added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes autosubmit Merge PR when tree becomes green via auto submit App labels Aug 25, 2026

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2026

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2026

auto-submitBot merged commit 740f093 into flutter:mainAug 25, 2026
13 checks passed

engine-flutter-autoroll mentioned this pull request Aug 25, 2026
Roll Packages from df2ba94faea6 to 740f09361ccc (17 revisions) flutter/flutter#191734
Merged

Navigation Menu

Uh oh!

[cupertino_ui] Remove unused parameters from constructors of generic classes. - #12457

[cupertino_ui] Remove unused parameters from constructors of generic classes.#12457
auto-submit[bot] merged 7 commits into
flutter:mainfrom
srawlins:unused-generic-cup

srawlins commented Aug 13, 2026•
edited
Loading

Uh oh!

gemini-code-assistBot left a comment

Uh oh!

dkwingsmt left a comment

Uh oh!

Piinks left a comment

Uh oh!

auto-submitBot commented Aug 25, 2026

Uh oh!

Uh oh!

Piinks left a comment

Uh oh!

auto-submitBot commented Aug 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

srawlins commented Aug 13, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Uh oh!

gemini-code-assistBot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submitBot commented Aug 25, 2026

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submitBot commented Aug 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

srawlins commented Aug 13, 2026•
edited
Loading