Skip to content

Adds animations package with open container transition - #30

Merged
goderbauer merged 19 commits into
flutter:masterfrom
goderbauer:animations
Nov 26, 2019
Merged

Adds animations package with open container transition#30
goderbauer merged 19 commits into
flutter:masterfrom
goderbauer:animations

Conversation

@goderbauer

@goderbauergoderbauer commented Aug 28, 2019

Copy link
Copy Markdown
Member

This adds a new package:animations to the repository, which will contain fancy pre-built animations that can be customized with content and dropped into any application to delight its users.

The first animation added in this patch is Material's Open Container Transition. It displays some kind of a container (e.g. a Card or Button) on screen and when tapped the container expands its size to take up the entire space of the surrounding navigator to reveal more content.

I am currently working on adding tests for this. In a follow-up PR I also plan to add an example application in which users can try out these effects.

HansMuller
HansMuller reviewed Sep 4, 2019
View reviewed changes

@HansMullerHansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only halfway through this. So far, just trivial comments to mark my progress :-).

Comment threadpackages/animations/lib/src/open_container.dart Outdated
/// Signature for a function that creates a [Widget] to be used within an
/// [OpenContainer].
///
/// The `action` callback provided to [OpenContainer.closedBuilder] can be used

@HansMullerHansMullerSep 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openBuilder?

Comment threadpackages/animations/lib/src/open_container.dart Outdated
/// The `action` callback provided to [OpenContainer.closedBuilder] can be used
/// to open the container. The `action` callback provided to
/// [OpenContainer.closedBuilder] can be used to close the container again.
typedef OpenContainerChildBuilder = Widget Function(

@HansMullerHansMullerSep 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just call this OpenContainerBuilder? That would forgo any discussion about if what was being built was actually the container's child, or a descendant.

Comment threadpackages/animations/lib/src/open_container.dart Outdated
VoidCallback action,
);

/// Container, that grows to fill the screen to reveal new content when tapped.

@HansMullerHansMullerSep 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A container that grows...

Comment threadpackages/animations/lib/src/open_container.dart Outdated
/// Container, that grows to fill the screen to reveal new content when tapped.
///
/// While the container is closed, it shows the [Widget] returned by
/// [closedBuilder]. When the container is tapped the container opens: It grows

@HansMullerHansMullerSep 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the container is tapped it grows

Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart Outdated
@override
Widget build(BuildContext context) {
return _Hideable(
key: _hidableKey,

@HansMullerHansMullerSep 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency is key :-) _hideable

Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart Outdated
Size get placeholder => _placeholder;
Size _placeholder;
set placeholder(Size value) {
if (_placeholder == value) {

@HansMullerHansMullerSep 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert value != null here?

@goderbauergoderbauerSep 4, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null is totally ok here, it means "don't use the placeholder" as per doc comment.

Comment threadpackages/animations/lib/src/open_container.dart Outdated

class _HideableState extends State<_Hideable> {
/// When non-null the child is replaced by a [SizedBox] of the set size.
Size get placeholder => _placeholder;

@HansMullerHansMullerSep 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property sounds like a widget value, maybe placeholderSize?

Comment threadpackages/animations/lib/src/open_container.dart Outdated
///
/// The value of this property is ignored when [placeholder] is non-null (i.e.
/// [isInTree] returns false).
bool get visible => _visible;

@HansMullerHansMullerSep 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe isVisible because bool?

HansMuller
HansMuller reviewed Sep 5, 2019
View reviewed changes

@HansMullerHansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small stuff here. The only things that worried me (a little) was the shape of the underlying material when the animation ended, and the possibility that the entire tree might have been destroyed by the time the postFrameCallback runs.

Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart Outdated
}

@override
Duration get transitionDuration => const Duration(milliseconds: 300);

@HansMullerHansMullerSep 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be a parameter

@goderbauergoderbauerSep 5, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@goderbauergoderbauer mentioned this pull request Sep 5, 2019
Open
goderbauer
goderbauer commented Sep 5, 2019
View reviewed changes

@goderbauergoderbauer left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Addressed all comments. PTAL

Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart Outdated
}

@override
Duration get transitionDuration => const Duration(milliseconds: 300);

@goderbauergoderbauerSep 5, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Comment threadpackages/animations/lib/src/open_container.dart
Comment threadpackages/animations/lib/src/open_container.dart
HansMuller
HansMuller approved these changes Nov 22, 2019
View reviewed changes

@HansMullerHansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, even if it's just v0. Looking forward to trying it out.

LGTM

Comment threadpackages/animations/lib/src/open_container.dart
/// See also:
///
/// * [Material.elevation], which is used to implement this property.
final double closedElevation;

@HansMullerHansMullerNov 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe open and closed elevation parameters should be Animatable<double>, so instead of

closedElevation:0,
openElevation:4,

You'd write

elevation:Tween<double>(begin:0, end:4),

The advantage is that you the developer could define an arbitrary elevation change (could be defined with a TweenSequence for example). The disadvantage is that it's not as clear: is "begin" open or closed?.

The open and closed shape properties could be handled similarly.

@goderbauergoderbauerNov 25, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talking this over, we decided to not add more configurability to this for now.

Comment threadpackages/animations/lib/src/open_container.dart
/// `action` callback that is provided to the [closedBuilder].
final bool tappable;

/// The time it will take to animate the container from its closed to its

@HansMullerHansMullerNov 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe provide open and closed durations?

@goderbauergoderbauerNov 25, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying ModalRoute would have to be extended for this to support different durations.

Comment threadpackages/animations/lib/src/open_container.dart Outdated
/// to its original size while the widget returned by [openBuilder] is faded out
/// and the widget returned by [openBuilder] is faded back in.
///
/// By default, the container is in the closed state.

@HansMullerHansMullerNov 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding things correctly, during the transition the widgets returned by the open and closed builders exist at the same time. Do we have to warn developers that these widgets cannot include the same global key?

@goderbauergoderbauerNov 25, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a warning.

Comment threadpackages/animations/lib/src/open_container.dart Outdated
final Rect rect = _insetsTween.evaluate(curvedAnimation);
final Size size = _sizeTween.evaluate(curvedAnimation);

return Container(

@HansMullerHansMullerNov 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a Padding widget

@goderbauergoderbauerNov 25, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

Comment threadpackages/animations/lib/src/open_container.dart
final Size size = _sizeTween.evaluate(curvedAnimation);

return Container(
padding: EdgeInsets.fromLTRB(

@HansMullerHansMullerNov 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we don't have EdgeInsets.fromRect()

@goderbauergoderbauerNov 25, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good addition. Filed flutter/flutter#45576.

Comment threadpackages/animations/lib/src/open_container.dart
height: size.height,
child: Material(
clipBehavior: Clip.antiAlias,
animationDuration: Duration.zero,

@HansMullerHansMullerNov 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need a Material.noImpliciAnimation() constructor - except with a better name.

@goderbauergoderbauerNov 25, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do! flutter/flutter#45577

Comment threadpackages/animations/README.md
@@ -0,0 +1,15 @@
# Fancy pre-built Animations for Flutter

@HansMullerHansMullerNov 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually we should up with a less fanciful (ha) description of this package. Here and elsewhere.

Comment threadpackages/animations/test/open_container_test.dart
matching: find.byType(Material),
),
);
final Material srcMaterial = srcMaterialElement.widget;

@HansMullerHansMullerNov 22, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we don't use tester.widget here. Wouldn't this work?

finalMaterial material = tester.widget<Material>(
find.ancestor(
of: find.text('Closed'),
matching: find.byType(Material),
),
);

@goderbauergoderbauerNov 25, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do that here. But further down I am checking how the Widget configuration of this element is changing over time and it this makes the test more symmetric.

@goderbauer
goderbauer merged commit 0b809df into flutter:masterNov 26, 2019
@goderbauer
goderbauer deleted the animations branch November 26, 2019 17:54
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
@dnfield
Fix gradient regressions, OoO support for use/gradients (#30)
b26bf0e
* Fix gradient regressions, OoO support for use/gradients
- Defer resolution to build and assert resolution doesn't happen during parsing.
- Fix regressions introduced in the last commit around userSpaceOnUse with transforms
for linear gradients, and regressions around radial gradients in general.
- Tests
Things that are still wrong:
- I noticed while working on flutter_svg's "devil" SVG test that blends are not
being accurately applied to individual paths. I'll try to address that
in a separate PR.
- userSpaceOnUse gradients with transforms are not being applied correctly. This
has been an issue in this repo forever, not a regression. Gotta figure out how
to properly transform the gradient to the transformed path coordinate space.
See https://github.com/dnfield/flutter_svg/pull/54/files#r216222991 and the
test files added in that PR, which do not compile correctly today.
* fix inheritence for gradient properties
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@goderbauer
Adds animations package with open container transition (flutter#30)
ea7f147
chunhtai pushed a commit to chunhtai/packages that referenced this pull request Jun 12, 2026
@fzyzcjy
Fix Null check operator used on a null value on TextField with cont…
efdf94f
…extMenuBuilder (#128114)
Close #128113 Fun fact: This is caught by monkey testing I have written (will soon be open sourced as well) that runs on my app!
Without the fix, the test fails as expected:
<details>
```
(base) � flutter git:(feat/text-field-npe) /Volumes/MyExternal/ExternalRefCode/flutter/bin/flutter test test/material/text_field_test.dart --name 'changes from default'
00:06 +0: context menu contextMenuBuilder changes from default to null ��� EXCEPTION CAUGHT BY WIDGETS LIBRARY ������������������������������������������������������������
The following _TypeError was thrown building
_OverlayEntryWidget-[LabeledGlobalKey<_OverlayEntryWidgetState>#e3717](state:
_OverlayEntryWidgetState#7666a):
Null check operator used on a null value
When the exception was thrown, this was the stack:
#0 EditableTextState._createSelectionOverlay.<anonymous closure> (package:flutter/src/widgets/editable_text.dart:3331:43)
flutter#1 SelectionOverlay.showToolbar.<anonymous closure> (package:flutter/src/widgets/text_selection.dart:1357:36)
flutter#2 ContextMenuController.show.<anonymous closure> (package:flutter/src/widgets/context_menu_controller.dart:65:54)
flutter#3 _OverlayEntryWidgetState.build (package:flutter/src/widgets/overlay.dart:351:36)
flutter#4 StatefulElement.build (package:flutter/src/widgets/framework.dart:5198:27)
flutter#5 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5086:15)
flutter#6 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#7 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#8 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#9 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#10 RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:6093:32)
flutter#11 MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6595:17)
flutter#12 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#13 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#14 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#15 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#16 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#17 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#18 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#19 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#20 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#21 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#22 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#23 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#24 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#25 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#26 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#27 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#28 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#29 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#30 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#31 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#32 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#33 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#34 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#35 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#36 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#37 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#38 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#39 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#40 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#41 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#42 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#43 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#44 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#45 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#46 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#47 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#48 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#49 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#50 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#51 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#52 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#53 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#54 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#55 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#56 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#57 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#58 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#59 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#60 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#61 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#62 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#63 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#64 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#65 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#66 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#67 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#68 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#69 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#70 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#71 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#72 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#73 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#74 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#75 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#76 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#77 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#78 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#79 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#80 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#81 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#82 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#83 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#84 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#85 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#86 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#87 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#88 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#89 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#90 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#91 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#92 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#93 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#94 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#95 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#96 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#97 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#98 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#99 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#100 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#101 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#102 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#103 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#104 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#105 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#106 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#107 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#108 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#109 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#110 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#111 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#112 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#113 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#114 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#115 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#116 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#117 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#118 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#119 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#120 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#121 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#122 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#123 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#124 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#125 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#126 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#127 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#128 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#129 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#130 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#131 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#132 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#133 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#134 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#135 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#136 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#137 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#138 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#139 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#140 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#141 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#142 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#143 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#144 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#145 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#146 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#147 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#148 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#149 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#150 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#151 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#152 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#153 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#154 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#155 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#156 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#157 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#158 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#159 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#160 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#161 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#162 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#163 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#164 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#165 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#166 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#167 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#168 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#169 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#170 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#171 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#172 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#173 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#174 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#175 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#176 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#177 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#178 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#179 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#180 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#181 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#182 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#183 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#184 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#185 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#186 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#187 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#188 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#189 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#190 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#191 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#192 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#193 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#194 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#195 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#196 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#197 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#198 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#199 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#200 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#201 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#202 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#203 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#204 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#205 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#206 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#207 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#208 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#209 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#210 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#211 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#212 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#213 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#214 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#215 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#216 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#217 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#218 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#219 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#220 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#221 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#222 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#223 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#224 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#225 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#226 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#227 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#228 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#229 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#230 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#231 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#232 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#233 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#234 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#235 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#236 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#237 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#238 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#239 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#240 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#241 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#242 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#243 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#244 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#245 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#246 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#247 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#248 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#249 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#250 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#251 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#252 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#253 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#254 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#255 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#256 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#257 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#258 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#259 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#260 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#261 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#262 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#263 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#264 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#265 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#266 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#267 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#268 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#269 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#270 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#271 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#272 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#273 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#274 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#275 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#276 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#277 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#278 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#279 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#280 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#281 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#282 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#283 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#284 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#285 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#286 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#287 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#288 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#289 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#290 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#291 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#292 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#293 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#294 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#295 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#296 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#297 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#298 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#299 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#300 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#301 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#302 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#303 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#304 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#305 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#306 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#307 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#308 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#309 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#310 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#311 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#312 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#313 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#314 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#315 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#316 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#317 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#318 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#319 RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:1253:16)
flutter#320 RenderObjectToWidgetElement.update (package:flutter/src/widgets/binding.dart:1230:5)
flutter#321 RenderObjectToWidgetElement.performRebuild (package:flutter/src/widgets/binding.dart:1244:7)
flutter#322 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#323 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2780:19)
flutter#324 AutomatedTestWidgetsFlutterBinding.drawFrame (package:flutter_test/src/binding.dart:1396:19)
flutter#325 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:358:5)
flutter#326 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1297:15)
flutter#327 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1227:9)
flutter#328 AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:1246:9)
flutter#331 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41)
flutter#332 AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:1232:27)
flutter#333 WidgetTester._pumpWidget (package:flutter_test/src/widget_tester.dart:587:20)
flutter#334 WidgetTester.pumpWidget.<anonymous closure> (package:flutter_test/src/widget_tester.dart:572:14)
flutter#337 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41)
flutter#338 WidgetTester.pumpWidget (package:flutter_test/src/widget_tester.dart:571:27)
flutter#339 main.<anonymous closure>.<anonymous closure> (file:///Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart:15687:20)
<asynchronous suspension>
<asynchronous suspension>
(elided 5 frames from dart:async and package:stack_trace)
����������������������������������������������������������������������������������������������������
00:06 +0 -1: context menu contextMenuBuilder changes from default to null [E] Test failed. See exception logs above.
The test description was: contextMenuBuilder changes from default to null
To run this test again: /Volumes/MyExternal/ExternalRefCode/flutter/bin/cache/dart-sdk/bin/dart test /Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart -p vm --plain-name 'context menu contextMenuBuilder changes from default to null'
00:06 +0 -1: Some tests failed. (base) � flutter git:(feat/text-field-npe) ```
</details>
chunhtai pushed a commit to chunhtai/packages that referenced this pull request Jun 12, 2026
@liumcse
Slider should check mounted before start interaction (#132010)
c2e464a
This is a follow up to the following pull requests:
- flutter/flutter#124514
I was finally able to reproduce this bug and found out why it was happening. Consider this code:
```dart
GestureDetector(
behavior: HitTestBehavior.translucent,
// Note: Make sure onTap is not null to ensure events
// are captured by `GestureDetector`
onTap: () {},
child: _shouldShowSlider
? Slider(value: _value, onChanged: _handleSlide)
: const SizedBox.shrink().
)
```
Runtime exception happens when:
1. User taps and holds the Slider (drag callback captured by `GestureDetector`)
2. `_shouldShowSlider` changes to false, Slider disappears and unmounts, and unregisters `_handleSlide`. But the callback is still registered by `GestureDetector`
3. Users moves finger as if Slider were still there
4. Drag callback is invoked, `_SliderState.showValueIndicator` is called
5. Exception - Slider is already disposed
This pull request fixes it by adding a mounted check inside `_SliderState.showValueIndicator` to ensure the Slider is actually mounted at the time of invoking drag event callback. I've added a unit test that will fail without this change.
The error stack trace is:
```
The following assertion was thrown while handling a gesture:
This widget has been unmounted, so the State no longer has a context (and should be considered
defunct).
Consider canceling any active work during "dispose" or using the "mounted" getter to determine if
the State is still active.
When the exception was thrown, this was the stack:
#0 State.context.<anonymous closure> (package:flutter/src/widgets/framework.dart:950:9)
flutter#1 State.context (package:flutter/src/widgets/framework.dart:956:6)
flutter#2 _SliderState.showValueIndicator (package:flutter/src/material/slider.dart:968:18)
flutter#3 _RenderSlider._startInteraction (package:flutter/src/material/slider.dart:1487:12)
flutter#4 _RenderSlider._handleDragStart (package:flutter/src/material/slider.dart:1541:5)
flutter#5 DragGestureRecognizer._checkStart.<anonymous closure> (package:flutter/src/gestures/monodrag.dart:531:53)
flutter#6 GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:275:24)
flutter#7 DragGestureRecognizer._checkStart (package:flutter/src/gestures/monodrag.dart:531:7)
flutter#8 DragGestureRecognizer._checkDrag (package:flutter/src/gestures/monodrag.dart:498:5)
flutter#9 DragGestureRecognizer.acceptGesture (package:flutter/src/gestures/monodrag.dart:431:7)
flutter#10 _CombiningGestureArenaMember.acceptGesture (package:flutter/src/gestures/team.dart:45:14)
flutter#11 GestureArenaManager._resolveInFavorOf (package:flutter/src/gestures/arena.dart:281:12)
flutter#12 GestureArenaManager._resolve (package:flutter/src/gestures/arena.dart:239:9)
flutter#13 GestureArenaEntry.resolve (package:flutter/src/gestures/arena.dart:53:12)
flutter#14 _CombiningGestureArenaMember._resolve (package:flutter/src/gestures/team.dart:85:15)
flutter#15 _CombiningGestureArenaEntry.resolve (package:flutter/src/gestures/team.dart:19:15)
flutter#16 OneSequenceGestureRecognizer.resolve (package:flutter/src/gestures/recognizer.dart:375:13)
flutter#17 DragGestureRecognizer.handleEvent (package:flutter/src/gestures/monodrag.dart:414:13)
flutter#18 PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:98:12)
flutter#19 PointerRouter._dispatchEventToRoutes.<anonymous closure> (package:flutter/src/gestures/pointer_router.dart:143:9)
flutter#20 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13)
flutter#21 PointerRouter._dispatchEventToRoutes (package:flutter/src/gestures/pointer_router.dart:141:18)
flutter#22 PointerRouter.route (package:flutter/src/gestures/pointer_router.dart:127:7)
flutter#23 GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:488:19)
flutter#24 GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:468:22)
flutter#25 RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:439:11)
flutter#26 GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:413:7)
flutter#27 GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:376:5)
flutter#28 GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:323:7)
flutter#29 GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:292:9)
flutter#30 _invoke1 (dart:ui/hooks.dart:186:13)
flutter#31 PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:433:7)
flutter#32 _dispatchPointerDataPacket (dart:ui/hooks.dart:119:31)
Handler: "onStart"
Recognizer:
HorizontalDragGestureRecognizer#a5df2
```
*List which issues are fixed by this PR. You must list at least one issue.*
Internal bug: b/273666179, b/192329942
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@HansMullerHansMullerHansMuller approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer@HansMuller