Skip to content

Added experimental code generator tool for platform channels: Pigeon - #77

Merged
gaaclarke merged 17 commits into
flutter:masterfrom
gaaclarke:pigeon
Feb 7, 2020
Merged

Added experimental code generator tool for platform channels: Pigeon#77
gaaclarke merged 17 commits into
flutter:masterfrom
gaaclarke:pigeon

Conversation

@gaaclarke

@gaaclarkegaaclarke commented Jan 31, 2020

Copy link
Copy Markdown
Member

No description provided.

@gaaclarkegaaclarke changed the title PigeonAdded experimental code generator tool for platform channels: PigeonJan 31, 2020
@gaaclarke
gaaclarke requested a review from mklimJanuary 31, 2020 22:18
blasten
blasten reviewed Feb 4, 2020
View reviewed changes

@blastenblasten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of comments

Comment threadpackages/pigeon/.gitignore Outdated
@@ -0,0 +1,2 @@
build/
e2e_tests/test_objc/ios/Flutter/ No newline at end of file

@blastenblastenFeb 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eof

@gaaclarkegaaclarkeFeb 4, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment threadpackages/pigeon/README.md
Comment threadpackages/pigeon/README.md
testWidgets("test pigeon", (WidgetTester tester) async {
SearchRequest request = SearchRequest()..query = "Aaron";
Api api = Api();
SearchReply reply = await api.search(request);

@blastenblastenFeb 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this actually calling the objective-C implementation under the hood?

@gaaclarkegaaclarkeFeb 4, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

Comment threadpackages/pigeon/lib/pigeon_lib.dart
help: 'Prefix for generated Objective-C classes and protocols.');

/// Convert command-line arugments to [PigeonOptions].
static PigeonOptions parseArgs(List<String> args) {

@blastenblastenFeb 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use args instead. https://pub.dev/packages/args

@gaaclarkegaaclarkeFeb 4, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am, it is used inside this function =)

Comment threadpackages/pigeon/bin/pigeon.dart
}
""";
const String tempFilename = '_pigeon_temp_.dart';
final File tempFile = await File(tempFilename).writeAsString(code);

@blastenblastenFeb 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the file already exists? Can you use createTempSync?

@gaaclarkegaaclarkeFeb 4, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the plan, added a todo. It's not trivial since I have to make dart able to read in the current package from a different directory.

Comment threadpackages/pigeon/lib/ast.dart
String returnType;

/// The data-type of the argument.
String argType;

@blastenblastenFeb 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@gaaclarkegaaclarkeFeb 4, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment threadpackages/pigeon/lib/ast.dart

/// All the API's contained in the AST.
List<Api> apis;
}

@blastenblastenFeb 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should each of this entities have a location in code? The location contains the line number and column, which can be used to provide syntax errors? e.g. a type or construct isn't supported, etc..

@gaaclarkegaaclarkeFeb 4, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we'll have to have that in the future. That is already showing up in my Error class. It's also why I have the Node superclass, i'll probably put source and line in that.

Comment threadpackages/pigeon/lib/dart_generator.dart
@@ -0,0 +1,75 @@
import 'ast.dart';

@blastenblastenFeb 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: copyright header

@gaaclarkegaaclarkeFeb 4, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment threadpackages/pigeon/test/dart_generator_test.dart
final StringBuffer sink = StringBuffer();
generateDart(root, sink);
final String code = sink.toString();
expect(code, contains('class Foobar'));

@blastenblastenFeb 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about structuring the tests such that for each one there's an input file and then the expected output files. This way, we can have end-to-end testing and less boilerplate in the test.

@gaaclarkegaaclarkeFeb 4, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have end to end tests too, they aren't getting checked in with this PR though because it would explode the pr to 95 files and there are still some bugs to chase in e2e package. The way I usually work is that when I get an error in the e2e tests I try to write a unit test that reproduces the error.

Comment threadpackages/pigeon/test/objc_generator_test.dart
import 'package:pigeon/objc_generator.dart';
import 'package:pigeon/ast.dart';

void main() {

@blastenblastenFeb 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment about test structure

@gaaclarkegaaclarkeFeb 4, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@gaaclarke

gaaclarke commented Feb 4, 2020

Copy link
Copy Markdown
MemberAuthor

First round of comments

Thanks for the review. Some of the stuff i've documented with TODO's. There is a lot more work to do here. I want to pin this version since it has an end to end slice that can be used and we can get some feedback on it.

@xsterxster mentioned this pull request Feb 4, 2020
Closed
mklim
mklim reviewed Feb 7, 2020
View reviewed changes
Comment threadpackages/pigeon/README.md
Comment threadpackages/pigeon/README.md
Comment threadpackages/pigeon/README.md
Comment threadpackages/pigeon/bin/pigeon.dart Outdated
Comment threadpackages/pigeon/bin/pigeon.dart Outdated
assert(opts.input != null);
String code = '';
if (opts.input != null) {
code = 'import \'${opts.input}\';\n';

@mklimmklimFeb 6, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can there be more than one import?

@gaaclarkegaaclarkeFeb 7, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, there is a special way to specify those flags with args

@mklimmklimFeb 7, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to document that somewhere (unless you already did and I missed it).

@gaaclarkegaaclarkeFeb 7, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's defined in the tool's help

Comment threadpackages/pigeon/lib/dart_generator.dart
Comment threadpackages/pigeon/lib/dart_generator.dart
Comment threadpackages/pigeon/lib/dart_generator.dart
Comment threadpackages/pigeon/lib/generator_tools.dart
Comment threadpackages/pigeon/lib/objc_generator.dart
}
}

const Map<String, String> _objcTypeForDartTypeMap = <String, String>{

@mklimmklimFeb 7, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this handle maps or generic list types?

@gaaclarkegaaclarkeFeb 7, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, i worked off the documentation for platform channels. If StandardMessageCodec supports it I can add it later.

@mklimmklimFeb 7, 2020•
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does support it yeah. It's not super clear but that's what it means by List and Map in https://flutter.dev/docs/development/platform-integration/platform-channels#codec.

If you pass a List<Map<String, List<int>> across the platform channels it will involve some boilerplate to serialize and unparse at each end, but the channel does support it. That specific type is convoluted but as a more realistic example we have a bunch of plugins that pass across effectively a Map<String, dynamic> that then cast that dynamic to stuff like List<int> or even List<Map<String, dynamic>> later on. The in_app_purchase plugin is probably the biggest example.

@gaaclarkegaaclarkeFeb 7, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added note to README about generics not being supported yet.

@gaaclarke
gaaclarke requested a review from mklimFebruary 7, 2020 01:17
mklim
mklim reviewed Feb 7, 2020
View reviewed changes
Comment threadpackages/pigeon/README.md

Pigeon uses the `StandardMessageCodec` so it supports any data-type platform
channels supports
[[documentation](https://flutter.dev/docs/development/platform-integration/platform-channels#codec)]. Nested data-types are supported, too.

@mklimmklimFeb 7, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think from other conversations on this PR this actually doesn't support the full range, so it's worth mentioning that as a caveat here. The platform channels codec does support stuff like Map<int, List<String>> natively.

@gaaclarkegaaclarkeFeb 7, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to README

Comment threadpackages/pigeon/lib/objc_generator.dart
}
}

const Map<String, String> _objcTypeForDartTypeMap = <String, String>{

@mklimmklimFeb 7, 2020•
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does support it yeah. It's not super clear but that's what it means by List and Map in https://flutter.dev/docs/development/platform-integration/platform-channels#codec.

If you pass a List<Map<String, List<int>> across the platform channels it will involve some boilerplate to serialize and unparse at each end, but the channel does support it. That specific type is convoluted but as a more realistic example we have a bunch of plugins that pass across effectively a Map<String, dynamic> that then cast that dynamic to stuff like List<int> or even List<Map<String, dynamic>> later on. The in_app_purchase plugin is probably the biggest example.

Comment threadpackages/pigeon/bin/pigeon.dart Outdated
assert(opts.input != null);
String code = '';
if (opts.input != null) {
code = 'import \'${opts.input}\';\n';

@mklimmklimFeb 7, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to document that somewhere (unless you already did and I missed it).

@gaaclarke
gaaclarke requested a review from mklimFebruary 7, 2020 21:16
mklim
mklim approved these changes Feb 7, 2020
View reviewed changes

@mklimmklim left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gaaclarke
gaaclarke merged commit 10dfe5b into flutter:masterFeb 7, 2020
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
Jonah Williams
switch to animation for opacity, update docs (#77)
3abf286
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@gaaclarke
Added experimental code generator tool for platform channels: Pigeon (f…
2266795
…lutter#77)
chunhtai pushed a commit to chunhtai/packages that referenced this pull request Jun 12, 2026
@fzyzcjy
Fix Null check operator used on a null value on TextField with cont…
efdf94f
…extMenuBuilder (#128114)
Close #128113 Fun fact: This is caught by monkey testing I have written (will soon be open sourced as well) that runs on my app!
Without the fix, the test fails as expected:
<details>
```
(base) � flutter git:(feat/text-field-npe) /Volumes/MyExternal/ExternalRefCode/flutter/bin/flutter test test/material/text_field_test.dart --name 'changes from default'
00:06 +0: context menu contextMenuBuilder changes from default to null ��� EXCEPTION CAUGHT BY WIDGETS LIBRARY ������������������������������������������������������������
The following _TypeError was thrown building
_OverlayEntryWidget-[LabeledGlobalKey<_OverlayEntryWidgetState>#e3717](state:
_OverlayEntryWidgetState#7666a):
Null check operator used on a null value
When the exception was thrown, this was the stack:
#0 EditableTextState._createSelectionOverlay.<anonymous closure> (package:flutter/src/widgets/editable_text.dart:3331:43)
flutter#1 SelectionOverlay.showToolbar.<anonymous closure> (package:flutter/src/widgets/text_selection.dart:1357:36)
flutter#2 ContextMenuController.show.<anonymous closure> (package:flutter/src/widgets/context_menu_controller.dart:65:54)
flutter#3 _OverlayEntryWidgetState.build (package:flutter/src/widgets/overlay.dart:351:36)
flutter#4 StatefulElement.build (package:flutter/src/widgets/framework.dart:5198:27)
flutter#5 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5086:15)
flutter#6 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#7 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#8 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#9 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#10 RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:6093:32)
flutter#11 MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6595:17)
flutter#12 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#13 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#14 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#15 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#16 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#17 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#18 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#19 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#20 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#21 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#22 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#23 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#24 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#25 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#26 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#27 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#28 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#29 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#30 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#31 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#32 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#33 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#34 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#35 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#36 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#37 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#38 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#39 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#40 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#41 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#42 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#43 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#44 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#45 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#46 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#47 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#48 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#49 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#50 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#51 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#52 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#53 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#54 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#55 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#56 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#57 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#58 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#59 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#60 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#61 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#62 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#63 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#64 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#65 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#66 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#67 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#68 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#69 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#70 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#71 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#72 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#73 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#74 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#75 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#76 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#77 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#78 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#79 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#80 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#81 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#82 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#83 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#84 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#85 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#86 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#87 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#88 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#89 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#90 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#91 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#92 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#93 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#94 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#95 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#96 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#97 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#98 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#99 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#100 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#101 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#102 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#103 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#104 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#105 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#106 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#107 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#108 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#109 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#110 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#111 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#112 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#113 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#114 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#115 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#116 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#117 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#118 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#119 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#120 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#121 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#122 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#123 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#124 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#125 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#126 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#127 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#128 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#129 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#130 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#131 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#132 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#133 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#134 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#135 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#136 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#137 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#138 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#139 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#140 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#141 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#142 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#143 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#144 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#145 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#146 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#147 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#148 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#149 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#150 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#151 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#152 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#153 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#154 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#155 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#156 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#157 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#158 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#159 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#160 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#161 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#162 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#163 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#164 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#165 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#166 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#167 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#168 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#169 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#170 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#171 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#172 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#173 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#174 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#175 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#176 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#177 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#178 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#179 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#180 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#181 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#182 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#183 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#184 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#185 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#186 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#187 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#188 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#189 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#190 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#191 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#192 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#193 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#194 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#195 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#196 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#197 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#198 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#199 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#200 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#201 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#202 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#203 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#204 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#205 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#206 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#207 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#208 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#209 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#210 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#211 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#212 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#213 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#214 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#215 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#216 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#217 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#218 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#219 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#220 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#221 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#222 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#223 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#224 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#225 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#226 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#227 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#228 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#229 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#230 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#231 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#232 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#233 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#234 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#235 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#236 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#237 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#238 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#239 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#240 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#241 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#242 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#243 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#244 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#245 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#246 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#247 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#248 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#249 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#250 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#251 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#252 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#253 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#254 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#255 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#256 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#257 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#258 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#259 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#260 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#261 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#262 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#263 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#264 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#265 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#266 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#267 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#268 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#269 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#270 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#271 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#272 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#273 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#274 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#275 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#276 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#277 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
flutter#278 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#279 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#280 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#281 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#282 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
flutter#283 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#284 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#285 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#286 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#287 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#288 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#289 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#290 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#291 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#292 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#293 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#294 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#295 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#296 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#297 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#298 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#299 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#300 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#301 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#302 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#303 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#304 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#305 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#306 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#307 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
flutter#308 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#309 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
flutter#310 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#311 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#312 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#313 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
flutter#314 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#315 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
flutter#316 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#317 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
flutter#318 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
flutter#319 RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:1253:16)
flutter#320 RenderObjectToWidgetElement.update (package:flutter/src/widgets/binding.dart:1230:5)
flutter#321 RenderObjectToWidgetElement.performRebuild (package:flutter/src/widgets/binding.dart:1244:7)
flutter#322 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
flutter#323 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2780:19)
flutter#324 AutomatedTestWidgetsFlutterBinding.drawFrame (package:flutter_test/src/binding.dart:1396:19)
flutter#325 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:358:5)
flutter#326 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1297:15)
flutter#327 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1227:9)
flutter#328 AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:1246:9)
flutter#331 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41)
flutter#332 AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:1232:27)
flutter#333 WidgetTester._pumpWidget (package:flutter_test/src/widget_tester.dart:587:20)
flutter#334 WidgetTester.pumpWidget.<anonymous closure> (package:flutter_test/src/widget_tester.dart:572:14)
flutter#337 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41)
flutter#338 WidgetTester.pumpWidget (package:flutter_test/src/widget_tester.dart:571:27)
flutter#339 main.<anonymous closure>.<anonymous closure> (file:///Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart:15687:20)
<asynchronous suspension>
<asynchronous suspension>
(elided 5 frames from dart:async and package:stack_trace)
����������������������������������������������������������������������������������������������������
00:06 +0 -1: context menu contextMenuBuilder changes from default to null [E] Test failed. See exception logs above.
The test description was: contextMenuBuilder changes from default to null
To run this test again: /Volumes/MyExternal/ExternalRefCode/flutter/bin/cache/dart-sdk/bin/dart test /Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart -p vm --plain-name 'context menu contextMenuBuilder changes from default to null'
00:06 +0 -1: Some tests failed. (base) � flutter git:(feat/text-field-npe) ```
</details>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparrishMinesbparrishMinesAwaiting requested review from bparrishMines
@blastenblastenAwaiting requested review from blasten
1 more reviewer
@mklimmklimmklim approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaaclarke@blasten@mklim