Uh oh!
There was an error while loading. Please reload this page.
[webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values - #3812
Merged
Merged
Conversation
| origin:(WKSecurityOrigin *)origin | ||
| frame:(WKFrameInfo *)frame | ||
| type:(FWFWKMediaCaptureType)type | ||
| type:(WKMediaCaptureType)type |
ContributorAuthor
There was a problem hiding this comment.
This was not causing an crash since all enums are represented by an NSInteger and the correct WKMediaCaptureType was still being passed. But this was causing the lint error:
error: implicit conversion from enumeration type 'FWFWKMediaCaptureType' (aka 'enum FWFWKMediaCaptureType') to different enumeration type 'WKMediaCaptureType' (aka 'enum WKMediaCaptureType') [-Werror,-Wenum-conversion]
bparrishMines
marked this pull request as ready for review
April 28, 2023 18:14
bparrishMines
requested review from
stuartmorgan-g
and removed request for
cyanglazApril 28, 2023 18:14
stuartmorgan-g
approved these changes
Apr 28, 2023
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with nit. Thanks!
| return [FWFNSKeyValueChangeKeyEnumData makeWithValue:FWFNSKeyValueChangeKeyEnumUnknown]; | ||
| } | ||
| return nil; |
Collaborator
There was a problem hiding this comment.
This is dead code now.
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 3, 2023
flutter/packages@f163786...407b7da 2023-05-03 vashworth@google.com Update Cirrus to Xcode 14.3 (flutter/packages#3890) 2023-05-03 stuartmorgan@google.com [file_selector] Deprecates `macUTIs` (flutter/packages#3888) 2023-05-03 41930132+hellohuanlin@users.noreply.github.com [pigeon]enable treat warning as errors for swift code in unit test (flutter/packages#3889) 2023-05-02 vashworth@google.com Update xcode to 14e222b (flutter/packages#3868) 2023-05-02 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix "as Any" workaround due to nested optional (flutter/packages#3658) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Adds support to accept third party cookies (flutter/packages#3834) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes an exception caused by the `onUrlChange` callback returning a null url (flutter/packages#3848) 2023-05-02 pateltirth454@gmail.com [google_maps_flutter] [Docs] Note regarding usage within a bounded & an unbound widget (flutter/packages#3691) 2023-05-02 evace93@gmail.com [local_auth_android] Fix Android lint warnings (flutter/packages#3764) 2023-05-02 koji.wakamiya@gmail.com [go_router_builder] Support go_router v7 (flutter/packages#3858) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values (flutter/packages#3812) 2023-05-02 stuartmorgan@google.com [file_selector] Add MIME type support on macOS (flutter/packages#3862) 2023-05-02 engine-flutter-autoroll@skia.org Roll Flutter from 828a040 to db6074a (12 revisions) (flutter/packages#3881) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
11 tasks
11 tasks
This was referenced Jul 12, 2023
nploi pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
… enum values (flutter#3812) Followup from flutter#3543 (comment)
11 tasks
11 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
… enum values (flutter#3812) Followup from flutter#3543 (comment)
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
… enum values (flutter#3812) Followup from flutter#3543 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup from #3543 (comment)
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.