Update xcode to 14e222b by vashworth · Pull Request #3868 · flutter/packages

vashworth · 2023-05-01T18:38:20Z

Packages part of flutter/flutter#125814.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

vashworth · 2023-05-01T18:52:52Z

Mac_arm64 ios_platform_tests_shard_1 test failing:

/Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/ios/Classes/FLTVideoPlayerPlugin.m:149:47: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
NS_INLINE UIViewController *rootViewController() {
^
void

Seems to be similar issue as flutter/flutter#125812.

vashworth · 2023-05-01T19:13:21Z

Mac_x64 check_podspecs failing due to same warning:

/Volumes/Work/s/w/ir/x/t/CocoaPods-Lint-20230501-45129-fsmr4f-camera_avfoundation/App/main.m:4:9: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]

jmagman · 2023-05-01T19:33:05Z

Mac_arm64 ios_platform_tests_shard_1 test failing:

/Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/ios/Classes/FLTVideoPlayerPlugin.m:149:47: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
NS_INLINE UIViewController *rootViewController() {
^
void

Seems to be similar issue as flutter/flutter#125812.

Same warning, but this is code that should be updated in this repo:

packages/packages/video_player/video_player_avfoundation/ios/Classes/FLTVideoPlayerPlugin.m

Line 149 in 7d7ce03

NS_INLINE UIViewController *rootViewController() {

- NS_INLINE UIViewController *rootViewController() {+ NS_INLINE UIViewController *rootViewController(void) {

Mac_x64 check_podspecs failing due to same warning:

Yes, this one is flutter/flutter#125812 and requires a CocoaPods bump. In the meantime we can add --allow-warnings with a TODO to remove when infra updates the necessary gem.

packages/script/tool/lib/src/podspec_check_command.dart

Line 143 in 7d7ce03

'--skip-tests',

jmagman · 2023-05-01T19:35:28Z

Same warning, but this is code that should be updated in this repo:

More examples pointed out in the test failures, like:

packages/packages/google_sign_in/google_sign_in_ios/ios/Classes/FLTGoogleSignInPlugin.m

Line 17 in 7d7ce03

staticNSDictionary<NSString *, id> *loadGoogleServiceInfo() {

flutter-dashboard · 2023-05-01T20:19:00Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jmagman

packages/.ci/scripts/create_simulator.sh

Line 9 in b73a598

readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-16-2

readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-16-3

vashworth · 2023-05-01T20:29:47Z

packages/.ci/scripts/create_simulator.sh
Line 9 in b73a598
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-16-2
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-16-3

Do you mean 16-4?

jmagman · 2023-05-01T20:30:21Z

Do you mean 16-4?

Ha, yup.

jmagman · 2023-05-01T20:31:14Z

Actually @vashworth you may have to update the void parts separately and wait for them to be published before updating Xcode since camera_avfoundation is using the published version of video_player_avfoundation, not the version in the repo (or is there some other way to do this @stuartmorgan?)

/Volumes/Work/s/w/ir/x/w/.pub-cache/hosted/pub.dev/video_player_avfoundation-2.4.4/ios/Classes/FLTVideoPlayerPlugin.m:149:47: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
NS_INLINE UIViewController *rootViewController() {
^
void
1 error generated.

…to avoid deprecation warning (#3873) Fixes usages of function without a prototype, surfaced by warning "a function declaration without a prototype is deprecated in all versions of C" introduced in Xcode 14.3. Tests failed because of this in #3868.

jmagman · 2023-05-01T22:33:54Z

Yes, this one is flutter/flutter#125812 and requires a CocoaPods bump. In the meantime we can add --allow-warnings with a TODO to remove when infra updates the necessary gem.

I think this would "fix" (turn off) the last issue.

stuartmorgan-g · 2023-05-02T15:09:46Z

or is there some other way to do this @stuartmorgan?

Sorry for the slow response, but if it's picking up transitive dependency warnings I don't think there was a non-hacky solution other than the route of pushing out the fix in a prequel PR.

jmagman

LGTM, thank you!

vashworth · 2023-05-02T19:33:32Z

@jmagman / @stuartmorgan do you have any idea why Cirrus CI / android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 0 --shardCount 7 test is failing? It it even supposed to run? Looks like other android-platform_tests get skipped

stuartmorgan-g · 2023-05-02T19:58:17Z

Looks like it's just flake, unfortunately.

It it even supposed to run? Looks like other android-platform_tests get skipped

If you touch CI files, essentially everything runs; we don't do any smarts around which platforms might actually be affected. Those stable tests are skipped because we don't test stable in presubmit any more (but they are marked as skipped so that in cases were we specifically want them we can trigger manual re-runs from the UI).

jmagman · 2023-05-02T21:24:08Z

It passed on re-run.

flutter/packages@f163786...407b7da 2023-05-03 vashworth@google.com Update Cirrus to Xcode 14.3 (flutter/packages#3890) 2023-05-03 stuartmorgan@google.com [file_selector] Deprecates `macUTIs` (flutter/packages#3888) 2023-05-03 41930132+hellohuanlin@users.noreply.github.com [pigeon]enable treat warning as errors for swift code in unit test (flutter/packages#3889) 2023-05-02 vashworth@google.com Update xcode to 14e222b (flutter/packages#3868) 2023-05-02 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix "as Any" workaround due to nested optional (flutter/packages#3658) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Adds support to accept third party cookies (flutter/packages#3834) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes an exception caused by the `onUrlChange` callback returning a null url (flutter/packages#3848) 2023-05-02 pateltirth454@gmail.com [google_maps_flutter] [Docs] Note regarding usage within a bounded & an unbound widget (flutter/packages#3691) 2023-05-02 evace93@gmail.com [local_auth_android] Fix Android lint warnings (flutter/packages#3764) 2023-05-02 koji.wakamiya@gmail.com [go_router_builder] Support go_router v7 (flutter/packages#3858) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values (flutter/packages#3812) 2023-05-02 stuartmorgan@google.com [file_selector] Add MIME type support on macOS (flutter/packages#3862) 2023-05-02 engine-flutter-autoroll@skia.org Roll Flutter from 828a040 to db6074a (12 revisions) (flutter/packages#3881) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…to avoid deprecation warning (#3873) Fixes usages of function without a prototype, surfaced by warning "a function declaration without a prototype is deprecated in all versions of C" introduced in Xcode 14.3. Tests failed because of this in flutter/packages#3868.

…to avoid deprecation warning (flutter#3873) Fixes usages of function without a prototype, surfaced by warning "a function declaration without a prototype is deprecated in all versions of C" introduced in Xcode 14.3. Tests failed because of this in flutter#3868.

Packages part of flutter/flutter#125814.

…to avoid deprecation warning (flutter#3873) Fixes usages of function without a prototype, surfaced by warning "a function declaration without a prototype is deprecated in all versions of C" introduced in Xcode 14.3. Tests failed because of this in flutter#3868.

Packages part of flutter/flutter#125814.

…to avoid deprecation warning (flutter#3873) Fixes usages of function without a prototype, surfaced by warning "a function declaration without a prototype is deprecated in all versions of C" introduced in Xcode 14.3. Tests failed because of this in flutter#3868.

Packages part of flutter/flutter#125814.

Update xcode to 14e222b
775a7d8

vashworth mentioned this pull request May 1, 2023
☂️ Update CI to Xcode 14.3 flutter/flutter#125814
Closed
8 tasks

vashworth added 2 commits May 1, 2023 15:17

update functions to include void as argument
82a90e6

update changelog and version
7784aef

vashworth requested a review from hellohuanlin as a code owner May 1, 2023 20:18

flutter-dashboardBot added the needs tests label May 1, 2023

github-actionsBot added p: google_sign_in p: video_player platform-ios labels May 1, 2023

jmagman reviewed May 1, 2023
View reviewed changes

Comment threadpackages/google_sign_in/google_sign_in_ios/CHANGELOG.md Outdated

vashworth mentioned this pull request May 1, 2023
[video_player, google_sign_in] Updates functions without a prototype to avoid deprecation warning #3873
Merged
11 tasks

vashworth added 2 commits May 1, 2023 16:09

Merge branch 'main' into xcode_upgrade_14_3
5f441c8

upgrade simulator to iOS 16.4
54e0ed4

github-actionsBot removed p: video_player p: google_sign_in platform-ios labels May 1, 2023

allow warnings
7106cb2

add new flag to test
f99e4cc

jmagman approved these changes May 2, 2023
View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2023

auto-submitBot merged commit b9f2f1e into flutter:mainMay 2, 2023

engine-flutter-autoroll mentioned this pull request May 3, 2023
Roll Packages from f163786731b8 to 74991926ef67 (12 revisions) flutter/flutter#125977
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2023
b9f2f1eUpdate xcode to 14e222b (flutter/packages#3868)
2b9b474

engine-flutter-autoroll mentioned this pull request May 3, 2023
Roll Packages from f163786731b8 to 407b7da0079e (13 revisions) flutter/flutter#125988
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2023
b9f2f1eUpdate xcode to 14e222b (flutter/packages#3868)
d19360d

reidbaker mentioned this pull request May 12, 2023
[url_launcher] Set broadcast reciever visability as required by target api 34 #3973
Merged
11 tasks

keyonghan mentioned this pull request May 18, 2023
iOS plugin builds are randomly *much* slower on ARM macOS than Intel macOS hosts flutter/flutter#119750
Closed

This was referenced Jul 7, 2023
[Tool] New tool to download android dependencies #4408
Merged
[camera] tree fix format 2023 05 12 #4450
Closed
[tooling] mark infra steps as infra steps in yaml files #4473
Merged

nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
Update xcode to 14e222b (flutter#3868)
1e5041b
Packages part of flutter/flutter#125814.

reidbaker mentioned this pull request Jul 26, 2023
[Tooling] Add google owned cache for dependencies as an option in ci #4567
Merged
11 tasks

reidbaker mentioned this pull request Aug 4, 2023
[All] Expand artifact hub to all plugins #4645
Merged
11 tasks

creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Update xcode to 14e222b (flutter#3868)
416e57e
Packages part of flutter/flutter#125814.

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Update xcode to 14e222b (flutter#3868)
9622a94
Packages part of flutter/flutter#125814.

Uh oh!

Conversation

vashworth commented May 1, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

vashworth commented May 1, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vashworth commented May 1, 2023

Uh oh!

jmagman commented May 1, 2023

Uh oh!

jmagman commented May 1, 2023

Uh oh!

flutter-dashboardBot commented May 1, 2023

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vashworth commented May 1, 2023

Uh oh!

jmagman commented May 1, 2023

Uh oh!

jmagman commented May 1, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented May 1, 2023

Uh oh!

stuartmorgan-g commented May 2, 2023

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

vashworth commented May 2, 2023

Uh oh!

stuartmorgan-g commented May 2, 2023

Uh oh!

jmagman commented May 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vashworth commented May 1, 2023•
edited
Loading

vashworth commented May 1, 2023•
edited
Loading

jmagman commented May 1, 2023•
edited
Loading