Skip to content

[go_router_builder] Support go_router v7 - #3858

Merged
auto-submit[bot] merged 5 commits into
flutter:mainfrom
koji-1009:support_go_router_v7
May 2, 2023
Merged

[go_router_builder] Support go_router v7#3858
auto-submit[bot] merged 5 commits into
flutter:mainfrom
koji-1009:support_go_router_v7

Conversation

@koji-1009

@koji-1009koji-1009 commented May 1, 2023

Copy link
Copy Markdown
Contributor

#3819

Fixed go_router_builder to generate code for go_router v7.0.0.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@koji-1009
koji-1009force-pushed the support_go_router_v7 branch from 1a9833a to 58d245fCompareMay 1, 2023 07:21
@koji-1009
koji-1009 marked this pull request as ready for review May 1, 2023 07:37
@koji-1009
koji-1009 requested a review from chunhtai as a code ownerMay 1, 2023 07:37

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadpackages/go_router_builder/CHANGELOG.md Outdated
@chunhtai
chunhtai requested a review from johnpryanMay 1, 2023 16:21
@chunhtai

Copy link
Copy Markdown
Contributor

Thanks for fixing this!

koji-1009and others added 2 commits May 2, 2023 07:55
Comment threadpackages/go_router_builder/README.md

@johnpryanjohnpryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@johnpryanjohnpryan added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2023
@auto-submit
auto-submitBot merged commit 9c592e0 into flutter:mainMay 2, 2023
@koji-1009
koji-1009 deleted the support_go_router_v7 branch May 3, 2023 00:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2023
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request May 3, 2023
flutter/packages@f163786...407b7da
2023-05-03 vashworth@google.com Update Cirrus to Xcode 14.3 (flutter/packages#3890)
2023-05-03 stuartmorgan@google.com [file_selector] Deprecates `macUTIs` (flutter/packages#3888)
2023-05-03 41930132+hellohuanlin@users.noreply.github.com [pigeon]enable treat warning as errors for swift code in unit test (flutter/packages#3889)
2023-05-02 vashworth@google.com Update xcode to 14e222b (flutter/packages#3868)
2023-05-02 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix "as Any" workaround due to nested optional (flutter/packages#3658)
2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Adds support to accept third party cookies (flutter/packages#3834)
2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes an exception caused by the `onUrlChange` callback returning a null url (flutter/packages#3848)
2023-05-02 pateltirth454@gmail.com [google_maps_flutter] [Docs] Note regarding usage within a bounded & an unbound widget (flutter/packages#3691)
2023-05-02 evace93@gmail.com [local_auth_android] Fix Android lint warnings (flutter/packages#3764)
2023-05-02 koji.wakamiya@gmail.com [go_router_builder] Support go_router v7 (flutter/packages#3858)
2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values (flutter/packages#3812)
2023-05-02 stuartmorgan@google.com [file_selector] Add MIME type support on macOS (flutter/packages#3862)
2023-05-02 engine-flutter-autoroll@skia.org Roll Flutter from 828a040 to db6074a (12 revisions) (flutter/packages#3881)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
flutter#3819
Fixed go_router_builder to generate code for go_router v7.0.0.
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter#3819
Fixed go_router_builder to generate code for go_router v7.0.0.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter#3819
Fixed go_router_builder to generate code for go_router v7.0.0.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: go_router_builder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@koji-1009@chunhtai@johnpryan