Skip to content

[google_sign_in_web] Migrate to pkg:web. - #5612

Merged
auto-submit[bot] merged 10 commits into
flutter:mainfrom
ditman:gsi-web-to-pkg-web
Dec 9, 2023
Merged

[google_sign_in_web] Migrate to pkg:web.#5612
auto-submit[bot] merged 10 commits into
flutter:mainfrom
ditman:gsi-web-to-pkg-web

Conversation

@ditman

@ditmanditman commented Dec 7, 2023

Copy link
Copy Markdown
Member

This PR updates google_sign_in_web to:

  • Use the latest google_identity_services_web and http
  • Use package:web

This should allow the package to compile to WASM.

Issues

Tests

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

kevmoo
kevmoo approved these changes Dec 7, 2023
View reviewed changes

@kevmookevmoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman

This comment was marked as resolved.

Sign in to view
kevmoo
kevmoo reviewed Dec 7, 2023
View reviewed changes
Comment threadpackages/google_sign_in/google_sign_in_web/example/pubspec.yaml Outdated
@ditman
ditmanforce-pushed the gsi-web-to-pkg-web branch 2 times, most recently from 4a54d26 to 0e8892cCompareDecember 8, 2023 03:14
@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2023
@ditman

ditman commented Dec 8, 2023

Copy link
Copy Markdown
MemberAuthor

This is ready to land.

@auto-submit

auto-submitBot commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/5612, due to - The status or check suite Linux_android android_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2023
@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2023
@auto-submit
auto-submitBot merged commit 5e81fd5 into flutter:mainDec 9, 2023
@amrgetment

This comment was marked as off-topic.

Sign in to view
@kevmoo

kevmoo commented Dec 10, 2023

Copy link
Copy Markdown
Contributor

@amrgetment – we're working on these docs. We'll have them early next year!

@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Dec 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
5e81fd5[google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612)
c1a98ea
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
Roll Packages from6cd0657tocb6dbcd(9 revisions) (#139911)
935d12c
flutter/packages@6cd0657...cb6dbcd
2023-12-09 stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529)
2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623)
2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612)
2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629)
2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614)
2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619)
2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625)
2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580)
2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered by a user action (flutter/packages#5143)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@ditman
ditman deleted the gsi-web-to-pkg-web branch December 11, 2023 23:34
@reidbakerreidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbakerreidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbakerreidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@ditman
[google_sign_in_web] Migrate to pkg:web. (flutter#5612)
b15972e
This PR updates `google_sign_in_web` to:
* Use the latest `google_identity_services_web` and `http`
* Use `package:web`
This should allow the package to compile to WASM.
## Issues
* Fixesflutter/flutter#139169
* Needed to flutter/flutter#139170 ## Tests
* All tests should pass (ran locally)
* Demo app compiled to WASM: https://dit-gis-test.web.app
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@ditman
[google_sign_in_web] Migrate to pkg:web. (flutter#5612)
bfdbf5c
This PR updates `google_sign_in_web` to:
* Use the latest `google_identity_services_web` and `http`
* Use `package:web`
This should allow the package to compile to WASM.
## Issues
* Fixesflutter/flutter#139169
* Needed to flutter/flutter#139170 ## Tests
* All tests should pass (ran locally)
* Demo app compiled to WASM: https://dit-gis-test.web.app
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevmookevmookevmoo approved these changes
@stuartmorgan-gstuartmorgan-gAwaiting requested review from stuartmorgan-g

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: google_sign_inplatform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[google_sign_in_web] migrate to pkg:web

4 participants

@ditman@amrgetment@kevmoo@stuartmorgan-g