Skip to content

Add parse constructors for the BenchmarkResults and BenchmarkScore classes - #5614

Merged
auto-submit[bot] merged 7 commits into
flutter:mainfrom
kenzieschmoll:parse
Dec 8, 2023
Merged

Add parse constructors for the BenchmarkResults and BenchmarkScore classes#5614
auto-submit[bot] merged 7 commits into
flutter:mainfrom
kenzieschmoll:parse

Conversation

@kenzieschmoll

Copy link
Copy Markdown
Member

No description provided.

@eyebrowsoffireeyebrowsoffire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenzieschmollkenzieschmoll added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2023
Comment threadpackages/web_benchmarks/lib/src/benchmark_result.dart Outdated
Comment threadpackages/web_benchmarks/lib/src/benchmark_result.dart Outdated
Comment threadpackages/web_benchmarks/lib/src/benchmark_result.dart Outdated

@yjbanovyjbanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@auto-submit
auto-submitBot merged commit 935b92f into flutter:mainDec 8, 2023
@kenzieschmoll
kenzieschmoll deleted the parse branch December 8, 2023 19:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2023
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Dec 11, 2023
flutter/packages@6cd0657...cb6dbcd
2023-12-09 stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529)
2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623)
2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612)
2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629)
2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614)
2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619)
2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625)
2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580)
2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered by a user action (flutter/packages#5143)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Jan 12, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: web_benchmarkswaiting for tree to go green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kenzieschmoll@yjbanov@eyebrowsoffire