Uh oh!
There was an error while loading. Please reload this page.
[google_maps_flutter] Disable failing iOS tests - #5629
Merged
auto-submit[bot] merged 2 commits intoDec 8, 2023
Conversation
Disables the tests that have started failing for unknown OOB reasons, in order to fix the tree. flutter/flutter#139825
camsim99
approved these changes
Dec 8, 2023
ditman
approved these changes
Dec 8, 2023
ditman
left a comment
Member
There was a problem hiding this comment.
LGTM! but maybe only skip if isIOS on the core plugin?
| }); | ||
| }, | ||
| // TODO(stuartmorgan): Re-enable; see https://github.com/flutter/flutter/issues/139825 | ||
| skip: true); |
Member
There was a problem hiding this comment.
Suggested change
| skip:true); | |
| skip:isIOS); |
| }); | ||
| }, | ||
| // TODO(stuartmorgan): Re-enable; see https://github.com/flutter/flutter/issues/139825 | ||
| skip: true); |
Member
There was a problem hiding this comment.
Suggested change
| skip:true); | |
| skip:isIOS); |
| }); | ||
| }, | ||
| // TODO(stuartmorgan): Re-enable; see https://github.com/flutter/flutter/issues/139825 | ||
| skip: true); |
Member
There was a problem hiding this comment.
Suggested change
| skip:true); | |
| skip:isIOS); |
stuartmorgan-g
commented
Dec 8, 2023
CollaboratorAuthor
Doh, I meant to make those iOS when switching plugins and then completely forgot. Thanks! |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 11, 2023
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 11, 2023
flutter/packages@6cd0657...cb6dbcd 2023-12-09 stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529) 2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623) 2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612) 2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629) 2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614) 2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619) 2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625) 2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580) 2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered by a user action (flutter/packages#5143) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
Disables the tests that have started failing for unknown OOB reasons, in order to fix the tree. flutter/flutter#139825
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
Disables the tests that have started failing for unknown OOB reasons, in order to fix the tree. flutter/flutter#139825
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables the tests that have started failing for unknown OOB reasons, in order to fix the tree.
flutter/flutter#139825