Skip to content

[pointer_interceptor] fix width and height unset warning on web platform - #5864

Merged
auto-submit[bot] merged 12 commits into
flutter:mainfrom
cedvdb:fix-141323-pointer-interceptor-width-height-unset
Jan 18, 2024
Merged

[pointer_interceptor] fix width and height unset warning on web platform#5864
auto-submit[bot] merged 12 commits into
flutter:mainfrom
cedvdb:fix-141323-pointer-interceptor-width-height-unset

Conversation

@cedvdb

@cedvdbcedvdb commented Jan 10, 2024•
edited by ditman
Loading

Copy link
Copy Markdown
Contributor

This PR adds width/height to the dom element created by the default factory to prevent the framework from screaming at usages of this plugin.

Needed until this bit becomes stable:

Issues

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [] I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cedvdb
cedvdb requested a review from ditman as a code ownerJanuary 10, 2024 23:47
@flutter-dashboard

flutter-dashboardBot commented Jan 10, 2024

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cedvdb
Update pubspec.yaml
39c3881
remove some auto formatting
@cedvdb
Update pubspec.yaml
75d2147
fix auto formatting
@cedvdb
Update pubspec.yaml
c83a978
fix auto formatting
@cedvdb
Update pubspec.yaml
697dd1d
fix auto formatting
@cedvdb
Update pubspec.yaml
bf225ab
fix auto formatting
@cedvdbcedvdb changed the title fix #141323 width and height unset[pointer_interceptor] fix #141323 width and height unsetJan 11, 2024
@cedvdbcedvdb changed the title [pointer_interceptor] fix #141323 width and height unset[pointer_interceptor] fix width and height unset warning on web platformJan 11, 2024
@cedvdbcedvdb mentioned this pull request Jan 11, 2024
Closed
navaronbracke
navaronbracke reviewed Jan 11, 2024
View reviewed changes
Comment threadpackages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart Outdated
ditman
ditman approved these changes Jan 18, 2024
View reviewed changes

@ditmanditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 18, 2024
@auto-submit
auto-submitBot merged commit 3e7d502 into flutter:mainJan 18, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jan 19, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 19, 2024
@engine-flutter-autoroll
3e7d502[pointer_interceptor] fix width and height unset warning on w…
aafc3c0
…eb platform (flutter/packages#5864)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jan 19, 2024
@engine-flutter-autoroll
Roll Packages from83c2c4dto129e08c(13 revisions) (#141865)
0487931
flutter/packages@83c2c4d...129e08c
2024-01-19 magder@google.com [pigeon] Run swift-format on ungenerated example app Swift files (flutter/packages#5934)
2024-01-19 magder@google.com [path_provider_foundation] Run swift-format on Swift files (flutter/packages#5935)
2024-01-19 magder@google.com [shared_preferences_foundation] Run swift-format on Swift files (flutter/packages#5933)
2024-01-19 magder@google.com [various] Run swift-format on example app Swift files (flutter/packages#5931)
2024-01-19 magder@google.com [camera_avfoundation] Remove development team from Xcode example app (flutter/packages#5930)
2024-01-18 jsharp83@gmail.com [webview_flutter_wkwebview] Add javascript panel interface for wkwebview (flutter/packages#5795)
2024-01-18 amirpanahandeh@yahoo.com [two_dimensional_scrollables] Fix must_call_super (flutter/packages#5921)
2024-01-18 cedvandenbosch@gmail.com [pointer_interceptor] fix width and height unset warning on web platform (flutter/packages#5864)
2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/packages#5922)
2024-01-18 stuartmorgan@google.com [google_maps_flutter] Clean up iOS example project (flutter/packages#5925)
2024-01-18 magder@google.com [ci] Add flags to formatter command to decide which formatters to run (flutter/packages#5905)
2024-01-18 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 and iOS 17 simulator (flutter/packages#5914)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter from def6af0 to f77f824 (25 revisions) (flutter/packages#5924)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbakerreidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@cedvdb
[pointer_interceptor] fix width and height unset warning on web platf…
0093f69
…orm (flutter#5864)
This PR adds width/height to the dom element created by the default factory to prevent the framework from screaming at usages of this plugin.
Needed until this bit becomes `stable`:
* https://github.com/flutter/engine/blob/3106e08e12198d98b75c459ac3290f4101b68574/lib/web_ui/lib/src/engine/platform_views/content_manager.dart#L229-L238
## Issues
* Fixesflutter/flutter#141323
- [] I updated/added relevant documentation (doc comments with `///`).
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@cedvdb
[pointer_interceptor] fix width and height unset warning on web platf…
cad3267
…orm (flutter#5864)
This PR adds width/height to the dom element created by the default factory to prevent the framework from screaming at usages of this plugin.
Needed until this bit becomes `stable`:
* https://github.com/flutter/engine/blob/3106e08e12198d98b75c459ac3290f4101b68574/lib/web_ui/lib/src/engine/platform_views/content_manager.dart#L229-L238
## Issues
* Fixesflutter/flutter#141323
- [] I updated/added relevant documentation (doc comments with `///`).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@navaronbrackenavaronbrackenavaronbracke left review comments
@ditmanditmanditman approved these changes
@mdebbarmdebbarmdebbar approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: pointer_interceptorplatform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pointer_interceptor] on web prints Set style.width to any appropriate value to stop this message.

4 participants

@cedvdb@ditman@mdebbar@navaronbracke