Skip to content

[path_provider_foundation] Run swift-format on Swift files - #5935

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
jmagman:pp-swift-format
Jan 19, 2024
Merged

[path_provider_foundation] Run swift-format on Swift files#5935
auto-submit[bot] merged 1 commit into
flutter:mainfrom
jmagman:pp-swift-format

Conversation

@jmagman

@jmagmanjmagman commented Jan 19, 2024

Copy link
Copy Markdown
Member

Run swift-format linter/formatter on Swift files.

Part of turning on swift-format CI formatting #5928

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagmanjmagman added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes platform-ios labels Jan 19, 2024
@jmagman

Copy link
Copy Markdown
MemberAuthor

No CHANGELOG or version bump needed based on #5933 (comment)

@jmagman
jmagman marked this pull request as ready for review January 19, 2024 04:57
@jmagmanjmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 19, 2024
@auto-submit
auto-submitBot merged commit 9379e4a into flutter:mainJan 19, 2024
@jmagman
jmagman deleted the pp-swift-format branch January 19, 2024 06:24
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jan 19, 2024
flutter/packages@83c2c4d...129e08c
2024-01-19 magder@google.com [pigeon] Run swift-format on ungenerated example app Swift files (flutter/packages#5934)
2024-01-19 magder@google.com [path_provider_foundation] Run swift-format on Swift files (flutter/packages#5935)
2024-01-19 magder@google.com [shared_preferences_foundation] Run swift-format on Swift files (flutter/packages#5933)
2024-01-19 magder@google.com [various] Run swift-format on example app Swift files (flutter/packages#5931)
2024-01-19 magder@google.com [camera_avfoundation] Remove development team from Xcode example app (flutter/packages#5930)
2024-01-18 jsharp83@gmail.com [webview_flutter_wkwebview] Add javascript panel interface for wkwebview (flutter/packages#5795)
2024-01-18 amirpanahandeh@yahoo.com [two_dimensional_scrollables] Fix must_call_super (flutter/packages#5921)
2024-01-18 cedvandenbosch@gmail.com [pointer_interceptor] fix width and height unset warning on web platform (flutter/packages#5864)
2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/packages#5922)
2024-01-18 stuartmorgan@google.com [google_maps_flutter] Clean up iOS example project (flutter/packages#5925)
2024-01-18 magder@google.com [ci] Add flags to formatter command to decide which formatters to run (flutter/packages#5905)
2024-01-18 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 and iOS 17 simulator (flutter/packages#5914)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter from def6af0 to f77f824 (25 revisions) (flutter/packages#5924)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
)
Run `swift-format` linter/formatter on Swift files.
Part of turning on swift-format CI formatting flutter#5928
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
)
Run `swift-format` linter/formatter on Swift files.
Part of turning on swift-format CI formatting flutter#5928
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appoverride: no changelog neededOverride the check requiring CHANGELOG updates for most changesoverride: no versioning neededOverride the check requiring version bumps for most changesp: path_provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman@hellohuanlin