Uh oh!
There was an error while loading. Please reload this page.
[various] Run swift-format on example app Swift files - #5931
Merged
Conversation
jmagman
marked this pull request as ready for review
January 19, 2024 01:45
jmagman
requested review from
Hixie, Piinks, chunhtai, ditman, domesticmouse, goderbauer, gspencergoog, hellohuanlin, stuartmorgan-g and tarrinneal
as code ownersJanuary 19, 2024 01:45
hellohuanlin
approved these changes
Jan 19, 2024
stuartmorgan-g
approved these changes
Jan 19, 2024
| @@ -1,3 +1,7 @@ | |||
| ## NEXT | |||
| * Fixes Swift format issues in example app. | |||
Collaborator
There was a problem hiding this comment.
Optional nit: you could revert all of the CHANGELOG changes, as this would fall under the "only affect[s] development of the package" exemption; formatting of the boilerplate runner code isn't going to be of interest to clients.
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2024
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2024
flutter/packages@83c2c4d...129e08c 2024-01-19 magder@google.com [pigeon] Run swift-format on ungenerated example app Swift files (flutter/packages#5934) 2024-01-19 magder@google.com [path_provider_foundation] Run swift-format on Swift files (flutter/packages#5935) 2024-01-19 magder@google.com [shared_preferences_foundation] Run swift-format on Swift files (flutter/packages#5933) 2024-01-19 magder@google.com [various] Run swift-format on example app Swift files (flutter/packages#5931) 2024-01-19 magder@google.com [camera_avfoundation] Remove development team from Xcode example app (flutter/packages#5930) 2024-01-18 jsharp83@gmail.com [webview_flutter_wkwebview] Add javascript panel interface for wkwebview (flutter/packages#5795) 2024-01-18 amirpanahandeh@yahoo.com [two_dimensional_scrollables] Fix must_call_super (flutter/packages#5921) 2024-01-18 cedvandenbosch@gmail.com [pointer_interceptor] fix width and height unset warning on web platform (flutter/packages#5864) 2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/packages#5922) 2024-01-18 stuartmorgan@google.com [google_maps_flutter] Clean up iOS example project (flutter/packages#5925) 2024-01-18 magder@google.com [ci] Add flags to formatter command to decide which formatters to run (flutter/packages#5905) 2024-01-18 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 and iOS 17 simulator (flutter/packages#5914) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter from def6af0 to f77f824 (25 revisions) (flutter/packages#5924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
Run `swift-format` linter/formatter on Swift files in example apps. This doesn't touch any Swift files in non-example code. Part of turning on swift-format CI formatting flutter#5928
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
Run `swift-format` linter/formatter on Swift files in example apps. This doesn't touch any Swift files in non-example code. Part of turning on swift-format CI formatting flutter#5928
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
swift-formatlinter/formatter on Swift files in example apps. This doesn't touch any Swift files in non-example code.Part of turning on swift-format CI formatting #5928
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.