[go_router] Feat add route redirect shellroutes (#114559) by VictorOhashi · Pull Request #6432 · flutter/packages

VictorOhashi · 2024-03-28T21:40:34Z

Possible solution for: flutter/flutter#114559

Pre-launch Checklist

flutter-dashboard · 2024-03-28T21:40:37Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

cedvdb · 2024-03-29T00:39:16Z

@VictorOhashi I don't think the reviewer works anymore, you might want to tag someone else.

VictorOhashi · 2024-03-29T00:54:39Z

@johnpryan could you have a look?

chunhtai

Thanks for your contribution, but we need a test to verify the new feature. Can you also bump the minor version since this is a new api?

VictorOhashi · 2024-04-09T14:07:59Z

Thanks for your contribution, but we need a test to verify the new feature. Can you also bump the minor version since this is a new api?

done

chunhtai

It is still missing a test

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>

…Ohashi/packages into feat/shell-route-redirect

chunhtai

LGTM

chunhtai · 2024-05-02T21:40:39Z

looks like there is a conflict

hannah-hyj

LGTM

…) (flutter/packages#6432)

flutter/packages@6c4482a...1412041 2024-05-13 stuartmorgan@google.com [in_app_purchase] Update country code Android example (flutter/packages#6722) 2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter from 1dfb46e to 1255435 (6 revisions) (flutter/packages#6723) 2024-05-13 43054281+camsim99@users.noreply.github.com [camera] Change default Android implementation from `camera_android` to `camera_android_camerax` (flutter/packages#6629) 2024-05-13 15619084+vashworth@users.noreply.github.com [image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods (flutter/packages#6707) 2024-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 2aa05c1 to 1dfb46e (3 revisions) (flutter/packages#6715) 2024-05-11 engine-flutter-autoroll@skia.org Roll Flutter from 2bfb1b0 to 2aa05c1 (26 revisions) (flutter/packages#6713) 2024-05-10 stuartmorgan@google.com [quick_actions] Add Swift Package Manager support (flutter/packages#6682) 2024-05-10 stuartmorgan@google.com [url_launcher] Add Swift Package Manager support (flutter/packages#6677) 2024-05-10 43054281+camsim99@users.noreply.github.com [Android][webview_flutter] Run integration tests on emulators running Android 34 (flutter/packages#6499) 2024-05-10 50643541+Mairramer@users.noreply.github.com [image_picker_android] - will fix crash on Android 12+ devices (flutter/packages#6691) 2024-05-10 43054281+camsim99@users.noreply.github.com [camerax] Make fixes required to swap camera_android_camerax for camera_android (flutter/packages#6697) 2024-05-10 737941+loic-sharma@users.noreply.github.com Update .gitignore for Swift Package Manager (flutter/packages#6705) 2024-05-10 34871572+gmackall@users.noreply.github.com [quick_actions_android] Switch to `Compat` version of `ShortcutManager` to support Google surfaces (flutter/packages#6638) 2024-05-10 737941+loic-sharma@users.noreply.github.com [local_auth_darwin] Adds Swift Package Manager compatibility (flutter/packages#6708) 2024-05-10 engine-flutter-autoroll@skia.org Roll Flutter from 00f4066 to 2bfb1b0 (9 revisions) (flutter/packages#6706) 2024-05-09 38299943+VictorOhashi@users.noreply.github.com [go_router] Feat add route redirect shellroutes (#114559) (flutter/packages#6432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Possible solution for: flutter/flutter#114559 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [X] I signed the [CLA]. - [X] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [X] I [linked to at least one issue that this PR fixes] in the description above. - [X] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [X] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. --------- Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> Co-authored-by: Victor Ohashi <victor.ohashi@govoll.com>

[go_router] Feat add route redirect shellroutes (#114559)
e3bcbb5

VictorOhashi requested a review from chunhtai as a code owner March 28, 2024 21:40

github-actionsBot added the p: go_router label Mar 28, 2024

chunhtai reviewed Apr 8, 2024
View reviewed changes

Comment threadpackages/go_router/lib/src/configuration.dart Outdated

VictorOhashiand others added 2 commits April 9, 2024 10:59

Merge branch 'flutter:main' into feat/shell-route-redirect
d0e016f

chore: Bump version
9cfe1b2

VictorOhashiand others added 2 commits April 9, 2024 16:18

fix: RouteRedirectResult null check
f1a7165

Merge branch 'main' into feat/shell-route-redirect
ed9e397

VictorOhashi requested a review from chunhtai April 11, 2024 17:53

chunhtai reviewed Apr 11, 2024
View reviewed changes

Comment threadpackages/go_router/lib/src/configuration.dart Outdated
Comment threadpackages/go_router/CHANGELOG.md Outdated

VictorOhashiand others added 4 commits April 11, 2024 19:18

Update packages/go_router/CHANGELOG.md
901c614
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>

fix: Route configuration
e4a700a

test: Add shell route redirect testes
c6f2e6b

Merge branch 'main' into feat/shell-route-redirect
69d8385

VictorOhashi requested a review from chunhtai April 21, 2024 13:52

Merge branch 'main' into feat/shell-route-redirect
c542306

johnpryan reviewed Apr 25, 2024
View reviewed changes

Comment threadpackages/go_router/CHANGELOG.md Outdated

VictorOhashiand others added 4 commits April 25, 2024 14:40

Merge branch 'flutter:main' into feat/shell-route-redirect
fe184b7

chore: Fix go_router version
c99e616

chore: Fix go_router version
95b029e

Merge branch 'feat/shell-route-redirect' ofhttps://github.com/Victor…
b8ef267
…Ohashi/packages into feat/shell-route-redirect

VictorOhashi requested a review from johnpryan April 25, 2024 17:45

chunhtai approved these changes May 2, 2024
View reviewed changes

chunhtai requested a review from hannah-hyj May 2, 2024 21:40

Merge branch 'main' into feat/shell-route-redirect
2f2511f

hannah-hyj approved these changes May 9, 2024
View reviewed changes

hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024

chunhtai merged commit 3fb302d into flutter:mainMay 9, 2024

engine-flutter-autoroll mentioned this pull request May 13, 2024
Roll Packages from 6c4482a64492 to ee8ee2eaa23e (13 revisions) flutter/flutter#148217
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
3fb302d[go_router] Feat add route redirect shellroutes (flutter#114559…
d0d6459
…) (flutter/packages#6432)

engine-flutter-autoroll mentioned this pull request May 13, 2024
Roll Packages from 6c4482a64492 to 9588cce77dba (14 revisions) flutter/flutter#148223
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
3fb302d[go_router] Feat add route redirect shellroutes (flutter#114559…
82bdc7a
…) (flutter/packages#6432)

engine-flutter-autoroll mentioned this pull request May 13, 2024
Roll Packages from 6c4482a64492 to f91f68916da9 (15 revisions) flutter/flutter#148232
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
3fb302d[go_router] Feat add route redirect shellroutes (flutter#114559…
321f662
…) (flutter/packages#6432)

engine-flutter-autoroll mentioned this pull request May 13, 2024
Roll Packages from 6c4482a64492 to 1412041fa3fe (16 revisions) flutter/flutter#148239
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
3fb302d[go_router] Feat add route redirect shellroutes (flutter#114559…
930e045
…) (flutter/packages#6432)

reidbaker mentioned this pull request Jul 2, 2024
i151188 update espresso dependencies v2 reidbaker/packages#6
Closed
11 tasks

rensPols mentioned this pull request Mar 5, 2025
[go_router] ShellRoute should have a redirect method similar to GoRouteflutter/flutter#114559
Closed

coderabbitaiBot mentioned this pull request Apr 3, 2026
refacto: migrate routing to go_router_builder for type-safe navigation linagora/twake-on-matrix#2901
Merged

Navigation Menu

Uh oh!

[go_router] Feat add route redirect shellroutes (#114559) - #6432

[go_router] Feat add route redirect shellroutes (#114559)#6432
chunhtai merged 15 commits into
flutter:mainfrom
VictorOhashi:feat/shell-route-redirect

VictorOhashi commented Mar 28, 2024•
edited
Loading

Uh oh!

flutter-dashboardBot commented Mar 28, 2024

Uh oh!

cedvdb commented Mar 29, 2024

Uh oh!

VictorOhashi commented Mar 29, 2024

Uh oh!

chunhtai left a comment

Uh oh!

Uh oh!

VictorOhashi commented Apr 9, 2024

Uh oh!

chunhtai left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chunhtai left a comment

Uh oh!

chunhtai commented May 2, 2024

Uh oh!

hannah-hyj left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

VictorOhashi commented Mar 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboardBot commented Mar 28, 2024

Uh oh!

cedvdb commented Mar 29, 2024

Uh oh!

VictorOhashi commented Mar 29, 2024

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VictorOhashi commented Apr 9, 2024

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai commented May 2, 2024

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VictorOhashi commented Mar 28, 2024•
edited
Loading