Skip to content

[quick_actions] Add Swift Package Manager support - #6682

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
stuartmorgan-g:quick-actions-spm
May 10, 2024
Merged

[quick_actions] Add Swift Package Manager support#6682
auto-submit[bot] merged 6 commits into
flutter:mainfrom
stuartmorgan-g:quick-actions-spm

Conversation

@stuartmorgan-g

@stuartmorgan-gstuartmorgan-g commented May 7, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

Adds SPM support. Does not include any package changes, to maintain compatibility with stable.

Also adds a missing import in a test; it looks like it was probabl/y compiling before due to bleed-through from the Cocoapod dependency, and switching to SPM broke it. The test references a UIKit type, so should definitely have been importing it.

Fixesflutter/flutter#146915

Pre-launch Checklist

vashworth
vashworth requested changes May 8, 2024
View reviewed changes

@vashworthvashworth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs some formatting tweaks

Comment thread...quick_actions/quick_actions_ios/example/ios/RunnerTests/Mocks/MockShortcutItemProvider.swift
Comment threadpackages/quick_actions/quick_actions_ios/ios/quick_actions_ios/Package.swift Outdated
stuartmorgan-gand others added 3 commits May 10, 2024 12:41
@stuartmorgan-g@vashworth
Update packages/quick_actions/quick_actions_ios/example/ios/RunnerTes…
96e03dd
…ts/Mocks/MockShortcutItemProvider.swift
Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com>
@stuartmorgan-g@vashworth
Update packages/quick_actions/quick_actions_ios/ios/quick_actions_ios…
6e8ac0e
…/Package.swift
Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com>
@stuartmorgan-g
Merge branch 'main' into quick-actions-spm
d1a4a9d
@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 10, 2024
vashworth
vashworth approved these changes May 10, 2024
View reviewed changes

@vashworthvashworth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit
auto-submitBot merged commit f1ca81a into flutter:mainMay 10, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
@engine-flutter-autoroll
f1ca81a[quick_actions] Add Swift Package Manager support (flutter/pa…
523c32b
…ckages#6682)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
@engine-flutter-autoroll
f1ca81a[quick_actions] Add Swift Package Manager support (flutter/pa…
9d39f2d
…ckages#6682)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
@engine-flutter-autoroll
f1ca81a[quick_actions] Add Swift Package Manager support (flutter/pa…
f3344e8
…ckages#6682)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 13, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
@engine-flutter-autoroll
f1ca81a[quick_actions] Add Swift Package Manager support (flutter/pa…
bafb7df
…ckages#6682)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request May 13, 2024
@engine-flutter-autoroll
Roll Packages from6c4482ato1412041(16 revisions) (#148239)
f394968
flutter/packages@6c4482a...1412041
2024-05-13 stuartmorgan@google.com [in_app_purchase] Update country code Android example (flutter/packages#6722)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter from 1dfb46e to 1255435 (6 revisions) (flutter/packages#6723)
2024-05-13 43054281+camsim99@users.noreply.github.com [camera] Change default Android implementation from `camera_android` to `camera_android_camerax` (flutter/packages#6629)
2024-05-13 15619084+vashworth@users.noreply.github.com [image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods (flutter/packages#6707)
2024-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 2aa05c1 to 1dfb46e (3 revisions) (flutter/packages#6715)
2024-05-11 engine-flutter-autoroll@skia.org Roll Flutter from 2bfb1b0 to 2aa05c1 (26 revisions) (flutter/packages#6713)
2024-05-10 stuartmorgan@google.com [quick_actions] Add Swift Package Manager support (flutter/packages#6682)
2024-05-10 stuartmorgan@google.com [url_launcher] Add Swift Package Manager support (flutter/packages#6677)
2024-05-10 43054281+camsim99@users.noreply.github.com [Android][webview_flutter] Run integration tests on emulators running Android 34 (flutter/packages#6499)
2024-05-10 50643541+Mairramer@users.noreply.github.com [image_picker_android] - will fix crash on Android 12+ devices (flutter/packages#6691)
2024-05-10 43054281+camsim99@users.noreply.github.com [camerax] Make fixes required to swap camera_android_camerax for camera_android (flutter/packages#6697)
2024-05-10 737941+loic-sharma@users.noreply.github.com Update .gitignore for Swift Package Manager (flutter/packages#6705)
2024-05-10 34871572+gmackall@users.noreply.github.com [quick_actions_android] Switch to `Compat` version of `ShortcutManager` to support Google surfaces (flutter/packages#6638)
2024-05-10 737941+loic-sharma@users.noreply.github.com [local_auth_darwin] Adds Swift Package Manager compatibility (flutter/packages#6708)
2024-05-10 engine-flutter-autoroll@skia.org Roll Flutter from 00f4066 to 2bfb1b0 (9 revisions) (flutter/packages#6706)
2024-05-09 38299943+VictorOhashi@users.noreply.github.com [go_router] Feat add route redirect shellroutes (#114559) (flutter/packages#6432)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@stuartmorgan-g@TecHaxter
[quick_actions] Add Swift Package Manager support (flutter#6682)
6d82423
Adds SPM support. Does not include any package changes, to maintain compatibility with `stable`.
Also adds a missing `import` in a test; it looks like it was probabl/y compiling before due to bleed-through from the Cocoapod dependency, and switching to SPM broke it. The test references a UIKit type, so should definitely have been importing it.
Fixesflutter/flutter#146915
@reidbakerreidbaker mentioned this pull request Jul 2, 2024
Closed
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@stuartmorgan-g
[quick_actions] Add Swift Package Manager support (flutter#6682)
b429e4e
Adds SPM support. Does not include any package changes, to maintain compatibility with `stable`.
Also adds a missing `import` in a test; it looks like it was probabl/y compiling before due to bleed-through from the Cocoapod dependency, and switching to SPM broke it. The test references a UIKit type, so should definitely have been importing it.
Fixesflutter/flutter#146915
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@stuartmorgan-g
[quick_actions] Add Swift Package Manager support (flutter#6682)
3d2b2a7
Adds SPM support. Does not include any package changes, to maintain compatibility with `stable`.
Also adds a missing `import` in a test; it looks like it was probabl/y compiling before due to bleed-through from the Cocoapod dependency, and switching to SPM broke it. The test references a UIKit type, so should definitely have been importing it.
Fixesflutter/flutter#146915
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworthvashworthvashworth approved these changes
@jmagmanjmagmanAwaiting requested review from jmagman

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: quick_actionsplatform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[quick_actions_ios] Add Swift Package Manager compatibility to quick_actions_ios

2 participants

@stuartmorgan-g@vashworth