[camera] Change default Android implementation from `camera_android` to `camera_android_camerax` by camsim99 · Pull Request #6629 · flutter/packages

camsim99 · 2024-04-30T15:46:20Z

Breaking change: Changes default Android implementation from camera_android to camera_android_camerax via a breaking change and updates relevant documentation.

Note: Planning to land this after #6608, as it is a semi-crucial fix. Done :)

Pre-launch Checklist

… used on Android (#6676) Adds empty implementation for the camera plugin method `prepareForVideoRecording` that is not used on Android. Prequel to #6629

camsim99 · 2024-05-08T22:54:26Z

~~WIP: There are some testing changes in here to land #6697; will delete before requesting review.~~ removed!

camsim99 · 2024-05-10T16:54:39Z

~~Waiting for #6697 to land to get camera_android_camerax version 0.6.5 landed but I would like the review process to start so I can hopefully land this by EOD Monday.~~ landed!

stuartmorgan-g

LGTM!

🚀 🎉

…ndroid` to `camera_android_camerax` (flutter/packages#6629)

flutter/packages@6c4482a...1412041 2024-05-13 stuartmorgan@google.com [in_app_purchase] Update country code Android example (flutter/packages#6722) 2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter from 1dfb46e to 1255435 (6 revisions) (flutter/packages#6723) 2024-05-13 43054281+camsim99@users.noreply.github.com [camera] Change default Android implementation from `camera_android` to `camera_android_camerax` (flutter/packages#6629) 2024-05-13 15619084+vashworth@users.noreply.github.com [image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods (flutter/packages#6707) 2024-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 2aa05c1 to 1dfb46e (3 revisions) (flutter/packages#6715) 2024-05-11 engine-flutter-autoroll@skia.org Roll Flutter from 2bfb1b0 to 2aa05c1 (26 revisions) (flutter/packages#6713) 2024-05-10 stuartmorgan@google.com [quick_actions] Add Swift Package Manager support (flutter/packages#6682) 2024-05-10 stuartmorgan@google.com [url_launcher] Add Swift Package Manager support (flutter/packages#6677) 2024-05-10 43054281+camsim99@users.noreply.github.com [Android][webview_flutter] Run integration tests on emulators running Android 34 (flutter/packages#6499) 2024-05-10 50643541+Mairramer@users.noreply.github.com [image_picker_android] - will fix crash on Android 12+ devices (flutter/packages#6691) 2024-05-10 43054281+camsim99@users.noreply.github.com [camerax] Make fixes required to swap camera_android_camerax for camera_android (flutter/packages#6697) 2024-05-10 737941+loic-sharma@users.noreply.github.com Update .gitignore for Swift Package Manager (flutter/packages#6705) 2024-05-10 34871572+gmackall@users.noreply.github.com [quick_actions_android] Switch to `Compat` version of `ShortcutManager` to support Google surfaces (flutter/packages#6638) 2024-05-10 737941+loic-sharma@users.noreply.github.com [local_auth_darwin] Adds Swift Package Manager compatibility (flutter/packages#6708) 2024-05-10 engine-flutter-autoroll@skia.org Roll Flutter from 00f4066 to 2bfb1b0 (9 revisions) (flutter/packages#6706) 2024-05-09 38299943+VictorOhashi@users.noreply.github.com [go_router] Feat add route redirect shellroutes (#114559) (flutter/packages#6432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

… used on Android (flutter#6676) Adds empty implementation for the camera plugin method `prepareForVideoRecording` that is not used on Android. Prequel to flutter#6629

…ra_android (flutter#6697) Makes changes needed to land flutter#6629. Specifically: - Fixes timing issue with `stopVideoRecording` such that the `Future` it returns will only complete when CameraX reports that the recording is finalized (via listening for the [finalized video recording event](https://developer.android.com/reference/androidx/camera/video/VideoRecordEvent.Finalize)) - Modifies `startVideoCapturing` such that the `Future` it returns will only complete when CameraX reports that video capturing has started (via listening for the [started video recording event](https://developer.android.com/reference/androidx/camera/video/VideoRecordEvent.Start)) - Adds empty implementation and TODO for implementing `setDescriptionWhileRecording`

…to `camera_android_camerax` (flutter#6629) Breaking change: Changes default Android implementation from `camera_android` to `camera_android_camerax` via a breaking change and updates relevant documentation. ~<ins>**Note:**</ins> Planning to land this after flutter#6608, as it is a semi-crucial fix.~ Done :)

… used on Android (flutter#6676) Adds empty implementation for the camera plugin method `prepareForVideoRecording` that is not used on Android. Prequel to flutter#6629

…ra_android (flutter#6697) Makes changes needed to land flutter#6629. Specifically: - Fixes timing issue with `stopVideoRecording` such that the `Future` it returns will only complete when CameraX reports that the recording is finalized (via listening for the [finalized video recording event](https://developer.android.com/reference/androidx/camera/video/VideoRecordEvent.Finalize)) - Modifies `startVideoCapturing` such that the `Future` it returns will only complete when CameraX reports that video capturing has started (via listening for the [started video recording event](https://developer.android.com/reference/androidx/camera/video/VideoRecordEvent.Start)) - Adds empty implementation and TODO for implementing `setDescriptionWhileRecording`

…to `camera_android_camerax` (flutter#6629) Breaking change: Changes default Android implementation from `camera_android` to `camera_android_camerax` via a breaking change and updates relevant documentation. ~<ins>**Note:**</ins> Planning to land this after flutter#6608, as it is a semi-crucial fix.~ Done :)

… used on Android (flutter#6676) Adds empty implementation for the camera plugin method `prepareForVideoRecording` that is not used on Android. Prequel to flutter#6629

…ra_android (flutter#6697) Makes changes needed to land flutter#6629. Specifically: - Fixes timing issue with `stopVideoRecording` such that the `Future` it returns will only complete when CameraX reports that the recording is finalized (via listening for the [finalized video recording event](https://developer.android.com/reference/androidx/camera/video/VideoRecordEvent.Finalize)) - Modifies `startVideoCapturing` such that the `Future` it returns will only complete when CameraX reports that video capturing has started (via listening for the [started video recording event](https://developer.android.com/reference/androidx/camera/video/VideoRecordEvent.Start)) - Adds empty implementation and TODO for implementing `setDescriptionWhileRecording`

…to `camera_android_camerax` (flutter#6629) Breaking change: Changes default Android implementation from `camera_android` to `camera_android_camerax` via a breaking change and updates relevant documentation. ~<ins>**Note:**</ins> Planning to land this after flutter#6608, as it is a semi-crucial fix.~ Done :)

Make base changes
1cf757b

github-actionsBot added p: camera platform-android labels Apr 30, 2024

camsim99 added 3 commits May 6, 2024 11:34

Merge remote-tracking branch 'upstream/main' into camx_def
9c511bb

Bump version
f55614a

Add prepareForVideoRecording empty impl
23ab00f

camsim99 mentioned this pull request May 6, 2024
[camerax] Add empty implementation for prepareForVideoRecording not used on Android #6676
Merged
11 tasks

camsim99 added 3 commits May 6, 2024 15:50

Merge remote-tracking branch 'upstream/main' into camx_def
91ab029

Bump version
17f8d38

Debugging video player file issue
2f75ebd

github-actionsBot added the p: video_player label May 8, 2024

camsim99 added 3 commits May 8, 2024 12:55

Test fixes
6ba8099

fxi
ef62ca8

Use void stream
15d44d8

camsim99 mentioned this pull request May 8, 2024
[camerax] Make fixes required to swap camera_android_camerax for camera_android #6697
Merged
11 tasks

camsim99 added 2 commits May 8, 2024 18:44

Remove prints
f4fdc8d

Merge remote-tracking branch 'upstream/main' into camx_def
5e875c8

github-actionsBot removed the p: video_player label May 8, 2024

camsim99 added 4 commits May 8, 2024 18:55

Add video recording integration test
8575e64

Prep for landing -- undo test fixes
a5182be

Undo more test changes
ccb8856

Address comments fromflutter#6697
b5108cc

camsim99 marked this pull request as ready for review May 10, 2024 16:53

camsim99 requested a review from bparrishMines as a code owner May 10, 2024 16:53

camsim99 requested review from mariamhas and stuartmorgan-g May 10, 2024 16:54

camsim99 requested a review from reidbaker May 10, 2024 17:33

stuartmorgan-g requested changes May 11, 2024
View reviewed changes

camsim99 added 3 commits May 11, 2024 12:33

Address review
961810d

Add link
6849640

Merge remote-tracking branch 'upstream/main' into camx_def
7c1d1f8

camsim99 requested a review from stuartmorgan-g May 11, 2024 17:32

stuartmorgan-g approved these changes May 11, 2024
View reviewed changes

reidbaker approved these changes May 13, 2024
View reviewed changes

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2024

auto-submitBot merged commit 9588cce into flutter:mainMay 13, 2024

engine-flutter-autoroll mentioned this pull request May 13, 2024
Roll Packages from 6c4482a64492 to 9588cce77dba (14 revisions) flutter/flutter#148223
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
9588cce[camera] Change default Android implementation from `camera_a…
e18e68f
…ndroid` to `camera_android_camerax` (flutter/packages#6629)

engine-flutter-autoroll mentioned this pull request May 13, 2024
Roll Packages from 6c4482a64492 to f91f68916da9 (15 revisions) flutter/flutter#148232
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
9588cce[camera] Change default Android implementation from `camera_a…
e03f8e5
…ndroid` to `camera_android_camerax` (flutter/packages#6629)

engine-flutter-autoroll mentioned this pull request May 13, 2024
Roll Packages from 6c4482a64492 to 1412041fa3fe (16 revisions) flutter/flutter#148239
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
9588cce[camera] Change default Android implementation from `camera_a…
996e7e1
…ndroid` to `camera_android_camerax` (flutter/packages#6629)

bparrishMines mentioned this pull request May 15, 2024
Roll pub packages flutter/flutter#148245
Closed

reidbaker mentioned this pull request Jul 2, 2024
i151188 update espresso dependencies v2 reidbaker/packages#6
Closed
11 tasks

Navigation Menu

Uh oh!

[camera] Change default Android implementation from `camera_android` to `camera_android_camerax` - #6629

[camera] Change default Android implementation from `camera_android` to `camera_android_camerax`#6629
auto-submit[bot] merged 19 commits into
flutter:mainfrom
camsim99:camx_def

camsim99 commented Apr 30, 2024•
edited
Loading

Uh oh!

camsim99 commented May 8, 2024•
edited
Loading

Uh oh!

camsim99 commented May 10, 2024•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

camsim99 commented Apr 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

camsim99 commented May 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camsim99 commented May 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camsim99 commented Apr 30, 2024•
edited
Loading

camsim99 commented May 8, 2024•
edited
Loading

camsim99 commented May 10, 2024•
edited
Loading