Skip to content

[interactive_media_ads] Adds support for pausing and resuming Ad playback and skipping an Ad - #7285

Merged
auto-submit[bot] merged 26 commits into
flutter:mainfrom
bparrishMines:ima_adsmanager
Sep 3, 2024
Merged

[interactive_media_ads] Adds support for pausing and resuming Ad playback and skipping an Ad#7285
auto-submit[bot] merged 26 commits into
flutter:mainfrom
bparrishMines:ima_adsmanager

Conversation

@bparrishMines

@bparrishMinesbparrishMines commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

Fixesflutter/flutter#152255

Also adds skip and discardAdBreak to AdsManager.

Also changes Android to not automatically start playing an Ad when the VideoView is prepared. onPrepared is called automatically whenever an app returns to the foreground by requiring the app to call AdsManager.resume to continue Ad playback after returning to the foreground. This makes Android consistent with iOS.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines
bparrishMines marked this pull request as draft August 14, 2024 17:31
@github-actionsgithub-actionsBot added the p: interactive_media_ads Plugin for IMA SDK label Aug 20, 2024
@bparrishMines
bparrishMines marked this pull request as ready for review August 29, 2024 23:56

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMinesbparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2024
@auto-submit
auto-submitBot merged commit a0ef40e into flutter:mainSep 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 4, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Sep 4, 2024
flutter/packages@848d7e9...e93995a
2024-09-04 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `JointType` to an enum (flutter/packages#7558)
2024-09-04 mhvdijk@gmail.com [flutter_adaptive_scaffold] Go router sample for AdaptiveScaffold (flutter/packages#7452)
2024-09-04 mhvdijk@gmail.com [flutter_adaptive_scaffold] Fix breakpoint not being active in certain cases like foldables (flutter/packages#7549)
2024-09-03 34871572+gmackall@users.noreply.github.com [google_sign_in_android] Downgrade Guava version from `33.3.0` to `32.0.1` (flutter/packages#7573)
2024-09-03 magder@google.com [google_maps_flutter] Remove unused MapKit imports from iOS example apps (flutter/packages#7522)
2024-09-03 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for pausing and resuming Ad playback and skipping an Ad (flutter/packages#7285)
2024-09-03 34871572+gmackall@users.noreply.github.com [rfw] Upgrade missed example app (flutter/packages#7545)
2024-09-03 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 1.4.0 to 1.4.1 in /packages/video_player/video_player_android/android (flutter/packages#7564)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bparrishMines
bparrishMines deleted the ima_adsmanager branch September 5, 2024 17:24
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…back and skipping an Ad (flutter#7285)
Fixesflutter/flutter#152255
Also adds `skip` and `discardAdBreak` to `AdsManager`.
Also changes Android to not automatically start playing an Ad when the `VideoView` is prepared. `onPrepared` is called automatically whenever an app returns to the foreground by requiring the app to call `AdsManager.resume` to continue Ad playback after returning to the foreground. This makes Android consistent with iOS.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…back and skipping an Ad (flutter#7285)
Fixesflutter/flutter#152255
Also adds `skip` and `discardAdBreak` to `AdsManager`.
Also changes Android to not automatically start playing an Ad when the `VideoView` is prepared. `onPrepared` is called automatically whenever an app returns to the foreground by requiring the app to call `AdsManager.resume` to continue Ad playback after returning to the foreground. This makes Android consistent with iOS.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: interactive_media_adsPlugin for IMA SDKplatform-androidplatform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[interactive_media_ads] Add support for AdsManager methods pause() and resume()

2 participants

@bparrishMines@stuartmorgan-g