Skip to content

[google_maps_flutter_android] Convert JointType to an enum - #7558

Merged
yaakovschectman merged 11 commits into
flutter:mainfrom
yaakovschectman:maps_joint
Sep 4, 2024
Merged

[google_maps_flutter_android] Convert JointType to an enum#7558
yaakovschectman merged 11 commits into
flutter:mainfrom
yaakovschectman:maps_joint

Conversation

@yaakovschectman

@yaakovschectmanyaakovschectman commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

Replace the raw integers used in PlatformPolyline to an enum.

flutter/flutter#153718 (comment)

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yaakovschectmanyaakovschectman self-assigned this Aug 30, 2024
@yaakovschectman
yaakovschectman marked this pull request as ready for review August 30, 2024 19:44
stuartmorgan-g
stuartmorgan-g requested changes Aug 30, 2024
View reviewed changes
Comment thread...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java Outdated
Comment thread...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
Comment threadpackages/google_maps_flutter/google_maps_flutter_android/pigeons/messages.dart Outdated
stuartmorgan-g
stuartmorgan-g requested changes Aug 31, 2024
View reviewed changes
Comment threadpackages/google_maps_flutter/google_maps_flutter_android/pigeons/messages.dart Outdated
Comment thread...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java Outdated
Comment thread...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
@yaakovschectman

yaakovschectman commented Sep 3, 2024

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan I am unclear on what we should do about this. We could add a default clause to the switch statement, but this would produce a warning for the time being as it is already exhaustive.

@stuartmorgan-g

stuartmorgan-g commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator

Are you talking about the Dart side? I linked to an example of our standard pattern for this, which includes the relevant ignore directive.

stuartmorgan-g
stuartmorgan-g requested changes Sep 3, 2024
View reviewed changes
Comment thread...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart Outdated
Comment thread...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md Outdated
stuartmorgan-g
stuartmorgan-g approved these changes Sep 4, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reidbaker
reidbaker approved these changes Sep 4, 2024
View reviewed changes
Comment thread...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
// any time, so provide a fallback that ensures this won't break when used
// with a version that contains new values. This is deliberately outside
// the switch rather than a `default` so that the linter will flag the
// switch as needing an update.

@reidbakerreidbakerSep 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is helpful.

@yaakovschectman
yaakovschectman merged commit e93995a into flutter:mainSep 4, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Sep 4, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
e93995a[google_maps_flutter_android] ConvertJointTypeto an enum (f…
8afd428
…lutter/packages#7558)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
Roll Packages from848d7e9toe93995a(8 revisions) (#154637)
5754e17
flutter/packages@848d7e9...e93995a
2024-09-04 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `JointType` to an enum (flutter/packages#7558)
2024-09-04 mhvdijk@gmail.com [flutter_adaptive_scaffold] Go router sample for AdaptiveScaffold (flutter/packages#7452)
2024-09-04 mhvdijk@gmail.com [flutter_adaptive_scaffold] Fix breakpoint not being active in certain cases like foldables (flutter/packages#7549)
2024-09-03 34871572+gmackall@users.noreply.github.com [google_sign_in_android] Downgrade Guava version from `33.3.0` to `32.0.1` (flutter/packages#7573)
2024-09-03 magder@google.com [google_maps_flutter] Remove unused MapKit imports from iOS example apps (flutter/packages#7522)
2024-09-03 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for pausing and resuming Ad playback and skipping an Ad (flutter/packages#7285)
2024-09-03 34871572+gmackall@users.noreply.github.com [rfw] Upgrade missed example app (flutter/packages#7545)
2024-09-03 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 1.4.0 to 1.4.1 in /packages/video_player/video_player_android/android (flutter/packages#7564)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@piedcipherpiedcipher mentioned this pull request Sep 5, 2024
Closed
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@yaakovschectman
[google_maps_flutter_android] ConvertJointTypeto an enum (flutter…
fd238d7
…#7558)
Replace the raw integers used in `PlatformPolyline` to an enum.
flutter/flutter#153718 (comment)
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [ ] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [ ] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style], or this PR is [exempt from
CHANGELOG changes].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[linked to at least one issue that this PR fixes]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[exempt from CHANGELOG changes]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@yaakovschectman
[google_maps_flutter_android] ConvertJointTypeto an enum (flutter…
c070b19
…#7558)
Replace the raw integers used in `PlatformPolyline` to an enum.
flutter/flutter#153718 (comment)
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [ ] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [ ] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style], or this PR is [exempt from
CHANGELOG changes].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[linked to at least one issue that this PR fixes]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[exempt from CHANGELOG changes]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@reidbakerreidbakerreidbaker approved these changes
@gmackallgmackallAwaiting requested review from gmackall

Assignees

@yaakovschectmanyaakovschectman

Labels

p: google_maps_flutterplatform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaakovschectman@stuartmorgan-g@reidbaker