Uh oh!
There was an error while loading. Please reload this page.
[flutter_adaptive_scaffold] Fix breakpoint not being active in certain cases like foldables - #7549
Merged
Merged
Conversation
11 tasks
hanskokx
commented
Aug 30, 2024
@martijn00 Tested and confirmed working on a Pixel Fold emulator using the following pubspec.yaml settings: flutter_adaptive_scaffold:
git:
url: https://github.com/martijn00/flutter_packages.gitref: af02e0e05adda36f22755cafd27575602ad95030path: packages/flutter_adaptive_scaffold |
martijn00
commented
Aug 30, 2024
ContributorAuthor
@Renzo-Olivares can you check this one? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
martijn00force-pushed
the
isactive-fix
branch
2 times, most recently
from
August 30, 2024 23:16
06ebea1 to
d0bdad8Comparemartijn00
commented
Sep 4, 2024
ContributorAuthor
@hanskokx this is now released. Can you confirm everything is good again? |
hanskokx
commented
Sep 4, 2024
Already saw and tested it. Everything looks good and works for me! Thanks for the quick fix :) |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2024
…n certain cases like foldables (flutter/packages#7549)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2024
…n certain cases like foldables (flutter/packages#7549)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2024
…n certain cases like foldables (flutter/packages#7549)
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 4, 2024
flutter/packages@848d7e9...e93995a 2024-09-04 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `JointType` to an enum (flutter/packages#7558) 2024-09-04 mhvdijk@gmail.com [flutter_adaptive_scaffold] Go router sample for AdaptiveScaffold (flutter/packages#7452) 2024-09-04 mhvdijk@gmail.com [flutter_adaptive_scaffold] Fix breakpoint not being active in certain cases like foldables (flutter/packages#7549) 2024-09-03 34871572+gmackall@users.noreply.github.com [google_sign_in_android] Downgrade Guava version from `33.3.0` to `32.0.1` (flutter/packages#7573) 2024-09-03 magder@google.com [google_maps_flutter] Remove unused MapKit imports from iOS example apps (flutter/packages#7522) 2024-09-03 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for pausing and resuming Ad playback and skipping an Ad (flutter/packages#7285) 2024-09-03 34871572+gmackall@users.noreply.github.com [rfw] Upgrade missed example app (flutter/packages#7545) 2024-09-03 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 1.4.0 to 1.4.1 in /packages/video_player/video_player_android/android (flutter/packages#7564) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…n cases like foldables (flutter#7549) *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* As pointed out by the docs on this: > Available width and height are classified separately, so at any point in time, your app has two window size classesâ��one for width, one for height. Available width is usually more important than available height due to the ubiquity of vertical scrolling, so the width window size class is likely more relevant to your app's UI. *List which issues are fixed by this PR. You must list at least one issue.*
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…n cases like foldables (flutter#7549) *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* As pointed out by the docs on this: > Available width and height are classified separately, so at any point in time, your app has two window size classesâ��one for width, one for height. Available width is usually more important than available height due to the ubiquity of vertical scrolling, so the width window size class is likely more relevant to your app's UI. *List which issues are fixed by this PR. You must list at least one issue.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
As pointed out by the docs on this:
List which issues are fixed by this PR. You must list at least one issue.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.