Skip to content

[in_app_purchase_storekit] Add Swift Package Manager compatibility - #8469

Merged
auto-submit[bot] merged 13 commits into
flutter:mainfrom
alejandro-all-win-software:feat/in-app-purchase-add-swift-package-manager-support
Jan 29, 2025
Merged

[in_app_purchase_storekit] Add Swift Package Manager compatibility#8469
auto-submit[bot] merged 13 commits into
flutter:mainfrom
alejandro-all-win-software:feat/in-app-purchase-add-swift-package-manager-support

Conversation

@alejandro-all-win-software

@alejandro-all-win-softwarealejandro-all-win-software commented Jan 21, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Makes in_app_purchase_storekit available as a Swift Package to Flutter

Closes#146905

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g

stuartmorgan-g commented Jan 21, 2025

Copy link
Copy Markdown
Collaborator
  • All existing and new tests are passing.

A number of the automated tests are not buildable in this PR. If you click into the failing CI tasks, click View more details on flutter-dashboard, and the go into the stdout for failing steps you can see the errors.

@alejandro-all-win-software
alejandro-all-win-software marked this pull request as draft January 21, 2025 21:55
@alejandro-all-win-software

alejandro-all-win-software commented Jan 22, 2025

Copy link
Copy Markdown
ContributorAuthor

I will fix tree issue tmr

@alejandro-all-win-software
alejandro-all-win-softwareforce-pushed the feat/in-app-purchase-add-swift-package-manager-support branch from b71a757 to 99a1132CompareJanuary 22, 2025 13:56
@alejandro-all-win-software

alejandro-all-win-software commented Jan 22, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hmm, I am not sure why the tree status is failing. I though it was because of the main merge in my branch.

@stuartmorgan-g

stuartmorgan-g commented Jan 22, 2025

Copy link
Copy Markdown
Collaborator

Hmm, I am not sure why the tree status is failing.

tree-status is a live-updating check reflecting the current post-submit state of the tree, in order to block all PRs from landing while the tree is broken. It is not related to the individual PR.

@alejandro-all-win-software

alejandro-all-win-software commented Jan 22, 2025

Copy link
Copy Markdown
ContributorAuthor

I see, thank you.

alejandro-all-win-software
Merge branch 'main' ofhttps://github.com/alejandro-all-win-software/…
f415bf0
…packages into feat/in-app-purchase-add-swift-package-manager-support
@alejandro-all-win-software
alejandro-all-win-softwareforce-pushed the feat/in-app-purchase-add-swift-package-manager-support branch from 99a1132 to f415bf0CompareJanuary 22, 2025 15:20
@alejandro-all-win-software
alejandro-all-win-software marked this pull request as ready for review January 22, 2025 15:21
alejandro-all-win-software
alejandro-all-win-software commented Jan 22, 2025
View reviewed changes
Comment threadpackages/in_app_purchase/in_app_purchase_storekit/example/shared/RunnerTests/Stubs.h
Comment on lines +14 to +18
#if __has_include(<in_app_purchase_storekit/in_app_purchase_storekit.h>)
@import in_app_purchase_storekit;
#else
@import storekit_objc;
#endif

@alejandro-all-win-softwarealejandro-all-win-softwareJan 22, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to avoid changing this file but I couldn't find a way.

@alejandro-all-win-software

alejandro-all-win-software commented Jan 22, 2025

Copy link
Copy Markdown
ContributorAuthor

Hey @loic-sharma, whenever you have a chance, could you review these changes, please? Thanks!

@stuartmorgan-gstuartmorgan-g added the triage-ios Should be looked at in iOS triage label Jan 23, 2025
@stuartmorgan-g

stuartmorgan-g commented Jan 23, 2025

Copy link
Copy Markdown
Collaborator

@alejandro-all-win-software Per our contributor docs, you should expect a review within two weeks, not 24 hours; please don't ping people just because they haven't immediately reviewed a PR.

alejandro-all-win-software added 2 commits January 24, 2025 13:55
alejandro-all-win-software added 2 commits January 24, 2025 17:25
loic-sharma
loic-sharma approved these changes Jan 27, 2025
View reviewed changes

@loic-sharmaloic-sharma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift Package Manager changes look good to me! Thank you for all the hard work, this is an excellent contribution 🥳

LouiseHsu
LouiseHsu approved these changes Jan 27, 2025
View reviewed changes

@LouiseHsuLouiseHsu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! I checked out your branch and everything functions correctly, thank you so much for doing this!

@loic-sharmaloic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2025
@auto-submit
auto-submitBot merged commit 91da100 into flutter:mainJan 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
91da100[in_app_purchase_storekit] Add Swift Package Manager compatib…
c169faf
…ility (flutter/packages#8469)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
91da100[in_app_purchase_storekit] Add Swift Package Manager compatib…
0998dc7
…ility (flutter/packages#8469)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 5, 2025
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
Roll Packages from02c6feftoe6ce02c(25 revisions) (#162760)
b6f659e
flutter/packages@02c6fef...e6ce02c
2025-02-05 65381000+raju8000@users.noreply.github.com [vector_graphics]
Allow transition between placeholder and loaded image to have an
animation (flutter/packages#8195)
2025-02-04 andrechalella@gmail.com [flutter_markdown] Make custom table
column alignments work when text wraps (flutter/packages#8340)
2025-02-04 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds internal wrapper for iOS native
`IMAAdPodInfo` (flutter/packages#8429)
2025-02-03 tarrinneal@gmail.com [pigeon] reorg generator files
(flutter/packages#8532)
2025-02-03 byoungchan.lee@gmx.com [pigeon] [swift] Fix `PigeonError`
sendability conformance in Swift 6 (flutter/packages#8302)
2025-02-03 engine-flutter-autoroll@skia.org Roll Flutter from
b007899 to 8e2a6fc (61 revisions) (flutter/packages#8556)
2025-02-03 20989940+aednlaxer@users.noreply.github.com
[google_maps_flutter] Support for Ground Overlay - platform interface
(flutter/packages#8518)
2025-01-31 737941+loic-sharma@users.noreply.github.com [tool] Add
--xcode-warnings-exceptions flag (flutter/packages#8524)
2025-01-31 stuartmorgan@google.com [tool] Ensure that injected
dependency overrides are sorted (flutter/packages#8542)
2025-01-31 jonahwilliams@google.com [vector_graphics] Revert leak
tracker change (flutter/packages#8544)
2025-01-31 parlough@gmail.com [shared_preferences_tool] Loosen
vm_service constraint to allow for 15 (flutter/packages#8539)
2025-01-31 32538273+ValentinVignal@users.noreply.github.com
[in_app_purchase] Activate leak testing for android
(flutter/packages#8369)
2025-01-31 cunderw@gmail.com [flutter_markdown] Allow tables to be
scrollable with IntrinsicColumnWidth (flutter/packages#8526)
2025-01-30 goderbauer@google.com Update CODEOWNERS for pkg:animations
(flutter/packages#8534)
2025-01-30 engine-flutter-autoroll@skia.org Roll Flutter from
c1ffaa9 to b007899 (43 revisions) (flutter/packages#8527)
2025-01-30 pawel.jakubowski@leancode.pl [video_player_web] Adjust Web
implementation to the new platform interface (flutter/packages#8528)
2025-01-30 tarrinneal@gmail.com [shared_preferences] Exposed
SharedPreferencesOptions. (flutter/packages#8530)
2025-01-29 stuartmorgan@google.com Re-land [shared_preferences] Add
shared preferences devtool (flutter/packages#8531)
2025-01-29 84978733+alejandro-all-win-software@users.noreply.github.com
[in_app_purchase_storekit] Add Swift Package Manager compatibility
(flutter/packages#8469)
2025-01-29 stuartmorgan@google.com Revert "Re-land [shared_preferences]
Add shared preferences devtool" (flutter/packages#8529)
2025-01-29 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Fixes trailing `?` by comparing iterables
(flutter/packages#8521)
2025-01-29 737941+loic-sharma@users.noreply.github.com [tool] Refactor
args of strings or YAML file lists (flutter/packages#8513)
2025-01-28 48155875+Michae1Weiss@users.noreply.github.com [go_router]
Add missing await keyword to onTap callback in the code example in
`navigation.md` (flutter/packages#8343)
2025-01-28 stuartmorgan@google.com Re-land [shared_preferences] Add
shared preferences devtool (flutter/packages#8519)
2025-01-28 32538273+ValentinVignal@users.noreply.github.com
[vector_graphics] Fix memory leaks and activate leak testing
[prod-leak-fix] (flutter/packages#8373)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@alejandro-all-win-software@androidseb
[in_app_purchase_storekit] Add Swift Package Manager compatibility (f…
0077325
…lutter#8469)
Makes `in_app_purchase_storekit` available as a Swift Package to Flutter
Closes [#146905](flutter/flutter#146905)
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@alejandro-all-win-software@FMorschel
[in_app_purchase_storekit] Add Swift Package Manager compatibility (f…
a5fc0e7
…lutter#8469)
Makes `in_app_purchase_storekit` available as a Swift Package to Flutter
Closes [#146905](flutter/flutter#146905)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@alejandro-all-win-software
[in_app_purchase_storekit] Add Swift Package Manager compatibility (f…
78fc98d
…lutter#8469)
Makes `in_app_purchase_storekit` available as a Swift Package to Flutter
Closes [#146905](flutter/flutter#146905)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@alejandro-all-win-software
[in_app_purchase_storekit] Add Swift Package Manager compatibility (f…
8b1e1e6
…lutter#8469)
Makes `in_app_purchase_storekit` available as a Swift Package to Flutter
Closes [#146905](flutter/flutter#146905)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagmanjmagmanjmagman left review comments
@loic-sharmaloic-sharmaloic-sharma approved these changes
@LouiseHsuLouiseHsuLouiseHsu approved these changes
@stuartmorgan-gstuartmorgan-gAwaiting requested review from stuartmorgan-g
@vashworthvashworthAwaiting requested review from vashworth

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: in_app_purchaseplatform-iosplatform-macostriage-iosShould be looked at in iOS triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[in_app_purchase_storekit] Add Swift Package Manager compatibility to in_app_purchase_storekit

5 participants

@alejandro-all-win-software@stuartmorgan-g@jmagman@loic-sharma@LouiseHsu