[google_maps_flutter] Support for Ground Overlay - platform interface by aednlaxer · Pull Request #8518 · flutter/packages

aednlaxer · 2025-01-28T12:24:52Z

This PR contains platform interface for the upcoming ground overlays support (#8432). Original PR with all the changes hasn't been approved yet but it was okayed to create the first sub-PR.

I'm not the author of the original PR but helping @jokerttu while he's on vacation.

Linked issue: flutter/flutter#26479

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…ground_overlay

stuartmorgan-g

LGTM with minor nits I missed in the main PR.

stuartmorgan-g · 2025-01-28T19:44:43Z

@tarrinneal or @bparrishMines could you do the secondary review on this one?

stuartmorgan-g · 2025-01-28T19:47:21Z

Hrm, looks like CI is hitting flutter/flutter#160810. I'll look at fixing that quickly so this can be rebased onto the fix.

…lay' of github.com:CodemateLtd/packages into feat/google_maps_flutter_platform_interface_ground_overlay

stuartmorgan-g · 2025-01-31T16:27:47Z

Hrm, looks like CI is hitting flutter/flutter#160810. I'll look at fixing that quickly so this can be rebased onto the fix.

Sorry I wasn't able to get to this as quickly as I thought; #8542 should fix it.

bparrishMines

LGTM with a couple nits

…ground_overlay

aednlaxer · 2025-02-03T07:36:52Z

Hrm, looks like CI is hitting flutter/flutter#160810. I'll look at fixing that quickly so this can be rebased onto the fix.
Sorry I wasn't able to get to this as quickly as I thought; #8542 should fix it.

Thanks! All CI checks now pass.

…nterface (flutter/packages#8518)

flutter/packages@02c6fef...e6ce02c 2025-02-05 65381000+raju8000@users.noreply.github.com [vector_graphics] Allow transition between placeholder and loaded image to have an animation (flutter/packages#8195) 2025-02-04 andrechalella@gmail.com [flutter_markdown] Make custom table column alignments work when text wraps (flutter/packages#8340) 2025-02-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for iOS native `IMAAdPodInfo` (flutter/packages#8429) 2025-02-03 tarrinneal@gmail.com [pigeon] reorg generator files (flutter/packages#8532) 2025-02-03 byoungchan.lee@gmx.com [pigeon] [swift] Fix `PigeonError` sendability conformance in Swift 6 (flutter/packages#8302) 2025-02-03 engine-flutter-autoroll@skia.org Roll Flutter from b007899 to 8e2a6fc (61 revisions) (flutter/packages#8556) 2025-02-03 20989940+aednlaxer@users.noreply.github.com [google_maps_flutter] Support for Ground Overlay - platform interface (flutter/packages#8518) 2025-01-31 737941+loic-sharma@users.noreply.github.com [tool] Add --xcode-warnings-exceptions flag (flutter/packages#8524) 2025-01-31 stuartmorgan@google.com [tool] Ensure that injected dependency overrides are sorted (flutter/packages#8542) 2025-01-31 jonahwilliams@google.com [vector_graphics] Revert leak tracker change (flutter/packages#8544) 2025-01-31 parlough@gmail.com [shared_preferences_tool] Loosen vm_service constraint to allow for 15 (flutter/packages#8539) 2025-01-31 32538273+ValentinVignal@users.noreply.github.com [in_app_purchase] Activate leak testing for android (flutter/packages#8369) 2025-01-31 cunderw@gmail.com [flutter_markdown] Allow tables to be scrollable with IntrinsicColumnWidth (flutter/packages#8526) 2025-01-30 goderbauer@google.com Update CODEOWNERS for pkg:animations (flutter/packages#8534) 2025-01-30 engine-flutter-autoroll@skia.org Roll Flutter from c1ffaa9 to b007899 (43 revisions) (flutter/packages#8527) 2025-01-30 pawel.jakubowski@leancode.pl [video_player_web] Adjust Web implementation to the new platform interface (flutter/packages#8528) 2025-01-30 tarrinneal@gmail.com [shared_preferences] Exposed SharedPreferencesOptions. (flutter/packages#8530) 2025-01-29 stuartmorgan@google.com Re-land [shared_preferences] Add shared preferences devtool (flutter/packages#8531) 2025-01-29 84978733+alejandro-all-win-software@users.noreply.github.com [in_app_purchase_storekit] Add Swift Package Manager compatibility (flutter/packages#8469) 2025-01-29 stuartmorgan@google.com Revert "Re-land [shared_preferences] Add shared preferences devtool" (flutter/packages#8529) 2025-01-29 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Fixes trailing `?` by comparing iterables (flutter/packages#8521) 2025-01-29 737941+loic-sharma@users.noreply.github.com [tool] Refactor args of strings or YAML file lists (flutter/packages#8513) 2025-01-28 48155875+Michae1Weiss@users.noreply.github.com [go_router] Add missing await keyword to onTap callback in the code example in `navigation.md` (flutter/packages#8343) 2025-01-28 stuartmorgan@google.com Re-land [shared_preferences] Add shared preferences devtool (flutter/packages#8519) 2025-01-28 32538273+ValentinVignal@users.noreply.github.com [vector_graphics] Fix memory leaks and activate leak testing [prod-leak-fix] (flutter/packages#8373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@jokerttu

…flutter#8518) This PR contains platform interface for the upcoming ground overlays support (flutter#8432). Original PR with all the changes hasn't been approved yet but it was [okayed](flutter#8432 (review)) to create the first sub-PR. I'm not the author of the original PR but helping @jokerttu while he's on vacation. Linked issue: flutter/flutter#26479

@jokerttu

…flutter#8518) This PR contains platform interface for the upcoming ground overlays support (flutter#8432). Original PR with all the changes hasn't been approved yet but it was [okayed](flutter#8432 (review)) to create the first sub-PR. I'm not the author of the original PR but helping @jokerttu while he's on vacation. Linked issue: flutter/flutter#26479

@jokerttu

…flutter#8518) This PR contains platform interface for the upcoming ground overlays support (flutter#8432). Original PR with all the changes hasn't been approved yet but it was [okayed](flutter#8432 (review)) to create the first sub-PR. I'm not the author of the original PR but helping @jokerttu while he's on vacation. Linked issue: flutter/flutter#26479

@jokerttu

…flutter#8518) This PR contains platform interface for the upcoming ground overlays support (flutter#8432). Original PR with all the changes hasn't been approved yet but it was [okayed](flutter#8432 (review)) to create the first sub-PR. I'm not the author of the original PR but helping @jokerttu while he's on vacation. Linked issue: flutter/flutter#26479

Add Ground Overlay support (platform interface)
0607ca7

aednlaxer requested a review from stuartmorgan-g as a code owner January 28, 2025 12:24

github-actionsBot added the p: google_maps_flutter label Jan 28, 2025

aednlaxer added 3 commits January 28, 2025 14:40

Update changelog
f8df341

Bump version code
14c6075

Merge branch 'main' into feat/google_maps_flutter_platform_interface_…
de39277
…ground_overlay

stuartmorgan-g approved these changes Jan 28, 2025
View reviewed changes

aednlaxer added 4 commits January 29, 2025 09:35

Change version to 2.10.0
753fbe1

Fix prepositions
396923b

Separate first sentence to its own paragraph
5220082

Merge branch 'feat/google_maps_flutter_platform_interface_ground_over…
8b04f87
…lay' of github.com:CodemateLtd/packages into feat/google_maps_flutter_platform_interface_ground_overlay

bparrishMines approved these changes Jan 31, 2025
View reviewed changes

Comment thread..._maps_flutter/google_maps_flutter_platform_interface/lib/src/types/utils/ground_overlay.dart Outdated
Comment thread...ogle_maps_flutter/google_maps_flutter_platform_interface/test/types/ground_overlay_test.dart Outdated

aednlaxer added 2 commits February 3, 2025 09:21

Fix nits
d90aa3b

Merge branch 'main' into feat/google_maps_flutter_platform_interface_…
a140f22
…ground_overlay

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025

auto-submitBot merged commit 54ef96e into flutter:mainFeb 3, 2025

aednlaxer deleted the feat/google_maps_flutter_platform_interface_ground_overlay branch February 3, 2025 13:14

engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Roll Packages from 02c6fef4ef63 to e6ce02c2a859 (25 revisions) flutter/flutter#162744
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 5, 2025
54ef96e[google_maps_flutter] Support for Ground Overlay - platform i…
e2dc6a4
…nterface (flutter/packages#8518)

engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Roll Packages from 02c6fef4ef63 to e6ce02c2a859 (25 revisions) flutter/flutter#162760
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 5, 2025
54ef96e[google_maps_flutter] Support for Ground Overlay - platform i…
331221f
…nterface (flutter/packages#8518)

Navigation Menu

Uh oh!

[google_maps_flutter] Support for Ground Overlay - platform interface - #8518

[google_maps_flutter] Support for Ground Overlay - platform interface#8518
auto-submit[bot] merged 10 commits into
flutter:mainfrom
CodemateLtd:feat/google_maps_flutter_platform_interface_ground_overlay

aednlaxer commented Jan 28, 2025•
edited
Loading

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g commented Jan 28, 2025

Uh oh!

stuartmorgan-g commented Jan 28, 2025

Uh oh!

stuartmorgan-g commented Jan 31, 2025

Uh oh!

bparrishMines left a comment

Uh oh!

Uh oh!

Uh oh!

aednlaxer commented Feb 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

aednlaxer commented Jan 28, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g commented Jan 28, 2025

Uh oh!

stuartmorgan-g commented Jan 28, 2025

Uh oh!

stuartmorgan-g commented Jan 31, 2025

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aednlaxer commented Feb 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aednlaxer commented Jan 28, 2025•
edited
Loading