Uh oh!
There was an error while loading. Please reload this page.
[video_player_web] Adjust Web implementation to the new platform interface - #8528
Merged
FirentisTFW merged 4 commits intoJan 30, 2025
Conversation
FirentisTFWforce-pushed
the
feature/video-player-web-platform-view-support
branch
from
January 29, 2025 17:24
711a9fe to
3e79a30CompareFirentisTFW
marked this pull request as ready for review
January 29, 2025 17:43
stuartmorgan-g
approved these changes
Jan 29, 2025
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the quick cleanup!
FirentisTFW
commented
Jan 30, 2025
ContributorAuthor
@ditman Would you like to do the secondary review? |
stuartmorgan-g
commented
Jan 30, 2025
Collaborator
@FirentisTFW Now that you have the magic (If this changed non-trivial web logic I'd definitely want someone with more web expertise than me to review it, but this is a straightforward PR.) |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2025
github-merge-queueBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 5, 2025
flutter/packages@02c6fef...e6ce02c 2025-02-05 65381000+raju8000@users.noreply.github.com [vector_graphics] Allow transition between placeholder and loaded image to have an animation (flutter/packages#8195) 2025-02-04 andrechalella@gmail.com [flutter_markdown] Make custom table column alignments work when text wraps (flutter/packages#8340) 2025-02-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for iOS native `IMAAdPodInfo` (flutter/packages#8429) 2025-02-03 tarrinneal@gmail.com [pigeon] reorg generator files (flutter/packages#8532) 2025-02-03 byoungchan.lee@gmx.com [pigeon] [swift] Fix `PigeonError` sendability conformance in Swift 6 (flutter/packages#8302) 2025-02-03 engine-flutter-autoroll@skia.org Roll Flutter from b007899 to 8e2a6fc (61 revisions) (flutter/packages#8556) 2025-02-03 20989940+aednlaxer@users.noreply.github.com [google_maps_flutter] Support for Ground Overlay - platform interface (flutter/packages#8518) 2025-01-31 737941+loic-sharma@users.noreply.github.com [tool] Add --xcode-warnings-exceptions flag (flutter/packages#8524) 2025-01-31 stuartmorgan@google.com [tool] Ensure that injected dependency overrides are sorted (flutter/packages#8542) 2025-01-31 jonahwilliams@google.com [vector_graphics] Revert leak tracker change (flutter/packages#8544) 2025-01-31 parlough@gmail.com [shared_preferences_tool] Loosen vm_service constraint to allow for 15 (flutter/packages#8539) 2025-01-31 32538273+ValentinVignal@users.noreply.github.com [in_app_purchase] Activate leak testing for android (flutter/packages#8369) 2025-01-31 cunderw@gmail.com [flutter_markdown] Allow tables to be scrollable with IntrinsicColumnWidth (flutter/packages#8526) 2025-01-30 goderbauer@google.com Update CODEOWNERS for pkg:animations (flutter/packages#8534) 2025-01-30 engine-flutter-autoroll@skia.org Roll Flutter from c1ffaa9 to b007899 (43 revisions) (flutter/packages#8527) 2025-01-30 pawel.jakubowski@leancode.pl [video_player_web] Adjust Web implementation to the new platform interface (flutter/packages#8528) 2025-01-30 tarrinneal@gmail.com [shared_preferences] Exposed SharedPreferencesOptions. (flutter/packages#8530) 2025-01-29 stuartmorgan@google.com Re-land [shared_preferences] Add shared preferences devtool (flutter/packages#8531) 2025-01-29 84978733+alejandro-all-win-software@users.noreply.github.com [in_app_purchase_storekit] Add Swift Package Manager compatibility (flutter/packages#8469) 2025-01-29 stuartmorgan@google.com Revert "Re-land [shared_preferences] Add shared preferences devtool" (flutter/packages#8529) 2025-01-29 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Fixes trailing `?` by comparing iterables (flutter/packages#8521) 2025-01-29 737941+loic-sharma@users.noreply.github.com [tool] Refactor args of strings or YAML file lists (flutter/packages#8513) 2025-01-28 48155875+Michae1Weiss@users.noreply.github.com [go_router] Add missing await keyword to onTap callback in the code example in `navigation.md` (flutter/packages#8343) 2025-01-28 stuartmorgan@google.com Re-land [shared_preferences] Add shared preferences devtool (flutter/packages#8519) 2025-01-28 32538273+ValentinVignal@users.noreply.github.com [vector_graphics] Fix memory leaks and activate leak testing [prod-leak-fix] (flutter/packages#8373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…rface (flutter#8528) This PR adjusts the Web `video_player` implementation to the new platform interface which was introduced in flutter#8453. Specifically, it renames `textureId` to `playerId` (which actually makes sense here, as there are no texture IDs on Web, it was just a "simulation" to comply with the interface). This PR does not fix any issue directly, but it's related to [#86613](flutter/flutter#86613).
FMorschel pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…rface (flutter#8528) This PR adjusts the Web `video_player` implementation to the new platform interface which was introduced in flutter#8453. Specifically, it renames `textureId` to `playerId` (which actually makes sense here, as there are no texture IDs on Web, it was just a "simulation" to comply with the interface). This PR does not fix any issue directly, but it's related to [#86613](flutter/flutter#86613).
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…rface (flutter#8528) This PR adjusts the Web `video_player` implementation to the new platform interface which was introduced in flutter#8453. Specifically, it renames `textureId` to `playerId` (which actually makes sense here, as there are no texture IDs on Web, it was just a "simulation" to comply with the interface). This PR does not fix any issue directly, but it's related to [#86613](flutter/flutter#86613).
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…rface (flutter#8528) This PR adjusts the Web `video_player` implementation to the new platform interface which was introduced in flutter#8453. Specifically, it renames `textureId` to `playerId` (which actually makes sense here, as there are no texture IDs on Web, it was just a "simulation" to comply with the interface). This PR does not fix any issue directly, but it's related to [#86613](flutter/flutter#86613).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the Web
video_playerimplementation to the new platform interface which was introduced in #8453. Specifically, it renamestextureIdtoplayerId(which actually makes sense here, as there are no texture IDs on Web, it was just a "simulation" to comply with the interface).This PR does not fix any issue directly, but it's related to #86613.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.