Uh oh!
There was an error while loading. Please reload this page.
feat(core): Streamline SpanJSON type - #14693
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Dec 13, 2024
Lms24
approved these changes
Dec 13, 2024
mydeaforce-pushed
the
fn/span-no-optional-data
branch
from
December 13, 2024 10:54
c5b1f0c to
50a66ffComparemydeaforce-pushed
the
fn/span-no-optional-data
branch
from
December 13, 2024 11:52
50a66ff to
7fba7dbCompareAbhiPrasad
approved these changes
Dec 13, 2024
mydeaforce-pushed
the
fn/span-no-optional-data
branch
from
December 16, 2024 07:56
7fba7db to
faa37deComparemydea
enabled auto-merge (squash)
December 16, 2024 07:56
mydeaforce-pushed
the
fn/span-no-optional-data
branch
from
December 16, 2024 08:10
faa37de to
fb7efb9Comparemydea added a commit
that referenced
this pull request
Dec 17, 2024
Since this was reworked in #14693 to always return something, we can safe some checks/fallbacks. This most likely does not change all the things, but focuses on the places that were easy to find/replace.
10 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
spanToJSONwould returnPartial<SpanJSON>. This meant that you always had to guard all the stuff you picked from it - even though in reality, we know that certain stuff will always be there.To alleviate this, this PR changes this so that
spanToJSONactually returnsSpanJSON. This means that in the fallback case, we returndata: {}, as well as a random (current) timestamp. Since we know that in reality we will only have the two scenarios that we properly handle, this is fine IMHO and makes usage of this everywhere else a little bit less painful.In a follow up, we can get rid of a bunch of
const data = spanToJSON(span).data || {}type code.While at it, I also updated the type of
datatoSpanAttributes, which is correct (it wasRecord<string, any>before). Since we only allow span attributes to be set on this anyhow now, we can type this better. This also uncovered a few places with slightly "incorrect" type checks, I updated those too.This change is on the v9 branch - I think it should not really be breaking to a user in any way, as we simply return more data from
spanToJSON, and type whatdatais on there more tightly, so no existing code relying on this should break. But to be safe, I figured we may as well do that on v9 only.