chore(deps): Fixes JS SDK v9 breakages - #4566

Closed
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom
antonis/bump-js9
Closed

chore(deps): Fixes JS SDK v9 breakages #4566
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom
antonis/bump-js9

Conversation

@antonis

@antonisantonis commented Feb 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #4528

📜 Description

I've opened this PR to fixJS SDK v9 breakages without interfering with the update-javascript.sh ci automation and to get a 2nd eye on the changes.

Changes handled:

💡 Motivation and Context

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time309.44 ms330.69 ms21.25 ms
Size17.75 MiB20.10 MiB2.36 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

RevisionPlainWith SentryDiff
2b518a4416.96 ms419.80 ms2.84 ms
adf3982425.40 ms405.88 ms-19.52 ms
f193e90432.83 ms433.10 ms0.27 ms
fcac744515.94 ms507.66 ms-8.28 ms
1e9894e431.94 ms445.06 ms13.12 ms
77069a3341.91 ms358.43 ms16.52 ms
ce14fde465.58 ms454.73 ms-10.85 ms
727778d472.20 ms462.50 ms-9.70 ms
ff80bc5332.24 ms329.44 ms-2.79 ms
1428daf432.50 ms416.16 ms-16.34 ms

App size

RevisionPlainWith SentryDiff
2b518a417.75 MiB20.11 MiB2.37 MiB
adf398217.74 MiB20.08 MiB2.35 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
fcac74417.74 MiB20.10 MiB2.36 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
77069a317.74 MiB20.08 MiB2.35 MiB
ce14fde17.74 MiB20.08 MiB2.35 MiB
727778d17.74 MiB20.09 MiB2.35 MiB
ff80bc517.75 MiB20.11 MiB2.37 MiB
1428daf17.74 MiB20.08 MiB2.35 MiB

@github-actions

github-actionsBot commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time410.04 ms396.82 ms-13.22 ms
Size7.15 MiB8.37 MiB1.22 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

RevisionPlainWith SentryDiff
6bbb5e8+dirty372.67 ms426.37 ms53.69 ms
ff80bc5+dirty388.34 ms419.56 ms31.22 ms
2fa2dd4+dirty410.71 ms460.00 ms49.29 ms
88a5c10+dirty387.13 ms438.66 ms51.53 ms
1428daf+dirty413.94 ms472.71 ms58.77 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
727778d+dirty379.36 ms416.67 ms37.32 ms
fcac744+dirty370.23 ms413.69 ms43.46 ms
adf3982+dirty407.54 ms468.67 ms61.12 ms
ee6386c+dirty381.81 ms426.33 ms44.52 ms

App size

RevisionPlainWith SentryDiff
6bbb5e8+dirty7.15 MiB8.37 MiB1.22 MiB
ff80bc5+dirty7.15 MiB8.38 MiB1.23 MiB
2fa2dd4+dirty7.15 MiB8.38 MiB1.23 MiB
88a5c10+dirty7.15 MiB8.36 MiB1.21 MiB
1428daf+dirty7.15 MiB8.37 MiB1.22 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
727778d+dirty7.15 MiB8.37 MiB1.22 MiB
fcac744+dirty7.15 MiB8.37 MiB1.22 MiB
adf3982+dirty7.15 MiB8.37 MiB1.22 MiB
ee6386c+dirty7.15 MiB8.37 MiB1.22 MiB

@github-actions

github-actionsBot commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1230.08 ms1232.06 ms1.98 ms
Size2.63 MiB3.73 MiB1.10 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
88a5c10+dirty1242.02 ms1249.54 ms7.52 ms
965cf9f+dirty1237.92 ms1234.81 ms-3.11 ms
29d1f5b+dirty1231.75 ms1240.86 ms9.11 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
d5790fb+dirty1237.59 ms1239.83 ms2.23 ms
1428daf+dirty1231.58 ms1226.54 ms-5.04 ms
0ce9e4f+dirty1226.02 ms1229.73 ms3.71 ms
adf3982+dirty1231.80 ms1232.20 ms0.41 ms
57faccb+dirty1240.02 ms1241.56 ms1.54 ms

App size

RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
88a5c10+dirty2.36 MiB3.10 MiB753.52 KiB
965cf9f+dirty2.36 MiB3.11 MiB761.34 KiB
29d1f5b+dirty2.36 MiB3.12 MiB778.61 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
d5790fb+dirty2.63 MiB3.69 MiB1.05 MiB
1428daf+dirty2.36 MiB3.10 MiB759.42 KiB
0ce9e4f+dirty2.36 MiB3.10 MiB759.36 KiB
adf3982+dirty2.36 MiB3.10 MiB759.41 KiB
57faccb+dirty2.36 MiB3.11 MiB760.10 KiB

@github-actions

github-actionsBot commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1235.90 ms1237.16 ms1.27 ms
Size3.19 MiB4.30 MiB1.11 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
88a5c10+dirty1244.39 ms1238.30 ms-6.09 ms
965cf9f+dirty1224.78 ms1242.71 ms17.94 ms
29d1f5b+dirty1233.35 ms1226.16 ms-7.19 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
d5790fb+dirty1227.04 ms1234.14 ms7.10 ms
1428daf+dirty1235.27 ms1237.24 ms1.98 ms
0ce9e4f+dirty1237.40 ms1238.87 ms1.47 ms
adf3982+dirty1243.14 ms1242.96 ms-0.18 ms
57faccb+dirty1242.55 ms1239.17 ms-3.38 ms

App size

RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
88a5c10+dirty2.92 MiB3.66 MiB758.74 KiB
965cf9f+dirty2.92 MiB3.67 MiB773.95 KiB
29d1f5b+dirty2.92 MiB3.69 MiB789.93 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
d5790fb+dirty3.19 MiB4.25 MiB1.06 MiB
1428daf+dirty2.92 MiB3.67 MiB772.07 KiB
0ce9e4f+dirty2.92 MiB3.67 MiB771.89 KiB
adf3982+dirty2.92 MiB3.67 MiB772.04 KiB
57faccb+dirty2.92 MiB3.67 MiB772.55 KiB

@antonis

antonis commented Feb 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Closing in favour of #4568 that targets v7

@antonisantonis closed this Feb 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@antonis
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore(deps): Fixes JS SDK v9 breakages  - #4566
Closed
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Closed
chore(deps): Fixes JS SDK v9 breakages #4566
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Conversation
@antonis
@antonisantonis
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4528
📜 Description
I've opened this PR to fixJS SDK v9 breakages without interfering with the update-javascript.sh ci automation and to get a 2nd eye on the changes.
Changes handled:
💡 Motivation and Context
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time309.44 ms330.69 ms21.25 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
2b518a4416.96 ms419.80 ms2.84 ms
adf3982425.40 ms405.88 ms-19.52 ms
f193e90432.83 ms433.10 ms0.27 ms
fcac744515.94 ms507.66 ms-8.28 ms
1e9894e431.94 ms445.06 ms13.12 ms
77069a3341.91 ms358.43 ms16.52 ms
ce14fde465.58 ms454.73 ms-10.85 ms
727778d472.20 ms462.50 ms-9.70 ms
ff80bc5332.24 ms329.44 ms-2.79 ms
1428daf432.50 ms416.16 ms-16.34 ms
App size
RevisionPlainWith SentryDiff
2b518a417.75 MiB20.11 MiB2.37 MiB
adf398217.74 MiB20.08 MiB2.35 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
fcac74417.74 MiB20.10 MiB2.36 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
77069a317.74 MiB20.08 MiB2.35 MiB
ce14fde17.74 MiB20.08 MiB2.35 MiB
727778d17.74 MiB20.09 MiB2.35 MiB
ff80bc517.75 MiB20.11 MiB2.37 MiB
1428daf17.74 MiB20.08 MiB2.35 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.04 ms396.82 ms-13.22 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
6bbb5e8+dirty372.67 ms426.37 ms53.69 ms
ff80bc5+dirty388.34 ms419.56 ms31.22 ms
2fa2dd4+dirty410.71 ms460.00 ms49.29 ms
88a5c10+dirty387.13 ms438.66 ms51.53 ms
1428daf+dirty413.94 ms472.71 ms58.77 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
727778d+dirty379.36 ms416.67 ms37.32 ms
fcac744+dirty370.23 ms413.69 ms43.46 ms
adf3982+dirty407.54 ms468.67 ms61.12 ms
ee6386c+dirty381.81 ms426.33 ms44.52 ms
App size
RevisionPlainWith SentryDiff
6bbb5e8+dirty7.15 MiB8.37 MiB1.22 MiB
ff80bc5+dirty7.15 MiB8.38 MiB1.23 MiB
2fa2dd4+dirty7.15 MiB8.38 MiB1.23 MiB
88a5c10+dirty7.15 MiB8.36 MiB1.21 MiB
1428daf+dirty7.15 MiB8.37 MiB1.22 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
727778d+dirty7.15 MiB8.37 MiB1.22 MiB
fcac744+dirty7.15 MiB8.37 MiB1.22 MiB
adf3982+dirty7.15 MiB8.37 MiB1.22 MiB
ee6386c+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1230.08 ms1232.06 ms1.98 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
88a5c10+dirty1242.02 ms1249.54 ms7.52 ms
965cf9f+dirty1237.92 ms1234.81 ms-3.11 ms
29d1f5b+dirty1231.75 ms1240.86 ms9.11 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
d5790fb+dirty1237.59 ms1239.83 ms2.23 ms
1428daf+dirty1231.58 ms1226.54 ms-5.04 ms
0ce9e4f+dirty1226.02 ms1229.73 ms3.71 ms
adf3982+dirty1231.80 ms1232.20 ms0.41 ms
57faccb+dirty1240.02 ms1241.56 ms1.54 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
88a5c10+dirty2.36 MiB3.10 MiB753.52 KiB
965cf9f+dirty2.36 MiB3.11 MiB761.34 KiB
29d1f5b+dirty2.36 MiB3.12 MiB778.61 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
d5790fb+dirty2.63 MiB3.69 MiB1.05 MiB
1428daf+dirty2.36 MiB3.10 MiB759.42 KiB
0ce9e4f+dirty2.36 MiB3.10 MiB759.36 KiB
adf3982+dirty2.36 MiB3.10 MiB759.41 KiB
57faccb+dirty2.36 MiB3.11 MiB760.10 KiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1235.90 ms1237.16 ms1.27 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
88a5c10+dirty1244.39 ms1238.30 ms-6.09 ms
965cf9f+dirty1224.78 ms1242.71 ms17.94 ms
29d1f5b+dirty1233.35 ms1226.16 ms-7.19 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
d5790fb+dirty1227.04 ms1234.14 ms7.10 ms
1428daf+dirty1235.27 ms1237.24 ms1.98 ms
0ce9e4f+dirty1237.40 ms1238.87 ms1.47 ms
adf3982+dirty1243.14 ms1242.96 ms-0.18 ms
57faccb+dirty1242.55 ms1239.17 ms-3.38 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
88a5c10+dirty2.92 MiB3.66 MiB758.74 KiB
965cf9f+dirty2.92 MiB3.67 MiB773.95 KiB
29d1f5b+dirty2.92 MiB3.69 MiB789.93 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
d5790fb+dirty3.19 MiB4.25 MiB1.06 MiB
1428daf+dirty2.92 MiB3.67 MiB772.07 KiB
0ce9e4f+dirty2.92 MiB3.67 MiB771.89 KiB
adf3982+dirty2.92 MiB3.67 MiB772.04 KiB
57faccb+dirty2.92 MiB3.67 MiB772.55 KiB
@antonis
antonis
commented
Feb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing in favour of #4568 that targets v7
@antonisantonis
closed this
Feb 19, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(deps): Fixes JS SDK v9 breakages  - #4566
Closed
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Closed
chore(deps): Fixes JS SDK v9 breakages #4566
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Conversation
@antonis
@antonisantonis
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4528
📜 Description
I've opened this PR to fixJS SDK v9 breakages without interfering with the update-javascript.sh ci automation and to get a 2nd eye on the changes.
Changes handled:
💡 Motivation and Context
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time309.44 ms330.69 ms21.25 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
2b518a4416.96 ms419.80 ms2.84 ms
adf3982425.40 ms405.88 ms-19.52 ms
f193e90432.83 ms433.10 ms0.27 ms
fcac744515.94 ms507.66 ms-8.28 ms
1e9894e431.94 ms445.06 ms13.12 ms
77069a3341.91 ms358.43 ms16.52 ms
ce14fde465.58 ms454.73 ms-10.85 ms
727778d472.20 ms462.50 ms-9.70 ms
ff80bc5332.24 ms329.44 ms-2.79 ms
1428daf432.50 ms416.16 ms-16.34 ms
App size
RevisionPlainWith SentryDiff
2b518a417.75 MiB20.11 MiB2.37 MiB
adf398217.74 MiB20.08 MiB2.35 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
fcac74417.74 MiB20.10 MiB2.36 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
77069a317.74 MiB20.08 MiB2.35 MiB
ce14fde17.74 MiB20.08 MiB2.35 MiB
727778d17.74 MiB20.09 MiB2.35 MiB
ff80bc517.75 MiB20.11 MiB2.37 MiB
1428daf17.74 MiB20.08 MiB2.35 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.04 ms396.82 ms-13.22 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
6bbb5e8+dirty372.67 ms426.37 ms53.69 ms
ff80bc5+dirty388.34 ms419.56 ms31.22 ms
2fa2dd4+dirty410.71 ms460.00 ms49.29 ms
88a5c10+dirty387.13 ms438.66 ms51.53 ms
1428daf+dirty413.94 ms472.71 ms58.77 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
727778d+dirty379.36 ms416.67 ms37.32 ms
fcac744+dirty370.23 ms413.69 ms43.46 ms
adf3982+dirty407.54 ms468.67 ms61.12 ms
ee6386c+dirty381.81 ms426.33 ms44.52 ms
App size
RevisionPlainWith SentryDiff
6bbb5e8+dirty7.15 MiB8.37 MiB1.22 MiB
ff80bc5+dirty7.15 MiB8.38 MiB1.23 MiB
2fa2dd4+dirty7.15 MiB8.38 MiB1.23 MiB
88a5c10+dirty7.15 MiB8.36 MiB1.21 MiB
1428daf+dirty7.15 MiB8.37 MiB1.22 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
727778d+dirty7.15 MiB8.37 MiB1.22 MiB
fcac744+dirty7.15 MiB8.37 MiB1.22 MiB
adf3982+dirty7.15 MiB8.37 MiB1.22 MiB
ee6386c+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1230.08 ms1232.06 ms1.98 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
88a5c10+dirty1242.02 ms1249.54 ms7.52 ms
965cf9f+dirty1237.92 ms1234.81 ms-3.11 ms
29d1f5b+dirty1231.75 ms1240.86 ms9.11 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
d5790fb+dirty1237.59 ms1239.83 ms2.23 ms
1428daf+dirty1231.58 ms1226.54 ms-5.04 ms
0ce9e4f+dirty1226.02 ms1229.73 ms3.71 ms
adf3982+dirty1231.80 ms1232.20 ms0.41 ms
57faccb+dirty1240.02 ms1241.56 ms1.54 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
88a5c10+dirty2.36 MiB3.10 MiB753.52 KiB
965cf9f+dirty2.36 MiB3.11 MiB761.34 KiB
29d1f5b+dirty2.36 MiB3.12 MiB778.61 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
d5790fb+dirty2.63 MiB3.69 MiB1.05 MiB
1428daf+dirty2.36 MiB3.10 MiB759.42 KiB
0ce9e4f+dirty2.36 MiB3.10 MiB759.36 KiB
adf3982+dirty2.36 MiB3.10 MiB759.41 KiB
57faccb+dirty2.36 MiB3.11 MiB760.10 KiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1235.90 ms1237.16 ms1.27 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
88a5c10+dirty1244.39 ms1238.30 ms-6.09 ms
965cf9f+dirty1224.78 ms1242.71 ms17.94 ms
29d1f5b+dirty1233.35 ms1226.16 ms-7.19 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
d5790fb+dirty1227.04 ms1234.14 ms7.10 ms
1428daf+dirty1235.27 ms1237.24 ms1.98 ms
0ce9e4f+dirty1237.40 ms1238.87 ms1.47 ms
adf3982+dirty1243.14 ms1242.96 ms-0.18 ms
57faccb+dirty1242.55 ms1239.17 ms-3.38 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
88a5c10+dirty2.92 MiB3.66 MiB758.74 KiB
965cf9f+dirty2.92 MiB3.67 MiB773.95 KiB
29d1f5b+dirty2.92 MiB3.69 MiB789.93 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
d5790fb+dirty3.19 MiB4.25 MiB1.06 MiB
1428daf+dirty2.92 MiB3.67 MiB772.07 KiB
0ce9e4f+dirty2.92 MiB3.67 MiB771.89 KiB
adf3982+dirty2.92 MiB3.67 MiB772.04 KiB
57faccb+dirty2.92 MiB3.67 MiB772.55 KiB
@antonis
antonis
commented
Feb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing in favour of #4568 that targets v7
@antonisantonis
closed this
Feb 19, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(deps): Fixes JS SDK v9 breakages  - #4566
Closed
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Closed
chore(deps): Fixes JS SDK v9 breakages #4566
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Conversation
@antonis
@antonisantonis
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4528
📜 Description
I've opened this PR to fixJS SDK v9 breakages without interfering with the update-javascript.sh ci automation and to get a 2nd eye on the changes.
Changes handled:
💡 Motivation and Context
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time309.44 ms330.69 ms21.25 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
2b518a4416.96 ms419.80 ms2.84 ms
adf3982425.40 ms405.88 ms-19.52 ms
f193e90432.83 ms433.10 ms0.27 ms
fcac744515.94 ms507.66 ms-8.28 ms
1e9894e431.94 ms445.06 ms13.12 ms
77069a3341.91 ms358.43 ms16.52 ms
ce14fde465.58 ms454.73 ms-10.85 ms
727778d472.20 ms462.50 ms-9.70 ms
ff80bc5332.24 ms329.44 ms-2.79 ms
1428daf432.50 ms416.16 ms-16.34 ms
App size
RevisionPlainWith SentryDiff
2b518a417.75 MiB20.11 MiB2.37 MiB
adf398217.74 MiB20.08 MiB2.35 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
fcac74417.74 MiB20.10 MiB2.36 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
77069a317.74 MiB20.08 MiB2.35 MiB
ce14fde17.74 MiB20.08 MiB2.35 MiB
727778d17.74 MiB20.09 MiB2.35 MiB
ff80bc517.75 MiB20.11 MiB2.37 MiB
1428daf17.74 MiB20.08 MiB2.35 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.04 ms396.82 ms-13.22 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
6bbb5e8+dirty372.67 ms426.37 ms53.69 ms
ff80bc5+dirty388.34 ms419.56 ms31.22 ms
2fa2dd4+dirty410.71 ms460.00 ms49.29 ms
88a5c10+dirty387.13 ms438.66 ms51.53 ms
1428daf+dirty413.94 ms472.71 ms58.77 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
727778d+dirty379.36 ms416.67 ms37.32 ms
fcac744+dirty370.23 ms413.69 ms43.46 ms
adf3982+dirty407.54 ms468.67 ms61.12 ms
ee6386c+dirty381.81 ms426.33 ms44.52 ms
App size
RevisionPlainWith SentryDiff
6bbb5e8+dirty7.15 MiB8.37 MiB1.22 MiB
ff80bc5+dirty7.15 MiB8.38 MiB1.23 MiB
2fa2dd4+dirty7.15 MiB8.38 MiB1.23 MiB
88a5c10+dirty7.15 MiB8.36 MiB1.21 MiB
1428daf+dirty7.15 MiB8.37 MiB1.22 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
727778d+dirty7.15 MiB8.37 MiB1.22 MiB
fcac744+dirty7.15 MiB8.37 MiB1.22 MiB
adf3982+dirty7.15 MiB8.37 MiB1.22 MiB
ee6386c+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1230.08 ms1232.06 ms1.98 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
88a5c10+dirty1242.02 ms1249.54 ms7.52 ms
965cf9f+dirty1237.92 ms1234.81 ms-3.11 ms
29d1f5b+dirty1231.75 ms1240.86 ms9.11 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
d5790fb+dirty1237.59 ms1239.83 ms2.23 ms
1428daf+dirty1231.58 ms1226.54 ms-5.04 ms
0ce9e4f+dirty1226.02 ms1229.73 ms3.71 ms
adf3982+dirty1231.80 ms1232.20 ms0.41 ms
57faccb+dirty1240.02 ms1241.56 ms1.54 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
88a5c10+dirty2.36 MiB3.10 MiB753.52 KiB
965cf9f+dirty2.36 MiB3.11 MiB761.34 KiB
29d1f5b+dirty2.36 MiB3.12 MiB778.61 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
d5790fb+dirty2.63 MiB3.69 MiB1.05 MiB
1428daf+dirty2.36 MiB3.10 MiB759.42 KiB
0ce9e4f+dirty2.36 MiB3.10 MiB759.36 KiB
adf3982+dirty2.36 MiB3.10 MiB759.41 KiB
57faccb+dirty2.36 MiB3.11 MiB760.10 KiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1235.90 ms1237.16 ms1.27 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
88a5c10+dirty1244.39 ms1238.30 ms-6.09 ms
965cf9f+dirty1224.78 ms1242.71 ms17.94 ms
29d1f5b+dirty1233.35 ms1226.16 ms-7.19 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
d5790fb+dirty1227.04 ms1234.14 ms7.10 ms
1428daf+dirty1235.27 ms1237.24 ms1.98 ms
0ce9e4f+dirty1237.40 ms1238.87 ms1.47 ms
adf3982+dirty1243.14 ms1242.96 ms-0.18 ms
57faccb+dirty1242.55 ms1239.17 ms-3.38 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
88a5c10+dirty2.92 MiB3.66 MiB758.74 KiB
965cf9f+dirty2.92 MiB3.67 MiB773.95 KiB
29d1f5b+dirty2.92 MiB3.69 MiB789.93 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
d5790fb+dirty3.19 MiB4.25 MiB1.06 MiB
1428daf+dirty2.92 MiB3.67 MiB772.07 KiB
0ce9e4f+dirty2.92 MiB3.67 MiB771.89 KiB
adf3982+dirty2.92 MiB3.67 MiB772.04 KiB
57faccb+dirty2.92 MiB3.67 MiB772.55 KiB
@antonis
antonis
commented
Feb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing in favour of #4568 that targets v7
@antonisantonis
closed this
Feb 19, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore(deps): Fixes JS SDK v9 breakages  - #4566
Closed
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Closed
chore(deps): Fixes JS SDK v9 breakages #4566
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Conversation
@antonis
@antonisantonis
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4528
📜 Description
I've opened this PR to fixJS SDK v9 breakages without interfering with the update-javascript.sh ci automation and to get a 2nd eye on the changes.
Changes handled:
💡 Motivation and Context
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time309.44 ms330.69 ms21.25 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
2b518a4416.96 ms419.80 ms2.84 ms
adf3982425.40 ms405.88 ms-19.52 ms
f193e90432.83 ms433.10 ms0.27 ms
fcac744515.94 ms507.66 ms-8.28 ms
1e9894e431.94 ms445.06 ms13.12 ms
77069a3341.91 ms358.43 ms16.52 ms
ce14fde465.58 ms454.73 ms-10.85 ms
727778d472.20 ms462.50 ms-9.70 ms
ff80bc5332.24 ms329.44 ms-2.79 ms
1428daf432.50 ms416.16 ms-16.34 ms
App size
RevisionPlainWith SentryDiff
2b518a417.75 MiB20.11 MiB2.37 MiB
adf398217.74 MiB20.08 MiB2.35 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
fcac74417.74 MiB20.10 MiB2.36 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
77069a317.74 MiB20.08 MiB2.35 MiB
ce14fde17.74 MiB20.08 MiB2.35 MiB
727778d17.74 MiB20.09 MiB2.35 MiB
ff80bc517.75 MiB20.11 MiB2.37 MiB
1428daf17.74 MiB20.08 MiB2.35 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.04 ms396.82 ms-13.22 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
6bbb5e8+dirty372.67 ms426.37 ms53.69 ms
ff80bc5+dirty388.34 ms419.56 ms31.22 ms
2fa2dd4+dirty410.71 ms460.00 ms49.29 ms
88a5c10+dirty387.13 ms438.66 ms51.53 ms
1428daf+dirty413.94 ms472.71 ms58.77 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
727778d+dirty379.36 ms416.67 ms37.32 ms
fcac744+dirty370.23 ms413.69 ms43.46 ms
adf3982+dirty407.54 ms468.67 ms61.12 ms
ee6386c+dirty381.81 ms426.33 ms44.52 ms
App size
RevisionPlainWith SentryDiff
6bbb5e8+dirty7.15 MiB8.37 MiB1.22 MiB
ff80bc5+dirty7.15 MiB8.38 MiB1.23 MiB
2fa2dd4+dirty7.15 MiB8.38 MiB1.23 MiB
88a5c10+dirty7.15 MiB8.36 MiB1.21 MiB
1428daf+dirty7.15 MiB8.37 MiB1.22 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
727778d+dirty7.15 MiB8.37 MiB1.22 MiB
fcac744+dirty7.15 MiB8.37 MiB1.22 MiB
adf3982+dirty7.15 MiB8.37 MiB1.22 MiB
ee6386c+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1230.08 ms1232.06 ms1.98 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
88a5c10+dirty1242.02 ms1249.54 ms7.52 ms
965cf9f+dirty1237.92 ms1234.81 ms-3.11 ms
29d1f5b+dirty1231.75 ms1240.86 ms9.11 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
d5790fb+dirty1237.59 ms1239.83 ms2.23 ms
1428daf+dirty1231.58 ms1226.54 ms-5.04 ms
0ce9e4f+dirty1226.02 ms1229.73 ms3.71 ms
adf3982+dirty1231.80 ms1232.20 ms0.41 ms
57faccb+dirty1240.02 ms1241.56 ms1.54 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
88a5c10+dirty2.36 MiB3.10 MiB753.52 KiB
965cf9f+dirty2.36 MiB3.11 MiB761.34 KiB
29d1f5b+dirty2.36 MiB3.12 MiB778.61 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
d5790fb+dirty2.63 MiB3.69 MiB1.05 MiB
1428daf+dirty2.36 MiB3.10 MiB759.42 KiB
0ce9e4f+dirty2.36 MiB3.10 MiB759.36 KiB
adf3982+dirty2.36 MiB3.10 MiB759.41 KiB
57faccb+dirty2.36 MiB3.11 MiB760.10 KiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1235.90 ms1237.16 ms1.27 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
88a5c10+dirty1244.39 ms1238.30 ms-6.09 ms
965cf9f+dirty1224.78 ms1242.71 ms17.94 ms
29d1f5b+dirty1233.35 ms1226.16 ms-7.19 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
d5790fb+dirty1227.04 ms1234.14 ms7.10 ms
1428daf+dirty1235.27 ms1237.24 ms1.98 ms
0ce9e4f+dirty1237.40 ms1238.87 ms1.47 ms
adf3982+dirty1243.14 ms1242.96 ms-0.18 ms
57faccb+dirty1242.55 ms1239.17 ms-3.38 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
88a5c10+dirty2.92 MiB3.66 MiB758.74 KiB
965cf9f+dirty2.92 MiB3.67 MiB773.95 KiB
29d1f5b+dirty2.92 MiB3.69 MiB789.93 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
d5790fb+dirty3.19 MiB4.25 MiB1.06 MiB
1428daf+dirty2.92 MiB3.67 MiB772.07 KiB
0ce9e4f+dirty2.92 MiB3.67 MiB771.89 KiB
adf3982+dirty2.92 MiB3.67 MiB772.04 KiB
57faccb+dirty2.92 MiB3.67 MiB772.55 KiB
@antonis
antonis
commented
Feb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing in favour of #4568 that targets v7
@antonisantonis
closed this
Feb 19, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(deps): Fixes JS SDK v9 breakages  - #4566
Closed
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Closed
chore(deps): Fixes JS SDK v9 breakages #4566
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Conversation
@antonis
@antonisantonis
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4528
📜 Description
I've opened this PR to fixJS SDK v9 breakages without interfering with the update-javascript.sh ci automation and to get a 2nd eye on the changes.
Changes handled:
💡 Motivation and Context
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time309.44 ms330.69 ms21.25 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
2b518a4416.96 ms419.80 ms2.84 ms
adf3982425.40 ms405.88 ms-19.52 ms
f193e90432.83 ms433.10 ms0.27 ms
fcac744515.94 ms507.66 ms-8.28 ms
1e9894e431.94 ms445.06 ms13.12 ms
77069a3341.91 ms358.43 ms16.52 ms
ce14fde465.58 ms454.73 ms-10.85 ms
727778d472.20 ms462.50 ms-9.70 ms
ff80bc5332.24 ms329.44 ms-2.79 ms
1428daf432.50 ms416.16 ms-16.34 ms
App size
RevisionPlainWith SentryDiff
2b518a417.75 MiB20.11 MiB2.37 MiB
adf398217.74 MiB20.08 MiB2.35 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
fcac74417.74 MiB20.10 MiB2.36 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
77069a317.74 MiB20.08 MiB2.35 MiB
ce14fde17.74 MiB20.08 MiB2.35 MiB
727778d17.74 MiB20.09 MiB2.35 MiB
ff80bc517.75 MiB20.11 MiB2.37 MiB
1428daf17.74 MiB20.08 MiB2.35 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.04 ms396.82 ms-13.22 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
6bbb5e8+dirty372.67 ms426.37 ms53.69 ms
ff80bc5+dirty388.34 ms419.56 ms31.22 ms
2fa2dd4+dirty410.71 ms460.00 ms49.29 ms
88a5c10+dirty387.13 ms438.66 ms51.53 ms
1428daf+dirty413.94 ms472.71 ms58.77 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
727778d+dirty379.36 ms416.67 ms37.32 ms
fcac744+dirty370.23 ms413.69 ms43.46 ms
adf3982+dirty407.54 ms468.67 ms61.12 ms
ee6386c+dirty381.81 ms426.33 ms44.52 ms
App size
RevisionPlainWith SentryDiff
6bbb5e8+dirty7.15 MiB8.37 MiB1.22 MiB
ff80bc5+dirty7.15 MiB8.38 MiB1.23 MiB
2fa2dd4+dirty7.15 MiB8.38 MiB1.23 MiB
88a5c10+dirty7.15 MiB8.36 MiB1.21 MiB
1428daf+dirty7.15 MiB8.37 MiB1.22 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
727778d+dirty7.15 MiB8.37 MiB1.22 MiB
fcac744+dirty7.15 MiB8.37 MiB1.22 MiB
adf3982+dirty7.15 MiB8.37 MiB1.22 MiB
ee6386c+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1230.08 ms1232.06 ms1.98 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
88a5c10+dirty1242.02 ms1249.54 ms7.52 ms
965cf9f+dirty1237.92 ms1234.81 ms-3.11 ms
29d1f5b+dirty1231.75 ms1240.86 ms9.11 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
d5790fb+dirty1237.59 ms1239.83 ms2.23 ms
1428daf+dirty1231.58 ms1226.54 ms-5.04 ms
0ce9e4f+dirty1226.02 ms1229.73 ms3.71 ms
adf3982+dirty1231.80 ms1232.20 ms0.41 ms
57faccb+dirty1240.02 ms1241.56 ms1.54 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
88a5c10+dirty2.36 MiB3.10 MiB753.52 KiB
965cf9f+dirty2.36 MiB3.11 MiB761.34 KiB
29d1f5b+dirty2.36 MiB3.12 MiB778.61 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
d5790fb+dirty2.63 MiB3.69 MiB1.05 MiB
1428daf+dirty2.36 MiB3.10 MiB759.42 KiB
0ce9e4f+dirty2.36 MiB3.10 MiB759.36 KiB
adf3982+dirty2.36 MiB3.10 MiB759.41 KiB
57faccb+dirty2.36 MiB3.11 MiB760.10 KiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1235.90 ms1237.16 ms1.27 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
88a5c10+dirty1244.39 ms1238.30 ms-6.09 ms
965cf9f+dirty1224.78 ms1242.71 ms17.94 ms
29d1f5b+dirty1233.35 ms1226.16 ms-7.19 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
d5790fb+dirty1227.04 ms1234.14 ms7.10 ms
1428daf+dirty1235.27 ms1237.24 ms1.98 ms
0ce9e4f+dirty1237.40 ms1238.87 ms1.47 ms
adf3982+dirty1243.14 ms1242.96 ms-0.18 ms
57faccb+dirty1242.55 ms1239.17 ms-3.38 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
88a5c10+dirty2.92 MiB3.66 MiB758.74 KiB
965cf9f+dirty2.92 MiB3.67 MiB773.95 KiB
29d1f5b+dirty2.92 MiB3.69 MiB789.93 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
d5790fb+dirty3.19 MiB4.25 MiB1.06 MiB
1428daf+dirty2.92 MiB3.67 MiB772.07 KiB
0ce9e4f+dirty2.92 MiB3.67 MiB771.89 KiB
adf3982+dirty2.92 MiB3.67 MiB772.04 KiB
57faccb+dirty2.92 MiB3.67 MiB772.55 KiB
@antonis
antonis
commented
Feb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing in favour of #4568 that targets v7
@antonisantonis
closed this
Feb 19, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(deps): Fixes JS SDK v9 breakages  - #4566
Closed
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Closed
chore(deps): Fixes JS SDK v9 breakages #4566
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Conversation
@antonis
@antonisantonis
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4528
📜 Description
I've opened this PR to fixJS SDK v9 breakages without interfering with the update-javascript.sh ci automation and to get a 2nd eye on the changes.
Changes handled:
💡 Motivation and Context
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time309.44 ms330.69 ms21.25 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
2b518a4416.96 ms419.80 ms2.84 ms
adf3982425.40 ms405.88 ms-19.52 ms
f193e90432.83 ms433.10 ms0.27 ms
fcac744515.94 ms507.66 ms-8.28 ms
1e9894e431.94 ms445.06 ms13.12 ms
77069a3341.91 ms358.43 ms16.52 ms
ce14fde465.58 ms454.73 ms-10.85 ms
727778d472.20 ms462.50 ms-9.70 ms
ff80bc5332.24 ms329.44 ms-2.79 ms
1428daf432.50 ms416.16 ms-16.34 ms
App size
RevisionPlainWith SentryDiff
2b518a417.75 MiB20.11 MiB2.37 MiB
adf398217.74 MiB20.08 MiB2.35 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
fcac74417.74 MiB20.10 MiB2.36 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
77069a317.74 MiB20.08 MiB2.35 MiB
ce14fde17.74 MiB20.08 MiB2.35 MiB
727778d17.74 MiB20.09 MiB2.35 MiB
ff80bc517.75 MiB20.11 MiB2.37 MiB
1428daf17.74 MiB20.08 MiB2.35 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.04 ms396.82 ms-13.22 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
6bbb5e8+dirty372.67 ms426.37 ms53.69 ms
ff80bc5+dirty388.34 ms419.56 ms31.22 ms
2fa2dd4+dirty410.71 ms460.00 ms49.29 ms
88a5c10+dirty387.13 ms438.66 ms51.53 ms
1428daf+dirty413.94 ms472.71 ms58.77 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
727778d+dirty379.36 ms416.67 ms37.32 ms
fcac744+dirty370.23 ms413.69 ms43.46 ms
adf3982+dirty407.54 ms468.67 ms61.12 ms
ee6386c+dirty381.81 ms426.33 ms44.52 ms
App size
RevisionPlainWith SentryDiff
6bbb5e8+dirty7.15 MiB8.37 MiB1.22 MiB
ff80bc5+dirty7.15 MiB8.38 MiB1.23 MiB
2fa2dd4+dirty7.15 MiB8.38 MiB1.23 MiB
88a5c10+dirty7.15 MiB8.36 MiB1.21 MiB
1428daf+dirty7.15 MiB8.37 MiB1.22 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
727778d+dirty7.15 MiB8.37 MiB1.22 MiB
fcac744+dirty7.15 MiB8.37 MiB1.22 MiB
adf3982+dirty7.15 MiB8.37 MiB1.22 MiB
ee6386c+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1230.08 ms1232.06 ms1.98 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
88a5c10+dirty1242.02 ms1249.54 ms7.52 ms
965cf9f+dirty1237.92 ms1234.81 ms-3.11 ms
29d1f5b+dirty1231.75 ms1240.86 ms9.11 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
d5790fb+dirty1237.59 ms1239.83 ms2.23 ms
1428daf+dirty1231.58 ms1226.54 ms-5.04 ms
0ce9e4f+dirty1226.02 ms1229.73 ms3.71 ms
adf3982+dirty1231.80 ms1232.20 ms0.41 ms
57faccb+dirty1240.02 ms1241.56 ms1.54 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
88a5c10+dirty2.36 MiB3.10 MiB753.52 KiB
965cf9f+dirty2.36 MiB3.11 MiB761.34 KiB
29d1f5b+dirty2.36 MiB3.12 MiB778.61 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
d5790fb+dirty2.63 MiB3.69 MiB1.05 MiB
1428daf+dirty2.36 MiB3.10 MiB759.42 KiB
0ce9e4f+dirty2.36 MiB3.10 MiB759.36 KiB
adf3982+dirty2.36 MiB3.10 MiB759.41 KiB
57faccb+dirty2.36 MiB3.11 MiB760.10 KiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1235.90 ms1237.16 ms1.27 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
88a5c10+dirty1244.39 ms1238.30 ms-6.09 ms
965cf9f+dirty1224.78 ms1242.71 ms17.94 ms
29d1f5b+dirty1233.35 ms1226.16 ms-7.19 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
d5790fb+dirty1227.04 ms1234.14 ms7.10 ms
1428daf+dirty1235.27 ms1237.24 ms1.98 ms
0ce9e4f+dirty1237.40 ms1238.87 ms1.47 ms
adf3982+dirty1243.14 ms1242.96 ms-0.18 ms
57faccb+dirty1242.55 ms1239.17 ms-3.38 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
88a5c10+dirty2.92 MiB3.66 MiB758.74 KiB
965cf9f+dirty2.92 MiB3.67 MiB773.95 KiB
29d1f5b+dirty2.92 MiB3.69 MiB789.93 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
d5790fb+dirty3.19 MiB4.25 MiB1.06 MiB
1428daf+dirty2.92 MiB3.67 MiB772.07 KiB
0ce9e4f+dirty2.92 MiB3.67 MiB771.89 KiB
adf3982+dirty2.92 MiB3.67 MiB772.04 KiB
57faccb+dirty2.92 MiB3.67 MiB772.55 KiB
@antonis
antonis
commented
Feb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing in favour of #4568 that targets v7
@antonisantonis
closed this
Feb 19, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore(deps): Fixes JS SDK v9 breakages  - #4566
Closed
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Closed
chore(deps): Fixes JS SDK v9 breakages #4566
antonis wants to merge 9 commits into
deps/scripts/update-javascript.shfrom 
antonis/bump-js9
Conversation
@antonis
@antonisantonis
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4528
📜 Description
I've opened this PR to fixJS SDK v9 breakages without interfering with the update-javascript.sh ci automation and to get a 2nd eye on the changes.
Changes handled:
💡 Motivation and Context
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time309.44 ms330.69 ms21.25 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
2b518a4416.96 ms419.80 ms2.84 ms
adf3982425.40 ms405.88 ms-19.52 ms
f193e90432.83 ms433.10 ms0.27 ms
fcac744515.94 ms507.66 ms-8.28 ms
1e9894e431.94 ms445.06 ms13.12 ms
77069a3341.91 ms358.43 ms16.52 ms
ce14fde465.58 ms454.73 ms-10.85 ms
727778d472.20 ms462.50 ms-9.70 ms
ff80bc5332.24 ms329.44 ms-2.79 ms
1428daf432.50 ms416.16 ms-16.34 ms
App size
RevisionPlainWith SentryDiff
2b518a417.75 MiB20.11 MiB2.37 MiB
adf398217.74 MiB20.08 MiB2.35 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
fcac74417.74 MiB20.10 MiB2.36 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
77069a317.74 MiB20.08 MiB2.35 MiB
ce14fde17.74 MiB20.08 MiB2.35 MiB
727778d17.74 MiB20.09 MiB2.35 MiB
ff80bc517.75 MiB20.11 MiB2.37 MiB
1428daf17.74 MiB20.08 MiB2.35 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.04 ms396.82 ms-13.22 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
6bbb5e8+dirty372.67 ms426.37 ms53.69 ms
ff80bc5+dirty388.34 ms419.56 ms31.22 ms
2fa2dd4+dirty410.71 ms460.00 ms49.29 ms
88a5c10+dirty387.13 ms438.66 ms51.53 ms
1428daf+dirty413.94 ms472.71 ms58.77 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
727778d+dirty379.36 ms416.67 ms37.32 ms
fcac744+dirty370.23 ms413.69 ms43.46 ms
adf3982+dirty407.54 ms468.67 ms61.12 ms
ee6386c+dirty381.81 ms426.33 ms44.52 ms
App size
RevisionPlainWith SentryDiff
6bbb5e8+dirty7.15 MiB8.37 MiB1.22 MiB
ff80bc5+dirty7.15 MiB8.38 MiB1.23 MiB
2fa2dd4+dirty7.15 MiB8.38 MiB1.23 MiB
88a5c10+dirty7.15 MiB8.36 MiB1.21 MiB
1428daf+dirty7.15 MiB8.37 MiB1.22 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
727778d+dirty7.15 MiB8.37 MiB1.22 MiB
fcac744+dirty7.15 MiB8.37 MiB1.22 MiB
adf3982+dirty7.15 MiB8.37 MiB1.22 MiB
ee6386c+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1230.08 ms1232.06 ms1.98 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
88a5c10+dirty1242.02 ms1249.54 ms7.52 ms
965cf9f+dirty1237.92 ms1234.81 ms-3.11 ms
29d1f5b+dirty1231.75 ms1240.86 ms9.11 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
d5790fb+dirty1237.59 ms1239.83 ms2.23 ms
1428daf+dirty1231.58 ms1226.54 ms-5.04 ms
0ce9e4f+dirty1226.02 ms1229.73 ms3.71 ms
adf3982+dirty1231.80 ms1232.20 ms0.41 ms
57faccb+dirty1240.02 ms1241.56 ms1.54 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
88a5c10+dirty2.36 MiB3.10 MiB753.52 KiB
965cf9f+dirty2.36 MiB3.11 MiB761.34 KiB
29d1f5b+dirty2.36 MiB3.12 MiB778.61 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
d5790fb+dirty2.63 MiB3.69 MiB1.05 MiB
1428daf+dirty2.36 MiB3.10 MiB759.42 KiB
0ce9e4f+dirty2.36 MiB3.10 MiB759.36 KiB
adf3982+dirty2.36 MiB3.10 MiB759.41 KiB
57faccb+dirty2.36 MiB3.11 MiB760.10 KiB
@github-actions
github-actionsBot
commented
Feb 19, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1235.90 ms1237.16 ms1.27 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
88a5c10+dirty1244.39 ms1238.30 ms-6.09 ms
965cf9f+dirty1224.78 ms1242.71 ms17.94 ms
29d1f5b+dirty1233.35 ms1226.16 ms-7.19 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
d5790fb+dirty1227.04 ms1234.14 ms7.10 ms
1428daf+dirty1235.27 ms1237.24 ms1.98 ms
0ce9e4f+dirty1237.40 ms1238.87 ms1.47 ms
adf3982+dirty1243.14 ms1242.96 ms-0.18 ms
57faccb+dirty1242.55 ms1239.17 ms-3.38 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
88a5c10+dirty2.92 MiB3.66 MiB758.74 KiB
965cf9f+dirty2.92 MiB3.67 MiB773.95 KiB
29d1f5b+dirty2.92 MiB3.69 MiB789.93 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
d5790fb+dirty3.19 MiB4.25 MiB1.06 MiB
1428daf+dirty2.92 MiB3.67 MiB772.07 KiB
0ce9e4f+dirty2.92 MiB3.67 MiB771.89 KiB
adf3982+dirty2.92 MiB3.67 MiB772.04 KiB
57faccb+dirty2.92 MiB3.67 MiB772.55 KiB
@antonis
antonis
commented
Feb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing in favour of #4568 that targets v7
@antonisantonis
closed this
Feb 19, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@antonis