Skip to content

Add Three token properties in GIDGoogleUser API - #189

Merged
Alex-4-Git merged 18 commits into
GIDGoogleUser-restructurefrom
pin-removeGIDAuthentication
Aug 11, 2022
Merged

Add Three token properties in GIDGoogleUser API#189
Alex-4-Git merged 18 commits into
GIDGoogleUser-restructurefrom
pin-removeGIDAuthentication

Conversation

@Alex-4-Git

@Alex-4-GitAlex-4-Git commented Jul 28, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Move the token related properties from GIDAuthentication.h to GIDGoogleUser.h.
In the previous PR we created the new class GIDToken. We can use this new type to add three tokens: access token, refresh token and ID token.

@Alex-4-GitAlex-4-Git reopened this Jul 28, 2022
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-removeGIDAuthentication branch 3 times, most recently from fbdcea6 to 09672e8CompareJuly 29, 2022 03:47
@mdmathias

mdmathias commented Jul 29, 2022

Copy link
Copy Markdown
Collaborator

It might be beneficial in the future to add some more context in your PR description. Off the top of my head, I'm not sure why we want to add the these three token properties. I can go looking for context to help, but it'd be nice to have it here too. Moreover, I think we are all much less likely to remember, or be able to find, this context if we return to this PR in the future.

mdmathias
mdmathias reviewed Jul 29, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-removeGIDAuthentication branch from 54c24b0 to a495e24CompareJuly 30, 2022 18:36
mdmathias
mdmathias reviewed Aug 1, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
mdmathias
mdmathias reviewed Aug 1, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDTokenTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDTokenTest.m Outdated
petea
petea suggested changes Aug 1, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
@Alex-4-Git
Alex-4-Git requested a review from peteaAugust 2, 2022 04:01
petea
petea suggested changes Aug 2, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-removeGIDAuthentication branch from 858c710 to 02f9af5CompareAugust 3, 2022 14:46
@Alex-4-Git
Create branch GIDGoogleUser-restructure to track PRs relating to GIDG…
549213e
…oogleUser
@Alex-4-Git
Create class GIDUserAuth (#177)
8520637
* Create class GIDUserAuth
Add class GIDUserAuth to represent the outcome of a successful signIn or addScopes flow.
@Alex-4-Git
Replace GIDSignInCallback (#179)
1f54000
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
@Alex-4-Git
Add GIDToken Class (#181)
4094422
Add GIDToken class
@Alex-4-Git
Add the propertyconfigurationtoGIDGoogleUser(#183)
be4f6fa
* Add the property GIDConfiguration to GIDGoogleUser
- Add a GIDConfiguration to replace hostedDomain, serverClientID, openRealm.
- Remove the property serverAuthCode.
@Alex-4-Git
Replace GIDSignInCallback (#179)
71f82c0
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
@Alex-4-Git
Add three tokens in GIDGoogleUser API
02d3736
@Alex-4-Git
Resolve comments
b320b07
@Alex-4-Git
Resolve comments
6111126
@Alex-4-Git
Resolve comment
59886e4
@Alex-4-Git
Add NS_ASSUME_NONNULL_BEGIN(END)
be0b965
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-removeGIDAuthentication branch from 02f9af5 to 9dcff47CompareAugust 3, 2022 18:09
@Alex-4-Git
Alex-4-Gitforce-pushed the GIDGoogleUser-restructure branch from 331202d to ada3203CompareAugust 3, 2022 19:52
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-removeGIDAuthentication branch from 312f45a to d86d5a9CompareAugust 3, 2022 20:54
petea
petea suggested changes Aug 4, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDToken.h Outdated
Comment threadGoogleSignIn/Sources/GIDToken.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDTokenTest.m
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
@Alex-4-Git
Alex-4-Git requested a review from peteaAugust 4, 2022 16:57
petea
petea suggested changes Aug 8, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
@Alex-4-Git
Resolve comments
c70498c
1. Add property getters in GIDGoogleUser to match the pattern of GIDConfiguration
2. Use copy on the string parsed from authState.
@Alex-4-Git
Alex-4-Git requested a review from peteaAugust 8, 2022 19:43
petea
petea suggested changes Aug 9, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
petea
petea suggested changes Aug 11, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
@Alex-4-Git
Alex-4-Git merged commit 5c8fa73 into GIDGoogleUser-restructureAug 11, 2022
@Alex-4-Git
Alex-4-Git deleted the pin-removeGIDAuthentication branch August 26, 2022 00:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasmdmathias approved these changes
+1 more reviewer
@peteapeteapetea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alex-4-Git@mdmathias@petea