Parse ResourceName into http endpoint path by andreamlin · Pull Request #481 · googleapis/gax-java

andreamlin · 2018-02-16T18:36:50Z

Moving parsing of ResourceNames to gax-java (instead of generated message classes). See googleapis/gapic-generator#1847.

Starting implementation for HTTP/JSON. This was tested by using the surface generated from https://github.com/googleapis/toolkit/tree/discogapic to list, get, insert, and delete Compute Address resources in a live Google Cloud project.

Exception handling and retry logic for http calls.

Merge in updates from the master branch.

…p http status codes to wrapper exception types

andreamlin · 2018-02-22T19:37:12Z

Made the suggested changes. PTAL
toolkit PR is also updated to reflect consumed changes.

Sign in to view


 @BetaApi
 public interface ApiMessage {
+ /* For a each fieldName in a set of fieldNames, fetch that field's List<String> value. */


Sign in to view

- ApiMessage getRequestBody();
+ ApiMessage getApiMessageRequestBody();
+
+ Map<String, String> getApiMessagePathParams();


…sage

andreamlin · 2018-02-24T05:19:20Z

Made the suggested changes. PTAL
toolkit PR is also updated to reflect consumed changes.

Sign in to view

+ apiMessage.populateFieldsInMap(Collections.singleton(resourceNameField));
+
+ String resourceNamePath = pathParamMap.get(resourceNameField).get(0);
+ return resourceNameInstance.parseFrom(resourceNamePath).getFieldValues();


Sign in to view

- return pathParams;
+ public Map<String, String> getPathParams(T apiMessage, String resourceNameField) {
+ Map<String, List<String>> pathParamMap =
+ apiMessage.populateFieldsInMap(Collections.singleton(resourceNameField));


Sign in to view

+public interface ResourceNameStruct extends ResourceName {
+ /* Fetch the comprehensive mapping of fieldNames to values. The set of keys of the resulting Map
+ should be constant, for a given instance of this interface. */
+ Map<String, String> getFieldValues();


Sign in to view

+ Map<String, List<String>> pathParamMap =
+ apiMessage.populateFieldsInMap(Collections.singleton(resourceNameField));
+
+ String resourceNamePath = pathParamMap.get(resourceNameField).get(0);


andreamlin · 2018-02-27T22:57:56Z

Blocked on googleapis/api-common-java#46.

andreamlin · 2018-02-28T22:20:06Z

PTAL
I'm not sure why the travis job is failing on gradle task verifyLicense for ResourceNameStruct; this passes locally for me and the file's license is identical to others.

The gradle build task passes for me locally.

Sign in to view

+
+ /* Return a new instance of this interface by parsing a formatted String. This should be treated as a static method. */
+ ResourceNameStruct parseFrom(String formattedString);
+}


garrettjonesgoogle · 2018-03-01T00:23:37Z

I believe that verifyLicense is failing because of #487 ; I think travis might locally merge your changes to master and run the build on that.

…ass; this depends on api-common PR

Sign in to view

+ String resourceNamePath = apiMessage.getFieldStringValue(resourceNameField);
+ if (resourceNamePath == null) {
+ throw new IOException(
+ String.format("Resource name field %s is null in message object.", resourceNameField));


Sign in to view

 @Override
 public Map<String, String> getPathParams(T apiMessage, String resourceNameField)
- throws IOException {
+ throws IllegalArgumentException {


andreamlin · 2018-03-07T01:04:36Z

Ok, two api-common releases later and this build passes! Further comments welcome. PTAL

garrettjonesgoogle

LGTM

garrettjonesgoogleand others added 30 commits August 22, 2017 09:51

Bootstrapping gax-httpjson (googleapis#355)
74089be

Http implementation (googleapis#361)
5e4a386
Starting implementation for HTTP/JSON. This was tested by using the surface generated from https://github.com/googleapis/toolkit/tree/discogapic to list, get, insert, and delete Compute Address resources in a live Google Cloud project.

Retry and failure-handling logic for http-json (googleapis#363)
33fa52b
Exception handling and retry logic for http calls.

Merge branch 'master' into merge_master
52db7d8

Merge master (googleapis#364)
30d6965
Merge in updates from the master branch.

Merge branch 'gax-httpjson' into apiexception
9f77e47

new HttpApiExceptionFactory that uses googleapis/rpc/code.proto to ma…
59d9460
…p http status codes to wrapper exception types

RetryTest passes
81a0db8

removed HttpJsonApiException.java
340af3c

no longer need to check status code when catching specific apiexception
bdd7469

Merge branch 'master' into apiexception
b6c627d

Merge branch 'master' into apiexception
d730192

merge master
cc311c8

rm according to master
2f0f216

???
3c3e031

Merge branch 'master' into apiexception
94ef9f7

Merge branch 'master' into apiexception
87fb34a

removed unused file
b449f09

expose setHttpTransport
2a579c9

Merge branch 'master' into apiexception
d1ac0bd

refactoring for mocking
f3ad3a3

managed http json channel:
9035411

Merge branch 'master' into apiexception
090e9b1

more test utils for mock http service
108b8c4

Merge branch 'master' into apiexception
98f973c

Merge branch 'master' into apiexception
e8aeade

Merge branch 'master' into apiexception
d5c7638

adding Struct class
0e0635d

removed unused MockHttpService
c4ad509

taking out changes from unit testing git branch
d936ce0

andreamlin added 2 commits February 22, 2018 10:39

remove pathParams
063d585

pathParams and requestBody to getApiMessagePathParams...
9e19414

garrettjonesgoogle reviewed Feb 23, 2018
View reviewed changes

andreamlin added 2 commits February 23, 2018 21:04

pushing ResourceNameStruct into ApiMethodDescriptor and out of ApiMes…
792f2f7
…sage

add license
cce327f

garrettjonesgoogle reviewed Feb 26, 2018
View reviewed changes

andreamlin added 2 commits February 27, 2018 16:38

getFieldValue() updated
6af8f4d

formatting and comments.
6262a22

andreamlin changed the title ~~Support resourcenames in gax-java~~Parse ResourceName into http endpoint pathFeb 28, 2018

garrettjonesgoogle reviewed Mar 1, 2018
View reviewed changes

andreamlin added 4 commits March 1, 2018 08:30

remove resourcenamestruct and replace with new resourcenamefactory cl…
f734de0
…ass; this depends on api-common PR

formatting
8a3105b

Merge branch 'master' into apiexception
5f63e56

apimessage.getFieldSTringValue doesn't throw IOException
84a58b2

garrettjonesgoogle reviewed Mar 1, 2018
View reviewed changes

andreamlin added 2 commits March 1, 2018 11:48

ResourseNameFactory uses parse() instead of parseFrom()
f106246

getPathParams throws IllegalArgException instead of IOException
9d7fb3b

garrettjonesgoogle reviewed Mar 1, 2018
View reviewed changes

no need to declare throws IllegalArgumentException"
746bb2e

andreamlin mentioned this pull request Mar 4, 2018
Discogapic: support setX(String) / (String)getX methods when X is a resource name type googleapis/gapic-generator#1804
Closed

Merge branch 'master' into apiexception
bd99c5a

garrettjonesgoogle approved these changes Mar 7, 2018
View reviewed changes

andreamlin merged commit 7f1d37b into googleapis:masterMar 7, 2018

Uh oh!

Conversation

andreamlin commented Feb 16, 2018

Uh oh!

andreamlin commented Feb 22, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

andreamlin commented Feb 24, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

andreamlin commented Feb 27, 2018

Uh oh!

andreamlin commented Feb 28, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Mar 1, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

andreamlin commented Mar 7, 2018

Uh oh!

garrettjonesgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andreamlin commented Feb 28, 2018•
edited
Loading