Uh oh!
There was an error while loading. Please reload this page.
impl(storage): new helpers for CRC32C computation - #11061
Merged
coryan merged 3 commits intoMar 18, 2023
Merged
Conversation
I am adding new functions to compute CRC32C checksums. When using recent versions of Abseil (>= 20230125) these functions can concatenate the checksum of two buffers. I am planning to use this in the GCS+gRPC plugin, where each `Write()` message includes a CRC32C and we also need to send the end-to-end checksum of all the `Write()` messages.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@## main #11061 +/- ##
========================================
Coverage 93.75% 93.76% ========================================
Files 1727 1730 +3 Lines 155798 155911 +113 ========================================
+ Hits 146069 146186 +117 + Misses 9729 9725 -4
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
coryan
marked this pull request as ready for review
March 17, 2023 20:28
dbolduc
reviewed
Mar 17, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dbolduc
approved these changes
Mar 18, 2023
kou added a commit
to kou/google-cloud-cpp
that referenced
this pull request
Aug 25, 2025
cc2a564 (googleapis#11061) introduced Abseil based CRC32C implementation. So we don't require crc32c when we use recent Abseil. If we don't require crc32c with recent Abseil, downstream users such as Apache Arrow don't need to bundle crc32c. It reduces maintenance cost. See also: apache/arrow#45989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am adding new functions to compute CRC32C checksums. When using recent versions of Abseil (>= 20230125) these functions can concatenate the checksum of two buffers. I am planning to use this in the GCS+gRPC plugin, where each
Write()message includes a CRC32C and we also need to send the end-to-end checksum of all theWrite()messages.Part of the work #11060
This change is