Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on May 8, 2026. It is now read-only.
chore: improve embedded version handling - #715
Merged
igorbernstein2 merged 9 commits intoApr 13, 2021
Merged
Conversation
Use new feature in releasetool (googleapis/releasetool#317) to manage the client version instead of maven tricks introduced in googleapis#451
igorbernstein2
commented
Apr 9, 2021
ContributorAuthor
Jeff is putting together a more general solution in googleapis/release-please#850. Need to wait for that |
Codecov Report
@@ Coverage Diff @@## master #715 +/- ##
============================================
- Coverage 83.62% 83.62% -0.01%
Complexity 1008 1008 ============================================
Files 106 106 Lines 6046 6045 -1 Branches 392 392 ============================================
- Hits 5056 5055 -1
Misses 788 788 Partials 202 202
Continue to review full report at Codecov.
|
chingor13
commented
Apr 9, 2021
Contributor
After googleapis/repo-automation-bots#1629 is merged, you should be able to add: extraFiles:
- google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/ClientVersion.javato |
Warning: This pull request is touching the following templated files:
|
igorbernstein2
marked this pull request as ready for review
April 9, 2021 21:30
chingor13
approved these changes
Apr 9, 2021
Your PR has conflicts that you need to resolve before merge-on-green can automerge |
# Conflicts: # google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubTest.java
kolea2
approved these changes
Apr 13, 2021
kolea2 pushed a commit
to kolea2/java-bigtable
that referenced
this pull request
May 20, 2021
* chore: improve embedded version handling Use new feature in releasetool (googleapis/releasetool#317) to manage the client version instead of maven tricks introduced in googleapis#451 * migrate to new version scheme * rename back to Version * config release-please for version bumps * make sure file doesnt get clobbered * add a couple of tests * fmt (cherry picked from commit 1af8925)
kolea2 added a commit
that referenced
this pull request
May 21, 2021
* chore: improve embedded version handling (#715) * chore: improve embedded version handling Use new feature in releasetool (googleapis/releasetool#317) to manage the client version instead of maven tricks introduced in #451 * migrate to new version scheme * rename back to Version * config release-please for version bumps * make sure file doesnt get clobbered * add a couple of tests * fmt (cherry picked from commit 1af8925) * update version * fix test * fix: add back in extraFiles and fix file path (#833) (cherry picked from commit f914954) * fix test Co-authored-by: Igor Bernstein <igorbernstein@google.com>
gcf-merge-on-greenBot
pushed a commit
that referenced
this pull request
May 24, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.22.0-sp.1](https://www.github.com/googleapis/java-bigtable/compare/1.22.0...v1.22.0-sp.1) (2021-05-21) ### Features * configure initial sp version ([#829](https://www.github.com/googleapis/java-bigtable/issues/829)) ([47480c5](https://www.github.com/googleapis/java-bigtable/commit/47480c55ab08b80154a4a7d2bb76a9dccfcdea03)) ### Bug Fixes * filter limit constant ([#787](https://www.github.com/googleapis/java-bigtable/issues/787)) ([#835](https://www.github.com/googleapis/java-bigtable/issues/835)) ([cf16cfe](https://www.github.com/googleapis/java-bigtable/commit/cf16cfe5ee1ec509ed8faf3ff1342bd02a041468)) * improve embedded version handling ([#715](https://www.github.com/googleapis/java-bigtable/issues/715)) ([#832](https://www.github.com/googleapis/java-bigtable/issues/832)) ([f0fc1bf](https://www.github.com/googleapis/java-bigtable/commit/f0fc1bf77962ddc80bfd5aca6a8ca731641d940b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use new feature in releasetool (googleapis/releasetool#317) to manage the client version instead of maven tricks introduced in #451
This should not be merged until the releasetool feature is released