Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: improve embedded version handling (#715) - #832

Merged
kolea2 merged 5 commits into
googleapis:1.22.0-spfrom
kolea2:sp-port-175
May 21, 2021
Merged

fix: improve embedded version handling (#715)#832
kolea2 merged 5 commits into
googleapis:1.22.0-spfrom
kolea2:sp-port-175

Conversation

@kolea2

@kolea2kolea2 commented May 20, 2021

Copy link
Copy Markdown
Contributor

(cherry picked from commit 1af8925)

additional fixing version cherry pick: (cherry picked from commit f914954)

igorbernstein2and others added 2 commits May 20, 2021 17:14
* chore: improve embedded version handling
Use new feature in releasetool (googleapis/releasetool#317) to manage the client version instead of maven tricks introduced in googleapis#451
* migrate to new version scheme
* rename back to Version
* config release-please for version bumps
* make sure file doesnt get clobbered
* add a couple of tests
* fmt
(cherry picked from commit 1af8925)
@kolea2
kolea2 requested review from a teamMay 20, 2021 21:20
@product-auto-labelproduct-auto-labelBot added the api: bigtable Issues related to the googleapis/java-bigtable API. label May 20, 2021
@generated-files-bot

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/release-please.yml

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2021

@igorbernstein2igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtableIssues related to the googleapis/java-bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kolea2@igorbernstein2