Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: add back in extraFiles and fix file path - #833

Merged
kolea2 merged 1 commit into
googleapis:masterfrom
kolea2:client-version-fix
May 20, 2021
Merged

fix: add back in extraFiles and fix file path#833
kolea2 merged 1 commit into
googleapis:masterfrom
kolea2:client-version-fix

Conversation

@kolea2

Copy link
Copy Markdown
Contributor

file path was removed in last sp merge. It was pointing to the wrong file

- google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/ClientVersion.java

@kolea2
kolea2 requested review from a teamMay 20, 2021 21:25
@generated-files-bot

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/release-please.yml

@product-auto-labelproduct-auto-labelBot added the api: bigtable Issues related to the googleapis/java-bigtable API. label May 20, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2021

@igorbernstein2igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kolea2kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2021
@kolea2
kolea2 merged commit f914954 into googleapis:masterMay 20, 2021
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2021
@kolea2
kolea2 deleted the client-version-fix branch May 20, 2021 21:41
kolea2 added a commit to kolea2/java-bigtable that referenced this pull request May 20, 2021
kolea2 added a commit that referenced this pull request May 21, 2021
* chore: improve embedded version handling (#715)
* chore: improve embedded version handling
Use new feature in releasetool (googleapis/releasetool#317) to manage the client version instead of maven tricks introduced in #451
* migrate to new version scheme
* rename back to Version
* config release-please for version bumps
* make sure file doesnt get clobbered
* add a couple of tests
* fmt
(cherry picked from commit 1af8925)
* update version
* fix test
* fix: add back in extraFiles and fix file path (#833)
(cherry picked from commit f914954)
* fix test
Co-authored-by: Igor Bernstein <igorbernstein@google.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtableIssues related to the googleapis/java-bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kolea2@igorbernstein2