You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Something else I would want to add to the encoded representation would be a shape attribute that holds the shape of the input array:
Here is the interpretation I was picturing:
If shape is a scalar number, then decode into a TypedArray. This is the current behavior of the PR.
If shape is an array of N numbers, then decode into an N dimensional ndarray. Assume and document whatever winding order is most natural for use with ndarray library.
Then to make use of this in Plotly.js:
Update heatmap and image traces to accept 2D ndarrays.
Update isosurface and volume traces to accept 3D ndarrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two commits to help resolve conflicts in plotly#2911
@jonmmease
cc: @plotly_js