Uh oh!
There was an error while loading. Please reload this page.
Update fee rate cache on startup and make sync interval configurable - #102
Merged
Conversation
tnullforce-pushed
the
2023-05-fee-fix
branch
4 times, most recently
from
May 23, 2023 11:22
65bb071 to
af9028cComparetnull
commented
May 23, 2023
CollaboratorAuthor
Rebased on #108. |
tnullforce-pushed
the
2023-05-fee-fix
branch
11 times, most recently
from
May 25, 2023 09:57
984d936 to
6b1f2ffCompareCollaboratorAuthor
tnullforce-pushed
the
2023-05-fee-fix
branch
2 times, most recently
from
May 27, 2023 06:57
db655e8 to
5053096Comparetnull
commented
May 27, 2023
CollaboratorAuthor
tnullforce-pushed
the
2023-05-fee-fix
branch
5 times, most recently
from
May 31, 2023 18:03
c4f3fe4 to
575c9f7Comparetnullforce-pushed
the
2023-05-fee-fix
branch
2 times, most recently
from
June 1, 2023 09:53
0393a8f to
d218da2Comparejkczyz
self-requested a review
June 1, 2023 13:10
tnull
commented
Jun 1, 2023
CollaboratorAuthor
Rebased on main. |
jkczyz
reviewed
Jun 1, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
We improve the docs, in particular mentioning now that users should always prefer background syncing over blocking sync if possible. Moreover, as we already have a current thread runtime setup for the BDK wallet, we now also use it to sync the LDK wallet. This is a good idea as we want to avoid calling `block_on` on our main runtime where possible, which is always in danger of (temporarily or permanently) blocking the world if something goes wrong.
So far we'd immediately start background syncing wallets and the fee cache upon `start()` which would work fine, except when these initial syncs failed, in which case we'd use our fallback fee. This might lead to being disconnected from peers as our fallback values are likely out of current fee ranges. To mitigate this we here simply enforce that an initial fee rate update in `start()` is successful. Additionally, we make the fee rate cache update interval configurable.
tnull
commented
Jun 2, 2023
CollaboratorAuthor
Squashed without further changes. |
jkczyz
approved these changes
Jun 5, 2023
joostjager pushed a commit
to joostjager/ldk-node
that referenced
this pull request
Jan 28, 2026
Add help text for all cli commands and args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #93.Based on #108.So far we'd immediately start background syncing upon
start()which would work fine, except when these initial syncs failed, in which case we'd use our fallback fee. This might lead to being disconnected from peers as our fallback values are likely out of current fee ranges.To mitigate this we here simply enforce that an initial update of our fee rate cache in
start()is successful and hence we'd at least once got a recent fee estimation update.Moreover, we make the background syncing intervals configurable, however enforcing a floor of 10 seconds.