Uh oh!
There was an error while loading. Please reload this page.
Improve logging - #108
Merged
Merged
Conversation
tnullforce-pushed
the
2023-05-improve-logging
branch
from
May 23, 2023 11:31
6b772ae to
5181b30Comparetnullforce-pushed
the
2023-05-improve-logging
branch
2 times, most recently
from
May 23, 2023 14:05
b022172 to
4266b2fComparetnullforce-pushed
the
2023-05-improve-logging
branch
4 times, most recently
from
May 23, 2023 20:02
af8de05 to
f2d157fComparetnull
commented
May 23, 2023
CollaboratorAuthor
Rebased after #93 has been merged. |
tnullforce-pushed
the
2023-05-improve-logging
branch
from
May 25, 2023 09:57
f2d157f to
d80acebComparetnull
commented
May 25, 2023
CollaboratorAuthor
Rebased on main after #101 landed. |
tnullforce-pushed
the
2023-05-improve-logging
branch
from
May 27, 2023 06:47
d80aceb to
3d87eaeComparetnull
commented
May 27, 2023
CollaboratorAuthor
Rebased on main after #88 landed. |
tnullforce-pushed
the
2023-05-improve-logging
branch
from
May 27, 2023 06:54
3d87eae to
f4d3ca8Comparejkczyz
self-requested a review
June 1, 2023 13:10
jkczyz
reviewed
Jun 1, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tnullforce-pushed
the
2023-05-improve-logging
branch
from
June 1, 2023 13:45
f4d3ca8 to
31fd0c8Comparetnullforce-pushed
the
2023-05-improve-logging
branch
from
June 1, 2023 15:51
31fd0c8 to
7ece643Comparetnull
commented
Jun 1, 2023
CollaboratorAuthor
Squashed without further changes. |
jkczyz
reviewed
Jun 1, 2023
Uh oh!
There was an error while loading. Please reload this page.
tnullforce-pushed
the
2023-05-improve-logging
branch
from
June 1, 2023 19:34
7ece643 to
52ccd58Comparejkczyz
approved these changes
Jun 1, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #93, Fixes#109.We improve our logging output by logging more detailed errors and introduce logging to
start/stopmethods.Additionally, we expose the log level via
Config::log_levelandBuilder::set_log_level.