Uh oh!
There was an error while loading. Please reload this page.
Regularly broadcast node announcements - #93
Merged
tnull merged 2 commits intoMay 23, 2023
Conversation
tnullforce-pushed
the
2023-04-broadcast-node-announcments
branch
4 times, most recently
from
May 12, 2023 11:21
5c35993 to
8f5a430CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tnullforce-pushed
the
2023-04-broadcast-node-announcments
branch
3 times, most recently
from
May 18, 2023 07:30
82a9d32 to
613053aCompareCollaboratorAuthor
Rebased after #70 was merged. |
tnullforce-pushed
the
2023-04-broadcast-node-announcments
branch
from
May 18, 2023 07:40
613053a to
52d0839Comparetnullforce-pushed
the
2023-04-broadcast-node-announcments
branch
from
May 19, 2023 12:10
52d0839 to
f2bbf12Comparewpaulino
commented
May 21, 2023
Contributor
Do you mind extracting 7102ff4 into its own PR and rebasing this on top? It'll make reviewing this a bit more straight-forward. |
tnullforce-pushed
the
2023-04-broadcast-node-announcments
branch
from
May 21, 2023 07:08
f2bbf12 to
90ad5d1Comparetnull
commented
May 21, 2023
CollaboratorAuthor
tnullforce-pushed
the
2023-04-broadcast-node-announcments
branch
from
May 23, 2023 11:05
90ad5d1 to
b344c3fCompare Merged
tnullforce-pushed
the
2023-04-broadcast-node-announcments
branch
from
May 23, 2023 11:31
b344c3f to
45bfccfComparetnullforce-pushed
the
2023-04-broadcast-node-announcments
branch
from
May 23, 2023 16:55
054646d to
ecb01dfCompareCollaboratorAuthor
Rebased after #104 landed and squashed the trivial fixup. |
We remember when we last broadcasted a node announcement and only re-announce if sufficient time has passed, we have at least one public channel, and we have some connected peers to gossip to.
tnullforce-pushed
the
2023-04-broadcast-node-announcments
branch
from
May 23, 2023 16:56
ecb01df to
d86aa1aComparewpaulino
approved these changes
May 23, 2023
joostjager pushed a commit
to joostjager/ldk-node
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#48, Based on #104.