Support HTTPS Esplora endpoints in `lightning-transaction-sync` via new feature by tnull · Pull Request #2085 · lightningdevkit/rust-lightning

tnull · 2023-03-08T11:17:08Z

To support HTTPS endpoints, the async HTTP library reqwest needs one of the -tls features enabled. While the users could specify this in their own cargo dependencies, we here provide a new esplora-async-https feature for convenience.

I for now refrained of making this enabled by default (i.e., directly adding it to esplora-async), as all current options for TLS libraries have rustc requirements of >1.56, and we're still exploring how to lower the MSRV of the lightning-transaction-sync crate.

codecov-commenter · 2023-03-08T11:48:18Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01⚠️

Comparison is base (ccac926) 91.14% compared to head (09038ee) 91.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@ Coverage Diff @@## main #2085 +/- ##
==========================================
- Coverage 91.14% 91.13% -0.01% 
==========================================
Files 101 101 Lines 48849 48849 Branches 48849 48849 ==========================================
- Hits 44521 44520 -1 - Misses 4328 4329 +1

Impacted Files	Coverage Δ
lightning-block-sync/src/rpc.rs	`76.92% <0.00%> (-0.70%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

TheBlueMatt

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

TheBlueMatt · 2023-03-08T18:11:59Z

Feel free to squash.

To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

tnull · 2023-03-08T18:25:54Z

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

Agreed. Squashed commits without further changes.

0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes" API Updates =========== * The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107). * Attempting to claim an un-expired payment on a channel which has closed no longer fails. The expiry time of payments is exposed via `PaymentClaimable::claim_deadline` (lightningdevkit#2148). * `payment_metadata` is now supported in `Invoice` deserialization, sending, and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127). * `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142). * BOLT12 messages now support stateless generation and validation (lightningdevkit#1989). * The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161). * Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138). * `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085). * A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098). * `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136). * `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079). * `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094). * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023). * The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206). Backwards Compatibility ======================= * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139). * `Event::PaymentPathFailed::retry` was removed and will always be `None` for payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063). * `Route`s and `PaymentParameters` with blinded path information will not be readable on prior versions of LDK. Such objects are not currently constructed by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146). * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a `ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is in general unsupported, and included here only for completeness. Bug Fixes ========= * Fixed a case where `process_events_async` may `poll` a `Future` which has already completed (lightningdevkit#2081). * Fixed deserialization of `u16` arrays. This bug may have previously corrupted the historical buckets in a `ProbabilisticScorer`. Users relying on the historical buckets may wish to wipe their scorer on upgrade to remove corrupt data rather than waiting on it to decay (lightningdevkit#2191). * The `process_events_async` task is now `Send` and can thus be polled on a multi-threaded runtime (lightningdevkit#2199). * Fixed a missing macro export causing `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091). * Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187) * Fix an issue where the `background-processor` would not wake when a `ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090). * Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145). * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather than `find_route`, as was intended and described in the API (lightningdevkit#2092). * Ensure `process_events_async` always exits if any sleep future returns true, not just if all sleep futures repeatedly return true (lightningdevkit#2145). * `channel_update` messages no longer set the disable bit unless the peer has been disconnected for some time. This should resolve cases where channels are disabled for extended periods of time (lightningdevkit#2198). * We no longer remove CLN nodes from the network graph for violating the BOLT spec in some cases after failing to pay through them (lightningdevkit#2220). * Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172). * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114) * Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158). Security ======== * Transaction re-broadcasting is now substantially more aggressive, including a new regular rebroadcast feature called on a timer from the `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`. This should substantially increase transaction confirmation reliability without relying on downstream `TransactionBroadcaster` implementations for rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208). * Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a privacy vulnerability which allows an intermediate node on the path to discover the final destination for a payment (lightningdevkit#2062). In total, this release features 110 files changed, 11928 insertions, 6368 deletions in 215 commits from 21 authors, in alphabetical order: * Advait * Alan Cohen * Alec Chen * Allan Douglas R. de Oliveira * Arik Sosman * Elias Rohrer * Evan Feenstra * Jeffrey Czyz * John Cantrell * Lucas Soriano del Pino * Marc Tyndel * Matt Corallo * Paul Miller * Steven * Steven Williamson * Steven Zhao * Tony Giorgio * Valentine Wallace * Wilmer Paulino * benthecarman * munjesi

tnull · 2023-03-08T11:17:08Z

To support HTTPS endpoints, the async HTTP library reqwest needs one of the -tls features enabled. While the users could specify this in their own cargo dependencies, we here provide a new esplora-async-https feature for convenience.

I for now refrained of making this enabled by default (i.e., directly adding it to esplora-async), as all current options for TLS libraries have rustc requirements of >1.56, and we're still exploring how to lower the MSRV of the lightning-transaction-sync crate.

codecov-commenter · 2023-03-08T11:48:18Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01⚠️

Comparison is base (ccac926) 91.14% compared to head (09038ee) 91.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@ Coverage Diff @@## main #2085 +/- ##
==========================================
- Coverage 91.14% 91.13% -0.01% 
==========================================
Files 101 101 Lines 48849 48849 Branches 48849 48849 ==========================================
- Hits 44521 44520 -1 - Misses 4328 4329 +1

Impacted Files	Coverage Δ
lightning-block-sync/src/rpc.rs	`76.92% <0.00%> (-0.70%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

TheBlueMatt

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

TheBlueMatt · 2023-03-08T18:11:59Z

Feel free to squash.

To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

tnull · 2023-03-08T18:25:54Z

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

Agreed. Squashed commits without further changes.

0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes" API Updates =========== * The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107). * Attempting to claim an un-expired payment on a channel which has closed no longer fails. The expiry time of payments is exposed via `PaymentClaimable::claim_deadline` (lightningdevkit#2148). * `payment_metadata` is now supported in `Invoice` deserialization, sending, and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127). * `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142). * BOLT12 messages now support stateless generation and validation (lightningdevkit#1989). * The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161). * Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138). * `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085). * A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098). * `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136). * `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079). * `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094). * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023). * The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206). Backwards Compatibility ======================= * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139). * `Event::PaymentPathFailed::retry` was removed and will always be `None` for payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063). * `Route`s and `PaymentParameters` with blinded path information will not be readable on prior versions of LDK. Such objects are not currently constructed by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146). * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a `ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is in general unsupported, and included here only for completeness. Bug Fixes ========= * Fixed a case where `process_events_async` may `poll` a `Future` which has already completed (lightningdevkit#2081). * Fixed deserialization of `u16` arrays. This bug may have previously corrupted the historical buckets in a `ProbabilisticScorer`. Users relying on the historical buckets may wish to wipe their scorer on upgrade to remove corrupt data rather than waiting on it to decay (lightningdevkit#2191). * The `process_events_async` task is now `Send` and can thus be polled on a multi-threaded runtime (lightningdevkit#2199). * Fixed a missing macro export causing `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091). * Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187) * Fix an issue where the `background-processor` would not wake when a `ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090). * Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145). * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather than `find_route`, as was intended and described in the API (lightningdevkit#2092). * Ensure `process_events_async` always exits if any sleep future returns true, not just if all sleep futures repeatedly return true (lightningdevkit#2145). * `channel_update` messages no longer set the disable bit unless the peer has been disconnected for some time. This should resolve cases where channels are disabled for extended periods of time (lightningdevkit#2198). * We no longer remove CLN nodes from the network graph for violating the BOLT spec in some cases after failing to pay through them (lightningdevkit#2220). * Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172). * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114) * Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158). Security ======== * Transaction re-broadcasting is now substantially more aggressive, including a new regular rebroadcast feature called on a timer from the `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`. This should substantially increase transaction confirmation reliability without relying on downstream `TransactionBroadcaster` implementations for rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208). * Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a privacy vulnerability which allows an intermediate node on the path to discover the final destination for a payment (lightningdevkit#2062). In total, this release features 110 files changed, 11928 insertions, 6368 deletions in 215 commits from 21 authors, in alphabetical order: * Advait * Alan Cohen * Alec Chen * Allan Douglas R. de Oliveira * Arik Sosman * Elias Rohrer * Evan Feenstra * Jeffrey Czyz * John Cantrell * Lucas Soriano del Pino * Marc Tyndel * Matt Corallo * Paul Miller * Steven * Steven Williamson * Steven Zhao * Tony Giorgio * Valentine Wallace * Wilmer Paulino * benthecarman * munjesi

tnull · 2023-03-08T11:17:08Z

To support HTTPS endpoints, the async HTTP library reqwest needs one of the -tls features enabled. While the users could specify this in their own cargo dependencies, we here provide a new esplora-async-https feature for convenience.

I for now refrained of making this enabled by default (i.e., directly adding it to esplora-async), as all current options for TLS libraries have rustc requirements of >1.56, and we're still exploring how to lower the MSRV of the lightning-transaction-sync crate.

codecov-commenter · 2023-03-08T11:48:18Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01⚠️

Comparison is base (ccac926) 91.14% compared to head (09038ee) 91.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@ Coverage Diff @@## main #2085 +/- ##
==========================================
- Coverage 91.14% 91.13% -0.01% 
==========================================
Files 101 101 Lines 48849 48849 Branches 48849 48849 ==========================================
- Hits 44521 44520 -1 - Misses 4328 4329 +1

Impacted Files	Coverage Δ
lightning-block-sync/src/rpc.rs	`76.92% <0.00%> (-0.70%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

TheBlueMatt

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

TheBlueMatt · 2023-03-08T18:11:59Z

Feel free to squash.

To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

tnull · 2023-03-08T18:25:54Z

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

Agreed. Squashed commits without further changes.

0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes" API Updates =========== * The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107). * Attempting to claim an un-expired payment on a channel which has closed no longer fails. The expiry time of payments is exposed via `PaymentClaimable::claim_deadline` (lightningdevkit#2148). * `payment_metadata` is now supported in `Invoice` deserialization, sending, and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127). * `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142). * BOLT12 messages now support stateless generation and validation (lightningdevkit#1989). * The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161). * Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138). * `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085). * A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098). * `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136). * `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079). * `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094). * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023). * The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206). Backwards Compatibility ======================= * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139). * `Event::PaymentPathFailed::retry` was removed and will always be `None` for payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063). * `Route`s and `PaymentParameters` with blinded path information will not be readable on prior versions of LDK. Such objects are not currently constructed by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146). * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a `ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is in general unsupported, and included here only for completeness. Bug Fixes ========= * Fixed a case where `process_events_async` may `poll` a `Future` which has already completed (lightningdevkit#2081). * Fixed deserialization of `u16` arrays. This bug may have previously corrupted the historical buckets in a `ProbabilisticScorer`. Users relying on the historical buckets may wish to wipe their scorer on upgrade to remove corrupt data rather than waiting on it to decay (lightningdevkit#2191). * The `process_events_async` task is now `Send` and can thus be polled on a multi-threaded runtime (lightningdevkit#2199). * Fixed a missing macro export causing `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091). * Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187) * Fix an issue where the `background-processor` would not wake when a `ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090). * Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145). * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather than `find_route`, as was intended and described in the API (lightningdevkit#2092). * Ensure `process_events_async` always exits if any sleep future returns true, not just if all sleep futures repeatedly return true (lightningdevkit#2145). * `channel_update` messages no longer set the disable bit unless the peer has been disconnected for some time. This should resolve cases where channels are disabled for extended periods of time (lightningdevkit#2198). * We no longer remove CLN nodes from the network graph for violating the BOLT spec in some cases after failing to pay through them (lightningdevkit#2220). * Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172). * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114) * Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158). Security ======== * Transaction re-broadcasting is now substantially more aggressive, including a new regular rebroadcast feature called on a timer from the `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`. This should substantially increase transaction confirmation reliability without relying on downstream `TransactionBroadcaster` implementations for rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208). * Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a privacy vulnerability which allows an intermediate node on the path to discover the final destination for a payment (lightningdevkit#2062). In total, this release features 110 files changed, 11928 insertions, 6368 deletions in 215 commits from 21 authors, in alphabetical order: * Advait * Alan Cohen * Alec Chen * Allan Douglas R. de Oliveira * Arik Sosman * Elias Rohrer * Evan Feenstra * Jeffrey Czyz * John Cantrell * Lucas Soriano del Pino * Marc Tyndel * Matt Corallo * Paul Miller * Steven * Steven Williamson * Steven Zhao * Tony Giorgio * Valentine Wallace * Wilmer Paulino * benthecarman * munjesi

tnull · 2023-03-08T11:17:08Z

To support HTTPS endpoints, the async HTTP library reqwest needs one of the -tls features enabled. While the users could specify this in their own cargo dependencies, we here provide a new esplora-async-https feature for convenience.

I for now refrained of making this enabled by default (i.e., directly adding it to esplora-async), as all current options for TLS libraries have rustc requirements of >1.56, and we're still exploring how to lower the MSRV of the lightning-transaction-sync crate.

codecov-commenter · 2023-03-08T11:48:18Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01⚠️

Comparison is base (ccac926) 91.14% compared to head (09038ee) 91.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@ Coverage Diff @@## main #2085 +/- ##
==========================================
- Coverage 91.14% 91.13% -0.01% 
==========================================
Files 101 101 Lines 48849 48849 Branches 48849 48849 ==========================================
- Hits 44521 44520 -1 - Misses 4328 4329 +1

Impacted Files	Coverage Δ
lightning-block-sync/src/rpc.rs	`76.92% <0.00%> (-0.70%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

TheBlueMatt

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

TheBlueMatt · 2023-03-08T18:11:59Z

Feel free to squash.

To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

tnull · 2023-03-08T18:25:54Z

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

Agreed. Squashed commits without further changes.

0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes" API Updates =========== * The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107). * Attempting to claim an un-expired payment on a channel which has closed no longer fails. The expiry time of payments is exposed via `PaymentClaimable::claim_deadline` (lightningdevkit#2148). * `payment_metadata` is now supported in `Invoice` deserialization, sending, and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127). * `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142). * BOLT12 messages now support stateless generation and validation (lightningdevkit#1989). * The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161). * Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138). * `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085). * A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098). * `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136). * `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079). * `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094). * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023). * The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206). Backwards Compatibility ======================= * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139). * `Event::PaymentPathFailed::retry` was removed and will always be `None` for payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063). * `Route`s and `PaymentParameters` with blinded path information will not be readable on prior versions of LDK. Such objects are not currently constructed by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146). * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a `ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is in general unsupported, and included here only for completeness. Bug Fixes ========= * Fixed a case where `process_events_async` may `poll` a `Future` which has already completed (lightningdevkit#2081). * Fixed deserialization of `u16` arrays. This bug may have previously corrupted the historical buckets in a `ProbabilisticScorer`. Users relying on the historical buckets may wish to wipe their scorer on upgrade to remove corrupt data rather than waiting on it to decay (lightningdevkit#2191). * The `process_events_async` task is now `Send` and can thus be polled on a multi-threaded runtime (lightningdevkit#2199). * Fixed a missing macro export causing `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091). * Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187) * Fix an issue where the `background-processor` would not wake when a `ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090). * Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145). * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather than `find_route`, as was intended and described in the API (lightningdevkit#2092). * Ensure `process_events_async` always exits if any sleep future returns true, not just if all sleep futures repeatedly return true (lightningdevkit#2145). * `channel_update` messages no longer set the disable bit unless the peer has been disconnected for some time. This should resolve cases where channels are disabled for extended periods of time (lightningdevkit#2198). * We no longer remove CLN nodes from the network graph for violating the BOLT spec in some cases after failing to pay through them (lightningdevkit#2220). * Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172). * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114) * Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158). Security ======== * Transaction re-broadcasting is now substantially more aggressive, including a new regular rebroadcast feature called on a timer from the `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`. This should substantially increase transaction confirmation reliability without relying on downstream `TransactionBroadcaster` implementations for rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208). * Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a privacy vulnerability which allows an intermediate node on the path to discover the final destination for a payment (lightningdevkit#2062). In total, this release features 110 files changed, 11928 insertions, 6368 deletions in 215 commits from 21 authors, in alphabetical order: * Advait * Alan Cohen * Alec Chen * Allan Douglas R. de Oliveira * Arik Sosman * Elias Rohrer * Evan Feenstra * Jeffrey Czyz * John Cantrell * Lucas Soriano del Pino * Marc Tyndel * Matt Corallo * Paul Miller * Steven * Steven Williamson * Steven Zhao * Tony Giorgio * Valentine Wallace * Wilmer Paulino * benthecarman * munjesi

tnull · 2023-03-08T11:17:08Z

To support HTTPS endpoints, the async HTTP library reqwest needs one of the -tls features enabled. While the users could specify this in their own cargo dependencies, we here provide a new esplora-async-https feature for convenience.

I for now refrained of making this enabled by default (i.e., directly adding it to esplora-async), as all current options for TLS libraries have rustc requirements of >1.56, and we're still exploring how to lower the MSRV of the lightning-transaction-sync crate.

codecov-commenter · 2023-03-08T11:48:18Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01⚠️

Comparison is base (ccac926) 91.14% compared to head (09038ee) 91.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@ Coverage Diff @@## main #2085 +/- ##
==========================================
- Coverage 91.14% 91.13% -0.01% 
==========================================
Files 101 101 Lines 48849 48849 Branches 48849 48849 ==========================================
- Hits 44521 44520 -1 - Misses 4328 4329 +1

Impacted Files	Coverage Δ
lightning-block-sync/src/rpc.rs	`76.92% <0.00%> (-0.70%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

TheBlueMatt

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

TheBlueMatt · 2023-03-08T18:11:59Z

Feel free to squash.

To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

tnull · 2023-03-08T18:25:54Z

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

Agreed. Squashed commits without further changes.

0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes" API Updates =========== * The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107). * Attempting to claim an un-expired payment on a channel which has closed no longer fails. The expiry time of payments is exposed via `PaymentClaimable::claim_deadline` (lightningdevkit#2148). * `payment_metadata` is now supported in `Invoice` deserialization, sending, and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127). * `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142). * BOLT12 messages now support stateless generation and validation (lightningdevkit#1989). * The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161). * Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138). * `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085). * A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098). * `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136). * `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079). * `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094). * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023). * The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206). Backwards Compatibility ======================= * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139). * `Event::PaymentPathFailed::retry` was removed and will always be `None` for payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063). * `Route`s and `PaymentParameters` with blinded path information will not be readable on prior versions of LDK. Such objects are not currently constructed by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146). * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a `ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is in general unsupported, and included here only for completeness. Bug Fixes ========= * Fixed a case where `process_events_async` may `poll` a `Future` which has already completed (lightningdevkit#2081). * Fixed deserialization of `u16` arrays. This bug may have previously corrupted the historical buckets in a `ProbabilisticScorer`. Users relying on the historical buckets may wish to wipe their scorer on upgrade to remove corrupt data rather than waiting on it to decay (lightningdevkit#2191). * The `process_events_async` task is now `Send` and can thus be polled on a multi-threaded runtime (lightningdevkit#2199). * Fixed a missing macro export causing `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091). * Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187) * Fix an issue where the `background-processor` would not wake when a `ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090). * Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145). * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather than `find_route`, as was intended and described in the API (lightningdevkit#2092). * Ensure `process_events_async` always exits if any sleep future returns true, not just if all sleep futures repeatedly return true (lightningdevkit#2145). * `channel_update` messages no longer set the disable bit unless the peer has been disconnected for some time. This should resolve cases where channels are disabled for extended periods of time (lightningdevkit#2198). * We no longer remove CLN nodes from the network graph for violating the BOLT spec in some cases after failing to pay through them (lightningdevkit#2220). * Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172). * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114) * Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158). Security ======== * Transaction re-broadcasting is now substantially more aggressive, including a new regular rebroadcast feature called on a timer from the `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`. This should substantially increase transaction confirmation reliability without relying on downstream `TransactionBroadcaster` implementations for rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208). * Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a privacy vulnerability which allows an intermediate node on the path to discover the final destination for a payment (lightningdevkit#2062). In total, this release features 110 files changed, 11928 insertions, 6368 deletions in 215 commits from 21 authors, in alphabetical order: * Advait * Alan Cohen * Alec Chen * Allan Douglas R. de Oliveira * Arik Sosman * Elias Rohrer * Evan Feenstra * Jeffrey Czyz * John Cantrell * Lucas Soriano del Pino * Marc Tyndel * Matt Corallo * Paul Miller * Steven * Steven Williamson * Steven Zhao * Tony Giorgio * Valentine Wallace * Wilmer Paulino * benthecarman * munjesi

tnull · 2023-03-08T11:17:08Z

To support HTTPS endpoints, the async HTTP library reqwest needs one of the -tls features enabled. While the users could specify this in their own cargo dependencies, we here provide a new esplora-async-https feature for convenience.

I for now refrained of making this enabled by default (i.e., directly adding it to esplora-async), as all current options for TLS libraries have rustc requirements of >1.56, and we're still exploring how to lower the MSRV of the lightning-transaction-sync crate.

codecov-commenter · 2023-03-08T11:48:18Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01⚠️

Comparison is base (ccac926) 91.14% compared to head (09038ee) 91.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@ Coverage Diff @@## main #2085 +/- ##
==========================================
- Coverage 91.14% 91.13% -0.01% 
==========================================
Files 101 101 Lines 48849 48849 Branches 48849 48849 ==========================================
- Hits 44521 44520 -1 - Misses 4328 4329 +1

Impacted Files	Coverage Δ
lightning-block-sync/src/rpc.rs	`76.92% <0.00%> (-0.70%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

TheBlueMatt

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

TheBlueMatt · 2023-03-08T18:11:59Z

Feel free to squash.

To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

tnull · 2023-03-08T18:25:54Z

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

Agreed. Squashed commits without further changes.

0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes" API Updates =========== * The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107). * Attempting to claim an un-expired payment on a channel which has closed no longer fails. The expiry time of payments is exposed via `PaymentClaimable::claim_deadline` (lightningdevkit#2148). * `payment_metadata` is now supported in `Invoice` deserialization, sending, and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127). * `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142). * BOLT12 messages now support stateless generation and validation (lightningdevkit#1989). * The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161). * Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138). * `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085). * A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098). * `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136). * `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079). * `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094). * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023). * The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206). Backwards Compatibility ======================= * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139). * `Event::PaymentPathFailed::retry` was removed and will always be `None` for payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063). * `Route`s and `PaymentParameters` with blinded path information will not be readable on prior versions of LDK. Such objects are not currently constructed by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146). * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a `ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is in general unsupported, and included here only for completeness. Bug Fixes ========= * Fixed a case where `process_events_async` may `poll` a `Future` which has already completed (lightningdevkit#2081). * Fixed deserialization of `u16` arrays. This bug may have previously corrupted the historical buckets in a `ProbabilisticScorer`. Users relying on the historical buckets may wish to wipe their scorer on upgrade to remove corrupt data rather than waiting on it to decay (lightningdevkit#2191). * The `process_events_async` task is now `Send` and can thus be polled on a multi-threaded runtime (lightningdevkit#2199). * Fixed a missing macro export causing `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091). * Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187) * Fix an issue where the `background-processor` would not wake when a `ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090). * Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145). * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather than `find_route`, as was intended and described in the API (lightningdevkit#2092). * Ensure `process_events_async` always exits if any sleep future returns true, not just if all sleep futures repeatedly return true (lightningdevkit#2145). * `channel_update` messages no longer set the disable bit unless the peer has been disconnected for some time. This should resolve cases where channels are disabled for extended periods of time (lightningdevkit#2198). * We no longer remove CLN nodes from the network graph for violating the BOLT spec in some cases after failing to pay through them (lightningdevkit#2220). * Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172). * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114) * Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158). Security ======== * Transaction re-broadcasting is now substantially more aggressive, including a new regular rebroadcast feature called on a timer from the `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`. This should substantially increase transaction confirmation reliability without relying on downstream `TransactionBroadcaster` implementations for rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208). * Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a privacy vulnerability which allows an intermediate node on the path to discover the final destination for a payment (lightningdevkit#2062). In total, this release features 110 files changed, 11928 insertions, 6368 deletions in 215 commits from 21 authors, in alphabetical order: * Advait * Alan Cohen * Alec Chen * Allan Douglas R. de Oliveira * Arik Sosman * Elias Rohrer * Evan Feenstra * Jeffrey Czyz * John Cantrell * Lucas Soriano del Pino * Marc Tyndel * Matt Corallo * Paul Miller * Steven * Steven Williamson * Steven Zhao * Tony Giorgio * Valentine Wallace * Wilmer Paulino * benthecarman * munjesi

tnull · 2023-03-08T11:17:08Z

To support HTTPS endpoints, the async HTTP library reqwest needs one of the -tls features enabled. While the users could specify this in their own cargo dependencies, we here provide a new esplora-async-https feature for convenience.

I for now refrained of making this enabled by default (i.e., directly adding it to esplora-async), as all current options for TLS libraries have rustc requirements of >1.56, and we're still exploring how to lower the MSRV of the lightning-transaction-sync crate.

codecov-commenter · 2023-03-08T11:48:18Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01⚠️

Comparison is base (ccac926) 91.14% compared to head (09038ee) 91.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@ Coverage Diff @@## main #2085 +/- ##
==========================================
- Coverage 91.14% 91.13% -0.01% 
==========================================
Files 101 101 Lines 48849 48849 Branches 48849 48849 ==========================================
- Hits 44521 44520 -1 - Misses 4328 4329 +1

Impacted Files	Coverage Δ
lightning-block-sync/src/rpc.rs	`76.92% <0.00%> (-0.70%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

TheBlueMatt

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

TheBlueMatt · 2023-03-08T18:11:59Z

Feel free to squash.

To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

tnull · 2023-03-08T18:25:54Z

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

Agreed. Squashed commits without further changes.

0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes" API Updates =========== * The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107). * Attempting to claim an un-expired payment on a channel which has closed no longer fails. The expiry time of payments is exposed via `PaymentClaimable::claim_deadline` (lightningdevkit#2148). * `payment_metadata` is now supported in `Invoice` deserialization, sending, and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127). * `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142). * BOLT12 messages now support stateless generation and validation (lightningdevkit#1989). * The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161). * Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138). * `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085). * A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098). * `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136). * `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079). * `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094). * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023). * The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206). Backwards Compatibility ======================= * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139). * `Event::PaymentPathFailed::retry` was removed and will always be `None` for payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063). * `Route`s and `PaymentParameters` with blinded path information will not be readable on prior versions of LDK. Such objects are not currently constructed by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146). * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a `ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is in general unsupported, and included here only for completeness. Bug Fixes ========= * Fixed a case where `process_events_async` may `poll` a `Future` which has already completed (lightningdevkit#2081). * Fixed deserialization of `u16` arrays. This bug may have previously corrupted the historical buckets in a `ProbabilisticScorer`. Users relying on the historical buckets may wish to wipe their scorer on upgrade to remove corrupt data rather than waiting on it to decay (lightningdevkit#2191). * The `process_events_async` task is now `Send` and can thus be polled on a multi-threaded runtime (lightningdevkit#2199). * Fixed a missing macro export causing `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091). * Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187) * Fix an issue where the `background-processor` would not wake when a `ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090). * Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145). * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather than `find_route`, as was intended and described in the API (lightningdevkit#2092). * Ensure `process_events_async` always exits if any sleep future returns true, not just if all sleep futures repeatedly return true (lightningdevkit#2145). * `channel_update` messages no longer set the disable bit unless the peer has been disconnected for some time. This should resolve cases where channels are disabled for extended periods of time (lightningdevkit#2198). * We no longer remove CLN nodes from the network graph for violating the BOLT spec in some cases after failing to pay through them (lightningdevkit#2220). * Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172). * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114) * Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158). Security ======== * Transaction re-broadcasting is now substantially more aggressive, including a new regular rebroadcast feature called on a timer from the `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`. This should substantially increase transaction confirmation reliability without relying on downstream `TransactionBroadcaster` implementations for rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208). * Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a privacy vulnerability which allows an intermediate node on the path to discover the final destination for a payment (lightningdevkit#2062). In total, this release features 110 files changed, 11928 insertions, 6368 deletions in 215 commits from 21 authors, in alphabetical order: * Advait * Alan Cohen * Alec Chen * Allan Douglas R. de Oliveira * Arik Sosman * Elias Rohrer * Evan Feenstra * Jeffrey Czyz * John Cantrell * Lucas Soriano del Pino * Marc Tyndel * Matt Corallo * Paul Miller * Steven * Steven Williamson * Steven Zhao * Tony Giorgio * Valentine Wallace * Wilmer Paulino * benthecarman * munjesi

tnull · 2023-03-08T11:17:08Z

To support HTTPS endpoints, the async HTTP library reqwest needs one of the -tls features enabled. While the users could specify this in their own cargo dependencies, we here provide a new esplora-async-https feature for convenience.

I for now refrained of making this enabled by default (i.e., directly adding it to esplora-async), as all current options for TLS libraries have rustc requirements of >1.56, and we're still exploring how to lower the MSRV of the lightning-transaction-sync crate.

codecov-commenter · 2023-03-08T11:48:18Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01⚠️

Comparison is base (ccac926) 91.14% compared to head (09038ee) 91.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@ Coverage Diff @@## main #2085 +/- ##
==========================================
- Coverage 91.14% 91.13% -0.01% 
==========================================
Files 101 101 Lines 48849 48849 Branches 48849 48849 ==========================================
- Hits 44521 44520 -1 - Misses 4328 4329 +1

Impacted Files	Coverage Δ
lightning-block-sync/src/rpc.rs	`76.92% <0.00%> (-0.70%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

TheBlueMatt

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

TheBlueMatt · 2023-03-08T18:11:59Z

Feel free to squash.

To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

tnull · 2023-03-08T18:25:54Z

Ugh, looking forward to when we can drop these giant HTTP dependency trees.

Agreed. Squashed commits without further changes.

0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes" API Updates =========== * The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107). * Attempting to claim an un-expired payment on a channel which has closed no longer fails. The expiry time of payments is exposed via `PaymentClaimable::claim_deadline` (lightningdevkit#2148). * `payment_metadata` is now supported in `Invoice` deserialization, sending, and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127). * `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142). * BOLT12 messages now support stateless generation and validation (lightningdevkit#1989). * The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161). * Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138). * `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085). * A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098). * `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136). * `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079). * `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094). * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023). * The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206). Backwards Compatibility ======================= * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139). * `Event::PaymentPathFailed::retry` was removed and will always be `None` for payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063). * `Route`s and `PaymentParameters` with blinded path information will not be readable on prior versions of LDK. Such objects are not currently constructed by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146). * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a `ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is in general unsupported, and included here only for completeness. Bug Fixes ========= * Fixed a case where `process_events_async` may `poll` a `Future` which has already completed (lightningdevkit#2081). * Fixed deserialization of `u16` arrays. This bug may have previously corrupted the historical buckets in a `ProbabilisticScorer`. Users relying on the historical buckets may wish to wipe their scorer on upgrade to remove corrupt data rather than waiting on it to decay (lightningdevkit#2191). * The `process_events_async` task is now `Send` and can thus be polled on a multi-threaded runtime (lightningdevkit#2199). * Fixed a missing macro export causing `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091). * Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187) * Fix an issue where the `background-processor` would not wake when a `ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090). * Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145). * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather than `find_route`, as was intended and described in the API (lightningdevkit#2092). * Ensure `process_events_async` always exits if any sleep future returns true, not just if all sleep futures repeatedly return true (lightningdevkit#2145). * `channel_update` messages no longer set the disable bit unless the peer has been disconnected for some time. This should resolve cases where channels are disabled for extended periods of time (lightningdevkit#2198). * We no longer remove CLN nodes from the network graph for violating the BOLT spec in some cases after failing to pay through them (lightningdevkit#2220). * Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172). * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114) * Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158). Security ======== * Transaction re-broadcasting is now substantially more aggressive, including a new regular rebroadcast feature called on a timer from the `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`. This should substantially increase transaction confirmation reliability without relying on downstream `TransactionBroadcaster` implementations for rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208). * Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a privacy vulnerability which allows an intermediate node on the path to discover the final destination for a payment (lightningdevkit#2062). In total, this release features 110 files changed, 11928 insertions, 6368 deletions in 215 commits from 21 authors, in alphabetical order: * Advait * Alan Cohen * Alec Chen * Allan Douglas R. de Oliveira * Arik Sosman * Elias Rohrer * Evan Feenstra * Jeffrey Czyz * John Cantrell * Lucas Soriano del Pino * Marc Tyndel * Matt Corallo * Paul Miller * Steven * Steven Williamson * Steven Zhao * Tony Giorgio * Valentine Wallace * Wilmer Paulino * benthecarman * munjesi

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 11fdd70 to 6fb7ccaCompare March 8, 2023 15:35

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/Cargo.toml

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 6fb7cca to 2820d4aCompare March 8, 2023 16:24

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/tests/integration_tests.rs Outdated

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 2820d4a to d327700Compare March 8, 2023 16:41

jkczyz previously approved these changes Mar 8, 2023
View reviewed changes

jkczyz added the Seeking Code Review label Mar 8, 2023

TheBlueMatt previously approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt removed the Seeking Code Review label Mar 8, 2023

tnull added 2 commits March 8, 2023 19:25

Support HTTPS Esplora endpoints via new feature
7a30f3e
To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

Remove unnecessary logging imports
09038ee

tnull dismissed stale reviews from TheBlueMatt and jkczyz via 09038eeMarch 8, 2023 18:25

tnull force-pushed the 2023-03-introduce-async-https-feature branch from d327700 to 09038eeCompare March 8, 2023 18:25

jkczyz approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt merged commit 6aa1cf9 into lightningdevkit:mainMar 8, 2023

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 11fdd70 to 6fb7ccaCompare March 8, 2023 15:35

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/Cargo.toml

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 6fb7cca to 2820d4aCompare March 8, 2023 16:24

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/tests/integration_tests.rs Outdated

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 2820d4a to d327700Compare March 8, 2023 16:41

jkczyz previously approved these changes Mar 8, 2023
View reviewed changes

jkczyz added the Seeking Code Review label Mar 8, 2023

TheBlueMatt previously approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt removed the Seeking Code Review label Mar 8, 2023

tnull added 2 commits March 8, 2023 19:25

Support HTTPS Esplora endpoints via new feature
7a30f3e
To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

Remove unnecessary logging imports
09038ee

tnull dismissed stale reviews from TheBlueMatt and jkczyz via 09038eeMarch 8, 2023 18:25

tnull force-pushed the 2023-03-introduce-async-https-feature branch from d327700 to 09038eeCompare March 8, 2023 18:25

jkczyz approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt merged commit 6aa1cf9 into lightningdevkit:mainMar 8, 2023

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 11fdd70 to 6fb7ccaCompare March 8, 2023 15:35

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/Cargo.toml

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 6fb7cca to 2820d4aCompare March 8, 2023 16:24

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/tests/integration_tests.rs Outdated

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 2820d4a to d327700Compare March 8, 2023 16:41

jkczyz previously approved these changes Mar 8, 2023
View reviewed changes

jkczyz added the Seeking Code Review label Mar 8, 2023

TheBlueMatt previously approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt removed the Seeking Code Review label Mar 8, 2023

tnull added 2 commits March 8, 2023 19:25

Support HTTPS Esplora endpoints via new feature
7a30f3e
To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

Remove unnecessary logging imports
09038ee

tnull dismissed stale reviews from TheBlueMatt and jkczyz via 09038eeMarch 8, 2023 18:25

tnull force-pushed the 2023-03-introduce-async-https-feature branch from d327700 to 09038eeCompare March 8, 2023 18:25

jkczyz approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt merged commit 6aa1cf9 into lightningdevkit:mainMar 8, 2023

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 11fdd70 to 6fb7ccaCompare March 8, 2023 15:35

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/Cargo.toml

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 6fb7cca to 2820d4aCompare March 8, 2023 16:24

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/tests/integration_tests.rs Outdated

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 2820d4a to d327700Compare March 8, 2023 16:41

jkczyz previously approved these changes Mar 8, 2023
View reviewed changes

jkczyz added the Seeking Code Review label Mar 8, 2023

TheBlueMatt previously approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt removed the Seeking Code Review label Mar 8, 2023

tnull added 2 commits March 8, 2023 19:25

Support HTTPS Esplora endpoints via new feature
7a30f3e
To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

Remove unnecessary logging imports
09038ee

tnull dismissed stale reviews from TheBlueMatt and jkczyz via 09038eeMarch 8, 2023 18:25

tnull force-pushed the 2023-03-introduce-async-https-feature branch from d327700 to 09038eeCompare March 8, 2023 18:25

jkczyz approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt merged commit 6aa1cf9 into lightningdevkit:mainMar 8, 2023

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 11fdd70 to 6fb7ccaCompare March 8, 2023 15:35

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/Cargo.toml

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 6fb7cca to 2820d4aCompare March 8, 2023 16:24

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/tests/integration_tests.rs Outdated

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 2820d4a to d327700Compare March 8, 2023 16:41

jkczyz previously approved these changes Mar 8, 2023
View reviewed changes

jkczyz added the Seeking Code Review label Mar 8, 2023

TheBlueMatt previously approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt removed the Seeking Code Review label Mar 8, 2023

tnull added 2 commits March 8, 2023 19:25

Support HTTPS Esplora endpoints via new feature
7a30f3e
To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

Remove unnecessary logging imports
09038ee

tnull dismissed stale reviews from TheBlueMatt and jkczyz via 09038eeMarch 8, 2023 18:25

tnull force-pushed the 2023-03-introduce-async-https-feature branch from d327700 to 09038eeCompare March 8, 2023 18:25

jkczyz approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt merged commit 6aa1cf9 into lightningdevkit:mainMar 8, 2023

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 11fdd70 to 6fb7ccaCompare March 8, 2023 15:35

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/Cargo.toml

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 6fb7cca to 2820d4aCompare March 8, 2023 16:24

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/tests/integration_tests.rs Outdated

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 2820d4a to d327700Compare March 8, 2023 16:41

jkczyz previously approved these changes Mar 8, 2023
View reviewed changes

jkczyz added the Seeking Code Review label Mar 8, 2023

TheBlueMatt previously approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt removed the Seeking Code Review label Mar 8, 2023

tnull added 2 commits March 8, 2023 19:25

Support HTTPS Esplora endpoints via new feature
7a30f3e
To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

Remove unnecessary logging imports
09038ee

tnull dismissed stale reviews from TheBlueMatt and jkczyz via 09038eeMarch 8, 2023 18:25

tnull force-pushed the 2023-03-introduce-async-https-feature branch from d327700 to 09038eeCompare March 8, 2023 18:25

jkczyz approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt merged commit 6aa1cf9 into lightningdevkit:mainMar 8, 2023

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 11fdd70 to 6fb7ccaCompare March 8, 2023 15:35

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/Cargo.toml

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 6fb7cca to 2820d4aCompare March 8, 2023 16:24

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/tests/integration_tests.rs Outdated

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 2820d4a to d327700Compare March 8, 2023 16:41

jkczyz previously approved these changes Mar 8, 2023
View reviewed changes

jkczyz added the Seeking Code Review label Mar 8, 2023

TheBlueMatt previously approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt removed the Seeking Code Review label Mar 8, 2023

tnull added 2 commits March 8, 2023 19:25

Support HTTPS Esplora endpoints via new feature
7a30f3e
To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

Remove unnecessary logging imports
09038ee

tnull dismissed stale reviews from TheBlueMatt and jkczyz via 09038eeMarch 8, 2023 18:25

tnull force-pushed the 2023-03-introduce-async-https-feature branch from d327700 to 09038eeCompare March 8, 2023 18:25

jkczyz approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt merged commit 6aa1cf9 into lightningdevkit:mainMar 8, 2023

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 11fdd70 to 6fb7ccaCompare March 8, 2023 15:35

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/Cargo.toml

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 6fb7cca to 2820d4aCompare March 8, 2023 16:24

jkczyz reviewed Mar 8, 2023
View reviewed changes

Comment threadlightning-transaction-sync/tests/integration_tests.rs Outdated

tnull force-pushed the 2023-03-introduce-async-https-feature branch from 2820d4a to d327700Compare March 8, 2023 16:41

jkczyz previously approved these changes Mar 8, 2023
View reviewed changes

jkczyz added the Seeking Code Review label Mar 8, 2023

TheBlueMatt previously approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt removed the Seeking Code Review label Mar 8, 2023

tnull added 2 commits March 8, 2023 19:25

Support HTTPS Esplora endpoints via new feature
7a30f3e
To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.

Remove unnecessary logging imports
09038ee

tnull dismissed stale reviews from TheBlueMatt and jkczyz via 09038eeMarch 8, 2023 18:25

tnull force-pushed the 2023-03-introduce-async-https-feature branch from d327700 to 09038eeCompare March 8, 2023 18:25

jkczyz approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt approved these changes Mar 8, 2023
View reviewed changes

TheBlueMatt merged commit 6aa1cf9 into lightningdevkit:mainMar 8, 2023

Uh oh!

Conversation

tnull commented Mar 8, 2023

Uh oh!

codecov-commenter commented Mar 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt commented Mar 8, 2023

Uh oh!

tnull commented Mar 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tnull commented Mar 8, 2023

Uh oh!

codecov-commenter commented Mar 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt commented Mar 8, 2023

Uh oh!

tnull commented Mar 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tnull commented Mar 8, 2023

Uh oh!

codecov-commenter commented Mar 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt commented Mar 8, 2023

Uh oh!

tnull commented Mar 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tnull commented Mar 8, 2023

Uh oh!

codecov-commenter commented Mar 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

codecov-commenter commented Mar 8, 2023•
edited
Loading

codecov-commenter commented Mar 8, 2023•
edited
Loading

codecov-commenter commented Mar 8, 2023•
edited
Loading

codecov-commenter commented Mar 8, 2023•
edited
Loading

codecov-commenter commented Mar 8, 2023•
edited
Loading