use PrintableString to Display CounterpartyForceClosed peer_msg - #2114

Merged
jkczyz merged 1 commit into
lightningdevkit:mainfrom
Evanfeenstra:force_close_msg_display
Mar 22, 2023
Merged

use PrintableString to Display CounterpartyForceClosed peer_msg#2114
jkczyz merged 1 commit into
lightningdevkit:mainfrom
Evanfeenstra:force_close_msg_display

Conversation

@Evanfeenstra

@EvanfeenstraEvanfeenstra commented Mar 18, 2023

Copy link
Copy Markdown
Contributor

This addresses #2108

It's a simple wrapper struct to safely print CounterpartyForceClosed peer_msg.

nothin like some Rust on a friday night

@codecov-commenter

codecov-commenter commented Mar 18, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage: 56.52% and project coverage change: -0.01⚠️

Comparison is base (217c3e0) 91.32% compared to head (bef56cb) 91.31%.

❗ Current head bef56cb differs from pull request most recent head 315fdf6. Consider uploading reports for the commit 315fdf6 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@ Coverage Diff @@## main #2114 +/- ##
==========================================
- Coverage 91.32% 91.31% -0.01% 
==========================================
Files 101 101 Lines 48791 48846 +55 Branches 48791 48846 +55 ==========================================
+ Hits 44558 44606 +48 - Misses 4233 4240 +7
Impacted FilesCoverage Δ
lightning/src/util/string.rs60.86% <25.00%> (-39.14%)⬇️
lightning/src/util/events.rs32.39% <50.00%> (+0.86%)⬆️
lightning/src/ln/channelmanager.rs89.10% <100.00%> (ø)
lightning/src/ln/functional_tests.rs98.24% <100.00%> (ø)
lightning/src/ln/payment_tests.rs97.42% <100.00%> (ø)
lightning/src/ln/reload_tests.rs95.52% <100.00%> (ø)
lightning/src/ln/reorg_tests.rs100.00% <100.00%> (ø)
lightning/src/ln/shutdown_tests.rs98.04% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

TheBlueMatt
TheBlueMatt reviewed Mar 19, 2023
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

Comment threadlightning/src/util/events.rs Outdated
Comment threadlightning/src/util/events.rs Outdated
Comment threadlightning/src/util/events.rs Outdated
Comment threadlightning/src/util/events.rs Outdated
@Evanfeenstra

Evanfeenstra commented Mar 19, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for tackling this!

No problem! Thanks for the suggestions, I implemented them

@Evanfeenstra

Evanfeenstra commented Mar 20, 2023

Copy link
Copy Markdown
ContributorAuthor

any tips on getting the ubuntu/windows/macos checks to pass?

valentinewallace
valentinewallace reviewed Mar 20, 2023
View reviewed changes

@valentinewallacevalentinewallace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, just some nits

Comment threadlightning/src/util/events.rs Outdated
Comment threadlightning/src/util/events.rs Outdated
TheBlueMatt
TheBlueMatt reviewed Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs Outdated
TheBlueMatt
TheBlueMatt reviewed Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs Outdated
@TheBlueMatt

TheBlueMatt commented Mar 20, 2023

Copy link
Copy Markdown
Collaborator

any tips on getting the ubuntu/windows/macos checks to pass?

Should be fixed for you when you push, it was an MSRV break due to serde being awful.

jkczyz
jkczyz reviewed Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs Outdated
jkczyz
jkczyz reviewed Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs Outdated
jkczyz
jkczyz reviewed Mar 21, 2023
View reviewed changes
Comment threadlightning/src/util/string.rs Outdated
Comment threadlightning/src/util/string.rs Outdated
Comment threadlightning/src/util/string.rs
Comment threadlightning/src/util/events.rs Outdated
jkczyz
jkczyz reviewed Mar 21, 2023
View reviewed changes

@jkczyzjkczyz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to squash, IMO.

Comment threadlightning/src/util/string.rs Outdated
@Evanfeenstra
Evanfeenstraforce-pushed the force_close_msg_display branch from bef56cb to 7cb5f8dCompareMarch 21, 2023 16:04
@Evanfeenstra

Evanfeenstra commented Mar 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Feel free to squash, IMO.

ok, squashed and re-ordered the util::string file

@TheBlueMatt

TheBlueMatt commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.

More importantly, though, please keep your commit titles and messages to around 80 chars long - if you have more information to convey, you should have one line that is the title followed by a blank line and then some number of lines that provide more details.

Other than those looks good.

@jkczyz

jkczyz commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.

Good point. I'd be fine with UntrustedString.

@Evanfeenstra

Evanfeenstra commented Mar 21, 2023

Copy link
Copy Markdown
ContributorAuthor

ok, renamed to UntrustedString

@TheBlueMatt

TheBlueMatt commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

Can you squash the fixup commits so that there aren't later commits fixing code introduced in earlier commits in the same PR? Other than that should be good, thanks!

@Evanfeenstra
Evanfeenstraforce-pushed the force_close_msg_display branch from 315fdf6 to 987ab95CompareMarch 22, 2023 04:39
@Evanfeenstra

Evanfeenstra commented Mar 22, 2023

Copy link
Copy Markdown
ContributorAuthor

Ok, it's in a single commit. Thanks for all the help yall!

@jkczyz
jkczyz merged commit 3d479c9 into lightningdevkit:mainMar 22, 2023
PXplod pushed a commit to bitlightlabs/rust-lightning that referenced this pull request Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt

@jkczyzjkczyz

@valentinewallacevalentinewallace

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Evanfeenstra@codecov-commenter@TheBlueMatt@jkczyz@valentinewallace
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
use PrintableString to Display CounterpartyForceClosed peer_msg - #2114
Merged
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Mar 22, 2023
Merged
use PrintableString to Display CounterpartyForceClosed peer_msg#2114
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Conversation
@Evanfeenstra
@EvanfeenstraEvanfeenstra
commented
Mar 18, 2023

Copy link


Copy Markdown

Contributor
This addresses #2108
It's a simple wrapper struct to safely print CounterpartyForceClosed peer_msg.
nothin like some Rust on a friday night
@codecov-commenter
codecov-commenter
commented
Mar 18, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 56.52% and project coverage change: -0.01⚠️
Comparison is base (217c3e0) 91.32% compared to head (bef56cb) 91.31%.
❗ Current head bef56cb differs from pull request most recent head 315fdf6. Consider uploading reports for the commit 315fdf6 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2114 +/- ##
==========================================
- Coverage 91.32% 91.31% -0.01% 
==========================================
Files 101 101 Lines 48791 48846 +55 Branches 48791 48846 +55 ==========================================
+ Hits 44558 44606 +48 - Misses 4233 4240 +7 
Impacted FilesCoverage Δ
lightning/src/util/string.rs60.86% <25.00%> (-39.14%)⬇️
lightning/src/util/events.rs32.39% <50.00%> (+0.86%)⬆️
lightning/src/ln/channelmanager.rs89.10% <100.00%> (ø)
lightning/src/ln/functional_tests.rs98.24% <100.00%> (ø)
lightning/src/ln/payment_tests.rs97.42% <100.00%> (ø)
lightning/src/ln/reload_tests.rs95.52% <100.00%> (ø)
lightning/src/ln/reorg_tests.rs100.00% <100.00%> (ø)
lightning/src/ln/shutdown_tests.rs98.04% <100.00%> (ø)
... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
TheBlueMatt
TheBlueMatt
reviewed
Mar 19, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

@Evanfeenstra
Evanfeenstra
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks for tackling this!
No problem! Thanks for the suggestions, I implemented them
@Evanfeenstra
Evanfeenstra
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
any tips on getting the ubuntu/windows/macos checks to pass?
valentinewallace
valentinewallace
reviewed
Mar 20, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, just some nits
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

@TheBlueMatt
TheBlueMatt
commented
Mar 20, 2023

Copy link


Copy Markdown

Collaborator
any tips on getting the ubuntu/windows/macos checks to pass?
Should be fixed for you when you push, it was an MSRV break due to serde being awful.
jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to squash, IMO.
Comment threadlightning/src/util/string.rs
Outdated

@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
bef56cb to
7cb5f8dCompareMarch 21, 2023 16:04
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Feel free to squash, IMO.
ok, squashed and re-ordered the util::string file
@TheBlueMatt
TheBlueMatt
commented
Mar 21, 2023

Copy link


Copy Markdown

Collaborator
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
More importantly, though, please keep your commit titles and messages to around 80 chars long - if you have more information to convey, you should have one line that is the title followed by a blank line and then some number of lines that provide more details.
Other than those looks good.
@jkczyz
jkczyz
commented
Mar 21, 2023

Copy link


Copy Markdown

Contributor
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
Good point. I'd be fine with UntrustedString.
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
ok, renamed to UntrustedString
@TheBlueMatt
TheBlueMatt
commented
Mar 22, 2023

Copy link


Copy Markdown

Collaborator
Can you squash the fixup commits so that there aren't later commits fixing code introduced in earlier commits in the same PR? Other than that should be good, thanks!
@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
315fdf6 to
987ab95CompareMarch 22, 2023 04:39
@Evanfeenstra
Evanfeenstra
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
Ok, it's in a single commit. Thanks for all the help yall!
@jkczyz
jkczyz
merged commit 3d479c9
into
lightningdevkit:mainMar 22, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Evanfeenstra@codecov-commenter@TheBlueMatt@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
use PrintableString to Display CounterpartyForceClosed peer_msg - #2114
Merged
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Mar 22, 2023
Merged
use PrintableString to Display CounterpartyForceClosed peer_msg#2114
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Conversation
@Evanfeenstra
@EvanfeenstraEvanfeenstra
commented
Mar 18, 2023

Copy link


Copy Markdown

Contributor
This addresses #2108
It's a simple wrapper struct to safely print CounterpartyForceClosed peer_msg.
nothin like some Rust on a friday night
@codecov-commenter
codecov-commenter
commented
Mar 18, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 56.52% and project coverage change: -0.01⚠️
Comparison is base (217c3e0) 91.32% compared to head (bef56cb) 91.31%.
❗ Current head bef56cb differs from pull request most recent head 315fdf6. Consider uploading reports for the commit 315fdf6 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2114 +/- ##
==========================================
- Coverage 91.32% 91.31% -0.01% 
==========================================
Files 101 101 Lines 48791 48846 +55 Branches 48791 48846 +55 ==========================================
+ Hits 44558 44606 +48 - Misses 4233 4240 +7 
Impacted FilesCoverage Δ
lightning/src/util/string.rs60.86% <25.00%> (-39.14%)⬇️
lightning/src/util/events.rs32.39% <50.00%> (+0.86%)⬆️
lightning/src/ln/channelmanager.rs89.10% <100.00%> (ø)
lightning/src/ln/functional_tests.rs98.24% <100.00%> (ø)
lightning/src/ln/payment_tests.rs97.42% <100.00%> (ø)
lightning/src/ln/reload_tests.rs95.52% <100.00%> (ø)
lightning/src/ln/reorg_tests.rs100.00% <100.00%> (ø)
lightning/src/ln/shutdown_tests.rs98.04% <100.00%> (ø)
... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
TheBlueMatt
TheBlueMatt
reviewed
Mar 19, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

@Evanfeenstra
Evanfeenstra
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks for tackling this!
No problem! Thanks for the suggestions, I implemented them
@Evanfeenstra
Evanfeenstra
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
any tips on getting the ubuntu/windows/macos checks to pass?
valentinewallace
valentinewallace
reviewed
Mar 20, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, just some nits
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

@TheBlueMatt
TheBlueMatt
commented
Mar 20, 2023

Copy link


Copy Markdown

Collaborator
any tips on getting the ubuntu/windows/macos checks to pass?
Should be fixed for you when you push, it was an MSRV break due to serde being awful.
jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to squash, IMO.
Comment threadlightning/src/util/string.rs
Outdated

@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
bef56cb to
7cb5f8dCompareMarch 21, 2023 16:04
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Feel free to squash, IMO.
ok, squashed and re-ordered the util::string file
@TheBlueMatt
TheBlueMatt
commented
Mar 21, 2023

Copy link


Copy Markdown

Collaborator
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
More importantly, though, please keep your commit titles and messages to around 80 chars long - if you have more information to convey, you should have one line that is the title followed by a blank line and then some number of lines that provide more details.
Other than those looks good.
@jkczyz
jkczyz
commented
Mar 21, 2023

Copy link


Copy Markdown

Contributor
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
Good point. I'd be fine with UntrustedString.
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
ok, renamed to UntrustedString
@TheBlueMatt
TheBlueMatt
commented
Mar 22, 2023

Copy link


Copy Markdown

Collaborator
Can you squash the fixup commits so that there aren't later commits fixing code introduced in earlier commits in the same PR? Other than that should be good, thanks!
@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
315fdf6 to
987ab95CompareMarch 22, 2023 04:39
@Evanfeenstra
Evanfeenstra
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
Ok, it's in a single commit. Thanks for all the help yall!
@jkczyz
jkczyz
merged commit 3d479c9
into
lightningdevkit:mainMar 22, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Evanfeenstra@codecov-commenter@TheBlueMatt@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
use PrintableString to Display CounterpartyForceClosed peer_msg - #2114
Merged
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Mar 22, 2023
Merged
use PrintableString to Display CounterpartyForceClosed peer_msg#2114
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Conversation
@Evanfeenstra
@EvanfeenstraEvanfeenstra
commented
Mar 18, 2023

Copy link


Copy Markdown

Contributor
This addresses #2108
It's a simple wrapper struct to safely print CounterpartyForceClosed peer_msg.
nothin like some Rust on a friday night
@codecov-commenter
codecov-commenter
commented
Mar 18, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 56.52% and project coverage change: -0.01⚠️
Comparison is base (217c3e0) 91.32% compared to head (bef56cb) 91.31%.
❗ Current head bef56cb differs from pull request most recent head 315fdf6. Consider uploading reports for the commit 315fdf6 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2114 +/- ##
==========================================
- Coverage 91.32% 91.31% -0.01% 
==========================================
Files 101 101 Lines 48791 48846 +55 Branches 48791 48846 +55 ==========================================
+ Hits 44558 44606 +48 - Misses 4233 4240 +7 
Impacted FilesCoverage Δ
lightning/src/util/string.rs60.86% <25.00%> (-39.14%)⬇️
lightning/src/util/events.rs32.39% <50.00%> (+0.86%)⬆️
lightning/src/ln/channelmanager.rs89.10% <100.00%> (ø)
lightning/src/ln/functional_tests.rs98.24% <100.00%> (ø)
lightning/src/ln/payment_tests.rs97.42% <100.00%> (ø)
lightning/src/ln/reload_tests.rs95.52% <100.00%> (ø)
lightning/src/ln/reorg_tests.rs100.00% <100.00%> (ø)
lightning/src/ln/shutdown_tests.rs98.04% <100.00%> (ø)
... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
TheBlueMatt
TheBlueMatt
reviewed
Mar 19, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

@Evanfeenstra
Evanfeenstra
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks for tackling this!
No problem! Thanks for the suggestions, I implemented them
@Evanfeenstra
Evanfeenstra
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
any tips on getting the ubuntu/windows/macos checks to pass?
valentinewallace
valentinewallace
reviewed
Mar 20, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, just some nits
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

@TheBlueMatt
TheBlueMatt
commented
Mar 20, 2023

Copy link


Copy Markdown

Collaborator
any tips on getting the ubuntu/windows/macos checks to pass?
Should be fixed for you when you push, it was an MSRV break due to serde being awful.
jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to squash, IMO.
Comment threadlightning/src/util/string.rs
Outdated

@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
bef56cb to
7cb5f8dCompareMarch 21, 2023 16:04
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Feel free to squash, IMO.
ok, squashed and re-ordered the util::string file
@TheBlueMatt
TheBlueMatt
commented
Mar 21, 2023

Copy link


Copy Markdown

Collaborator
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
More importantly, though, please keep your commit titles and messages to around 80 chars long - if you have more information to convey, you should have one line that is the title followed by a blank line and then some number of lines that provide more details.
Other than those looks good.
@jkczyz
jkczyz
commented
Mar 21, 2023

Copy link


Copy Markdown

Contributor
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
Good point. I'd be fine with UntrustedString.
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
ok, renamed to UntrustedString
@TheBlueMatt
TheBlueMatt
commented
Mar 22, 2023

Copy link


Copy Markdown

Collaborator
Can you squash the fixup commits so that there aren't later commits fixing code introduced in earlier commits in the same PR? Other than that should be good, thanks!
@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
315fdf6 to
987ab95CompareMarch 22, 2023 04:39
@Evanfeenstra
Evanfeenstra
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
Ok, it's in a single commit. Thanks for all the help yall!
@jkczyz
jkczyz
merged commit 3d479c9
into
lightningdevkit:mainMar 22, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Evanfeenstra@codecov-commenter@TheBlueMatt@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
use PrintableString to Display CounterpartyForceClosed peer_msg - #2114
Merged
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Mar 22, 2023
Merged
use PrintableString to Display CounterpartyForceClosed peer_msg#2114
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Conversation
@Evanfeenstra
@EvanfeenstraEvanfeenstra
commented
Mar 18, 2023

Copy link


Copy Markdown

Contributor
This addresses #2108
It's a simple wrapper struct to safely print CounterpartyForceClosed peer_msg.
nothin like some Rust on a friday night
@codecov-commenter
codecov-commenter
commented
Mar 18, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 56.52% and project coverage change: -0.01⚠️
Comparison is base (217c3e0) 91.32% compared to head (bef56cb) 91.31%.
❗ Current head bef56cb differs from pull request most recent head 315fdf6. Consider uploading reports for the commit 315fdf6 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2114 +/- ##
==========================================
- Coverage 91.32% 91.31% -0.01% 
==========================================
Files 101 101 Lines 48791 48846 +55 Branches 48791 48846 +55 ==========================================
+ Hits 44558 44606 +48 - Misses 4233 4240 +7 
Impacted FilesCoverage Δ
lightning/src/util/string.rs60.86% <25.00%> (-39.14%)⬇️
lightning/src/util/events.rs32.39% <50.00%> (+0.86%)⬆️
lightning/src/ln/channelmanager.rs89.10% <100.00%> (ø)
lightning/src/ln/functional_tests.rs98.24% <100.00%> (ø)
lightning/src/ln/payment_tests.rs97.42% <100.00%> (ø)
lightning/src/ln/reload_tests.rs95.52% <100.00%> (ø)
lightning/src/ln/reorg_tests.rs100.00% <100.00%> (ø)
lightning/src/ln/shutdown_tests.rs98.04% <100.00%> (ø)
... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
TheBlueMatt
TheBlueMatt
reviewed
Mar 19, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

@Evanfeenstra
Evanfeenstra
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks for tackling this!
No problem! Thanks for the suggestions, I implemented them
@Evanfeenstra
Evanfeenstra
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
any tips on getting the ubuntu/windows/macos checks to pass?
valentinewallace
valentinewallace
reviewed
Mar 20, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, just some nits
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

@TheBlueMatt
TheBlueMatt
commented
Mar 20, 2023

Copy link


Copy Markdown

Collaborator
any tips on getting the ubuntu/windows/macos checks to pass?
Should be fixed for you when you push, it was an MSRV break due to serde being awful.
jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to squash, IMO.
Comment threadlightning/src/util/string.rs
Outdated

@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
bef56cb to
7cb5f8dCompareMarch 21, 2023 16:04
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Feel free to squash, IMO.
ok, squashed and re-ordered the util::string file
@TheBlueMatt
TheBlueMatt
commented
Mar 21, 2023

Copy link


Copy Markdown

Collaborator
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
More importantly, though, please keep your commit titles and messages to around 80 chars long - if you have more information to convey, you should have one line that is the title followed by a blank line and then some number of lines that provide more details.
Other than those looks good.
@jkczyz
jkczyz
commented
Mar 21, 2023

Copy link


Copy Markdown

Contributor
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
Good point. I'd be fine with UntrustedString.
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
ok, renamed to UntrustedString
@TheBlueMatt
TheBlueMatt
commented
Mar 22, 2023

Copy link


Copy Markdown

Collaborator
Can you squash the fixup commits so that there aren't later commits fixing code introduced in earlier commits in the same PR? Other than that should be good, thanks!
@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
315fdf6 to
987ab95CompareMarch 22, 2023 04:39
@Evanfeenstra
Evanfeenstra
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
Ok, it's in a single commit. Thanks for all the help yall!
@jkczyz
jkczyz
merged commit 3d479c9
into
lightningdevkit:mainMar 22, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Evanfeenstra@codecov-commenter@TheBlueMatt@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
use PrintableString to Display CounterpartyForceClosed peer_msg - #2114
Merged
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Mar 22, 2023
Merged
use PrintableString to Display CounterpartyForceClosed peer_msg#2114
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Conversation
@Evanfeenstra
@EvanfeenstraEvanfeenstra
commented
Mar 18, 2023

Copy link


Copy Markdown

Contributor
This addresses #2108
It's a simple wrapper struct to safely print CounterpartyForceClosed peer_msg.
nothin like some Rust on a friday night
@codecov-commenter
codecov-commenter
commented
Mar 18, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 56.52% and project coverage change: -0.01⚠️
Comparison is base (217c3e0) 91.32% compared to head (bef56cb) 91.31%.
❗ Current head bef56cb differs from pull request most recent head 315fdf6. Consider uploading reports for the commit 315fdf6 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2114 +/- ##
==========================================
- Coverage 91.32% 91.31% -0.01% 
==========================================
Files 101 101 Lines 48791 48846 +55 Branches 48791 48846 +55 ==========================================
+ Hits 44558 44606 +48 - Misses 4233 4240 +7 
Impacted FilesCoverage Δ
lightning/src/util/string.rs60.86% <25.00%> (-39.14%)⬇️
lightning/src/util/events.rs32.39% <50.00%> (+0.86%)⬆️
lightning/src/ln/channelmanager.rs89.10% <100.00%> (ø)
lightning/src/ln/functional_tests.rs98.24% <100.00%> (ø)
lightning/src/ln/payment_tests.rs97.42% <100.00%> (ø)
lightning/src/ln/reload_tests.rs95.52% <100.00%> (ø)
lightning/src/ln/reorg_tests.rs100.00% <100.00%> (ø)
lightning/src/ln/shutdown_tests.rs98.04% <100.00%> (ø)
... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
TheBlueMatt
TheBlueMatt
reviewed
Mar 19, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

@Evanfeenstra
Evanfeenstra
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks for tackling this!
No problem! Thanks for the suggestions, I implemented them
@Evanfeenstra
Evanfeenstra
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
any tips on getting the ubuntu/windows/macos checks to pass?
valentinewallace
valentinewallace
reviewed
Mar 20, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, just some nits
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

@TheBlueMatt
TheBlueMatt
commented
Mar 20, 2023

Copy link


Copy Markdown

Collaborator
any tips on getting the ubuntu/windows/macos checks to pass?
Should be fixed for you when you push, it was an MSRV break due to serde being awful.
jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to squash, IMO.
Comment threadlightning/src/util/string.rs
Outdated

@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
bef56cb to
7cb5f8dCompareMarch 21, 2023 16:04
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Feel free to squash, IMO.
ok, squashed and re-ordered the util::string file
@TheBlueMatt
TheBlueMatt
commented
Mar 21, 2023

Copy link


Copy Markdown

Collaborator
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
More importantly, though, please keep your commit titles and messages to around 80 chars long - if you have more information to convey, you should have one line that is the title followed by a blank line and then some number of lines that provide more details.
Other than those looks good.
@jkczyz
jkczyz
commented
Mar 21, 2023

Copy link


Copy Markdown

Contributor
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
Good point. I'd be fine with UntrustedString.
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
ok, renamed to UntrustedString
@TheBlueMatt
TheBlueMatt
commented
Mar 22, 2023

Copy link


Copy Markdown

Collaborator
Can you squash the fixup commits so that there aren't later commits fixing code introduced in earlier commits in the same PR? Other than that should be good, thanks!
@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
315fdf6 to
987ab95CompareMarch 22, 2023 04:39
@Evanfeenstra
Evanfeenstra
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
Ok, it's in a single commit. Thanks for all the help yall!
@jkczyz
jkczyz
merged commit 3d479c9
into
lightningdevkit:mainMar 22, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Evanfeenstra@codecov-commenter@TheBlueMatt@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
use PrintableString to Display CounterpartyForceClosed peer_msg - #2114
Merged
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Mar 22, 2023
Merged
use PrintableString to Display CounterpartyForceClosed peer_msg#2114
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Conversation
@Evanfeenstra
@EvanfeenstraEvanfeenstra
commented
Mar 18, 2023

Copy link


Copy Markdown

Contributor
This addresses #2108
It's a simple wrapper struct to safely print CounterpartyForceClosed peer_msg.
nothin like some Rust on a friday night
@codecov-commenter
codecov-commenter
commented
Mar 18, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 56.52% and project coverage change: -0.01⚠️
Comparison is base (217c3e0) 91.32% compared to head (bef56cb) 91.31%.
❗ Current head bef56cb differs from pull request most recent head 315fdf6. Consider uploading reports for the commit 315fdf6 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2114 +/- ##
==========================================
- Coverage 91.32% 91.31% -0.01% 
==========================================
Files 101 101 Lines 48791 48846 +55 Branches 48791 48846 +55 ==========================================
+ Hits 44558 44606 +48 - Misses 4233 4240 +7 
Impacted FilesCoverage Δ
lightning/src/util/string.rs60.86% <25.00%> (-39.14%)⬇️
lightning/src/util/events.rs32.39% <50.00%> (+0.86%)⬆️
lightning/src/ln/channelmanager.rs89.10% <100.00%> (ø)
lightning/src/ln/functional_tests.rs98.24% <100.00%> (ø)
lightning/src/ln/payment_tests.rs97.42% <100.00%> (ø)
lightning/src/ln/reload_tests.rs95.52% <100.00%> (ø)
lightning/src/ln/reorg_tests.rs100.00% <100.00%> (ø)
lightning/src/ln/shutdown_tests.rs98.04% <100.00%> (ø)
... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
TheBlueMatt
TheBlueMatt
reviewed
Mar 19, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

@Evanfeenstra
Evanfeenstra
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks for tackling this!
No problem! Thanks for the suggestions, I implemented them
@Evanfeenstra
Evanfeenstra
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
any tips on getting the ubuntu/windows/macos checks to pass?
valentinewallace
valentinewallace
reviewed
Mar 20, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, just some nits
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

@TheBlueMatt
TheBlueMatt
commented
Mar 20, 2023

Copy link


Copy Markdown

Collaborator
any tips on getting the ubuntu/windows/macos checks to pass?
Should be fixed for you when you push, it was an MSRV break due to serde being awful.
jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to squash, IMO.
Comment threadlightning/src/util/string.rs
Outdated

@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
bef56cb to
7cb5f8dCompareMarch 21, 2023 16:04
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Feel free to squash, IMO.
ok, squashed and re-ordered the util::string file
@TheBlueMatt
TheBlueMatt
commented
Mar 21, 2023

Copy link


Copy Markdown

Collaborator
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
More importantly, though, please keep your commit titles and messages to around 80 chars long - if you have more information to convey, you should have one line that is the title followed by a blank line and then some number of lines that provide more details.
Other than those looks good.
@jkczyz
jkczyz
commented
Mar 21, 2023

Copy link


Copy Markdown

Contributor
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
Good point. I'd be fine with UntrustedString.
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
ok, renamed to UntrustedString
@TheBlueMatt
TheBlueMatt
commented
Mar 22, 2023

Copy link


Copy Markdown

Collaborator
Can you squash the fixup commits so that there aren't later commits fixing code introduced in earlier commits in the same PR? Other than that should be good, thanks!
@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
315fdf6 to
987ab95CompareMarch 22, 2023 04:39
@Evanfeenstra
Evanfeenstra
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
Ok, it's in a single commit. Thanks for all the help yall!
@jkczyz
jkczyz
merged commit 3d479c9
into
lightningdevkit:mainMar 22, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Evanfeenstra@codecov-commenter@TheBlueMatt@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
use PrintableString to Display CounterpartyForceClosed peer_msg - #2114
Merged
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Mar 22, 2023
Merged
use PrintableString to Display CounterpartyForceClosed peer_msg#2114
jkczyz merged 1 commit into
lightningdevkit:mainfrom 
Evanfeenstra:force_close_msg_display
Conversation
@Evanfeenstra
@EvanfeenstraEvanfeenstra
commented
Mar 18, 2023

Copy link


Copy Markdown

Contributor
This addresses #2108
It's a simple wrapper struct to safely print CounterpartyForceClosed peer_msg.
nothin like some Rust on a friday night
@codecov-commenter
codecov-commenter
commented
Mar 18, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 56.52% and project coverage change: -0.01⚠️
Comparison is base (217c3e0) 91.32% compared to head (bef56cb) 91.31%.
❗ Current head bef56cb differs from pull request most recent head 315fdf6. Consider uploading reports for the commit 315fdf6 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2114 +/- ##
==========================================
- Coverage 91.32% 91.31% -0.01% 
==========================================
Files 101 101 Lines 48791 48846 +55 Branches 48791 48846 +55 ==========================================
+ Hits 44558 44606 +48 - Misses 4233 4240 +7 
Impacted FilesCoverage Δ
lightning/src/util/string.rs60.86% <25.00%> (-39.14%)⬇️
lightning/src/util/events.rs32.39% <50.00%> (+0.86%)⬆️
lightning/src/ln/channelmanager.rs89.10% <100.00%> (ø)
lightning/src/ln/functional_tests.rs98.24% <100.00%> (ø)
lightning/src/ln/payment_tests.rs97.42% <100.00%> (ø)
lightning/src/ln/reload_tests.rs95.52% <100.00%> (ø)
lightning/src/ln/reorg_tests.rs100.00% <100.00%> (ø)
lightning/src/ln/shutdown_tests.rs98.04% <100.00%> (ø)
... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
TheBlueMatt
TheBlueMatt
reviewed
Mar 19, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

@Evanfeenstra
Evanfeenstra
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks for tackling this!
No problem! Thanks for the suggestions, I implemented them
@Evanfeenstra
Evanfeenstra
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
any tips on getting the ubuntu/windows/macos checks to pass?
valentinewallace
valentinewallace
reviewed
Mar 20, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, just some nits
Comment threadlightning/src/util/events.rs
Outdated

Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

@TheBlueMatt
TheBlueMatt
commented
Mar 20, 2023

Copy link


Copy Markdown

Collaborator
any tips on getting the ubuntu/windows/macos checks to pass?
Should be fixed for you when you push, it was an MSRV break due to serde being awful.
jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 20, 2023
View reviewed changes
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Outdated

Comment threadlightning/src/util/string.rs
Comment threadlightning/src/util/events.rs
Outdated

jkczyz
jkczyz
reviewed
Mar 21, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to squash, IMO.
Comment threadlightning/src/util/string.rs
Outdated

@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
bef56cb to
7cb5f8dCompareMarch 21, 2023 16:04
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Feel free to squash, IMO.
ok, squashed and re-ordered the util::string file
@TheBlueMatt
TheBlueMatt
commented
Mar 21, 2023

Copy link


Copy Markdown

Collaborator
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
More importantly, though, please keep your commit titles and messages to around 80 chars long - if you have more information to convey, you should have one line that is the title followed by a blank line and then some number of lines that provide more details.
Other than those looks good.
@jkczyz
jkczyz
commented
Mar 21, 2023

Copy link


Copy Markdown

Contributor
nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.
Good point. I'd be fine with UntrustedString.
@Evanfeenstra
Evanfeenstra
commented
Mar 21, 2023

Copy link


Copy Markdown

ContributorAuthor
ok, renamed to UntrustedString
@TheBlueMatt
TheBlueMatt
commented
Mar 22, 2023

Copy link


Copy Markdown

Collaborator
Can you squash the fixup commits so that there aren't later commits fixing code introduced in earlier commits in the same PR? Other than that should be good, thanks!
@Evanfeenstra
Evanfeenstraforce-pushed
the
force_close_msg_display
branch
from
315fdf6 to
987ab95CompareMarch 22, 2023 04:39
@Evanfeenstra
Evanfeenstra
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
Ok, it's in a single commit. Thanks for all the help yall!
@jkczyz
jkczyz
merged commit 3d479c9
into
lightningdevkit:mainMar 22, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Evanfeenstra@codecov-commenter@TheBlueMatt@jkczyz@valentinewallace