Skip to content

Replace OUR_MAX_HTLCS with config knob - #2138

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
swilliamson5:replace-our-max-htlcs-constant
Apr 17, 2023
Merged

Replace OUR_MAX_HTLCS with config knob#2138
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
swilliamson5:replace-our-max-htlcs-constant

Conversation

@swilliamson5

@swilliamson5swilliamson5 commented Mar 29, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Add a config knob for holder_max_accepted_htlcs to replace the constant OUR_MAX_HTLCS.

resolves#1990

@swilliamson5swilliamson5 changed the title Replace OUR_MAX_HTLCS with config knob[DRAFT] Replace OUR_MAX_HTLCS with config knobMar 30, 2023
TheBlueMatt
TheBlueMatt reviewed Mar 30, 2023
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a config knob in ChannelHandshakeConfig in config.rs.

Comment threadlightning/src/ln/channel.rs Outdated
Comment threadlightning/src/ln/channel.rs Outdated
Comment threadlightning/src/ln/channel.rs Outdated
swilliamson5
swilliamson5 commented Mar 30, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs Outdated
TheBlueMatt
TheBlueMatt reviewed Apr 3, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs Outdated
Comment threadlightning/src/ln/channel.rs Outdated
Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/util/config.rs
@codecov-commenter

codecov-commenter commented Apr 8, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage: 94.11% and project coverage change: -0.03⚠️

Comparison is base (e1e3819) 91.35% compared to head (604eb91) 91.33%.

❗ Current head 604eb91 differs from pull request most recent head f656609. Consider uploading reports for the commit f656609 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@ Coverage Diff @@## main #2138 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.03% 
==========================================
Files 102 102 Lines 50382 50389 +7 Branches 50382 50389 +7 ==========================================
- Hits 46027 46021 -6 - Misses 4355 4368 +13
Impacted FilesCoverage Δ
lightning/src/util/config.rs40.00% <0.00%> (-0.63%)⬇️
lightning/src/ln/channel.rs90.16% <100.00%> (+0.01%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt

TheBlueMatt commented Apr 12, 2023

Copy link
Copy Markdown
Collaborator

Still needs more docs on the knob ( #2138 (comment) ) but the code looks good to me! When you do address that, feel free to rebase and squash so that its a clean set of non-merge commits based on upstream (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes for how to).

@TheBlueMattTheBlueMatt mentioned this pull request Apr 12, 2023
Merged
@TheBlueMatt

TheBlueMatt commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

Probably can mark this non-draft too, when you get there :)

@swilliamson5swilliamson5 changed the title [DRAFT] Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
@swilliamson5
swilliamson5 marked this pull request as ready for review April 15, 2023 00:24
@swilliamson5
swilliamson5force-pushed the replace-our-max-htlcs-constant branch 2 times, most recently from 54ca4fa to 09b9a19CompareApril 15, 2023 01:31
@swilliamson5
swilliamson5force-pushed the replace-our-max-htlcs-constant branch from 09b9a19 to f8deb84CompareApril 15, 2023 01:34
@swilliamson5swilliamson5 changed the title Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
TheBlueMatt
TheBlueMatt reviewed Apr 16, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs Outdated
Comment threadlightning/src/util/config.rs Outdated
Comment threadlightning/src/util/config.rs Outdated
Comment threadlightning/src/util/config.rs Outdated
@swilliamson5
swilliamson5force-pushed the replace-our-max-htlcs-constant branch 2 times, most recently from c99da4c to 44ff074CompareApril 16, 2023 20:57
@swilliamson5
swilliamson5force-pushed the replace-our-max-htlcs-constant branch from 44ff074 to fce8013CompareApril 16, 2023 21:56
TheBlueMatt
TheBlueMatt previously approved these changes Apr 16, 2023
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll get another reviewer on this Monday, thanks!

Comment threadlightning/src/ln/channel.rs Outdated
@swilliamson5
Replace OUR_MAX_HTLCS constant with config knob
f656609
holder_max_accepted_htlcs. Set upper bound of 483
Writes an even TLV if the value isn't 50
@swilliamson5
swilliamson5force-pushed the replace-our-max-htlcs-constant branch from fce8013 to f656609CompareApril 16, 2023 23:29
@TheBlueMattTheBlueMatt added this to the 0.0.115 milestone Apr 17, 2023
arik-so
arik-so approved these changes Apr 17, 2023
View reviewed changes

@arik-soarik-so left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@TheBlueMatt
TheBlueMatt merged commit 2ebbe6f into lightningdevkit:mainApr 17, 2023
PXplod pushed a commit to bitlightlabs/rust-lightning that referenced this pull request Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@arik-soarik-soarik-so approved these changes

Assignees

No one assigned

Labels

Seeking Code Review

Projects

None yet

Milestone

0.0.115

Development

Successfully merging this pull request may close these issues.

Replace OUR_MAX_HTLCS constant with a config knob

4 participants

@swilliamson5@codecov-commenter@TheBlueMatt@arik-so
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Replace `OUR_MAX_HTLCS` with config knob by swilliamson5 · Pull Request #2138 · lightningdevkit/rust-lightning · GitHub
Skip to content
Replace OUR_MAX_HTLCS with config knob - #2138
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Apr 17, 2023
Merged
Replace OUR_MAX_HTLCS with config knob#2138
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Conversation
@swilliamson5
@swilliamson5swilliamson5
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add a config knob for holder_max_accepted_htlcs to replace the constant OUR_MAX_HTLCS.
resolves#1990
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knob[DRAFT] Replace OUR_MAX_HTLCS with config knobMar 30, 2023
TheBlueMatt
TheBlueMatt
reviewed
Mar 30, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a config knob in ChannelHandshakeConfig in config.rs.
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

swilliamson5
swilliamson5
commented
Mar 30, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Apr 3, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/util/config.rs
@codecov-commenter
codecov-commenter
commented
Apr 8, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 94.11% and project coverage change: -0.03⚠️
Comparison is base (e1e3819) 91.35% compared to head (604eb91) 91.33%.
❗ Current head 604eb91 differs from pull request most recent head f656609. Consider uploading reports for the commit f656609 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2138 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.03% 
==========================================
Files 102 102 Lines 50382 50389 +7 Branches 50382 50389 +7 ==========================================
- Hits 46027 46021 -6 - Misses 4355 4368 +13 
Impacted FilesCoverage Δ
lightning/src/util/config.rs40.00% <0.00%> (-0.63%)⬇️
lightning/src/ln/channel.rs90.16% <100.00%> (+0.01%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TheBlueMatt
TheBlueMatt
commented
Apr 12, 2023

Copy link


Copy Markdown

Collaborator
Still needs more docs on the knob ( #2138 (comment) ) but the code looks good to me! When you do address that, feel free to rebase and squash so that its a clean set of non-merge commits based on upstream (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes for how to).
@TheBlueMattTheBlueMatt
mentioned this pull request
Apr 12, 2023
 Merged

@TheBlueMatt
TheBlueMatt
commented
Apr 13, 2023

Copy link


Copy Markdown

Collaborator
Probably can mark this non-draft too, when you get there :)
@swilliamson5swilliamson5
changed the title
[DRAFT] Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
@swilliamson5
swilliamson5
marked this pull request as ready for review
April 15, 2023 00:24
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
54ca4fa to
09b9a19CompareApril 15, 2023 01:31
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
09b9a19 to
f8deb84CompareApril 15, 2023 01:34
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
TheBlueMatt
TheBlueMatt
reviewed
Apr 16, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
c99da4c to
44ff074CompareApril 16, 2023 20:57
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
44ff074 to
fce8013CompareApril 16, 2023 21:56
TheBlueMatt
TheBlueMatt
previously approved these changes
Apr 16, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll get another reviewer on this Monday, thanks!
Comment threadlightning/src/ln/channel.rs
Outdated

@swilliamson5
Replace OUR_MAX_HTLCS constant with config knob
f656609
holder_max_accepted_htlcs. Set upper bound of 483
Writes an even TLV if the value isn't 50
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
fce8013 to
f656609CompareApril 16, 2023 23:29
@TheBlueMattTheBlueMatt
added this to the 0.0.115 milestone
Apr 17, 2023
arik-so
arik-so
approved these changes
Apr 17, 2023
View reviewed changes
@arik-soarik-so
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
@TheBlueMatt
TheBlueMatt
merged commit 2ebbe6f
into
lightningdevkit:mainApr 17, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@arik-soarik-soarik-so approved these changes

Assignees


No one assigned


Labels

Seeking Code Review

Projects


None yet


Milestone

0.0.115

Development

Successfully merging this pull request may close these issues.

Replace OUR_MAX_HTLCS constant with a config knob


4 participants

@swilliamson5@codecov-commenter@TheBlueMatt@arik-so

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Replace `OUR_MAX_HTLCS` with config knob by swilliamson5 · Pull Request #2138 · lightningdevkit/rust-lightning · GitHub
Skip to content
Replace OUR_MAX_HTLCS with config knob - #2138
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Apr 17, 2023
Merged
Replace OUR_MAX_HTLCS with config knob#2138
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Conversation
@swilliamson5
@swilliamson5swilliamson5
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add a config knob for holder_max_accepted_htlcs to replace the constant OUR_MAX_HTLCS.
resolves#1990
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knob[DRAFT] Replace OUR_MAX_HTLCS with config knobMar 30, 2023
TheBlueMatt
TheBlueMatt
reviewed
Mar 30, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a config knob in ChannelHandshakeConfig in config.rs.
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

swilliamson5
swilliamson5
commented
Mar 30, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Apr 3, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/util/config.rs
@codecov-commenter
codecov-commenter
commented
Apr 8, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 94.11% and project coverage change: -0.03⚠️
Comparison is base (e1e3819) 91.35% compared to head (604eb91) 91.33%.
❗ Current head 604eb91 differs from pull request most recent head f656609. Consider uploading reports for the commit f656609 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2138 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.03% 
==========================================
Files 102 102 Lines 50382 50389 +7 Branches 50382 50389 +7 ==========================================
- Hits 46027 46021 -6 - Misses 4355 4368 +13 
Impacted FilesCoverage Δ
lightning/src/util/config.rs40.00% <0.00%> (-0.63%)⬇️
lightning/src/ln/channel.rs90.16% <100.00%> (+0.01%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TheBlueMatt
TheBlueMatt
commented
Apr 12, 2023

Copy link


Copy Markdown

Collaborator
Still needs more docs on the knob ( #2138 (comment) ) but the code looks good to me! When you do address that, feel free to rebase and squash so that its a clean set of non-merge commits based on upstream (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes for how to).
@TheBlueMattTheBlueMatt
mentioned this pull request
Apr 12, 2023
 Merged

@TheBlueMatt
TheBlueMatt
commented
Apr 13, 2023

Copy link


Copy Markdown

Collaborator
Probably can mark this non-draft too, when you get there :)
@swilliamson5swilliamson5
changed the title
[DRAFT] Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
@swilliamson5
swilliamson5
marked this pull request as ready for review
April 15, 2023 00:24
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
54ca4fa to
09b9a19CompareApril 15, 2023 01:31
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
09b9a19 to
f8deb84CompareApril 15, 2023 01:34
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
TheBlueMatt
TheBlueMatt
reviewed
Apr 16, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
c99da4c to
44ff074CompareApril 16, 2023 20:57
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
44ff074 to
fce8013CompareApril 16, 2023 21:56
TheBlueMatt
TheBlueMatt
previously approved these changes
Apr 16, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll get another reviewer on this Monday, thanks!
Comment threadlightning/src/ln/channel.rs
Outdated

@swilliamson5
Replace OUR_MAX_HTLCS constant with config knob
f656609
holder_max_accepted_htlcs. Set upper bound of 483
Writes an even TLV if the value isn't 50
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
fce8013 to
f656609CompareApril 16, 2023 23:29
@TheBlueMattTheBlueMatt
added this to the 0.0.115 milestone
Apr 17, 2023
arik-so
arik-so
approved these changes
Apr 17, 2023
View reviewed changes
@arik-soarik-so
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
@TheBlueMatt
TheBlueMatt
merged commit 2ebbe6f
into
lightningdevkit:mainApr 17, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@arik-soarik-soarik-so approved these changes

Assignees


No one assigned


Labels

Seeking Code Review

Projects


None yet


Milestone

0.0.115

Development

Successfully merging this pull request may close these issues.

Replace OUR_MAX_HTLCS constant with a config knob


4 participants

@swilliamson5@codecov-commenter@TheBlueMatt@arik-so

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Replace `OUR_MAX_HTLCS` with config knob by swilliamson5 · Pull Request #2138 · lightningdevkit/rust-lightning · GitHub
Skip to content
Replace OUR_MAX_HTLCS with config knob - #2138
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Apr 17, 2023
Merged
Replace OUR_MAX_HTLCS with config knob#2138
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Conversation
@swilliamson5
@swilliamson5swilliamson5
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add a config knob for holder_max_accepted_htlcs to replace the constant OUR_MAX_HTLCS.
resolves#1990
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knob[DRAFT] Replace OUR_MAX_HTLCS with config knobMar 30, 2023
TheBlueMatt
TheBlueMatt
reviewed
Mar 30, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a config knob in ChannelHandshakeConfig in config.rs.
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

swilliamson5
swilliamson5
commented
Mar 30, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Apr 3, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/util/config.rs
@codecov-commenter
codecov-commenter
commented
Apr 8, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 94.11% and project coverage change: -0.03⚠️
Comparison is base (e1e3819) 91.35% compared to head (604eb91) 91.33%.
❗ Current head 604eb91 differs from pull request most recent head f656609. Consider uploading reports for the commit f656609 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2138 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.03% 
==========================================
Files 102 102 Lines 50382 50389 +7 Branches 50382 50389 +7 ==========================================
- Hits 46027 46021 -6 - Misses 4355 4368 +13 
Impacted FilesCoverage Δ
lightning/src/util/config.rs40.00% <0.00%> (-0.63%)⬇️
lightning/src/ln/channel.rs90.16% <100.00%> (+0.01%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TheBlueMatt
TheBlueMatt
commented
Apr 12, 2023

Copy link


Copy Markdown

Collaborator
Still needs more docs on the knob ( #2138 (comment) ) but the code looks good to me! When you do address that, feel free to rebase and squash so that its a clean set of non-merge commits based on upstream (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes for how to).
@TheBlueMattTheBlueMatt
mentioned this pull request
Apr 12, 2023
 Merged

@TheBlueMatt
TheBlueMatt
commented
Apr 13, 2023

Copy link


Copy Markdown

Collaborator
Probably can mark this non-draft too, when you get there :)
@swilliamson5swilliamson5
changed the title
[DRAFT] Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
@swilliamson5
swilliamson5
marked this pull request as ready for review
April 15, 2023 00:24
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
54ca4fa to
09b9a19CompareApril 15, 2023 01:31
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
09b9a19 to
f8deb84CompareApril 15, 2023 01:34
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
TheBlueMatt
TheBlueMatt
reviewed
Apr 16, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
c99da4c to
44ff074CompareApril 16, 2023 20:57
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
44ff074 to
fce8013CompareApril 16, 2023 21:56
TheBlueMatt
TheBlueMatt
previously approved these changes
Apr 16, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll get another reviewer on this Monday, thanks!
Comment threadlightning/src/ln/channel.rs
Outdated

@swilliamson5
Replace OUR_MAX_HTLCS constant with config knob
f656609
holder_max_accepted_htlcs. Set upper bound of 483
Writes an even TLV if the value isn't 50
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
fce8013 to
f656609CompareApril 16, 2023 23:29
@TheBlueMattTheBlueMatt
added this to the 0.0.115 milestone
Apr 17, 2023
arik-so
arik-so
approved these changes
Apr 17, 2023
View reviewed changes
@arik-soarik-so
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
@TheBlueMatt
TheBlueMatt
merged commit 2ebbe6f
into
lightningdevkit:mainApr 17, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@arik-soarik-soarik-so approved these changes

Assignees


No one assigned


Labels

Seeking Code Review

Projects


None yet


Milestone

0.0.115

Development

Successfully merging this pull request may close these issues.

Replace OUR_MAX_HTLCS constant with a config knob


4 participants

@swilliamson5@codecov-commenter@TheBlueMatt@arik-so

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Replace `OUR_MAX_HTLCS` with config knob by swilliamson5 · Pull Request #2138 · lightningdevkit/rust-lightning · GitHub
Skip to content
Replace OUR_MAX_HTLCS with config knob - #2138
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Apr 17, 2023
Merged
Replace OUR_MAX_HTLCS with config knob#2138
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Conversation
@swilliamson5
@swilliamson5swilliamson5
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add a config knob for holder_max_accepted_htlcs to replace the constant OUR_MAX_HTLCS.
resolves#1990
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knob[DRAFT] Replace OUR_MAX_HTLCS with config knobMar 30, 2023
TheBlueMatt
TheBlueMatt
reviewed
Mar 30, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a config knob in ChannelHandshakeConfig in config.rs.
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

swilliamson5
swilliamson5
commented
Mar 30, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Apr 3, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/util/config.rs
@codecov-commenter
codecov-commenter
commented
Apr 8, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 94.11% and project coverage change: -0.03⚠️
Comparison is base (e1e3819) 91.35% compared to head (604eb91) 91.33%.
❗ Current head 604eb91 differs from pull request most recent head f656609. Consider uploading reports for the commit f656609 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2138 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.03% 
==========================================
Files 102 102 Lines 50382 50389 +7 Branches 50382 50389 +7 ==========================================
- Hits 46027 46021 -6 - Misses 4355 4368 +13 
Impacted FilesCoverage Δ
lightning/src/util/config.rs40.00% <0.00%> (-0.63%)⬇️
lightning/src/ln/channel.rs90.16% <100.00%> (+0.01%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TheBlueMatt
TheBlueMatt
commented
Apr 12, 2023

Copy link


Copy Markdown

Collaborator
Still needs more docs on the knob ( #2138 (comment) ) but the code looks good to me! When you do address that, feel free to rebase and squash so that its a clean set of non-merge commits based on upstream (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes for how to).
@TheBlueMattTheBlueMatt
mentioned this pull request
Apr 12, 2023
 Merged

@TheBlueMatt
TheBlueMatt
commented
Apr 13, 2023

Copy link


Copy Markdown

Collaborator
Probably can mark this non-draft too, when you get there :)
@swilliamson5swilliamson5
changed the title
[DRAFT] Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
@swilliamson5
swilliamson5
marked this pull request as ready for review
April 15, 2023 00:24
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
54ca4fa to
09b9a19CompareApril 15, 2023 01:31
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
09b9a19 to
f8deb84CompareApril 15, 2023 01:34
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
TheBlueMatt
TheBlueMatt
reviewed
Apr 16, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
c99da4c to
44ff074CompareApril 16, 2023 20:57
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
44ff074 to
fce8013CompareApril 16, 2023 21:56
TheBlueMatt
TheBlueMatt
previously approved these changes
Apr 16, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll get another reviewer on this Monday, thanks!
Comment threadlightning/src/ln/channel.rs
Outdated

@swilliamson5
Replace OUR_MAX_HTLCS constant with config knob
f656609
holder_max_accepted_htlcs. Set upper bound of 483
Writes an even TLV if the value isn't 50
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
fce8013 to
f656609CompareApril 16, 2023 23:29
@TheBlueMattTheBlueMatt
added this to the 0.0.115 milestone
Apr 17, 2023
arik-so
arik-so
approved these changes
Apr 17, 2023
View reviewed changes
@arik-soarik-so
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
@TheBlueMatt
TheBlueMatt
merged commit 2ebbe6f
into
lightningdevkit:mainApr 17, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@arik-soarik-soarik-so approved these changes

Assignees


No one assigned


Labels

Seeking Code Review

Projects


None yet


Milestone

0.0.115

Development

Successfully merging this pull request may close these issues.

Replace OUR_MAX_HTLCS constant with a config knob


4 participants

@swilliamson5@codecov-commenter@TheBlueMatt@arik-so

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Replace `OUR_MAX_HTLCS` with config knob by swilliamson5 · Pull Request #2138 · lightningdevkit/rust-lightning · GitHub
Skip to content
Replace OUR_MAX_HTLCS with config knob - #2138
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Apr 17, 2023
Merged
Replace OUR_MAX_HTLCS with config knob#2138
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Conversation
@swilliamson5
@swilliamson5swilliamson5
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add a config knob for holder_max_accepted_htlcs to replace the constant OUR_MAX_HTLCS.
resolves#1990
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knob[DRAFT] Replace OUR_MAX_HTLCS with config knobMar 30, 2023
TheBlueMatt
TheBlueMatt
reviewed
Mar 30, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a config knob in ChannelHandshakeConfig in config.rs.
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

swilliamson5
swilliamson5
commented
Mar 30, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Apr 3, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/util/config.rs
@codecov-commenter
codecov-commenter
commented
Apr 8, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 94.11% and project coverage change: -0.03⚠️
Comparison is base (e1e3819) 91.35% compared to head (604eb91) 91.33%.
❗ Current head 604eb91 differs from pull request most recent head f656609. Consider uploading reports for the commit f656609 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2138 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.03% 
==========================================
Files 102 102 Lines 50382 50389 +7 Branches 50382 50389 +7 ==========================================
- Hits 46027 46021 -6 - Misses 4355 4368 +13 
Impacted FilesCoverage Δ
lightning/src/util/config.rs40.00% <0.00%> (-0.63%)⬇️
lightning/src/ln/channel.rs90.16% <100.00%> (+0.01%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TheBlueMatt
TheBlueMatt
commented
Apr 12, 2023

Copy link


Copy Markdown

Collaborator
Still needs more docs on the knob ( #2138 (comment) ) but the code looks good to me! When you do address that, feel free to rebase and squash so that its a clean set of non-merge commits based on upstream (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes for how to).
@TheBlueMattTheBlueMatt
mentioned this pull request
Apr 12, 2023
 Merged

@TheBlueMatt
TheBlueMatt
commented
Apr 13, 2023

Copy link


Copy Markdown

Collaborator
Probably can mark this non-draft too, when you get there :)
@swilliamson5swilliamson5
changed the title
[DRAFT] Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
@swilliamson5
swilliamson5
marked this pull request as ready for review
April 15, 2023 00:24
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
54ca4fa to
09b9a19CompareApril 15, 2023 01:31
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
09b9a19 to
f8deb84CompareApril 15, 2023 01:34
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
TheBlueMatt
TheBlueMatt
reviewed
Apr 16, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
c99da4c to
44ff074CompareApril 16, 2023 20:57
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
44ff074 to
fce8013CompareApril 16, 2023 21:56
TheBlueMatt
TheBlueMatt
previously approved these changes
Apr 16, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll get another reviewer on this Monday, thanks!
Comment threadlightning/src/ln/channel.rs
Outdated

@swilliamson5
Replace OUR_MAX_HTLCS constant with config knob
f656609
holder_max_accepted_htlcs. Set upper bound of 483
Writes an even TLV if the value isn't 50
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
fce8013 to
f656609CompareApril 16, 2023 23:29
@TheBlueMattTheBlueMatt
added this to the 0.0.115 milestone
Apr 17, 2023
arik-so
arik-so
approved these changes
Apr 17, 2023
View reviewed changes
@arik-soarik-so
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
@TheBlueMatt
TheBlueMatt
merged commit 2ebbe6f
into
lightningdevkit:mainApr 17, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@arik-soarik-soarik-so approved these changes

Assignees


No one assigned


Labels

Seeking Code Review

Projects


None yet


Milestone

0.0.115

Development

Successfully merging this pull request may close these issues.

Replace OUR_MAX_HTLCS constant with a config knob


4 participants

@swilliamson5@codecov-commenter@TheBlueMatt@arik-so

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Replace `OUR_MAX_HTLCS` with config knob by swilliamson5 · Pull Request #2138 · lightningdevkit/rust-lightning · GitHub
Skip to content
Replace OUR_MAX_HTLCS with config knob - #2138
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Apr 17, 2023
Merged
Replace OUR_MAX_HTLCS with config knob#2138
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Conversation
@swilliamson5
@swilliamson5swilliamson5
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add a config knob for holder_max_accepted_htlcs to replace the constant OUR_MAX_HTLCS.
resolves#1990
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knob[DRAFT] Replace OUR_MAX_HTLCS with config knobMar 30, 2023
TheBlueMatt
TheBlueMatt
reviewed
Mar 30, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a config knob in ChannelHandshakeConfig in config.rs.
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

swilliamson5
swilliamson5
commented
Mar 30, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Apr 3, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/util/config.rs
@codecov-commenter
codecov-commenter
commented
Apr 8, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 94.11% and project coverage change: -0.03⚠️
Comparison is base (e1e3819) 91.35% compared to head (604eb91) 91.33%.
❗ Current head 604eb91 differs from pull request most recent head f656609. Consider uploading reports for the commit f656609 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2138 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.03% 
==========================================
Files 102 102 Lines 50382 50389 +7 Branches 50382 50389 +7 ==========================================
- Hits 46027 46021 -6 - Misses 4355 4368 +13 
Impacted FilesCoverage Δ
lightning/src/util/config.rs40.00% <0.00%> (-0.63%)⬇️
lightning/src/ln/channel.rs90.16% <100.00%> (+0.01%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TheBlueMatt
TheBlueMatt
commented
Apr 12, 2023

Copy link


Copy Markdown

Collaborator
Still needs more docs on the knob ( #2138 (comment) ) but the code looks good to me! When you do address that, feel free to rebase and squash so that its a clean set of non-merge commits based on upstream (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes for how to).
@TheBlueMattTheBlueMatt
mentioned this pull request
Apr 12, 2023
 Merged

@TheBlueMatt
TheBlueMatt
commented
Apr 13, 2023

Copy link


Copy Markdown

Collaborator
Probably can mark this non-draft too, when you get there :)
@swilliamson5swilliamson5
changed the title
[DRAFT] Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
@swilliamson5
swilliamson5
marked this pull request as ready for review
April 15, 2023 00:24
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
54ca4fa to
09b9a19CompareApril 15, 2023 01:31
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
09b9a19 to
f8deb84CompareApril 15, 2023 01:34
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
TheBlueMatt
TheBlueMatt
reviewed
Apr 16, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
c99da4c to
44ff074CompareApril 16, 2023 20:57
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
44ff074 to
fce8013CompareApril 16, 2023 21:56
TheBlueMatt
TheBlueMatt
previously approved these changes
Apr 16, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll get another reviewer on this Monday, thanks!
Comment threadlightning/src/ln/channel.rs
Outdated

@swilliamson5
Replace OUR_MAX_HTLCS constant with config knob
f656609
holder_max_accepted_htlcs. Set upper bound of 483
Writes an even TLV if the value isn't 50
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
fce8013 to
f656609CompareApril 16, 2023 23:29
@TheBlueMattTheBlueMatt
added this to the 0.0.115 milestone
Apr 17, 2023
arik-so
arik-so
approved these changes
Apr 17, 2023
View reviewed changes
@arik-soarik-so
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
@TheBlueMatt
TheBlueMatt
merged commit 2ebbe6f
into
lightningdevkit:mainApr 17, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@arik-soarik-soarik-so approved these changes

Assignees


No one assigned


Labels

Seeking Code Review

Projects


None yet


Milestone

0.0.115

Development

Successfully merging this pull request may close these issues.

Replace OUR_MAX_HTLCS constant with a config knob


4 participants

@swilliamson5@codecov-commenter@TheBlueMatt@arik-so

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Replace `OUR_MAX_HTLCS` with config knob by swilliamson5 · Pull Request #2138 · lightningdevkit/rust-lightning · GitHub
Skip to content
Replace OUR_MAX_HTLCS with config knob - #2138
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Apr 17, 2023
Merged
Replace OUR_MAX_HTLCS with config knob#2138
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
swilliamson5:replace-our-max-htlcs-constant
Conversation
@swilliamson5
@swilliamson5swilliamson5
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add a config knob for holder_max_accepted_htlcs to replace the constant OUR_MAX_HTLCS.
resolves#1990
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knob[DRAFT] Replace OUR_MAX_HTLCS with config knobMar 30, 2023
TheBlueMatt
TheBlueMatt
reviewed
Mar 30, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a config knob in ChannelHandshakeConfig in config.rs.
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

swilliamson5
swilliamson5
commented
Mar 30, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

TheBlueMatt
TheBlueMatt
reviewed
Apr 3, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/util/config.rs
@codecov-commenter
codecov-commenter
commented
Apr 8, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 94.11% and project coverage change: -0.03⚠️
Comparison is base (e1e3819) 91.35% compared to head (604eb91) 91.33%.
❗ Current head 604eb91 differs from pull request most recent head f656609. Consider uploading reports for the commit f656609 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2138 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.03% 
==========================================
Files 102 102 Lines 50382 50389 +7 Branches 50382 50389 +7 ==========================================
- Hits 46027 46021 -6 - Misses 4355 4368 +13 
Impacted FilesCoverage Δ
lightning/src/util/config.rs40.00% <0.00%> (-0.63%)⬇️
lightning/src/ln/channel.rs90.16% <100.00%> (+0.01%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TheBlueMatt
TheBlueMatt
commented
Apr 12, 2023

Copy link


Copy Markdown

Collaborator
Still needs more docs on the knob ( #2138 (comment) ) but the code looks good to me! When you do address that, feel free to rebase and squash so that its a clean set of non-merge commits based on upstream (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes for how to).
@TheBlueMattTheBlueMatt
mentioned this pull request
Apr 12, 2023
 Merged

@TheBlueMatt
TheBlueMatt
commented
Apr 13, 2023

Copy link


Copy Markdown

Collaborator
Probably can mark this non-draft too, when you get there :)
@swilliamson5swilliamson5
changed the title
[DRAFT] Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
@swilliamson5
swilliamson5
marked this pull request as ready for review
April 15, 2023 00:24
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
54ca4fa to
09b9a19CompareApril 15, 2023 01:31
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
09b9a19 to
f8deb84CompareApril 15, 2023 01:34
@swilliamson5swilliamson5
changed the title
Replace OUR_MAX_HTLCS with config knobReplace OUR_MAX_HTLCS with config knobApr 15, 2023
TheBlueMatt
TheBlueMatt
reviewed
Apr 16, 2023
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

Comment threadlightning/src/util/config.rs
Outdated

@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
2 times, most recently
from
c99da4c to
44ff074CompareApril 16, 2023 20:57
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
44ff074 to
fce8013CompareApril 16, 2023 21:56
TheBlueMatt
TheBlueMatt
previously approved these changes
Apr 16, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll get another reviewer on this Monday, thanks!
Comment threadlightning/src/ln/channel.rs
Outdated

@swilliamson5
Replace OUR_MAX_HTLCS constant with config knob
f656609
holder_max_accepted_htlcs. Set upper bound of 483
Writes an even TLV if the value isn't 50
@swilliamson5
swilliamson5force-pushed
the
replace-our-max-htlcs-constant
branch
from
fce8013 to
f656609CompareApril 16, 2023 23:29
@TheBlueMattTheBlueMatt
added this to the 0.0.115 milestone
Apr 17, 2023
arik-so
arik-so
approved these changes
Apr 17, 2023
View reviewed changes
@arik-soarik-so
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
@TheBlueMatt
TheBlueMatt
merged commit 2ebbe6f
into
lightningdevkit:mainApr 17, 2023
PXplod pushed a commit
to bitlightlabs/rust-lightning
that referenced
this pull request
Sep 30, 2024
@zoedberg
Merge tag 'v0.0.115' into 89b585b
6de8c4f
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
===========
* The MSRV of the main LDK crates has been increased to 1.48 (lightningdevkit#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (lightningdevkit#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (lightningdevkit#2139, lightningdevkit#2127).
* `Event::PaymentFailed` now exposes a failure reason (lightningdevkit#2142).
* BOLT12 messages now support stateless generation and validation (lightningdevkit#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (lightningdevkit#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (lightningdevkit#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (lightningdevkit#2085).
* A `ChannelPending` event is now emitted after the initial handshake (lightningdevkit#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (lightningdevkit#2136).
* `ChannelManager::list_channels_by_counterparty` was added (lightningdevkit#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (lightningdevkit#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (lightningdevkit#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (lightningdevkit#2206).
Backwards Compatibility
=======================
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (lightningdevkit#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (lightningdevkit#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (lightningdevkit#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (lightningdevkit#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
=========
* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (lightningdevkit#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (lightningdevkit#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (lightningdevkit#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (lightningdevkit#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (lightningdevkit#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (lightningdevkit#2090).
* Fix an issue where `process_events_async` would exit immediately (lightningdevkit#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (lightningdevkit#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (lightningdevkit#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (lightningdevkit#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (lightningdevkit#2220).
* Fixed a debug assertion which may panic under heavy load (lightningdevkit#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (lightningdevkit#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (lightningdevkit#2158).
Security
========
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (lightningdevkit#2203, lightningdevkit#2205, lightningdevkit#2208).
* Implemented the changes from BOLT PRs lightningdevkit#1031, lightningdevkit#1032, and lightningdevkit#1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (lightningdevkit#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@arik-soarik-soarik-so approved these changes

Assignees


No one assigned


Labels

Seeking Code Review

Projects


None yet


Milestone

0.0.115

Development

Successfully merging this pull request may close these issues.

Replace OUR_MAX_HTLCS constant with a config knob


4 participants

@swilliamson5@codecov-commenter@TheBlueMatt@arik-so