test(server): remove duplicate missing worktree test

[t3-code]

a standalone integration test only called removeWorktree for a path that had never existed and passed when the call did not fail. this removes that duplicate without changing production code.

why it was useless

• the remaining prunes stale registrations when removing an already-gone worktree test calls removeWorktree with a different never-registered, absent path. it requires the same no-op behavior and additionally proves the prune side effect.
• the remaining removes the same worktree path twice without failing test also reaches the already-gone path on its second removal.
• production selects this branch only when git reports a missing worktree and the target path does not exist, so the deleted case exercised no distinct condition.

verification

before deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 57 tests

after deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 56 tests
• ./node_modules/.bin/vp run --filter t3 typecheck passed, with existing ts377019 suggestion diagnostics
• ./node_modules/.bin/vp lint apps/server/src/vcs/GitVcsDriverCore.test.ts --report-unused-disable-directives passed
• ./node_modules/.bin/vp fmt --check apps/server/src/vcs/GitVcsDriverCore.test.ts passed
• git diff --check passed

generated by gpt-5.6-sol with hermes agent.

---

Note

Low Risk
Test-only deletion with no runtime code touched; remaining tests still exercise removeWorktree no-op paths.

Overview
Removes the treats removing an already-gone worktree as a no-op integration test from GitVcsDriverCore.test.ts. That case only called removeWorktree on a path that had never been registered and asserted the call did not throw.

No production or driver behavior changes—only test suite cleanup. Coverage for idempotent removal of absent worktrees remains via removes the same worktree path twice without failing (second call hits an already-gone path) and prunes stale registrations when removing an already-gone worktree (same no-op expectation plus stale registration pruning).

^{Reviewed by Cursor Bugbot for commit add029a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove duplicate missing worktree test from GitVcsDriver

Deletes the test that asserted removeWorktree on a non-existent path completes without error, in GitVcsDriverCore.test.ts. The test suite no longer covers that no-op scenario.

^{Macroscope summarized add029a.}

[macroscopeapp]

Approvability

Verdict: Approved at add029a

Macroscope's review found this PR approvable — This PR only removes one duplicate server integration test and does not modify production code or customer-facing behavior. Its impact is limited to eliminating redundant test execution.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−5 B (−0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	−4 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−1 B (−0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−23 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	+7 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−30 B (−0.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	11	10	−1 (−9.1%)	21	✅

Baseline: b0a0281 · PR result: add029a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[t3-code]

a standalone integration test only called removeWorktree for a path that had never existed and passed when the call did not fail. this removes that duplicate without changing production code.

why it was useless

• the remaining prunes stale registrations when removing an already-gone worktree test calls removeWorktree with a different never-registered, absent path. it requires the same no-op behavior and additionally proves the prune side effect.
• the remaining removes the same worktree path twice without failing test also reaches the already-gone path on its second removal.
• production selects this branch only when git reports a missing worktree and the target path does not exist, so the deleted case exercised no distinct condition.

verification

before deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 57 tests

after deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 56 tests
• ./node_modules/.bin/vp run --filter t3 typecheck passed, with existing ts377019 suggestion diagnostics
• ./node_modules/.bin/vp lint apps/server/src/vcs/GitVcsDriverCore.test.ts --report-unused-disable-directives passed
• ./node_modules/.bin/vp fmt --check apps/server/src/vcs/GitVcsDriverCore.test.ts passed
• git diff --check passed

generated by gpt-5.6-sol with hermes agent.

---

Note

Low Risk
Test-only deletion with no runtime code touched; remaining tests still exercise removeWorktree no-op paths.

Overview
Removes the treats removing an already-gone worktree as a no-op integration test from GitVcsDriverCore.test.ts. That case only called removeWorktree on a path that had never been registered and asserted the call did not throw.

No production or driver behavior changes—only test suite cleanup. Coverage for idempotent removal of absent worktrees remains via removes the same worktree path twice without failing (second call hits an already-gone path) and prunes stale registrations when removing an already-gone worktree (same no-op expectation plus stale registration pruning).

^{Reviewed by Cursor Bugbot for commit add029a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove duplicate missing worktree test from GitVcsDriver

Deletes the test that asserted removeWorktree on a non-existent path completes without error, in GitVcsDriverCore.test.ts. The test suite no longer covers that no-op scenario.

^{Macroscope summarized add029a.}

[macroscopeapp]

Approvability

Verdict: Approved at add029a

Macroscope's review found this PR approvable — This PR only removes one duplicate server integration test and does not modify production code or customer-facing behavior. Its impact is limited to eliminating redundant test execution.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−5 B (−0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	−4 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−1 B (−0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−23 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	+7 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−30 B (−0.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	11	10	−1 (−9.1%)	21	✅

Baseline: b0a0281 · PR result: add029a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[t3-code]

a standalone integration test only called removeWorktree for a path that had never existed and passed when the call did not fail. this removes that duplicate without changing production code.

why it was useless

• the remaining prunes stale registrations when removing an already-gone worktree test calls removeWorktree with a different never-registered, absent path. it requires the same no-op behavior and additionally proves the prune side effect.
• the remaining removes the same worktree path twice without failing test also reaches the already-gone path on its second removal.
• production selects this branch only when git reports a missing worktree and the target path does not exist, so the deleted case exercised no distinct condition.

verification

before deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 57 tests

after deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 56 tests
• ./node_modules/.bin/vp run --filter t3 typecheck passed, with existing ts377019 suggestion diagnostics
• ./node_modules/.bin/vp lint apps/server/src/vcs/GitVcsDriverCore.test.ts --report-unused-disable-directives passed
• ./node_modules/.bin/vp fmt --check apps/server/src/vcs/GitVcsDriverCore.test.ts passed
• git diff --check passed

generated by gpt-5.6-sol with hermes agent.

---

Note

Low Risk
Test-only deletion with no runtime code touched; remaining tests still exercise removeWorktree no-op paths.

Overview
Removes the treats removing an already-gone worktree as a no-op integration test from GitVcsDriverCore.test.ts. That case only called removeWorktree on a path that had never been registered and asserted the call did not throw.

No production or driver behavior changes—only test suite cleanup. Coverage for idempotent removal of absent worktrees remains via removes the same worktree path twice without failing (second call hits an already-gone path) and prunes stale registrations when removing an already-gone worktree (same no-op expectation plus stale registration pruning).

^{Reviewed by Cursor Bugbot for commit add029a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove duplicate missing worktree test from GitVcsDriver

Deletes the test that asserted removeWorktree on a non-existent path completes without error, in GitVcsDriverCore.test.ts. The test suite no longer covers that no-op scenario.

^{Macroscope summarized add029a.}

[macroscopeapp]

Approvability

Verdict: Approved at add029a

Macroscope's review found this PR approvable — This PR only removes one duplicate server integration test and does not modify production code or customer-facing behavior. Its impact is limited to eliminating redundant test execution.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−5 B (−0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	−4 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−1 B (−0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−23 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	+7 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−30 B (−0.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	11	10	−1 (−9.1%)	21	✅

Baseline: b0a0281 · PR result: add029a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[t3-code]

a standalone integration test only called removeWorktree for a path that had never existed and passed when the call did not fail. this removes that duplicate without changing production code.

why it was useless

• the remaining prunes stale registrations when removing an already-gone worktree test calls removeWorktree with a different never-registered, absent path. it requires the same no-op behavior and additionally proves the prune side effect.
• the remaining removes the same worktree path twice without failing test also reaches the already-gone path on its second removal.
• production selects this branch only when git reports a missing worktree and the target path does not exist, so the deleted case exercised no distinct condition.

verification

before deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 57 tests

after deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 56 tests
• ./node_modules/.bin/vp run --filter t3 typecheck passed, with existing ts377019 suggestion diagnostics
• ./node_modules/.bin/vp lint apps/server/src/vcs/GitVcsDriverCore.test.ts --report-unused-disable-directives passed
• ./node_modules/.bin/vp fmt --check apps/server/src/vcs/GitVcsDriverCore.test.ts passed
• git diff --check passed

generated by gpt-5.6-sol with hermes agent.

---

Note

Low Risk
Test-only deletion with no runtime code touched; remaining tests still exercise removeWorktree no-op paths.

Overview
Removes the treats removing an already-gone worktree as a no-op integration test from GitVcsDriverCore.test.ts. That case only called removeWorktree on a path that had never been registered and asserted the call did not throw.

No production or driver behavior changes—only test suite cleanup. Coverage for idempotent removal of absent worktrees remains via removes the same worktree path twice without failing (second call hits an already-gone path) and prunes stale registrations when removing an already-gone worktree (same no-op expectation plus stale registration pruning).

^{Reviewed by Cursor Bugbot for commit add029a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove duplicate missing worktree test from GitVcsDriver

Deletes the test that asserted removeWorktree on a non-existent path completes without error, in GitVcsDriverCore.test.ts. The test suite no longer covers that no-op scenario.

^{Macroscope summarized add029a.}

[macroscopeapp]

Approvability

Verdict: Approved at add029a

Macroscope's review found this PR approvable — This PR only removes one duplicate server integration test and does not modify production code or customer-facing behavior. Its impact is limited to eliminating redundant test execution.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−5 B (−0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	−4 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−1 B (−0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−23 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	+7 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−30 B (−0.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	11	10	−1 (−9.1%)	21	✅

Baseline: b0a0281 · PR result: add029a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[t3-code]

a standalone integration test only called removeWorktree for a path that had never existed and passed when the call did not fail. this removes that duplicate without changing production code.

why it was useless

• the remaining prunes stale registrations when removing an already-gone worktree test calls removeWorktree with a different never-registered, absent path. it requires the same no-op behavior and additionally proves the prune side effect.
• the remaining removes the same worktree path twice without failing test also reaches the already-gone path on its second removal.
• production selects this branch only when git reports a missing worktree and the target path does not exist, so the deleted case exercised no distinct condition.

verification

before deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 57 tests

after deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 56 tests
• ./node_modules/.bin/vp run --filter t3 typecheck passed, with existing ts377019 suggestion diagnostics
• ./node_modules/.bin/vp lint apps/server/src/vcs/GitVcsDriverCore.test.ts --report-unused-disable-directives passed
• ./node_modules/.bin/vp fmt --check apps/server/src/vcs/GitVcsDriverCore.test.ts passed
• git diff --check passed

generated by gpt-5.6-sol with hermes agent.

---

Note

Low Risk
Test-only deletion with no runtime code touched; remaining tests still exercise removeWorktree no-op paths.

Overview
Removes the treats removing an already-gone worktree as a no-op integration test from GitVcsDriverCore.test.ts. That case only called removeWorktree on a path that had never been registered and asserted the call did not throw.

No production or driver behavior changes—only test suite cleanup. Coverage for idempotent removal of absent worktrees remains via removes the same worktree path twice without failing (second call hits an already-gone path) and prunes stale registrations when removing an already-gone worktree (same no-op expectation plus stale registration pruning).

^{Reviewed by Cursor Bugbot for commit add029a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove duplicate missing worktree test from GitVcsDriver

Deletes the test that asserted removeWorktree on a non-existent path completes without error, in GitVcsDriverCore.test.ts. The test suite no longer covers that no-op scenario.

^{Macroscope summarized add029a.}

[macroscopeapp]

Approvability

Verdict: Approved at add029a

Macroscope's review found this PR approvable — This PR only removes one duplicate server integration test and does not modify production code or customer-facing behavior. Its impact is limited to eliminating redundant test execution.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−5 B (−0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	−4 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−1 B (−0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−23 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	+7 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−30 B (−0.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	11	10	−1 (−9.1%)	21	✅

Baseline: b0a0281 · PR result: add029a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[t3-code]

a standalone integration test only called removeWorktree for a path that had never existed and passed when the call did not fail. this removes that duplicate without changing production code.

why it was useless

• the remaining prunes stale registrations when removing an already-gone worktree test calls removeWorktree with a different never-registered, absent path. it requires the same no-op behavior and additionally proves the prune side effect.
• the remaining removes the same worktree path twice without failing test also reaches the already-gone path on its second removal.
• production selects this branch only when git reports a missing worktree and the target path does not exist, so the deleted case exercised no distinct condition.

verification

before deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 57 tests

after deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 56 tests
• ./node_modules/.bin/vp run --filter t3 typecheck passed, with existing ts377019 suggestion diagnostics
• ./node_modules/.bin/vp lint apps/server/src/vcs/GitVcsDriverCore.test.ts --report-unused-disable-directives passed
• ./node_modules/.bin/vp fmt --check apps/server/src/vcs/GitVcsDriverCore.test.ts passed
• git diff --check passed

generated by gpt-5.6-sol with hermes agent.

---

Note

Low Risk
Test-only deletion with no runtime code touched; remaining tests still exercise removeWorktree no-op paths.

Overview
Removes the treats removing an already-gone worktree as a no-op integration test from GitVcsDriverCore.test.ts. That case only called removeWorktree on a path that had never been registered and asserted the call did not throw.

No production or driver behavior changes—only test suite cleanup. Coverage for idempotent removal of absent worktrees remains via removes the same worktree path twice without failing (second call hits an already-gone path) and prunes stale registrations when removing an already-gone worktree (same no-op expectation plus stale registration pruning).

^{Reviewed by Cursor Bugbot for commit add029a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove duplicate missing worktree test from GitVcsDriver

Deletes the test that asserted removeWorktree on a non-existent path completes without error, in GitVcsDriverCore.test.ts. The test suite no longer covers that no-op scenario.

^{Macroscope summarized add029a.}

[macroscopeapp]

Approvability

Verdict: Approved at add029a

Macroscope's review found this PR approvable — This PR only removes one duplicate server integration test and does not modify production code or customer-facing behavior. Its impact is limited to eliminating redundant test execution.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−5 B (−0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	−4 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−1 B (−0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−23 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	+7 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−30 B (−0.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	11	10	−1 (−9.1%)	21	✅

Baseline: b0a0281 · PR result: add029a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[t3-code]

a standalone integration test only called removeWorktree for a path that had never existed and passed when the call did not fail. this removes that duplicate without changing production code.

why it was useless

• the remaining prunes stale registrations when removing an already-gone worktree test calls removeWorktree with a different never-registered, absent path. it requires the same no-op behavior and additionally proves the prune side effect.
• the remaining removes the same worktree path twice without failing test also reaches the already-gone path on its second removal.
• production selects this branch only when git reports a missing worktree and the target path does not exist, so the deleted case exercised no distinct condition.

verification

before deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 57 tests

after deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 56 tests
• ./node_modules/.bin/vp run --filter t3 typecheck passed, with existing ts377019 suggestion diagnostics
• ./node_modules/.bin/vp lint apps/server/src/vcs/GitVcsDriverCore.test.ts --report-unused-disable-directives passed
• ./node_modules/.bin/vp fmt --check apps/server/src/vcs/GitVcsDriverCore.test.ts passed
• git diff --check passed

generated by gpt-5.6-sol with hermes agent.

---

Note

Low Risk
Test-only deletion with no runtime code touched; remaining tests still exercise removeWorktree no-op paths.

Overview
Removes the treats removing an already-gone worktree as a no-op integration test from GitVcsDriverCore.test.ts. That case only called removeWorktree on a path that had never been registered and asserted the call did not throw.

No production or driver behavior changes—only test suite cleanup. Coverage for idempotent removal of absent worktrees remains via removes the same worktree path twice without failing (second call hits an already-gone path) and prunes stale registrations when removing an already-gone worktree (same no-op expectation plus stale registration pruning).

^{Reviewed by Cursor Bugbot for commit add029a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove duplicate missing worktree test from GitVcsDriver

Deletes the test that asserted removeWorktree on a non-existent path completes without error, in GitVcsDriverCore.test.ts. The test suite no longer covers that no-op scenario.

^{Macroscope summarized add029a.}

[macroscopeapp]

Approvability

Verdict: Approved at add029a

Macroscope's review found this PR approvable — This PR only removes one duplicate server integration test and does not modify production code or customer-facing behavior. Its impact is limited to eliminating redundant test execution.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−5 B (−0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	−4 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−1 B (−0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−23 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	+7 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−30 B (−0.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	11	10	−1 (−9.1%)	21	✅

Baseline: b0a0281 · PR result: add029a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[t3-code]

a standalone integration test only called removeWorktree for a path that had never existed and passed when the call did not fail. this removes that duplicate without changing production code.

why it was useless

• the remaining prunes stale registrations when removing an already-gone worktree test calls removeWorktree with a different never-registered, absent path. it requires the same no-op behavior and additionally proves the prune side effect.
• the remaining removes the same worktree path twice without failing test also reaches the already-gone path on its second removal.
• production selects this branch only when git reports a missing worktree and the target path does not exist, so the deleted case exercised no distinct condition.

verification

before deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 57 tests

after deletion:

• ./node_modules/.bin/vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts passed, 56 tests
• ./node_modules/.bin/vp run --filter t3 typecheck passed, with existing ts377019 suggestion diagnostics
• ./node_modules/.bin/vp lint apps/server/src/vcs/GitVcsDriverCore.test.ts --report-unused-disable-directives passed
• ./node_modules/.bin/vp fmt --check apps/server/src/vcs/GitVcsDriverCore.test.ts passed
• git diff --check passed

generated by gpt-5.6-sol with hermes agent.

---

Note

Low Risk
Test-only deletion with no runtime code touched; remaining tests still exercise removeWorktree no-op paths.

Overview
Removes the treats removing an already-gone worktree as a no-op integration test from GitVcsDriverCore.test.ts. That case only called removeWorktree on a path that had never been registered and asserted the call did not throw.

No production or driver behavior changes—only test suite cleanup. Coverage for idempotent removal of absent worktrees remains via removes the same worktree path twice without failing (second call hits an already-gone path) and prunes stale registrations when removing an already-gone worktree (same no-op expectation plus stale registration pruning).

^{Reviewed by Cursor Bugbot for commit add029a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove duplicate missing worktree test from GitVcsDriver

Deletes the test that asserted removeWorktree on a non-existent path completes without error, in GitVcsDriverCore.test.ts. The test suite no longer covers that no-op scenario.

^{Macroscope summarized add029a.}

[macroscopeapp]

Approvability

Verdict: Approved at add029a

Macroscope's review found this PR approvable — This PR only removes one duplicate server integration test and does not modify production code or customer-facing behavior. Its impact is limited to eliminating redundant test execution.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−5 B (−0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	−4 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−1 B (−0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−23 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	+7 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−30 B (−0.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	11	10	−1 (−9.1%)	21	✅

Baseline: b0a0281 · PR result: add029a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.