Merge master into release 2.1 by mhegazy · Pull Request #12160 · microsoft/TypeScript

Mohamed Hegazy (mhegazy) · 2016-11-10T23:32:22Z

No description provided.

… string keys (which it did before too)

switch was missing the rule for converting literal types to the literal base type if needed.

Since all callers need this check -- it's how equality is supposed to work everywhere.

There are more literal types in error messages because error reporting no longer has the advantage of calls to getBaseLiteralType

…moduleNameResolver responsible for omitting files based on compiler options

… avoid using resolution.resolvedFileName if the diagnostic is defined.

…e` and `resolvedJsFileName` optional properties (but still automatically infer one of them to supply if the host supplied neither)

…ue in the program

Object rest

Fix comparable in switch

Object spread/rest

Fixes issue #12050

Support for --jsxFactory option

Report all the js file errors and skip only the nodes that are not allowed in JS file

Previously it crashed in the binder.

…s-for-__rest Import helpers reports errors for __rest

* add es2017.string.d.ts for String.prototype.{padStart,padEnd} * append es2017.string.d.ts into es2017.d.ts * add es2017.string into commandLineParser * append es2017.string into error message for unit tests of commandLineParser * append es2017.string into Gulpfile * append es2017.string into Jakefile

…mentOfIdenticallyNamedTypes Adds error message for incompatible assignment of identically named type

…12118) * Exclude js files in non-configured projects CoS emitting * remove unnecessary method

* Update LKG * Update version * Update LKG * Skip overloads with too-short function parameters If the parameter of an overload is a function and the argument is also a function, skip the overload if the parameter has fewer arguments than the argument does. That overload cannot possibly apply, and should not participate in, for example, contextual typing. Example: ```ts interface I { (a: number): void; (b: string, c): void; } declare function f(i: I): void; f((x, y) => {}); ``` This code now skips the first overload instead of considering. This was a longstanding bug but was only uncovered now that more functions expressions are context sensitive. * Test skip overloads w/too-short function params 1. Update changed baseline. 2. Add a new test with baseline. * Minor style improvements * Ignore optionality when skipping overloads * Do not use contextual signatures with too few parameters * isAritySmaller runs later: getNonGenericSignature * rewrite void-returning statements in constructors that capture result of super call (#11868) * rewrite void-returning statements in constructors that capture result of super call * linter * Update LKG * Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters * Add tests and baselines * Skip trying to use alias if there is target type * Update baselines * Add diagnostics to remind adding tsconfig file for certain external project (#11932) * Add diagnostics for certain external project * Show tsconfig suggestion * fix lint error * Address pr * fix comment * Update error message * Flag for not overwrite js files by default without generating errors (#11980) * WIP * Properly naming things * refactor * apply the option to all files and check out options * Fix typo * Update LKG * lockLinter * use local registry to check if typings package exist (#12014) (#12032) use local registry to check if typings package exist * Add test for #11980 (#12027) * add test for the fix for overwrite emitting error * cr feedback * enable sending telemetry events to tsserver client (#12034) (#12051) enable sending telemetry events * Update LKG * Reuse subtree transform flags for incrementally parsed nodes (#12088) * Update LKG * Update version * Update LKG * Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module * Add tests and baselines * [Release 2.1] fix11754 global augmentation (#12133) * Exclude global augmentation from module resolution logic * Address PR: check using string literal instead of NodeFlags.globalAugmentation * Remove comment

Mohamed Hegazy (mhegazy) · 2016-11-10T23:32:22Z

No description provided.

… string keys (which it did before too)

switch was missing the rule for converting literal types to the literal base type if needed.

Since all callers need this check -- it's how equality is supposed to work everywhere.

There are more literal types in error messages because error reporting no longer has the advantage of calls to getBaseLiteralType

…moduleNameResolver responsible for omitting files based on compiler options

… avoid using resolution.resolvedFileName if the diagnostic is defined.

…e` and `resolvedJsFileName` optional properties (but still automatically infer one of them to supply if the host supplied neither)

…ue in the program

Object rest

Fix comparable in switch

Object spread/rest

Fixes issue #12050

Support for --jsxFactory option

Report all the js file errors and skip only the nodes that are not allowed in JS file

Previously it crashed in the binder.

…s-for-__rest Import helpers reports errors for __rest

* add es2017.string.d.ts for String.prototype.{padStart,padEnd} * append es2017.string.d.ts into es2017.d.ts * add es2017.string into commandLineParser * append es2017.string into error message for unit tests of commandLineParser * append es2017.string into Gulpfile * append es2017.string into Jakefile

…mentOfIdenticallyNamedTypes Adds error message for incompatible assignment of identically named type

…12118) * Exclude js files in non-configured projects CoS emitting * remove unnecessary method

* Update LKG * Update version * Update LKG * Skip overloads with too-short function parameters If the parameter of an overload is a function and the argument is also a function, skip the overload if the parameter has fewer arguments than the argument does. That overload cannot possibly apply, and should not participate in, for example, contextual typing. Example: ```ts interface I { (a: number): void; (b: string, c): void; } declare function f(i: I): void; f((x, y) => {}); ``` This code now skips the first overload instead of considering. This was a longstanding bug but was only uncovered now that more functions expressions are context sensitive. * Test skip overloads w/too-short function params 1. Update changed baseline. 2. Add a new test with baseline. * Minor style improvements * Ignore optionality when skipping overloads * Do not use contextual signatures with too few parameters * isAritySmaller runs later: getNonGenericSignature * rewrite void-returning statements in constructors that capture result of super call (#11868) * rewrite void-returning statements in constructors that capture result of super call * linter * Update LKG * Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters * Add tests and baselines * Skip trying to use alias if there is target type * Update baselines * Add diagnostics to remind adding tsconfig file for certain external project (#11932) * Add diagnostics for certain external project * Show tsconfig suggestion * fix lint error * Address pr * fix comment * Update error message * Flag for not overwrite js files by default without generating errors (#11980) * WIP * Properly naming things * refactor * apply the option to all files and check out options * Fix typo * Update LKG * lockLinter * use local registry to check if typings package exist (#12014) (#12032) use local registry to check if typings package exist * Add test for #11980 (#12027) * add test for the fix for overwrite emitting error * cr feedback * enable sending telemetry events to tsserver client (#12034) (#12051) enable sending telemetry events * Update LKG * Reuse subtree transform flags for incrementally parsed nodes (#12088) * Update LKG * Update version * Update LKG * Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module * Add tests and baselines * [Release 2.1] fix11754 global augmentation (#12133) * Exclude global augmentation from module resolution logic * Address PR: check using string literal instead of NodeFlags.globalAugmentation * Remove comment

Mohamed Hegazy (mhegazy) · 2016-11-10T23:32:22Z

No description provided.

… string keys (which it did before too)

switch was missing the rule for converting literal types to the literal base type if needed.

Since all callers need this check -- it's how equality is supposed to work everywhere.

There are more literal types in error messages because error reporting no longer has the advantage of calls to getBaseLiteralType

…moduleNameResolver responsible for omitting files based on compiler options

… avoid using resolution.resolvedFileName if the diagnostic is defined.

…e` and `resolvedJsFileName` optional properties (but still automatically infer one of them to supply if the host supplied neither)

…ue in the program

Object rest

Fix comparable in switch

Object spread/rest

Fixes issue #12050

Support for --jsxFactory option

Report all the js file errors and skip only the nodes that are not allowed in JS file

Previously it crashed in the binder.

…s-for-__rest Import helpers reports errors for __rest

* add es2017.string.d.ts for String.prototype.{padStart,padEnd} * append es2017.string.d.ts into es2017.d.ts * add es2017.string into commandLineParser * append es2017.string into error message for unit tests of commandLineParser * append es2017.string into Gulpfile * append es2017.string into Jakefile

…mentOfIdenticallyNamedTypes Adds error message for incompatible assignment of identically named type

…12118) * Exclude js files in non-configured projects CoS emitting * remove unnecessary method

* Update LKG * Update version * Update LKG * Skip overloads with too-short function parameters If the parameter of an overload is a function and the argument is also a function, skip the overload if the parameter has fewer arguments than the argument does. That overload cannot possibly apply, and should not participate in, for example, contextual typing. Example: ```ts interface I { (a: number): void; (b: string, c): void; } declare function f(i: I): void; f((x, y) => {}); ``` This code now skips the first overload instead of considering. This was a longstanding bug but was only uncovered now that more functions expressions are context sensitive. * Test skip overloads w/too-short function params 1. Update changed baseline. 2. Add a new test with baseline. * Minor style improvements * Ignore optionality when skipping overloads * Do not use contextual signatures with too few parameters * isAritySmaller runs later: getNonGenericSignature * rewrite void-returning statements in constructors that capture result of super call (#11868) * rewrite void-returning statements in constructors that capture result of super call * linter * Update LKG * Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters * Add tests and baselines * Skip trying to use alias if there is target type * Update baselines * Add diagnostics to remind adding tsconfig file for certain external project (#11932) * Add diagnostics for certain external project * Show tsconfig suggestion * fix lint error * Address pr * fix comment * Update error message * Flag for not overwrite js files by default without generating errors (#11980) * WIP * Properly naming things * refactor * apply the option to all files and check out options * Fix typo * Update LKG * lockLinter * use local registry to check if typings package exist (#12014) (#12032) use local registry to check if typings package exist * Add test for #11980 (#12027) * add test for the fix for overwrite emitting error * cr feedback * enable sending telemetry events to tsserver client (#12034) (#12051) enable sending telemetry events * Update LKG * Reuse subtree transform flags for incrementally parsed nodes (#12088) * Update LKG * Update version * Update LKG * Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module * Add tests and baselines * [Release 2.1] fix11754 global augmentation (#12133) * Exclude global augmentation from module resolution logic * Address PR: check using string literal instead of NodeFlags.globalAugmentation * Remove comment

Mohamed Hegazy (mhegazy) · 2016-11-10T23:32:22Z

No description provided.

… string keys (which it did before too)

switch was missing the rule for converting literal types to the literal base type if needed.

Since all callers need this check -- it's how equality is supposed to work everywhere.

There are more literal types in error messages because error reporting no longer has the advantage of calls to getBaseLiteralType

…moduleNameResolver responsible for omitting files based on compiler options

… avoid using resolution.resolvedFileName if the diagnostic is defined.

…e` and `resolvedJsFileName` optional properties (but still automatically infer one of them to supply if the host supplied neither)

…ue in the program

Object rest

Fix comparable in switch

Object spread/rest

Fixes issue #12050

Support for --jsxFactory option

Report all the js file errors and skip only the nodes that are not allowed in JS file

Previously it crashed in the binder.

…s-for-__rest Import helpers reports errors for __rest

* add es2017.string.d.ts for String.prototype.{padStart,padEnd} * append es2017.string.d.ts into es2017.d.ts * add es2017.string into commandLineParser * append es2017.string into error message for unit tests of commandLineParser * append es2017.string into Gulpfile * append es2017.string into Jakefile

…mentOfIdenticallyNamedTypes Adds error message for incompatible assignment of identically named type

…12118) * Exclude js files in non-configured projects CoS emitting * remove unnecessary method

* Update LKG * Update version * Update LKG * Skip overloads with too-short function parameters If the parameter of an overload is a function and the argument is also a function, skip the overload if the parameter has fewer arguments than the argument does. That overload cannot possibly apply, and should not participate in, for example, contextual typing. Example: ```ts interface I { (a: number): void; (b: string, c): void; } declare function f(i: I): void; f((x, y) => {}); ``` This code now skips the first overload instead of considering. This was a longstanding bug but was only uncovered now that more functions expressions are context sensitive. * Test skip overloads w/too-short function params 1. Update changed baseline. 2. Add a new test with baseline. * Minor style improvements * Ignore optionality when skipping overloads * Do not use contextual signatures with too few parameters * isAritySmaller runs later: getNonGenericSignature * rewrite void-returning statements in constructors that capture result of super call (#11868) * rewrite void-returning statements in constructors that capture result of super call * linter * Update LKG * Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters * Add tests and baselines * Skip trying to use alias if there is target type * Update baselines * Add diagnostics to remind adding tsconfig file for certain external project (#11932) * Add diagnostics for certain external project * Show tsconfig suggestion * fix lint error * Address pr * fix comment * Update error message * Flag for not overwrite js files by default without generating errors (#11980) * WIP * Properly naming things * refactor * apply the option to all files and check out options * Fix typo * Update LKG * lockLinter * use local registry to check if typings package exist (#12014) (#12032) use local registry to check if typings package exist * Add test for #11980 (#12027) * add test for the fix for overwrite emitting error * cr feedback * enable sending telemetry events to tsserver client (#12034) (#12051) enable sending telemetry events * Update LKG * Reuse subtree transform flags for incrementally parsed nodes (#12088) * Update LKG * Update version * Update LKG * Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module * Add tests and baselines * [Release 2.1] fix11754 global augmentation (#12133) * Exclude global augmentation from module resolution logic * Address PR: check using string literal instead of NodeFlags.globalAugmentation * Remove comment

Mohamed Hegazy (mhegazy) · 2016-11-10T23:32:22Z

No description provided.

… string keys (which it did before too)

switch was missing the rule for converting literal types to the literal base type if needed.

Since all callers need this check -- it's how equality is supposed to work everywhere.

There are more literal types in error messages because error reporting no longer has the advantage of calls to getBaseLiteralType

…moduleNameResolver responsible for omitting files based on compiler options

… avoid using resolution.resolvedFileName if the diagnostic is defined.

…e` and `resolvedJsFileName` optional properties (but still automatically infer one of them to supply if the host supplied neither)

…ue in the program

Object rest

Fix comparable in switch

Object spread/rest

Fixes issue #12050

Support for --jsxFactory option

Report all the js file errors and skip only the nodes that are not allowed in JS file

Previously it crashed in the binder.

…s-for-__rest Import helpers reports errors for __rest

* add es2017.string.d.ts for String.prototype.{padStart,padEnd} * append es2017.string.d.ts into es2017.d.ts * add es2017.string into commandLineParser * append es2017.string into error message for unit tests of commandLineParser * append es2017.string into Gulpfile * append es2017.string into Jakefile

…mentOfIdenticallyNamedTypes Adds error message for incompatible assignment of identically named type

…12118) * Exclude js files in non-configured projects CoS emitting * remove unnecessary method

* Update LKG * Update version * Update LKG * Skip overloads with too-short function parameters If the parameter of an overload is a function and the argument is also a function, skip the overload if the parameter has fewer arguments than the argument does. That overload cannot possibly apply, and should not participate in, for example, contextual typing. Example: ```ts interface I { (a: number): void; (b: string, c): void; } declare function f(i: I): void; f((x, y) => {}); ``` This code now skips the first overload instead of considering. This was a longstanding bug but was only uncovered now that more functions expressions are context sensitive. * Test skip overloads w/too-short function params 1. Update changed baseline. 2. Add a new test with baseline. * Minor style improvements * Ignore optionality when skipping overloads * Do not use contextual signatures with too few parameters * isAritySmaller runs later: getNonGenericSignature * rewrite void-returning statements in constructors that capture result of super call (#11868) * rewrite void-returning statements in constructors that capture result of super call * linter * Update LKG * Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters * Add tests and baselines * Skip trying to use alias if there is target type * Update baselines * Add diagnostics to remind adding tsconfig file for certain external project (#11932) * Add diagnostics for certain external project * Show tsconfig suggestion * fix lint error * Address pr * fix comment * Update error message * Flag for not overwrite js files by default without generating errors (#11980) * WIP * Properly naming things * refactor * apply the option to all files and check out options * Fix typo * Update LKG * lockLinter * use local registry to check if typings package exist (#12014) (#12032) use local registry to check if typings package exist * Add test for #11980 (#12027) * add test for the fix for overwrite emitting error * cr feedback * enable sending telemetry events to tsserver client (#12034) (#12051) enable sending telemetry events * Update LKG * Reuse subtree transform flags for incrementally parsed nodes (#12088) * Update LKG * Update version * Update LKG * Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module * Add tests and baselines * [Release 2.1] fix11754 global augmentation (#12133) * Exclude global augmentation from module resolution logic * Address PR: check using string literal instead of NodeFlags.globalAugmentation * Remove comment

Mohamed Hegazy (mhegazy) · 2016-11-10T23:32:22Z

No description provided.

… string keys (which it did before too)

switch was missing the rule for converting literal types to the literal base type if needed.

Since all callers need this check -- it's how equality is supposed to work everywhere.

There are more literal types in error messages because error reporting no longer has the advantage of calls to getBaseLiteralType

…moduleNameResolver responsible for omitting files based on compiler options

… avoid using resolution.resolvedFileName if the diagnostic is defined.

…e` and `resolvedJsFileName` optional properties (but still automatically infer one of them to supply if the host supplied neither)

…ue in the program

Object rest

Fix comparable in switch

Object spread/rest

Fixes issue #12050

Support for --jsxFactory option

Report all the js file errors and skip only the nodes that are not allowed in JS file

Previously it crashed in the binder.

…s-for-__rest Import helpers reports errors for __rest

* add es2017.string.d.ts for String.prototype.{padStart,padEnd} * append es2017.string.d.ts into es2017.d.ts * add es2017.string into commandLineParser * append es2017.string into error message for unit tests of commandLineParser * append es2017.string into Gulpfile * append es2017.string into Jakefile

…mentOfIdenticallyNamedTypes Adds error message for incompatible assignment of identically named type

…12118) * Exclude js files in non-configured projects CoS emitting * remove unnecessary method

* Update LKG * Update version * Update LKG * Skip overloads with too-short function parameters If the parameter of an overload is a function and the argument is also a function, skip the overload if the parameter has fewer arguments than the argument does. That overload cannot possibly apply, and should not participate in, for example, contextual typing. Example: ```ts interface I { (a: number): void; (b: string, c): void; } declare function f(i: I): void; f((x, y) => {}); ``` This code now skips the first overload instead of considering. This was a longstanding bug but was only uncovered now that more functions expressions are context sensitive. * Test skip overloads w/too-short function params 1. Update changed baseline. 2. Add a new test with baseline. * Minor style improvements * Ignore optionality when skipping overloads * Do not use contextual signatures with too few parameters * isAritySmaller runs later: getNonGenericSignature * rewrite void-returning statements in constructors that capture result of super call (#11868) * rewrite void-returning statements in constructors that capture result of super call * linter * Update LKG * Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters * Add tests and baselines * Skip trying to use alias if there is target type * Update baselines * Add diagnostics to remind adding tsconfig file for certain external project (#11932) * Add diagnostics for certain external project * Show tsconfig suggestion * fix lint error * Address pr * fix comment * Update error message * Flag for not overwrite js files by default without generating errors (#11980) * WIP * Properly naming things * refactor * apply the option to all files and check out options * Fix typo * Update LKG * lockLinter * use local registry to check if typings package exist (#12014) (#12032) use local registry to check if typings package exist * Add test for #11980 (#12027) * add test for the fix for overwrite emitting error * cr feedback * enable sending telemetry events to tsserver client (#12034) (#12051) enable sending telemetry events * Update LKG * Reuse subtree transform flags for incrementally parsed nodes (#12088) * Update LKG * Update version * Update LKG * Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module * Add tests and baselines * [Release 2.1] fix11754 global augmentation (#12133) * Exclude global augmentation from module resolution logic * Address PR: check using string literal instead of NodeFlags.globalAugmentation * Remove comment

Mohamed Hegazy (mhegazy) · 2016-11-10T23:32:22Z

No description provided.

… string keys (which it did before too)

switch was missing the rule for converting literal types to the literal base type if needed.

Since all callers need this check -- it's how equality is supposed to work everywhere.

There are more literal types in error messages because error reporting no longer has the advantage of calls to getBaseLiteralType

…moduleNameResolver responsible for omitting files based on compiler options

… avoid using resolution.resolvedFileName if the diagnostic is defined.

…e` and `resolvedJsFileName` optional properties (but still automatically infer one of them to supply if the host supplied neither)

…ue in the program

Object rest

Fix comparable in switch

Object spread/rest

Fixes issue #12050

Support for --jsxFactory option

Report all the js file errors and skip only the nodes that are not allowed in JS file

Previously it crashed in the binder.

…s-for-__rest Import helpers reports errors for __rest

* add es2017.string.d.ts for String.prototype.{padStart,padEnd} * append es2017.string.d.ts into es2017.d.ts * add es2017.string into commandLineParser * append es2017.string into error message for unit tests of commandLineParser * append es2017.string into Gulpfile * append es2017.string into Jakefile

…mentOfIdenticallyNamedTypes Adds error message for incompatible assignment of identically named type

…12118) * Exclude js files in non-configured projects CoS emitting * remove unnecessary method

* Update LKG * Update version * Update LKG * Skip overloads with too-short function parameters If the parameter of an overload is a function and the argument is also a function, skip the overload if the parameter has fewer arguments than the argument does. That overload cannot possibly apply, and should not participate in, for example, contextual typing. Example: ```ts interface I { (a: number): void; (b: string, c): void; } declare function f(i: I): void; f((x, y) => {}); ``` This code now skips the first overload instead of considering. This was a longstanding bug but was only uncovered now that more functions expressions are context sensitive. * Test skip overloads w/too-short function params 1. Update changed baseline. 2. Add a new test with baseline. * Minor style improvements * Ignore optionality when skipping overloads * Do not use contextual signatures with too few parameters * isAritySmaller runs later: getNonGenericSignature * rewrite void-returning statements in constructors that capture result of super call (#11868) * rewrite void-returning statements in constructors that capture result of super call * linter * Update LKG * Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters * Add tests and baselines * Skip trying to use alias if there is target type * Update baselines * Add diagnostics to remind adding tsconfig file for certain external project (#11932) * Add diagnostics for certain external project * Show tsconfig suggestion * fix lint error * Address pr * fix comment * Update error message * Flag for not overwrite js files by default without generating errors (#11980) * WIP * Properly naming things * refactor * apply the option to all files and check out options * Fix typo * Update LKG * lockLinter * use local registry to check if typings package exist (#12014) (#12032) use local registry to check if typings package exist * Add test for #11980 (#12027) * add test for the fix for overwrite emitting error * cr feedback * enable sending telemetry events to tsserver client (#12034) (#12051) enable sending telemetry events * Update LKG * Reuse subtree transform flags for incrementally parsed nodes (#12088) * Update LKG * Update version * Update LKG * Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module * Add tests and baselines * [Release 2.1] fix11754 global augmentation (#12133) * Exclude global augmentation from module resolution logic * Address PR: check using string literal instead of NodeFlags.globalAugmentation * Remove comment

Mohamed Hegazy (mhegazy) · 2016-11-10T23:32:22Z

No description provided.

… string keys (which it did before too)

switch was missing the rule for converting literal types to the literal base type if needed.

Since all callers need this check -- it's how equality is supposed to work everywhere.

There are more literal types in error messages because error reporting no longer has the advantage of calls to getBaseLiteralType

…moduleNameResolver responsible for omitting files based on compiler options

… avoid using resolution.resolvedFileName if the diagnostic is defined.

…e` and `resolvedJsFileName` optional properties (but still automatically infer one of them to supply if the host supplied neither)

…ue in the program

Object rest

Fix comparable in switch

Object spread/rest

Fixes issue #12050

Support for --jsxFactory option

Report all the js file errors and skip only the nodes that are not allowed in JS file

Previously it crashed in the binder.

…s-for-__rest Import helpers reports errors for __rest

* add es2017.string.d.ts for String.prototype.{padStart,padEnd} * append es2017.string.d.ts into es2017.d.ts * add es2017.string into commandLineParser * append es2017.string into error message for unit tests of commandLineParser * append es2017.string into Gulpfile * append es2017.string into Jakefile

…mentOfIdenticallyNamedTypes Adds error message for incompatible assignment of identically named type

…12118) * Exclude js files in non-configured projects CoS emitting * remove unnecessary method

* Update LKG * Update version * Update LKG * Skip overloads with too-short function parameters If the parameter of an overload is a function and the argument is also a function, skip the overload if the parameter has fewer arguments than the argument does. That overload cannot possibly apply, and should not participate in, for example, contextual typing. Example: ```ts interface I { (a: number): void; (b: string, c): void; } declare function f(i: I): void; f((x, y) => {}); ``` This code now skips the first overload instead of considering. This was a longstanding bug but was only uncovered now that more functions expressions are context sensitive. * Test skip overloads w/too-short function params 1. Update changed baseline. 2. Add a new test with baseline. * Minor style improvements * Ignore optionality when skipping overloads * Do not use contextual signatures with too few parameters * isAritySmaller runs later: getNonGenericSignature * rewrite void-returning statements in constructors that capture result of super call (#11868) * rewrite void-returning statements in constructors that capture result of super call * linter * Update LKG * Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters * Add tests and baselines * Skip trying to use alias if there is target type * Update baselines * Add diagnostics to remind adding tsconfig file for certain external project (#11932) * Add diagnostics for certain external project * Show tsconfig suggestion * fix lint error * Address pr * fix comment * Update error message * Flag for not overwrite js files by default without generating errors (#11980) * WIP * Properly naming things * refactor * apply the option to all files and check out options * Fix typo * Update LKG * lockLinter * use local registry to check if typings package exist (#12014) (#12032) use local registry to check if typings package exist * Add test for #11980 (#12027) * add test for the fix for overwrite emitting error * cr feedback * enable sending telemetry events to tsserver client (#12034) (#12051) enable sending telemetry events * Update LKG * Reuse subtree transform flags for incrementally parsed nodes (#12088) * Update LKG * Update version * Update LKG * Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module * Add tests and baselines * [Release 2.1] fix11754 global augmentation (#12133) * Exclude global augmentation from module resolution logic * Address PR: check using string literal instead of NodeFlags.globalAugmentation * Remove comment

Andy Hansonand others added 30 commits October 12, 2016 07:56

Use a single ShimMap class, and indicate that iteration always yields…
f73d906
… string keys (which it did before too)

Remove emacs-added newline at end of baseline
97dda6e

Merge branch 'master' into map4
e8c7224

Remove space at end of line in baseline
c5228d3

Add numeric indexer to strings and remove lint
5a037ad

Update baselines with spread string's numeric indexers
1728ae1

Merge branch 'master' into map4
475125b

Reset baseline line number to the locally incorrect value
ab1b2bb

Remove trailing newline from baseline again
3a85312

Respond to PR comments
9b2e6a3

Refactor getTypeFromTypeLiteral, from PR comments
dceebcd

Fix lint
ce84cee

Use same literal comparison rules for switch/===
00ebf59
switch was missing the rule for converting literal types to the literal base type if needed.

Add switch comparability test and update baselines
982abc2

Push eitherIsNotLiteral check into isTypeEqualityComparableTo
0168f67
Since all callers need this check -- it's how equality is supposed to work everywhere.

Update baselines
83d6abc
There are more literal types in error messages because error reporting no longer has the advantage of calls to getBaseLiteralType

Merge branch 'master' into object-spread
b6819dc

Adds ES5 to ES3 transformer for reserved words
e97368b

Minor cleanup
f025e0c

Cleaned up emit of enum declaration
bb8a3c4

Merge branch 'master' into map4
7292f9f

Return both ts and js results from module resolution, and don't have …
b557211
…moduleNameResolver responsible for omitting files based on compiler options

Merge branch 'master' into map4
f828bc3

Instead of getResolutionOrDiagnostic, use getResolutionDiagnostic and…
7c53a1d
… avoid using resolution.resolvedFileName if the diagnostic is defined.

Merge branch 'master' into object-spread
f9fe01a

Merge branch 'master' into refactor_module_resolution
1d201c1

Remove "ResolvedModuleFromHost" type and just make `resolvedTsFileNam…
df20cf3
…e` and `resolvedJsFileName` optional properties (but still automatically infer one of them to supply if the host supplied neither)

Remove type inference for spread types
18c692a

Update inference test for spread types
62c1868

Merge branch 'master' into map4
a118382

Nathan Shively-Sanders (sandersn)and others added 26 commits November 9, 2016 13:39

Treat | undefined like optionality in spread type
fcf32c4

Add strictNullChecks test for object spread
9b1f43b

Verify that jsxFactory is either identifier or qualified name
f7bac98

Resolve first identifier of the jsxFactory as part of type check
06affa6

When emitting use jsx factory entity expression if provided
3d6950d

Transpile unit test case
35e4c45

Enabled test case for source map
c6b1bbe

Add test cases for when jsxFactory cannot be resolved
a88c2ae

Parse the jsxFactory again in the checker instead of using cached val…
dd7f00f
…ue in the program

Merge pull request#12028from Microsoft/object-rest
25462c9
Object rest

Merge pull request#11633from Microsoft/fix-comparable-in-switch
6398e0d
Fix comparable in switch

Merge pull request#11150from Microsoft/object-spread
be5e5fb
Object spread/rest

Adds error message for incompatible assignment of identically named type
c05e226
Fixes issue #12050

Updated condition for more readability
2eba10a

Merge pull request#12135from Microsoft/jsxFactory
c458576
Support for --jsxFactory option

Merge pull request#11978from Microsoft/errorReportingInJsFile
c87bce1
Report all the js file errors and skip only the nodes that are not allowed in JS file

Report errors for import helpers missing __rest
0d4ac01

Correctly check spread assignments in strict mode
d6bf27d
Previously it crashed in the binder.

Test error for import helpers with no __rest
ba6e5a0

synthesize complete import declaration for tslib (#12151)
3ecb601

Merge pull request#12154from Microsoft/import-helpers-reports-error…
205ce32
…s-for-__rest Import helpers reports errors for __rest

Merge pull request#12147from mylesmegyesi/12050-IncompatableAssigne…
6e1aac1
…mentOfIdenticallyNamedTypes Adds error message for incompatible assignment of identically named type

Exclude js files in non-configured projects compile-on-save emitting (#…
4dc58dd
…12118) * Exclude js files in non-configured projects CoS emitting * remove unnecessary method

Merge branch 'master' into mergeMasterIntoRelease-2.1-2
8a33a46

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Nov 10, 2016

Mohamed Hegazy (mhegazy) merged commit 245a998 into release-2.1Nov 10, 2016

Mohamed Hegazy (mhegazy) deleted the mergeMasterIntoRelease-2.1-2 branch November 10, 2016 23:43

Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018