Skip to content

feat(fabric): Add more macOS props to host platform - #2698

Closed
Saad Najmi (Saadnajmi) wants to merge 3 commits into
microsoft:mainfrom
Saadnajmi:more-host-platform
Closed

feat(fabric): Add more macOS props to host platform#2698
Saad Najmi (Saadnajmi) wants to merge 3 commits into
microsoft:mainfrom
Saadnajmi:more-host-platform

Conversation

@Saadnajmi

Copy link
Copy Markdown
Collaborator

Summary:

This builds on top of #2690 and adds more macOS only props (but not all the ones we have in paper) to our host platform. This was originally done in #2364 on a different branch.

Test Plan:

CI should pass

/*
* Describes a mouse enter/leave event.
*/
struct MouseEvent {

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RNW's MouseEvent looks quite different, since it inherets from PointerEvent: microsoft/react-native-windows#14713

Maybe we should match.

@Saadnajmi

Copy link
Copy Markdown
CollaboratorAuthor

Marking as draft as I've got open questions on the implementation for a couple of the added definitions, which might affect the definition. Meanwhile, I'll work on implementing keyboard events first

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Saadnajmi@sbuggay